* feat(onboarding): company setup from the conversation and POST /api/v1/companies Third PR of agent-first onboarding (#1814). Once connected, the agent can now set up a company end to end without the web wizard, and partner platforms can provision companies over REST. - create_company_for_user: service-role-only SECURITY DEFINER twin of create_company_with_owner taking the owner explicitly (service clients have no auth.uid()). pg-real test covers creation, role gating, unknown owner and foreign team. - lib/company/create-company.ts: the wizard's creation sequence (org number, TIC snapshot, BAS chart, settings, first fiscal period, tax deadlines, rollback) extracted into createCompanyCore; the Server Action delegates to it, behaviour unchanged. - lib/company/onboarding-input.ts: one Zod schema + planner for the agent/API paths; a VAT-registered company without moms_period is refused (a missing period silently yields zero VAT deadlines). - MCP: gnubok_create_company (two-phase: preview, then confirm=true; companies:write, company-independent), gnubok_connect_bank and gnubok_connect_skatteverket (status + the browser link, gated on bank_sync / skatteverket, search-only in the catalog), the "onboarding" skill, and initialize instructions pointing at it. - Consent page pre-ticks companies:write for an account with no company yet, so the setup does not dead-end on insufficient scope after signup. - POST /api/v1/companies (companies:write, dry-run aware) on the same core; scope map, registry, spec snapshot and the generated API skill updated. - tools/list payload ceiling raised 59.95K -> 60.4K for the one new default-catalog tool (documented in the guard). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018wCdzRTatKiDByKB8hCNT6 * fix(onboarding): explicit f_skatt, org number when VAT-registered, EF first year ends 31 Dec Review findings on #1864 (Swedish compliance review): - f_skatt is required, never defaulted to approved (SE-R-005 risk). - org_number is required when vat_registered: the invoice momsregistreringsnummer derives from it (ML 17 kap 24 §). - An enskild firma's first fiscal year must end on 31 December and its start month is forced to 1 even with first_fiscal_year set, mirroring the wizard's own rule text (BFL 3 kap. 1 §). - POST /api/v1/companies no longer claims Idempotency-Key support (the wrapper only honours it on company-scoped routes). - pg-real: createCompanyCore's chart seed runs under the real service_role, which the unit tests could not prove. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018wCdzRTatKiDByKB8hCNT6 * test(pg): starter chart has 41 accounts, assert non-empty The service_role chart-seed proof passed the part that mattered (no 42501 from seed_chart_of_accounts) and failed on a wrong row-count guess: the seeded chart is a curated starter set, not the full BAS list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018wCdzRTatKiDByKB8hCNT6 * fix(migrations): move create_company_for_user to 20260825120000 main gained 20260824170000_bulk_book_transactions_service_actor.sql with the same version while this branch was open; two files on one version abort every Supabase branch apply and the prod auto-apply. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018wCdzRTatKiDByKB8hCNT6 * chore(api): refresh spec snapshot and generated skill after rebasing onto main Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018wCdzRTatKiDByKB8hCNT6 * fix(mcp): flat create_company result, refuse localhost connect links, test hygiene CodeRabbit on #1864: the confirmed-create result was wrapped in the { data, next } envelope while its outputSchema promised top-level fields; it now returns the fields with next as a sibling. The two connect-link tools refuse to build a link when NEXT_PUBLIC_APP_URL is unset instead of handing a remote user a localhost URL. Tests clear mocks and the event bus in beforeEach. Not changed: the rollback already survives user_preferences.active_company_id (that FK is ON DELETE SET NULL since 20260331010000), and v1 error details stay in the surface's English developer convention. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018wCdzRTatKiDByKB8hCNT6 --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
101 lines
4.4 KiB
TypeScript
101 lines
4.4 KiB
TypeScript
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { TOOL_SCOPE_MAP } from '@/lib/auth/api-keys'
|
|
import { eventBus } from '@/lib/events/bus'
|
|
import { MCP_TOOL_CAPABILITY_MAP } from '@/lib/entitlements/keys'
|
|
import { tools } from '../server'
|
|
|
|
// Onboarding connect-link tools (issue #1814 PR 3): status + the browser link
|
|
// the user opens. Both flows need a cookie session and BankID in a browser,
|
|
// so the tools never try to drive them.
|
|
|
|
const COMPANY_ID = '11111111-1111-4111-8111-111111111111'
|
|
const bankTool = tools.find((t) => t.name === 'gnubok_connect_bank')!
|
|
const skvTool = tools.find((t) => t.name === 'gnubok_connect_skatteverket')!
|
|
|
|
function listClient(rows: unknown[] | null, error: unknown = null) {
|
|
const chain: Record<string, ReturnType<typeof vi.fn>> = {
|
|
select: vi.fn(() => chain),
|
|
eq: vi.fn(() => chain),
|
|
in: vi.fn(() => chain),
|
|
order: vi.fn(() => chain),
|
|
limit: vi.fn(() => chain),
|
|
maybeSingle: vi.fn().mockResolvedValue({ data: rows?.[0] ?? null, error }),
|
|
then: (resolve: (v: unknown) => void) => resolve({ data: rows, error }),
|
|
}
|
|
return { from: vi.fn(() => chain), chain }
|
|
}
|
|
|
|
describe('onboarding connect-link tools', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
eventBus.clear()
|
|
vi.stubEnv('NEXT_PUBLIC_APP_URL', 'https://app.example.test')
|
|
})
|
|
afterEach(() => {
|
|
vi.unstubAllEnvs()
|
|
})
|
|
|
|
it('are read-only companies:read tools gated on the capability their link needs', () => {
|
|
expect(TOOL_SCOPE_MAP.gnubok_connect_bank).toBe('companies:read')
|
|
expect(TOOL_SCOPE_MAP.gnubok_connect_skatteverket).toBe('companies:read')
|
|
expect(MCP_TOOL_CAPABILITY_MAP.gnubok_connect_bank).toBe('bank_sync')
|
|
expect(MCP_TOOL_CAPABILITY_MAP.gnubok_connect_skatteverket).toBe('skatteverket')
|
|
expect(bankTool.annotations.readOnlyHint).toBe(true)
|
|
expect(skvTool.annotations.readOnlyHint).toBe(true)
|
|
})
|
|
|
|
it('bank: reports no connection and hands out the PSD2 import link', async () => {
|
|
const { from, chain } = listClient([])
|
|
const result = (await bankTool.execute({}, COMPANY_ID, 'user-1', { from } as never)) as Record<string, unknown>
|
|
expect(result.connected).toBe(false)
|
|
expect(result.connect_url).toBe('https://app.example.test/import?mode=psd2')
|
|
expect(chain.eq).toHaveBeenCalledWith('company_id', COMPANY_ID)
|
|
})
|
|
|
|
it('bank: reports an active connection', async () => {
|
|
const { from } = listClient([
|
|
{ id: 'c1', bank_name: 'Swedbank', status: 'active', created_at: '2026-08-01T00:00:00Z' },
|
|
])
|
|
const result = (await bankTool.execute({}, COMPANY_ID, 'user-1', { from } as never)) as Record<string, unknown>
|
|
expect(result.connected).toBe(true)
|
|
expect(result.connections).toEqual([
|
|
{ connection_id: 'c1', bank: 'Swedbank', status: 'active', since: '2026-08-01T00:00:00Z' },
|
|
])
|
|
})
|
|
|
|
it('skatteverket: hands out the authorize link when enabled and not connected', async () => {
|
|
vi.stubEnv('SKATTEVERKET_ENABLED', 'true')
|
|
const { from } = listClient([])
|
|
const result = (await skvTool.execute({}, COMPANY_ID, 'user-1', { from } as never)) as Record<string, unknown>
|
|
expect(result.available).toBe(true)
|
|
expect(result.connected).toBe(false)
|
|
expect(result.connect_url).toBe(
|
|
'https://app.example.test/api/extensions/ext/skatteverket/authorize?return_to=%2F'
|
|
)
|
|
})
|
|
|
|
it('skatteverket: reports connected with the token expiry', async () => {
|
|
vi.stubEnv('SKATTEVERKET_ENABLED', 'true')
|
|
const { from } = listClient([{ expires_at: '2026-12-01T00:00:00Z' }])
|
|
const result = (await skvTool.execute({}, COMPANY_ID, 'user-1', { from } as never)) as Record<string, unknown>
|
|
expect(result.connected).toBe(true)
|
|
expect(result.token_expires_at).toBe('2026-12-01T00:00:00Z')
|
|
})
|
|
|
|
it('refuses to hand out a link when NEXT_PUBLIC_APP_URL is not configured', async () => {
|
|
vi.stubEnv('NEXT_PUBLIC_APP_URL', '')
|
|
const { from } = listClient([])
|
|
await expect(bankTool.execute({}, COMPANY_ID, 'user-1', { from } as never)).rejects.toMatchObject({
|
|
code: 'INTERNAL_ERROR',
|
|
})
|
|
})
|
|
|
|
it('skatteverket: says so when the integration is disabled on the installation', async () => {
|
|
vi.stubEnv('SKATTEVERKET_ENABLED', 'false')
|
|
const { from } = listClient([])
|
|
const result = (await skvTool.execute({}, COMPANY_ID, 'user-1', { from } as never)) as Record<string, unknown>
|
|
expect(result.available).toBe(false)
|
|
expect(result.connect_url).toBeNull()
|
|
})
|
|
})
|