Files
accounted/app/(dashboard)/bookkeeping/page.tsx
T
MattssonandClaude Fable 5 0676f5a564 feat(bookkeeping): dashboard deep link filters verifikat utan underlag server-side (#1840)
* feat(bookkeeping): dashboard deep link filters verifikat utan underlag server-side

The dashboard "Verifikat utan underlag" card (and the push-notification
link) pointed at /bookkeeping?missingUnderlag=true, but nothing read the
param: the user landed on the plain unfiltered ledger. The existing
"Visa saknade underlag" toggle also only filtered the already-fetched
page, so it could not represent the badge count across pages.

- lib/bookkeeping/missing-underlag.ts: shared resolver of "posted
  verifikat lacking underlag" (document-requiring source types, no
  current-version document, no anchored supplier-invoice reference per
  BFL 5 kap 7 §, no exemption), extracted from the bulk "Inget underlag
  krävs" route so list, bulk remedy and dashboard badge share one
  predicate.
- GET /api/bookkeeping/journal-entries?missing_underlag=true: resolves
  the full missing set server-side, applies the active sort stack, pages
  it, and returns the full-set count, fetching page rows in id chunks so
  the "Alla" page size cannot blow the PostgREST URL limit.
- JournalEntryList: the toggle is now server-backed (refetch on change,
  honest count in the dialog badge); client-side re-filtering against
  late-arriving attachment counts removed. Deep-link arrival turns the
  filter on and scopes the visit to all fiscal years in memory only,
  matching the all-years badge count without touching the saved
  preference.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(bookkeeping): harden the saknade-underlag filter after skeptic review

Three skeptic subagents refuted the first cut; this fixes every confirmed
finding in one pass:

- FyPicker: new suppressAutoRestore prop. The deep-link visit opens as
  "Alla räkenskapsår" in memory, and FyPicker's on-load restore of the
  persisted year (value === null) snapped the scope back right after
  load, desyncing the list from the all-years badge that launched it.
  Manual picks still persist as usual.
- Voucher-label search: the resolver now carries the same parseVoucher
  OR-branch as the direct list path, so searching "A209" with the filter
  on finds verifikat A209 instead of silently returning 0 rows.
- Staleness while the filter is on: batch exempt, the single-row "Inget
  underlag krävs" toggle, and a row gaining its first underlag now
  refetch in place so fixed rows leave the filtered list and the count
  stays honest (the pre-server-filter behavior). The attachment-driven
  refetch is guarded per entry id against predicate-disagreement loops.
- Drafts view: the filter switch is disabled there; the predicate is
  posted-only and the badge would mislabel the draft count.
- Perf: the bulk-exempt route resolves ids only, skipping the per-row
  total_amount computed column on its full post-import candidate scan.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(bookkeeping): keep the underlag resolver statically checkable

The skeptic-fix commit tripped the phantom-column scanner ceiling
(tests/schema/no-phantom-columns.test.ts, 382 > 380): a computed
select() string and a runtime-built .or() are expressions the scanner
cannot resolve against the schema. Restructured instead of raising the
ceiling: the idOnly/full column choice is two literal select() calls
behind a lazy branch, and a voucher-label search fans out to two
statically-checkable candidate queries (description ilike, series+number
eq) unioned by id, same semantics as before.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-24 15:06:30 +02:00

363 lines
14 KiB
TypeScript

'use client'
import { useState, useEffect, useMemo } from 'react'
import dynamic from 'next/dynamic'
import { useRouter, useSearchParams } from 'next/navigation'
import { useTranslations } from 'next-intl'
import JournalEntryList from '@/components/bookkeeping/JournalEntryList'
import { StartCard } from '@/components/dashboard/StartCard'
import { type FormLine } from '@/components/bookkeeping/JournalEntryForm'
import type { CopyPrefill, SkvLinkPrefill } from '@/components/bookkeeping/NewJournalEntryDialog'
import {
buildSkvPrefillLines,
takeSkvManualPrefill,
type SkvManualPrefill,
} from '@/lib/skatteverket/manual-verifikat-prefill'
import { getErrorMessage } from '@/lib/errors/get-error-message'
import { formatCurrency, formatDate } from '@/lib/utils'
import { DialogLoadingSkeleton } from '@/components/ui/dialog-loading-skeleton'
import { SplitButton } from '@/components/ui/split-button'
import { useAgentSheet } from '@/components/agent/AgentSheetProvider'
import { useUiState } from '@/lib/hooks/use-ui-state'
import { resolveInitialMode } from '@/lib/ui-state/client'
import { useToast } from '@/components/ui/use-toast'
import { Plus, LayoutTemplate, Sparkles } from 'lucide-react'
import { PageHeader } from '@/components/ui/page-header'
import { formatVoucher } from '@/lib/bookkeeping/voucher-series-resolver'
import type { JournalEntry, JournalEntryLine } from '@/types'
const NewJournalEntryDialog = dynamic(
() => import('@/components/bookkeeping/NewJournalEntryDialog'),
{ loading: DialogLoadingSkeleton },
)
const TemplateBookDialog = dynamic(
() => import('@/components/bookkeeping/TemplateBookDialog'),
{ loading: DialogLoadingSkeleton },
)
// SplitButton modes for "Nytt verifikat" (concept scene 9). The last-used
// mode persists per user in ui_state.create_mode.bookkeeping.
const CREATE_MODES = ['tomt', 'mall', 'assistent'] as const
interface NextVoucher {
next: number
series: string
}
const UUID_RE = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i
export default function BookkeepingPage() {
const { toast } = useToast()
const router = useRouter()
const searchParams = useSearchParams()
const copyFromId = useMemo<string | null>(() => {
const raw = searchParams.get('copy_from')
return raw && UUID_RE.test(raw) ? raw : null
}, [searchParams])
// Deep link from the dashboard "Verifikat utan underlag" card (and the
// push-notification link): open the list with the saknade-underlag filter
// already on. Read once on mount: the param stays in the URL (shareable),
// and later in-page filter changes must not be fought by the URL.
const [initialShowMissingOnly] = useState(
() => searchParams.get('missingUnderlag') === 'true',
)
const [refreshKey, setRefreshKey] = useState(0)
const [showNewEntry, setShowNewEntry] = useState(false)
const [showTemplateDialog, setShowTemplateDialog] = useState(false)
const [copyPrefill, setCopyPrefill] = useState<CopyPrefill | null>(null)
const [isLoadingCopy, setIsLoadingCopy] = useState(false)
// Set from the skattekonto deep link (skv_tx & co): prefills the Nytt
// verifikat dialog and makes the created entry auto-link back to the row.
const [skvLink, setSkvLink] = useState<SkvManualPrefill | null>(null)
const [nextVoucher, setNextVoucher] = useState<NextVoucher | null>(null)
const t = useTranslations('bookkeeping')
const tStart = useTranslations('start_cards')
const { openAgentSheet } = useAgentSheet()
const { uiState, loaded: uiStateLoaded } = useUiState()
// React to copy_from in URL: switch tab, fetch source entry, then clean URL.
// useSearchParams keeps this reactive even when navigation happens within the
// same route (e.g. clicking the Kopiera button in the expanded list row),
// which a one-shot useState initializer wouldn't notice.
/* eslint-disable react-hooks/set-state-in-effect -- URL→state sync requires sync setState */
useEffect(() => {
if (!copyFromId) return
setShowNewEntry(true)
setCopyPrefill(null)
setIsLoadingCopy(true)
fetch(`/api/bookkeeping/journal-entries/${copyFromId}`)
.then((res) => res.json())
.then(({ data, error }: { data?: JournalEntry; error?: string }) => {
if (error || !data) {
toast({
title: t('copy_failed_title'),
description: error || t('copy_source_missing'),
variant: 'destructive',
})
return
}
const sourceLines = ((data.lines || []) as JournalEntryLine[])
.slice()
.sort((a, b) => a.sort_order - b.sort_order)
const lines: FormLine[] = sourceLines.map((l) => {
const debit = Number(l.debit_amount) || 0
const credit = Number(l.credit_amount) || 0
return {
account_number: l.account_number,
debit_amount: debit > 0 ? debit.toFixed(2) : '',
credit_amount: credit > 0 ? credit.toFixed(2) : '',
line_description: l.line_description || '',
}
})
setCopyPrefill({
sourceId: copyFromId,
sourceVoucherLabel: formatVoucher(data),
lines,
description: data.description || '',
notes: data.notes || '',
})
})
.catch(() => {
toast({
title: t('copy_failed_title'),
description: t('copy_fetch_failed'),
variant: 'destructive',
})
})
.finally(() => {
setIsLoadingCopy(false)
// Clear copy_from so a refresh doesn't re-trigger and so clicking the
// same entry's Kopiera button again re-fires this effect.
router.replace('/bookkeeping')
})
}, [copyFromId, toast, router])
// React to the skattekonto deep link the same way: consume the staged
// payload (single-use, sessionStorage; the URL carries only the opaque id),
// open the dialog prefilled, and clean the URL so a refresh doesn't
// re-trigger. copy_from wins if both are somehow present. A missing or
// invalid payload (shared/stale link) degrades to the plain list.
useEffect(() => {
if (copyFromId) return
const rawId = searchParams.get('skv_tx')
if (!rawId) return
const prefill = takeSkvManualPrefill(rawId)
router.replace('/bookkeeping')
if (!prefill) return
setSkvLink(prefill)
setCopyPrefill(null)
setShowNewEntry(true)
}, [searchParams, copyFromId, router])
/* eslint-enable react-hooks/set-state-in-effect */
const skvPrefill = useMemo<SkvLinkPrefill | null>(() => {
if (!skvLink) return null
return {
transactionId: skvLink.transactionId,
bannerLabel: [formatDate(skvLink.date), skvLink.text, formatCurrency(skvLink.amount)]
.filter(Boolean)
.join(' • '),
lines: buildSkvPrefillLines(skvLink) as FormLine[],
description: skvLink.text,
date: skvLink.date,
}
}, [skvLink])
// Link the created verifikat back to the skattekonto row. The entry exists
// either way, so a failed link degrades to a loud toast pointing at the
// manual "Matcha mot verifikat" path instead of silently orphaning the row.
async function handleSkvEntryCreated(entryId: string) {
if (!skvLink) return
const target = skvLink
setSkvLink(null)
let reason = ''
try {
const res = await fetch(
`/api/extensions/ext/skatteverket/skattekonto/transaktioner/${target.transactionId}/match`,
{
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ journal_entry_id: entryId }),
},
)
if (res.ok) {
toast({
title: t('skv_link_success_title'),
description: t('skv_link_success_description', { text: target.text }),
})
return
}
const json: unknown = await res.json().catch(() => null)
reason = getErrorMessage(json ?? {}, { statusCode: res.status })
} catch (err) {
reason = err instanceof Error ? getErrorMessage(err) : ''
}
toast({
title: t('skv_link_failed_title'),
description: [reason, t('skv_link_failed_hint')].filter(Boolean).join(' '),
variant: 'destructive',
})
}
// Fetch the next voucher number for today's fiscal period + default series.
// Re-runs after each commit (refreshKey++) so the tab label stays current.
useEffect(() => {
let cancelled = false
fetch('/api/bookkeeping/voucher-sequences/next')
.then((r) => r.json())
.then(({ data }) => {
if (cancelled) return
if (data?.next != null) {
setNextVoucher({ next: data.next, series: data.series })
} else {
setNextVoucher(null)
}
})
.catch(() => {
if (!cancelled) setNextVoucher(null)
})
return () => {
cancelled = true
}
}, [refreshKey])
return (
<div className="space-y-8">
<PageHeader
title={t('title')}
action={
<SplitButton
// Remount once ui_state loads so the primary face re-resolves
// to the persisted last-used mode.
key={uiStateLoaded ? 'loaded' : 'initial'}
persistKey="bookkeeping"
initialModeKey={resolveInitialMode(uiState, 'bookkeeping', CREATE_MODES, 'tomt')}
options={[
{
key: 'tomt',
label: nextVoucher
? `${t('create_tomt')} (${nextVoucher.series}${nextVoucher.next})`
: t('create_tomt'),
icon: Plus,
description: t('create_tomt_desc'),
onSelect: () => {
setCopyPrefill(null)
setSkvLink(null)
setShowNewEntry(true)
},
},
{
key: 'mall',
label: t('create_mall'),
icon: LayoutTemplate,
description: t('create_mall_desc'),
onSelect: () => setShowTemplateDialog(true),
},
{
key: 'assistent',
label: t('create_with_assistant'),
icon: Sparkles,
description: t('create_assistent_desc'),
onSelect: () =>
openAgentSheet({
intentId: 'verifikation.draft',
contextRef: 'verifikation:new',
}),
},
]}
/>
}
/>
{/* refreshToken, NOT key: a created verifikat refreshes the list in
place (dim + refetch) instead of remounting it into a spinner and
losing expansion/selection/scroll. */}
<JournalEntryList
refreshToken={refreshKey}
initialShowMissingOnly={initialShowMissingOnly}
pristineSlot={
<div className="animate-fade-in space-y-4">
<StartCard
card="ledger"
layout="bleed-left"
title={tStart('bookkeeping_title')}
body={tStart('bookkeeping_body')}
primary={{ label: tStart('bookkeeping_primary'), href: '/import?mode=migration' }}
secondary={{ label: tStart('bookkeeping_secondary'), href: '/import?mode=sie' }}
/>
{/* The split button's three create modes, laid out as cards so the
pristine page shows what the ledger can do instead of a bare table. */}
<div className="grid gap-4 sm:grid-cols-3">
{(
[
['mall', () => setShowTemplateDialog(true)],
[
'assistent',
() => openAgentSheet({ intentId: 'verifikation.draft', contextRef: 'verifikation:new' }),
],
[
'tomt',
() => {
setCopyPrefill(null)
setSkvLink(null)
setShowNewEntry(true)
},
],
] as const
).map(([mode, onClick]) => (
<button
key={mode}
type="button"
onClick={onClick}
className="rounded-lg border border-border bg-background p-4 text-left transition-colors duration-150 hover:bg-secondary/35 active:bg-secondary/35 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
>
<div className="text-[13px] font-medium">{tStart(`bookkeeping_mini_${mode}_title`)}</div>
<p className="mt-1 text-xs leading-relaxed text-muted-foreground">
{tStart(`bookkeeping_mini_${mode}_body`)}
</p>
</button>
))}
</div>
</div>
}
/>
{showTemplateDialog && (
<TemplateBookDialog
open
onOpenChange={setShowTemplateDialog}
onCreated={() => setRefreshKey((k) => k + 1)}
/>
)}
{showNewEntry && (
<NewJournalEntryDialog
open
onOpenChange={(o) => {
setShowNewEntry(o)
if (!o) {
setCopyPrefill(null)
setSkvLink(null)
}
}}
onCreated={() => {
setRefreshKey((k) => k + 1)
setShowNewEntry(false)
setCopyPrefill(null)
// handleSkvEntryCreated runs from the same render's closure, so
// clearing here doesn't rob it of the link target.
setSkvLink(null)
}}
onEntryCreated={skvLink ? handleSkvEntryCreated : undefined}
copyPrefill={copyPrefill}
skvPrefill={skvPrefill}
isLoading={isLoadingCopy}
/>
)}
</div>
)
}