Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
42 lines
1.5 KiB
TypeScript
42 lines
1.5 KiB
TypeScript
import type { SkatteverketAuthError } from './api-client'
|
|
|
|
export interface StructuredSkvError {
|
|
code: string
|
|
httpStatus: number
|
|
}
|
|
|
|
/**
|
|
* Map a SkatteverketAuthError.code to the structured error code + HTTP status
|
|
* used across the MCP surface (registry: lib/errors/structured-errors.ts).
|
|
*
|
|
* Shared by the commit-side services (extensions/general/skatteverket/index.ts)
|
|
* and the MCP tools (extensions/general/mcp-server/server.ts) so connection
|
|
* failures surface one consistent reconnect remediation everywhere.
|
|
*
|
|
* Every auth code is recoverable in the commit sense (the op is fine, the
|
|
* connection/scope/quota isn't), so callers reconnect (or wait) and retry the
|
|
* same operation. The three buckets collapse the nine raw SKV codes onto the
|
|
* remediation that actually differs: reconnect with BankID, fix authorisation
|
|
* at SKV, or back off.
|
|
*/
|
|
export function skvAuthCodeToStructured(
|
|
code: SkatteverketAuthError['code'],
|
|
): StructuredSkvError {
|
|
switch (code) {
|
|
case 'NOT_CONNECTED':
|
|
case 'SESSION_EXPIRED':
|
|
case 'REFRESH_EXHAUSTED':
|
|
case 'TOKEN_REVOKED':
|
|
case 'TOKEN_CORRUPTED':
|
|
case 'MISSING_SCOPE':
|
|
// All resolved the same way: disconnect + reconnect with BankID to mint a
|
|
// fresh token with the right scope.
|
|
return { code: 'SKATTEVERKET_NOT_CONNECTED', httpStatus: 401 }
|
|
case 'BEHORIGHET_SAKNAS':
|
|
case 'ACCESS_DENIED':
|
|
return { code: 'SKATTEVERKET_ACCESS_DENIED', httpStatus: 403 }
|
|
case 'RATE_LIMITED':
|
|
return { code: 'SKATTEVERKET_RATE_LIMITED', httpStatus: 429 }
|
|
}
|
|
}
|