Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
60 lines
2.2 KiB
TypeScript
60 lines
2.2 KiB
TypeScript
import type { ExtensionContext } from '@/lib/extensions/types'
|
|
|
|
/**
|
|
* Append an immutable row to skatteverket_api_audit_log. Errors are
|
|
* swallowed (logged only) so an audit-table outage does not break the
|
|
* regulator flow, but a successful primary call without an audit row
|
|
* shows up as a noisy console.error for ops to investigate.
|
|
*
|
|
* Lives in its own module so the route handlers (which pass a real
|
|
* ExtensionContext), the commit-side services, and the MCP read tools can all
|
|
* share one audit writer. Callers that only hold (supabase, userId, companyId)
|
|
* build a context with `createExtensionContext(supabase, userId, companyId,
|
|
* 'skatteverket')`: cheap, no I/O, and pass it here. The `(ctx, fields)`
|
|
* signature is preserved verbatim so the existing handlers stay byte-identical.
|
|
*/
|
|
export async function writeSkatteverketAudit(
|
|
ctx: ExtensionContext,
|
|
fields: {
|
|
endpoint: string
|
|
agRegistreradId?: string | null
|
|
redovisningsperiod?: string | null
|
|
outcome: 'ok' | 'validation_error' | 'skv_error' | 'auth_error' | 'internal_error'
|
|
responseStatus?: number | null
|
|
skvStatus?: string | null
|
|
requestSizeBytes?: number | null
|
|
correlationId?: string | null
|
|
errorMessage?: string | null
|
|
},
|
|
): Promise<void> {
|
|
try {
|
|
const { error } = await ctx.supabase
|
|
.from('skatteverket_api_audit_log')
|
|
.insert({
|
|
company_id: ctx.companyId,
|
|
user_id: ctx.userId,
|
|
endpoint: fields.endpoint,
|
|
ag_registered_id: fields.agRegistreradId ?? null,
|
|
redovisningsperiod: fields.redovisningsperiod ?? null,
|
|
outcome: fields.outcome,
|
|
response_status: fields.responseStatus ?? null,
|
|
skv_status: fields.skvStatus ?? null,
|
|
request_size_bytes: fields.requestSizeBytes ?? null,
|
|
correlation_id: fields.correlationId ?? null,
|
|
error_message: fields.errorMessage ?? null,
|
|
})
|
|
if (error) {
|
|
ctx.log.error('skatteverket_api_audit_log insert failed', {
|
|
endpoint: fields.endpoint,
|
|
outcome: fields.outcome,
|
|
error: error.message,
|
|
})
|
|
}
|
|
} catch (err) {
|
|
ctx.log.error('skatteverket_api_audit_log insert threw', {
|
|
endpoint: fields.endpoint,
|
|
error: err instanceof Error ? err.message : String(err),
|
|
})
|
|
}
|
|
}
|