Files
accounted/extensions/general/mcp-server/__tests__/create-supplier-invoice-from-inbox.test.ts
T
Jonas Flodén b700108107 feat(mcp): add invoice_date_override to create_supplier_invoice_from_inbox (#848)
Unblocks inbox items where OCR missed the invoice date: priority is override, then extracted invoiceDate, then the existing hard error. Both date overrides now reject non-ISO input at staging time instead of failing opaquely at booking. Includes dry_run and validation tests.
2026-07-06 11:24:05 +02:00

556 lines
21 KiB
TypeScript

/**
* Unit tests for gnubok_create_supplier_invoice_from_inbox.
*
* Verifies registration, scope, supplier-resolution branches, dry_run preview,
* already-converted guard, and the missing-extraction error.
*/
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { tools } from '../server'
import { TOOL_SCOPE_MAP } from '@/lib/auth/api-keys'
import { OPERATION_RISK_TIERS } from '@/lib/pending-operations/risk-tiers'
vi.mock('@/lib/currency/riksbanken', () => ({
fetchExchangeRate: vi.fn().mockResolvedValue(11.5),
convertToSEK: vi.fn(),
}))
describe('gnubok_create_supplier_invoice_from_inbox: registration', () => {
it('is registered with idempotent + non-read-only annotations', () => {
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')
expect(tool).toBeDefined()
expect(tool?.annotations.readOnlyHint).toBe(false)
expect(tool?.annotations.idempotentHint).toBe(true)
expect(tool?.annotations.destructiveHint).toBe(false)
})
it('requires inbox_item_id', () => {
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const schema = tool.inputSchema as { required?: string[] }
expect(schema.required).toContain('inbox_item_id')
})
it('is mapped to suppliers:write scope', () => {
expect(TOOL_SCOPE_MAP.gnubok_create_supplier_invoice_from_inbox).toBe('suppliers:write')
})
it('is classified as medium risk', () => {
expect(OPERATION_RISK_TIERS.create_supplier_invoice_from_inbox).toBe('medium')
})
})
/**
* Build a supabase mock that:
* - returns the given inbox row from .from('invoice_inbox_items').select(...).eq(...).eq(...).single()
* - returns the given supplier row from .from('suppliers') lookups
* - resolves the pending_operations insert
*/
function makeMock(opts: {
inbox?: Record<string, unknown> | null
supplierByOrg?: Record<string, unknown> | null
supplierByName?: Record<string, unknown> | null
pendingInsert?: Record<string, unknown>
/** When set, company_settings/dimensions/dimension_values serve this registry. */
dimensions?: {
enabled: boolean
registry?: Array<Record<string, unknown>>
values?: Array<Record<string, unknown>>
}
/** When provided, every pending_operations .insert(payload) is recorded here. */
inserts?: Array<Record<string, unknown>>
/** Served by the awaited (non-maybeSingle) suppliers list query: candidate search. */
supplierList?: Array<Record<string, unknown>>
/** Served by the .single() defaults/tenancy fetch. Pass explicit null to simulate a supplier missing from the company. */
supplierRecord?: Record<string, unknown> | null
}) {
const inboxResult = { data: opts.inbox ?? null, error: opts.inbox ? null : { message: 'not found' } }
const supplierByOrgResult = { data: opts.supplierByOrg ?? null, error: null }
const supplierByNameResult = { data: opts.supplierByName ?? null, error: null }
const insertResult = { data: opts.pendingInsert ?? { id: 'op-1' }, error: null }
// suppliers lookups distinguish by query method: org_number → .eq() chain ending in maybeSingle()
// name → .ilike() chain ending in maybeSingle().
// We stub by tracking the most recent .eq vs .ilike call. Simpler: return
// org-result first, name-result second (the tool falls through).
let supplierLookupCall = 0
const supplierChain = (): unknown =>
new Proxy(
{},
{
get(_t, prop) {
if (prop === 'maybeSingle') {
return () => {
supplierLookupCall++
return Promise.resolve(supplierLookupCall === 1 ? supplierByOrgResult : supplierByNameResult)
}
}
if (prop === 'single') {
return () =>
Promise.resolve(
'supplierRecord' in opts
? { data: opts.supplierRecord, error: opts.supplierRecord ? null : { message: 'not found' } }
: { data: { id: 'resolved-supplier', default_expense_account: null }, error: null },
)
}
if (prop === 'then') {
return (resolve: (v: unknown) => void) =>
resolve(opts.supplierList ? { data: opts.supplierList, error: null } : supplierByOrgResult)
}
return () => supplierChain()
},
},
)
const inboxChain = (): unknown =>
new Proxy(
{},
{
get(_t, prop) {
if (prop === 'single') return () => Promise.resolve(inboxResult)
if (prop === 'then') return (resolve: (v: unknown) => void) => resolve(inboxResult)
return () => inboxChain()
},
},
)
const pendingChain = (): unknown =>
new Proxy(
{},
{
get(_t, prop) {
if (prop === 'insert') {
return (payload: Record<string, unknown>) => {
opts.inserts?.push(payload)
return pendingChain()
}
}
if (prop === 'single') return () => Promise.resolve(insertResult)
if (prop === 'then') return (resolve: (v: unknown) => void) => resolve(insertResult)
return () => pendingChain()
},
},
)
// Static chains for the dims registry (resolveDimensionBags reads these).
const staticChain = (result: { data: unknown; error: unknown }): unknown =>
new Proxy(
{},
{
get(_t, prop) {
if (prop === 'single' || prop === 'maybeSingle') return () => Promise.resolve(result)
if (prop === 'then') return (resolve: (v: unknown) => void) => resolve(result)
return () => staticChain(result)
},
},
)
return {
from: vi.fn().mockImplementation((table: string) => {
if (table === 'invoice_inbox_items') return inboxChain()
if (table === 'suppliers') return supplierChain()
if (table === 'pending_operations') return pendingChain()
if (table === 'company_settings' && opts.dimensions) {
return staticChain({ data: { dimensions_enabled: opts.dimensions.enabled }, error: null })
}
if (table === 'dimensions' && opts.dimensions) {
return staticChain({ data: opts.dimensions.registry ?? [], error: null })
}
if (table === 'dimension_values' && opts.dimensions) {
return staticChain({ data: opts.dimensions.values ?? [], error: null })
}
return inboxChain()
}),
rpc: vi.fn().mockResolvedValue({ data: null, error: null }),
} as never
}
const baseExtracted = {
supplier: { name: 'Acme AB', organizationNumber: '5566778899' },
invoice: { invoiceNumber: 'INV-100', invoiceDate: '2026-03-15', dueDate: '2026-04-14', currency: 'SEK' },
totals: { subtotal: 1000, vat: 250, total: 1250 },
lineItems: [
{ description: 'Konsulttimmar', quantity: 10, unit_price: 100, line_total: 1000, vat_rate: 25, vat_amount: 250 },
],
}
describe('gnubok_create_supplier_invoice_from_inbox: execute', () => {
beforeEach(() => {
vi.clearAllMocks()
})
it('dry_run returns preview without inserting pending_operations', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-1',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: null,
document_id: 'doc-1',
},
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{ inbox_item_id: 'inbox-1', dry_run: true },
'company-1',
'user-1',
supabase,
)) as { dry_run?: boolean; staged: boolean; preview: Record<string, unknown> }
expect(result.dry_run).toBe(true)
expect(result.staged).toBe(false)
expect(result.preview.supplier_id).toBe('supplier-1')
expect(result.preview.supplier_resolution).toBe('matched')
expect(result.preview.total).toBe(1250)
})
it('falls through to org_number lookup when no matched supplier', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-2',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: null,
created_supplier_invoice_id: null,
document_id: 'doc-2',
},
supplierByOrg: { id: 'supplier-org-lookup' },
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{ inbox_item_id: 'inbox-2', dry_run: true },
'company-1', 'user-1', supabase,
)) as { preview: { supplier_resolution: string; supplier_id: string } }
expect(result.preview.supplier_id).toBe('supplier-org-lookup')
expect(result.preview.supplier_resolution).toBe('lookup_org_number')
})
it('falls through to name lookup when org_number returns null', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-7',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: null,
created_supplier_invoice_id: null,
document_id: 'doc-7',
},
supplierByOrg: null,
supplierByName: { id: 'supplier-name-lookup' },
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{ inbox_item_id: 'inbox-7', dry_run: true },
'company-1', 'user-1', supabase,
)) as { preview: { supplier_resolution: string; supplier_id: string } }
expect(result.preview.supplier_id).toBe('supplier-name-lookup')
expect(result.preview.supplier_resolution).toBe('lookup_name')
})
it('throws when inbox item already converted', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-3',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: 'si-existing',
document_id: 'doc-3',
},
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
await expect(
tool.execute({ inbox_item_id: 'inbox-3' }, 'company-1', 'user-1', supabase),
).rejects.toThrow(/already converted/)
})
it('unresolved supplier with no similar suppliers returns staged:false + create-supplier next hint', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-4',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: null,
created_supplier_invoice_id: null,
document_id: 'doc-4',
},
supplierByOrg: null,
supplierByName: null,
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{ inbox_item_id: 'inbox-4' },
'company-1', 'user-1', supabase,
)) as {
staged: boolean
risk_level: string
preview: { supplier_resolution: string; candidates: unknown[]; unresolved_supplier: Record<string, unknown> }
next: { tool: string; args: Record<string, unknown> }
}
expect(result.staged).toBe(false)
expect(result.risk_level).toBe('medium')
expect(result.preview.supplier_resolution).toBe('unresolved')
expect(result.preview.candidates).toEqual([])
expect(result.preview.unresolved_supplier).toEqual({
extracted_name: 'Acme AB',
extracted_org_number: '5566778899',
})
// Next hint prefills gnubok_create_supplier from the extraction.
expect(result.next.tool).toBe('gnubok_create_supplier')
expect(result.next.args).toEqual({ name: 'Acme AB', org_number: '5566778899' })
})
it('unresolved supplier with a near-miss candidate returns it with a retry-with-override next hint', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-8',
status: 'received',
extracted_data: {
...baseExtracted,
supplier: { name: 'Polarn o Pyret' }, // OCR variant: no punctuation, no AB, no org number
},
matched_supplier_id: null,
created_supplier_invoice_id: null,
document_id: 'doc-8',
},
supplierByOrg: null,
supplierByName: null, // exact ilike on the full name misses the punctuation/suffix variant
supplierList: [
{ id: 'sup-dnb', name: 'DNB Bank AB', org_number: '5169077454' },
{ id: 'sup-polarn', name: 'Polarn O. Pyret AB', org_number: '556235-8797' },
],
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{ inbox_item_id: 'inbox-8' },
'company-1', 'user-1', supabase,
)) as {
staged: boolean
preview: { candidates: Array<{ supplier_id: string; score: number; matched_on: string }> }
next: { tool: string; args: Record<string, unknown> }
}
expect(result.staged).toBe(false)
expect(result.preview.candidates[0]).toMatchObject({
supplier_id: 'sup-polarn',
score: 1,
matched_on: 'name',
})
// Next hint is the retry with the best candidate as override: the agent
// confirms against the underlag; fuzzy never auto-resolves.
expect(result.next.tool).toBe('gnubok_create_supplier_invoice_from_inbox')
expect(result.next.args).toEqual({ inbox_item_id: 'inbox-8', supplier_id_override: 'sup-polarn' })
})
it('rejects a supplier_id_override that does not exist in the company', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-9',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: null,
created_supplier_invoice_id: null,
document_id: 'doc-9',
},
supplierRecord: null, // tenancy fetch finds nothing for the override id
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
await expect(
tool.execute(
{ inbox_item_id: 'inbox-9', supplier_id_override: 'sup-foreign' },
'company-1', 'user-1', supabase,
),
).rejects.toThrow(/supplier_id_override sup-foreign does not match any supplier in this company/)
})
it('applies line_overrides: overridden account wins over extracted accountSuggestion', async () => {
const extractedWithSuggestion = {
...baseExtracted,
lineItems: [
{ description: 'Line A', quantity: 1, unit_price: 400, line_total: 400, vat_rate: 25, vat_amount: 100, accountSuggestion: '6550' },
{ description: 'Line B', quantity: 1, unit_price: 600, line_total: 600, vat_rate: 25, vat_amount: 150, accountSuggestion: '6550' },
],
}
const supabase = makeMock({
inbox: {
id: 'inbox-6',
status: 'received',
extracted_data: extractedWithSuggestion,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: null,
document_id: 'doc-6',
},
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{
inbox_item_id: 'inbox-6',
dry_run: true,
line_overrides: [{ line_number: 2, account_number: '6420' }],
},
'company-1', 'user-1', supabase,
)) as { preview: { items_preview: Array<{ line_number: number; account_number: string }> } }
const items = result.preview.items_preview
expect(items[0].account_number).toBe('6550') // untouched, extracted suggestion wins
expect(items[1].account_number).toBe('6420') // override wins over extracted suggestion
})
it('stages resolved default_dimensions top-level and per-line bags via line_overrides', async () => {
const extractedTwoLines = {
...baseExtracted,
lineItems: [
{ description: 'Line A', quantity: 1, unit_price: 400, line_total: 400, vat_rate: 25, vat_amount: 100 },
{ description: 'Line B', quantity: 1, unit_price: 600, line_total: 600, vat_rate: 25, vat_amount: 150 },
],
}
const inserts: Array<Record<string, unknown>> = []
const supabase = makeMock({
inbox: {
id: 'inbox-8',
status: 'received',
extracted_data: extractedTwoLines,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: null,
document_id: 'doc-8',
},
dimensions: {
enabled: true,
registry: [
{ id: 'dim-1', sie_dim_no: 1, name: 'Kostnadsställe', resets_annually: true, is_system: true, is_active: true, sort_order: 10 },
{ id: 'dim-6', sie_dim_no: 6, name: 'Projekt', resets_annually: false, is_system: true, is_active: true, sort_order: 20 },
],
values: [
{ id: 'v1', dimension_id: 'dim-1', code: 'KS01', name: 'Stockholm', is_active: true, start_date: null, end_date: null },
{ id: 'v2', dimension_id: 'dim-6', code: 'P001', name: 'Villa Almgren takrenovering', is_active: true, start_date: null, end_date: null },
],
},
inserts,
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{
inbox_item_id: 'inbox-8',
default_dimensions: { '6': 'villa almgren tak' },
line_overrides: [{ line_number: 2, dimensions: { '1': 'KS01' } }],
},
'company-1', 'user-1', supabase,
)) as {
staged: boolean
preview: { dimension_resolutions?: Array<Record<string, unknown>> }
}
expect(result.staged).toBe(true)
// Contract: staged params carry `default_dimensions` top-level (resolved to
// codes) and each item its OWN resolved bag: the executor merges.
expect(inserts).toHaveLength(1)
const params = inserts[0].params as {
default_dimensions?: Record<string, string>
items: Array<{ dimensions?: Record<string, string> }>
}
expect(params.default_dimensions).toEqual({ '6': 'P001' })
expect(params.items[0].dimensions).toBeUndefined()
expect(params.items[1].dimensions).toEqual({ '1': 'KS01' })
// Non-exact name resolution is echoed in the preview.
expect(result.preview.dimension_resolutions).toHaveLength(1)
expect(result.preview.dimension_resolutions![0]).toMatchObject({
dimension: 6,
input: 'villa almgren tak',
resolved_code: 'P001',
resolved_name: 'Villa Almgren takrenovering',
})
})
it('stages no dims keys when nothing is tagged (backward compatible)', async () => {
const inserts: Array<Record<string, unknown>> = []
const supabase = makeMock({
inbox: {
id: 'inbox-9',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: null,
document_id: 'doc-9',
},
inserts,
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{ inbox_item_id: 'inbox-9' },
'company-1', 'user-1', supabase,
)) as { staged: boolean; preview: Record<string, unknown> }
expect(result.staged).toBe(true)
expect(result.preview.dimension_resolutions).toBeUndefined()
const params = inserts[0].params as { default_dimensions?: unknown; items: Array<Record<string, unknown>> }
expect('default_dimensions' in params).toBe(false)
expect('dimensions' in params.items[0]).toBe(false)
})
it('invoice_date_override rescues an inbox item with no extracted invoiceDate', async () => {
const extractedNoDate = {
...baseExtracted,
invoice: { ...baseExtracted.invoice, invoiceDate: null },
}
const supabase = makeMock({
inbox: {
id: 'inbox-10',
status: 'received',
extracted_data: extractedNoDate,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: null,
document_id: 'doc-10',
},
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
const result = (await tool.execute(
{ inbox_item_id: 'inbox-10', dry_run: true, invoice_date_override: '2025-07-15' },
'company-1', 'user-1', supabase,
)) as { dry_run: boolean; preview: { invoice_date: string } }
expect(result.dry_run).toBe(true)
expect(result.preview.invoice_date).toBe('2025-07-15')
})
it('rejects a non-ISO invoice_date_override before staging', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-11',
status: 'received',
extracted_data: baseExtracted,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: null,
document_id: 'doc-11',
},
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
await expect(
tool.execute(
{ inbox_item_id: 'inbox-11', dry_run: true, invoice_date_override: '15/07/2025' },
'company-1', 'user-1', supabase,
),
).rejects.toThrow(/invoice_date_override must be an ISO date/)
})
it('throws when extracted_data is missing', async () => {
const supabase = makeMock({
inbox: {
id: 'inbox-5',
status: 'received',
extracted_data: null,
matched_supplier_id: 'supplier-1',
created_supplier_invoice_id: null,
document_id: null,
},
})
const tool = tools.find((t) => t.name === 'gnubok_create_supplier_invoice_from_inbox')!
await expect(
tool.execute({ inbox_item_id: 'inbox-5' }, 'company-1', 'user-1', supabase),
).rejects.toThrow(/no extracted_data/)
})
})