Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
279 lines
13 KiB
TypeScript
279 lines
13 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import {
|
|
parseJsonResponse,
|
|
createMockRouteParams,
|
|
createQueuedMockSupabase,
|
|
} from '@/tests/helpers'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createClient: () => Promise.resolve(mockSupabase),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/require-write', () => ({
|
|
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
|
|
}))
|
|
|
|
vi.mock('@/lib/init', () => ({
|
|
ensureInitialized: vi.fn(),
|
|
}))
|
|
|
|
import { POST, DELETE } from '../route'
|
|
|
|
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: mockUser } })
|
|
})
|
|
|
|
function makeReq(body: unknown, method: 'POST' | 'DELETE' = 'POST') {
|
|
return new Request('http://localhost/api/transactions/tx-1/attach-document', {
|
|
method,
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: method === 'POST' ? JSON.stringify(body) : undefined,
|
|
})
|
|
}
|
|
|
|
describe('POST /api/transactions/[id]/attach-document', () => {
|
|
it('returns 401 when not authenticated', async () => {
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
|
|
const res = await POST(makeReq({ document_id: 'doc-1' }), createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(res)
|
|
expect(status).toBe(401)
|
|
expect(body).toEqual({ error: 'Unauthorized' })
|
|
})
|
|
|
|
it('returns 400 when document_id missing', async () => {
|
|
const res = await POST(makeReq({}), createMockRouteParams({ id: 'tx-1' }))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(400)
|
|
})
|
|
|
|
it('returns 404 when transaction not in company', async () => {
|
|
enqueue({ data: null, error: null }) // tx fetch
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse(res)
|
|
expect(status).toBe(404)
|
|
expect(body).toEqual({ error: 'Transaction not found' })
|
|
})
|
|
|
|
it('returns 404 when document not in company', async () => {
|
|
enqueue({ data: { id: 'tx-1' }, error: null }) // tx fetch
|
|
enqueue({ data: null, error: null }) // doc fetch
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse(res)
|
|
expect(status).toBe(404)
|
|
expect(body).toEqual({ error: 'Document not found' })
|
|
})
|
|
|
|
it('attaches when both rows exist', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: null }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: { journal_entry_id: null }, error: null }) // transactions update (RETURNING)
|
|
enqueue({ data: null, error: null }) // inbox-link best-effort update
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ data: { transaction_id: string; document_id: string; journal_entry_id: string | null } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.transaction_id).toBe('tx-1')
|
|
expect(body.data.document_id).toBe('11111111-1111-4111-8111-111111111111')
|
|
expect(body.data.journal_entry_id).toBeNull()
|
|
// Unbooked tx: document_attachments is only read (doc fetch), never
|
|
// written: no journal entry to propagate to.
|
|
const fromCalls = mockSupabase.from.mock.calls.map((c) => c[0])
|
|
expect(fromCalls.filter((t) => t === 'document_attachments')).toHaveLength(1)
|
|
})
|
|
|
|
it('propagates the link onto the verifikation when the transaction is booked', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: 'je-1' }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: { journal_entry_id: 'je-1' }, error: null }) // transactions update (RETURNING)
|
|
enqueue({ data: null, error: null }) // inbox-link best-effort update
|
|
enqueue({ data: null, error: null }) // document_attachments propagation
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ data: { journal_entry_id: string } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.journal_entry_id).toBe('je-1')
|
|
// doc fetch + propagation write
|
|
const fromCalls = mockSupabase.from.mock.calls.map((c) => c[0])
|
|
expect(fromCalls.filter((t) => t === 'document_attachments')).toHaveLength(2)
|
|
})
|
|
|
|
it('skips propagation when the doc already points at the same verifikation (idempotent re-attach)', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: 'je-1' }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1' }, error: null }) // doc fetch
|
|
enqueue({ data: { journal_entry_id: 'je-1' }, error: null }) // transactions update (RETURNING)
|
|
enqueue({ data: null, error: null }) // inbox-link best-effort update
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(200)
|
|
// No propagation write: only the doc fetch touched document_attachments.
|
|
const fromCalls = mockSupabase.from.mock.calls.map((c) => c[0])
|
|
expect(fromCalls.filter((t) => t === 'document_attachments')).toHaveLength(1)
|
|
})
|
|
|
|
it('returns 409 when the document already belongs to a different verifikation', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: 'je-1' }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-OTHER' }, error: null }) // doc fetch
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: string }>(res)
|
|
expect(status).toBe(409)
|
|
expect(body.error).toContain('annan verifikation')
|
|
})
|
|
|
|
it('returns 409 when the verifikation period is locked during propagation', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: 'je-1' }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: { journal_entry_id: 'je-1' }, error: null }) // transactions update (RETURNING)
|
|
enqueue({ data: null, error: null }) // inbox-link best-effort update
|
|
enqueue({ data: null, error: { message: 'cannot link document in a locked/closed fiscal period' } }) // propagation blocked
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: string }>(res)
|
|
expect(status).toBe(409)
|
|
expect(body.error).toContain('låst')
|
|
})
|
|
|
|
it('returns 500 with the idempotent-retry message when propagation fails', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: 'je-1' }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: { journal_entry_id: 'je-1' }, error: null }) // transactions update (RETURNING)
|
|
enqueue({ data: null, error: null }) // inbox-link best-effort update
|
|
enqueue({ data: null, error: { message: 'boom' } }) // propagation fails
|
|
const spy = vi.spyOn(console, 'error').mockImplementation(() => {})
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: string }>(res)
|
|
expect(status).toBe(500)
|
|
expect(body.error).toContain('idempotent')
|
|
spy.mockRestore()
|
|
})
|
|
|
|
it('returns 404 when the update matches no row (concurrent delete)', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: null }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: null, error: null }) // transactions update returns no row
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(404)
|
|
})
|
|
|
|
it('attempts to update invoice_inbox_items.matched_transaction_id after successful attach', async () => {
|
|
// The side effect lets the inbox UI flip an item from "needs action" to
|
|
// "Kopplad till transaktion" without an extra round-trip.
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: null }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: { journal_entry_id: null }, error: null }) // transactions update (RETURNING)
|
|
enqueue({ data: null, error: null }) // inbox-link update
|
|
|
|
await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
// Verify the inbox_items table was touched.
|
|
const fromCalls = mockSupabase.from.mock.calls.map((c) => c[0])
|
|
expect(fromCalls).toContain('invoice_inbox_items')
|
|
})
|
|
|
|
it('tolerates a failing inbox-link update: the document attach is the primary effect', async () => {
|
|
enqueue({ data: { id: 'tx-1', journal_entry_id: null }, error: null }) // tx fetch
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: { journal_entry_id: null }, error: null }) // transactions update (RETURNING)
|
|
enqueue({ data: null, error: { message: 'rls denied' } }) // inbox-link fails
|
|
|
|
const spy = vi.spyOn(console, 'error').mockImplementation(() => {})
|
|
const res = await POST(
|
|
makeReq({ document_id: '11111111-1111-4111-8111-111111111111' }),
|
|
createMockRouteParams({ id: 'tx-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ data: { transaction_id: string } }>(res)
|
|
// Side-effect failure must not roll back the (compliant) document attach.
|
|
expect(status).toBe(200)
|
|
expect(body.data.transaction_id).toBe('tx-1')
|
|
// The Supabase client resolves with { error } rather than rejecting, so
|
|
// we additionally assert that the error was actually inspected and logged
|
|
// (not silently dropped by a try/catch that never fires).
|
|
expect(spy).toHaveBeenCalledWith(
|
|
'[attach-document] Failed to link inbox item:',
|
|
expect.objectContaining({ message: 'rls denied' }),
|
|
)
|
|
spy.mockRestore()
|
|
})
|
|
})
|
|
|
|
describe('DELETE /api/transactions/[id]/attach-document', () => {
|
|
it('returns 401 when not authenticated', async () => {
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
|
|
const res = await DELETE(makeReq(null, 'DELETE'), createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(res)
|
|
expect(status).toBe(401)
|
|
expect(body).toEqual({ error: 'Unauthorized' })
|
|
})
|
|
|
|
it('returns 404 when transaction not in company', async () => {
|
|
enqueue({ data: null, error: null }) // tx fetch
|
|
const res = await DELETE(makeReq(null, 'DELETE'), createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(res)
|
|
expect(status).toBe(404)
|
|
expect(body).toEqual({ error: 'Transaction not found' })
|
|
})
|
|
|
|
it('returns 409 when document is already on a journal entry', async () => {
|
|
enqueue({ data: { id: 'tx-1', document_id: 'doc-1' }, error: null }) // tx fetch
|
|
enqueue({ data: { journal_entry_id: 'je-1' }, error: null }) // doc fetch
|
|
const res = await DELETE(makeReq(null, 'DELETE'), createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse<{ error: string }>(res)
|
|
expect(status).toBe(409)
|
|
expect(body.error).toContain('verifikation')
|
|
})
|
|
|
|
it('clears document_id when no journal entry link', async () => {
|
|
enqueue({ data: { id: 'tx-1', document_id: 'doc-1' }, error: null }) // tx fetch
|
|
enqueue({ data: { journal_entry_id: null }, error: null }) // doc fetch
|
|
enqueue({ data: null, error: null }) // update
|
|
const res = await DELETE(makeReq(null, 'DELETE'), createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse<{ data: { document_id: string | null } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.document_id).toBeNull()
|
|
})
|
|
|
|
it('clears document_id when no doc was attached', async () => {
|
|
enqueue({ data: { id: 'tx-1', document_id: null }, error: null }) // tx fetch
|
|
enqueue({ data: null, error: null }) // update
|
|
const res = await DELETE(makeReq(null, 'DELETE'), createMockRouteParams({ id: 'tx-1' }))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(200)
|
|
})
|
|
})
|