Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
92 lines
2.7 KiB
TypeScript
92 lines
2.7 KiB
TypeScript
import { createClient } from '@/lib/supabase/server'
|
|
import { NextResponse } from 'next/server'
|
|
import { mergeWithDefaults } from '@/lib/reports/kpi-definitions'
|
|
import { requireCompanyId } from '@/lib/company/context'
|
|
import { requireWritePermission } from '@/lib/auth/require-write'
|
|
import type { KPIPreferences } from '@/types'
|
|
|
|
const EXTENSION_ID = 'core/kpi'
|
|
const KEY = 'preferences'
|
|
|
|
export async function GET() {
|
|
const supabase = await createClient()
|
|
const { data: { user } } = await supabase.auth.getUser()
|
|
if (!user) return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
|
|
|
|
const companyId = await requireCompanyId(supabase, user.id)
|
|
|
|
const { data } = await supabase
|
|
.from('extension_data')
|
|
.select('value')
|
|
.eq('company_id', companyId)
|
|
.eq('extension_id', EXTENSION_ID)
|
|
.eq('key', KEY)
|
|
.single()
|
|
|
|
const preferences = mergeWithDefaults((data?.value as Partial<KPIPreferences>) ?? {})
|
|
return NextResponse.json({ data: preferences })
|
|
}
|
|
|
|
export async function PUT(request: Request) {
|
|
const supabase = await createClient()
|
|
const { data: { user } } = await supabase.auth.getUser()
|
|
if (!user) return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
|
|
|
|
const writeCheck = await requireWritePermission(supabase, user.id)
|
|
if (!writeCheck.ok) return writeCheck.response
|
|
|
|
const companyId = await requireCompanyId(supabase, user.id)
|
|
|
|
let body: unknown
|
|
try {
|
|
body = await request.json()
|
|
} catch {
|
|
return NextResponse.json({ error: 'Invalid JSON' }, { status: 400 })
|
|
}
|
|
|
|
const prefs = body as Partial<KPIPreferences>
|
|
|
|
// Validate account overrides: must be 4-digit numeric strings
|
|
if (prefs.accountOverrides) {
|
|
for (const [kpiId, accounts] of Object.entries(prefs.accountOverrides)) {
|
|
if (!Array.isArray(accounts)) {
|
|
return NextResponse.json(
|
|
{ error: `accountOverrides.${kpiId} must be an array` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
for (const acc of accounts) {
|
|
if (typeof acc !== 'string' || !/^\d{4}$/.test(acc)) {
|
|
return NextResponse.json(
|
|
{ error: `Invalid account number "${acc}" in ${kpiId}: must be 4 digits` },
|
|
{ status: 400 }
|
|
)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
const merged = mergeWithDefaults(prefs)
|
|
|
|
const { data, error } = await supabase
|
|
.from('extension_data')
|
|
.upsert(
|
|
{
|
|
user_id: user.id,
|
|
company_id: companyId,
|
|
extension_id: EXTENSION_ID,
|
|
key: KEY,
|
|
value: merged,
|
|
},
|
|
{ onConflict: 'user_id,extension_id,key' }
|
|
)
|
|
.select()
|
|
.single()
|
|
|
|
if (error) {
|
|
return NextResponse.json({ error: error.message }, { status: 500 })
|
|
}
|
|
|
|
return NextResponse.json({ data: data.value })
|
|
}
|