Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
189 lines
6.0 KiB
TypeScript
189 lines
6.0 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { ensureInitialized } from '@/lib/init'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { errorResponse } from '@/lib/errors/get-structured-error'
|
|
import { UpdateRecurringScheduleSchema } from '@/lib/api/schemas'
|
|
|
|
ensureInitialized()
|
|
|
|
export const GET = withRouteContext(
|
|
'recurring_invoice.get',
|
|
async (_request, ctx, { params }: { params: Promise<{ id: string }> }) => {
|
|
const { id } = await params
|
|
const { supabase, companyId, log } = ctx
|
|
const { data, error } = await supabase
|
|
.from('recurring_invoice_schedules')
|
|
.select('*, customer:customers(*), items:recurring_invoice_schedule_items(*)')
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
if (error || !data) {
|
|
log.warn('recurring schedule not found', { scheduleId: id })
|
|
return NextResponse.json(
|
|
{ error: 'Schedule not found', type: 'not_found' },
|
|
{ status: 404 },
|
|
)
|
|
}
|
|
return NextResponse.json({ data })
|
|
},
|
|
)
|
|
|
|
export const PATCH = withRouteContext(
|
|
'recurring_invoice.update',
|
|
async (request, ctx, { params }: { params: Promise<{ id: string }> }) => {
|
|
const { id } = await params
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
|
|
let rawBody: unknown
|
|
try {
|
|
rawBody = await request.json()
|
|
} catch {
|
|
return NextResponse.json(
|
|
{ error: 'Invalid JSON in request body', type: 'validation_error' },
|
|
{ status: 400 },
|
|
)
|
|
}
|
|
|
|
const parsed = UpdateRecurringScheduleSchema.safeParse(rawBody)
|
|
if (!parsed.success) {
|
|
return NextResponse.json(
|
|
{
|
|
error: 'Validation failed',
|
|
type: 'validation_error',
|
|
errors: parsed.error.issues.map((i) => ({
|
|
field: i.path.join('.'),
|
|
message: i.message,
|
|
code: i.code,
|
|
})),
|
|
},
|
|
{ status: 400 },
|
|
)
|
|
}
|
|
const input = parsed.data
|
|
const { items, ...scheduleFields } = input
|
|
|
|
// Only forward fields the user actually supplied.
|
|
const updateRow: Record<string, unknown> = {}
|
|
for (const [k, v] of Object.entries(scheduleFields)) {
|
|
if (v !== undefined) updateRow[k] = v
|
|
}
|
|
|
|
if (Object.keys(updateRow).length > 0) {
|
|
const { error: updateError } = await supabase
|
|
.from('recurring_invoice_schedules')
|
|
.update(updateRow)
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
|
|
if (updateError) {
|
|
log.error('failed to update recurring schedule', updateError)
|
|
return errorResponse(updateError, log, { requestId })
|
|
}
|
|
}
|
|
|
|
if (items) {
|
|
// Replace items wholesale. Cheaper than diffing for a small list and
|
|
// matches how the UI form sends the full list back on every save.
|
|
const { data: existing } = await supabase
|
|
.from('recurring_invoice_schedules')
|
|
.select('id')
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
if (!existing) {
|
|
return NextResponse.json(
|
|
{ error: 'Schedule not found', type: 'not_found' },
|
|
{ status: 404 },
|
|
)
|
|
}
|
|
|
|
// Snapshot existing rows so we can restore them if the insert fails.
|
|
// Without this, a failed replace would leave the schedule with zero
|
|
// items and every subsequent cron run would throw "schedule has no
|
|
// items", silently skipping billing dates.
|
|
const { data: previousItems } = await supabase
|
|
.from('recurring_invoice_schedule_items')
|
|
.select('sort_order, description, quantity, unit, unit_price, vat_rate')
|
|
.eq('schedule_id', id)
|
|
|
|
await supabase
|
|
.from('recurring_invoice_schedule_items')
|
|
.delete()
|
|
.eq('schedule_id', id)
|
|
|
|
const itemRows = items.map((item, idx) => ({
|
|
schedule_id: id,
|
|
sort_order: idx,
|
|
description: item.description,
|
|
quantity: item.quantity,
|
|
unit: item.unit,
|
|
unit_price: item.unit_price,
|
|
vat_rate: item.vat_rate ?? null,
|
|
}))
|
|
const { error: itemsError } = await supabase
|
|
.from('recurring_invoice_schedule_items')
|
|
.insert(itemRows)
|
|
if (itemsError) {
|
|
log.error('failed to replace schedule items', itemsError)
|
|
// Restore the snapshot so the schedule stays valid for the cron.
|
|
if (previousItems && previousItems.length > 0) {
|
|
const restoreRows = previousItems.map((row) => ({
|
|
schedule_id: id,
|
|
sort_order: row.sort_order,
|
|
description: row.description,
|
|
quantity: row.quantity,
|
|
unit: row.unit,
|
|
unit_price: row.unit_price,
|
|
vat_rate: row.vat_rate,
|
|
}))
|
|
const { error: restoreError } = await supabase
|
|
.from('recurring_invoice_schedule_items')
|
|
.insert(restoreRows)
|
|
if (restoreError) {
|
|
log.error(
|
|
'failed to restore schedule items after failed replace: schedule may be left empty',
|
|
restoreError,
|
|
{ scheduleId: id },
|
|
)
|
|
}
|
|
}
|
|
return errorResponse(itemsError, log, { requestId })
|
|
}
|
|
}
|
|
|
|
const { data: complete } = await supabase
|
|
.from('recurring_invoice_schedules')
|
|
.select('*, customer:customers(*), items:recurring_invoice_schedule_items(*)')
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
return NextResponse.json({ data: complete })
|
|
},
|
|
{ requireWrite: true },
|
|
)
|
|
|
|
export const DELETE = withRouteContext(
|
|
'recurring_invoice.delete',
|
|
async (_request, ctx, { params }: { params: Promise<{ id: string }> }) => {
|
|
const { id } = await params
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
|
|
// Items cascade-delete via FK ON DELETE CASCADE.
|
|
const { error } = await supabase
|
|
.from('recurring_invoice_schedules')
|
|
.delete()
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
|
|
if (error) {
|
|
log.error('failed to delete recurring schedule', error)
|
|
return errorResponse(error, log, { requestId })
|
|
}
|
|
return NextResponse.json({ success: true })
|
|
},
|
|
{ requireWrite: true },
|
|
)
|