Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
66 lines
2.4 KiB
TypeScript
66 lines
2.4 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { ensureInitialized } from '@/lib/init'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
|
|
import { dissolveScheduleNow } from '@/lib/bookkeeping/accruals/service'
|
|
import {
|
|
ACCRUAL_NOTHING_TO_DISSOLVE,
|
|
ACCRUAL_SCHEDULE_NOT_ACTIVE,
|
|
ACCRUAL_SCHEDULE_NOT_FOUND,
|
|
isAccrualError,
|
|
} from '@/lib/bookkeeping/accruals/errors'
|
|
|
|
ensureInitialized()
|
|
|
|
/**
|
|
* POST /api/bookkeeping/accruals/[id]/dissolve
|
|
*
|
|
* "Lös upp nu": books the schedule's remaining months in ONE verifikat dated
|
|
* today (clamped by lock date) and completes the schedule. Used when the
|
|
* underlying service ends early or the user wants the rest expensed now.
|
|
* Cancelling-with-storno only happens via the credit flows: a standalone
|
|
* cancel would strand the interim-account balance.
|
|
*/
|
|
export const POST = withRouteContext<{ params: Promise<{ id: string }> }>(
|
|
'accruals.dissolve',
|
|
async (_request, ctx, { params }) => {
|
|
const { id } = await params
|
|
const { user, supabase, companyId, log, requestId } = ctx
|
|
|
|
try {
|
|
const result = await dissolveScheduleNow(supabase, companyId!, user.id, id)
|
|
// Manual financial write: log the acting user for auditability.
|
|
log.info('accrual schedule dissolved', {
|
|
userId: user.id,
|
|
companyId,
|
|
scheduleId: id,
|
|
amount: result.amount,
|
|
journalEntryId: result.journalEntryId,
|
|
})
|
|
return NextResponse.json({ data: result })
|
|
} catch (err) {
|
|
const reason = err instanceof Error ? err.message : 'unknown'
|
|
// Typed domain errors carry a stable code: never match Swedish prose.
|
|
if (isAccrualError(err)) {
|
|
switch (err.code) {
|
|
case ACCRUAL_SCHEDULE_NOT_FOUND:
|
|
return errorResponseFromCode('ACCRUAL_NOT_FOUND', log, { requestId })
|
|
case ACCRUAL_SCHEDULE_NOT_ACTIVE:
|
|
return errorResponseFromCode('ACCRUAL_NOT_ACTIVE', log, {
|
|
requestId,
|
|
details: { currentStatus: err.currentStatus },
|
|
})
|
|
case ACCRUAL_NOTHING_TO_DISSOLVE:
|
|
return errorResponseFromCode('ACCRUAL_NOTHING_TO_DISSOLVE', log, { requestId })
|
|
}
|
|
}
|
|
log.error('accrual dissolve failed', err as Error, { entityId: id })
|
|
return errorResponseFromCode('ACCRUAL_DISSOLVE_FAILED', log, {
|
|
requestId,
|
|
details: { reason },
|
|
})
|
|
}
|
|
},
|
|
{ requireWrite: true },
|
|
)
|