* feat(dimensions): PR10 advanced — custom dimensions, hierarchy, account rules, commit enforcement The final rung of the dimensions ladder (dev_docs/dimensions_implementation_plan.md §7 row 10): - custom dimensions: POST /api/dimensions creates registry dims (next free SIE number >= 20 when omitted; explicit numbers allowed — SIE import already mints reserved ones); register gets a 'Ny dimension' dialog with a quiet Avancerat disclosure for the #UNDERDIM parent; GET now carries parent_sie_dim_no (the column + SIE round-trip existed since PR1/PR5 — this exposes it) - account_dimension_rules (migration 20260703120000): one rule per (account, dimension) — required / default / fixed, per-rule is_active, company-scoped RLS, composite FK to the registry, value-presence CHECK - enforcement, opt-in BY CONSTRUCTION (zero rules = engine byte-identical; deliberately NO settings toggle — a rule that exists but is ignored is worse than either extreme): default/fixed apply onto line bags at draft creation (fixed overwrites, default fills); required asserts at commitEntry with a Swedish MANDATORY_DIMENSION_MISSING naming every account + dimension; the bulk-book route runs the same policy before its RPC; storno/correction paths never pass through commitEntry so history always reverses regardless of policy; rule fetches fail open incl. thrown exceptions - chart of accounts: per-account Dimensionsregler section in EditAccountDialog (Krävs/Förval/Låst, value picker, pause switch), gated on the existing dimensions toggle, quiet when empty - pickers: LineDimensionFields is registry-driven (one combobox per active dimension, cached fetch, hardcoded 1/6 fallback) — every existing mount lights up custom dims with zero changes - agent briefing: per-dimension required_on_accounts/default_on_accounts so agents self-correct instead of bouncing off the policy error - rules CRUD API with existence/active/company validation and qualified DTO ids; firm_id FK deferred until the firms table lands (per plan) 39 new tests (pure-fn rules, engine enforcement, both new API surfaces, pg-real RLS/CHECK/cascade suite); full suite 6,791 green; migration replayed on a fresh container. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: renumber migration to 20260703200000 — version collision with prod The concurrent session shipped pending_operations_add_link_document_to_voucher as 20260703120000 today; the Supabase preview branch (cloned from prod) rejected the duplicate version key. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix: review round — auto-pick retry on collision, fail-open warnings, query schema - POST /api/dimensions retries once past a concurrent number claim when the number was auto-picked (explicit choices still 409) - every fail-open skip of the dimension-rules policy now logs a structured warning (engine draft/commit paths + bulk-book) — deliberate fail-open, but observable - GET /api/dimensions/rules validates its query through ListDimensionRulesQuerySchema instead of an inline regex Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
92 lines
3.1 KiB
TypeScript
92 lines
3.1 KiB
TypeScript
'use client'
|
|
|
|
import { useEffect, useMemo, useState } from 'react'
|
|
import { Label } from '@/components/ui/label'
|
|
import DimensionCombobox from '@/components/dimensions/DimensionCombobox'
|
|
import {
|
|
fetchDimensionsCached,
|
|
type DimensionDto,
|
|
} from '@/components/dimensions/types'
|
|
|
|
interface LineDimensionFieldsProps {
|
|
/** Current dimensions map ({sie_dim_no: object_code}) — a line's map or the header default. */
|
|
dimensions: Record<string, string> | undefined
|
|
/** Fired per dimension; `code === null` clears the value. */
|
|
onChange: (sieDimNo: string, code: string | null) => void
|
|
disabled?: boolean
|
|
/** Vertical layout for narrow containers (row popover); default is a 2-col grid. */
|
|
stacked?: boolean
|
|
/** Extra classes merged into the combobox inputs (pass 'h-8' for dense contexts). */
|
|
inputClassName?: string
|
|
}
|
|
|
|
/**
|
|
* While the registry loads (or if the fetch fails) we render the seeded
|
|
* system pair (SIE dims 1/6) so the tagging affordance never disappears —
|
|
* the registry always contains at least these two.
|
|
*/
|
|
const FALLBACK_FIELDS: { sieDimNo: string; label: string }[] = [
|
|
{ sieDimNo: '1', label: 'Kostnadsställe' },
|
|
{ sieDimNo: '6', label: 'Projekt' },
|
|
]
|
|
|
|
/**
|
|
* Registry-driven dimension comboboxes used by the voucher form's header
|
|
* default, the per-row tag popover, and the mobile line cards. One combobox
|
|
* per active registry dimension, ordered by sort_order then sie_dim_no (the
|
|
* seeded 1/6 pair sorts first). Labels are the registry dimension names and
|
|
* hardcoded-Swedish fallbacks — the component mounts on the voucher editor,
|
|
* a stays-Swedish surface per .claude/rules/i18n.md (same convention as
|
|
* DimensionCombobox).
|
|
*/
|
|
export default function LineDimensionFields({
|
|
dimensions,
|
|
onChange,
|
|
disabled,
|
|
stacked,
|
|
inputClassName,
|
|
}: LineDimensionFieldsProps) {
|
|
const [registry, setRegistry] = useState<DimensionDto[] | null>(null)
|
|
|
|
useEffect(() => {
|
|
let cancelled = false
|
|
fetchDimensionsCached()
|
|
.then((dims) => {
|
|
if (!cancelled) setRegistry(dims)
|
|
})
|
|
.catch(() => {
|
|
/* keep the hardcoded 1/6 fallback */
|
|
})
|
|
return () => {
|
|
cancelled = true
|
|
}
|
|
}, [])
|
|
|
|
const fields = useMemo(() => {
|
|
const active = registry?.filter((d) => d.is_active) ?? []
|
|
if (active.length === 0) return FALLBACK_FIELDS
|
|
return [...active]
|
|
.sort((a, b) => a.sort_order - b.sort_order || a.sie_dim_no - b.sie_dim_no)
|
|
.map((d) => ({ sieDimNo: String(d.sie_dim_no), label: d.name }))
|
|
}, [registry])
|
|
|
|
return (
|
|
<div className={stacked ? 'space-y-3' : 'grid grid-cols-2 gap-3'}>
|
|
{fields.map((field) => (
|
|
<div key={field.sieDimNo}>
|
|
<Label className="text-xs text-muted-foreground">{field.label}</Label>
|
|
<div className="mt-1">
|
|
<DimensionCombobox
|
|
sieDimNo={field.sieDimNo}
|
|
value={dimensions?.[field.sieDimNo] ?? null}
|
|
onChange={(code) => onChange(field.sieDimNo, code)}
|
|
disabled={disabled}
|
|
className={inputClassName}
|
|
/>
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
)
|
|
}
|