Files
accounted/lib/events/handlers/__tests__/event-log-handler.test.ts
T
Jakob WennbergandClaude Opus 4.6 5cb8c3c1e4 feat: support contact links and SIE import UX polish (#138)
* feat: event log, pending operations, and MCP staging

- Event log system: persist bus events to event_log table for external
  automation platforms. Batch insert for transaction.synced. Daily
  cleanup cron at 02:00 UTC.
- Pending operations: MCP write tools (categorize, create customer,
  create invoice) now stage to pending_operations instead of executing
  directly. Users review and commit/reject from /pending in the web UI.
- Granskning page: card-based review UI with expandable previews,
  commit/reject dialogs. Only shown in nav when pending ops exist.
- Commit route re-executes using core lib functions (no extension
  imports). Guards against stale state (double-commit, deleted entities).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: stage new MCP write tools after main merge

Add staging for 4 new write tools from #133:
- mark_invoice_paid, send_invoice, mark_invoice_sent,
  match_transaction_invoice
- Expand pending_operations CHECK constraint
- Add commit executors with full execution logic
- Add UI labels and generic preview component
- Remove confirm parameter from categorize (single-call staging)
- Fix UUID in pending op title (fetch transaction description)
- Hide Granskning nav when no pending ops

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address PR review feedback

- Fix TS build error: use `select('*, customer:customers(*)')` for
  match_transaction_invoice to avoid array type inference
- Add status guard to commitSendInvoice (prevents duplicate sends)
- Replace auth.admin.getUserById with user email from session auth
- Restore optimistic lock check in commitMatchTransactionInvoice
- Fix tool description typo: expense_software → expense_office

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* feat: add support contact links and improve SIE import UX

Add a SupportLink component with a contact dialog throughout the app
(nav, help page, settings, MFA, error pages, empty states). Improve
SIE import flow with phased loading states, structured skip breakdowns,
and an elapsed-time counter. Fix MFA enroll stale factor cleanup and
URL encoding for settings return path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address PR review — open redirect, XSS, test cleanup, fallback email

- Validate returnTo is a relative path in MFA enroll (prevents open redirect)
- Add afterEach import to event-log-handler tests (fixes handler leak)
- HTML-escape user-supplied subject and message in support email body
- Replace hardcoded personal email with support@gnubok.se fallback

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-26 11:14:17 +01:00

155 lines
4.5 KiB
TypeScript

import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
import { eventBus } from '@/lib/events/bus'
import { makeTransaction, makeInvoice, makeCustomer, makeFiscalPeriod } from '@/tests/helpers'
// Mock the service client
const mockInsert = vi.fn().mockResolvedValue({ error: null })
vi.mock('@/lib/auth/api-keys', () => ({
createServiceClientNoCookies: () => ({
from: () => ({
insert: mockInsert,
}),
}),
}))
// Import after mocks
import { registerEventLogHandler } from '../event-log-handler'
describe('event-log-handler', () => {
let unsubscribers: (() => void)[]
beforeEach(() => {
vi.clearAllMocks()
eventBus.clear()
mockInsert.mockResolvedValue({ error: null })
unsubscribers = registerEventLogHandler()
})
afterEach(() => {
unsubscribers.forEach(unsub => unsub())
})
it('persists invoice.created event with correct entity_id', async () => {
const invoice = makeInvoice({ id: 'inv-123' })
await eventBus.emit({
type: 'invoice.created',
payload: { invoice, userId: 'user-1' },
})
expect(mockInsert).toHaveBeenCalledTimes(1)
expect(mockInsert).toHaveBeenCalledWith(
expect.objectContaining({
user_id: 'user-1',
event_type: 'invoice.created',
entity_id: 'inv-123',
})
)
// Data should NOT contain userId (it's in its own column)
const insertedData = mockInsert.mock.calls[0][0].data
expect(insertedData).not.toHaveProperty('userId')
expect(insertedData).toHaveProperty('invoice')
})
it('persists customer.created event', async () => {
const customer = makeCustomer({ id: 'cust-456' })
await eventBus.emit({
type: 'customer.created',
payload: { customer, userId: 'user-1' },
})
expect(mockInsert).toHaveBeenCalledTimes(1)
expect(mockInsert).toHaveBeenCalledWith(
expect.objectContaining({
user_id: 'user-1',
event_type: 'customer.created',
entity_id: 'cust-456',
})
)
})
it('batch-inserts transaction.synced as individual rows', async () => {
const tx1 = makeTransaction({ id: 'tx-1' })
const tx2 = makeTransaction({ id: 'tx-2' })
const tx3 = makeTransaction({ id: 'tx-3' })
await eventBus.emit({
type: 'transaction.synced',
payload: { transactions: [tx1, tx2, tx3], userId: 'user-1' },
})
expect(mockInsert).toHaveBeenCalledTimes(1)
const rows = mockInsert.mock.calls[0][0]
expect(rows).toHaveLength(3)
expect(rows[0]).toMatchObject({ event_type: 'transaction.synced', entity_id: 'tx-1' })
expect(rows[1]).toMatchObject({ event_type: 'transaction.synced', entity_id: 'tx-2' })
expect(rows[2]).toMatchObject({ event_type: 'transaction.synced', entity_id: 'tx-3' })
})
it('does NOT persist journal_entry.drafted (excluded noise event)', async () => {
await eventBus.emit({
type: 'journal_entry.drafted',
payload: { entry: {} as unknown, userId: 'user-1' },
})
expect(mockInsert).not.toHaveBeenCalled()
})
it('does NOT persist receipt.extracted (excluded noise event)', async () => {
await eventBus.emit({
type: 'receipt.extracted',
payload: { receipt: {} as unknown, documentId: null, confidence: 0.9, userId: 'user-1' },
})
expect(mockInsert).not.toHaveBeenCalled()
})
it('does NOT persist supplier_invoice.received (excluded noise event)', async () => {
await eventBus.emit({
type: 'supplier_invoice.received',
payload: { inboxItem: {} as unknown, userId: 'user-1' },
})
expect(mockInsert).not.toHaveBeenCalled()
})
it('does NOT persist supplier_invoice.extracted (excluded noise event)', async () => {
await eventBus.emit({
type: 'supplier_invoice.extracted',
payload: { inboxItem: {} as unknown, confidence: 0.9, userId: 'user-1' },
})
expect(mockInsert).not.toHaveBeenCalled()
})
it('does not throw when persistence fails', async () => {
mockInsert.mockResolvedValue({ error: { message: 'DB down' } })
// Should not throw
await eventBus.emit({
type: 'customer.created',
payload: { customer: makeCustomer(), userId: 'user-1' },
})
expect(mockInsert).toHaveBeenCalledTimes(1)
})
it('persists period.locked with period entity_id', async () => {
const period = makeFiscalPeriod({ id: 'period-1' })
await eventBus.emit({
type: 'period.locked',
payload: { period, userId: 'user-1' },
})
expect(mockInsert).toHaveBeenCalledWith(
expect.objectContaining({
event_type: 'period.locked',
entity_id: 'period-1',
})
)
})
})