* feat(dimensions): PR4 reports — dimension-filtered P&L everywhere + Resultat per projekt/kostnadsställe The Project P&L milestone of the dimensions plan (dev_docs §7 PR4). One choke point lights up everything: generateTrialBalance gains options.dimensions (SIE dim → code map) pushed down as jsonb containment (dimensions @>, served by idx_jel_dimensions_gin) on both line queries, with company-wide opening balances dropped when filtered (they cannot be dimension-scoped; P&L-safe by whitelist). Resultatrapport, resultaträkning, huvudbok, monthly-breakdown and the TB drill-down inherit the filter; the KPI route filters only its P&L-side inputs (income statement, months, expense composition) — never cash/VAT. New report lib/reports/dimension-pnl.ts — "Resultat per projekt/ kostnadsställe" (Fortnox Resultatrapport projekt): value-as-column matrix over one dimension with an explicit "(Utan dimension)" bucket computed as the residual against the same trial-balance pass resultatrapport uses, so every row and the Totalt column reconcile with the unfiltered resultatrapport by construction. Registered in REPORT_CATALOG (visible only when dimensions_enabled), slug-routed view + xlsx export. UI: DimensionFilter (dimension + value picker, persistent "Filtrerad — ej fullständig rapport" chip) mounts in FocusedReport for catalog entries flagged dimensions: true; huvudbok rows show line dim codes. Statutory exclusion pinned by TEST, not convention: lib/reports/__tests__/dimension-statutory-guard.test.ts fails if the filter parser leaks into balance sheet, balansrapport, kassaflöde, VAT, SIE or full-archive routes/generators, or if the catalog whitelist widens. MCP: new gnubok_get_dimension_pnl (reports:read); dimensions filter arg on get_trial_balance/get_income_statement/get_general_ledger with resolve-don't-select (names → registry codes, resolution echoes); query_journal totals fixed to aggregate the FULL match set (was silently slice-scoped while claiming otherwise) with an honest totals_scope field, plus group_by / group_by_dimension aggregation. Also: voucher-detail dim-6 badge now uses the registry name instead of the non-standard "PR" abbreviation (#859 review follow-up). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(dimensions): address #862 review — export disclosure, prior-column suppression, period-label honesty, route hardening - Filtered XLSX/PDF exports now carry the partial-view disclosure past the file boundary (BFNAR 2013:2): filename suffix (-dim6-p001), a "Filtrerad … — ej fullständig rapport" row on every sheet, and a header note/title line in the PDFs. - Resultatrapport drops the prior-year column when a dimension filter is active — project codes are time-limited under K2/K3, so "this code last year" may be a different project (same rule as narrowed date ranges). - dimension-pnl no longer accepts fromDate: the matrix is cumulative from period_start by design (closing-balance semantics), and the period label now states exactly that instead of echoing a lower bound that was never applied. Routes/MCP tool updated to toDate-only. - dimension-pnl routes 404 on an unknown/foreign period id and cap dim_no to 4 digits (matching the MCP tool's PostgREST-path guard, which the generator now also enforces itself). - Statutory-guard test's generateTrialBalance call-site scan is paren-aware instead of a 300-char window; added fully-untagged and injection-guard test cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
161 lines
5.5 KiB
TypeScript
161 lines
5.5 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
// ============================================================
|
|
// Dimension-filtered trial balance (dimensions PR4).
|
|
//
|
|
// Table-keyed FIFO mock like trial-balance.test.ts, extended with
|
|
// `contains`/`not` and per-table call capture so the jsonb containment
|
|
// pushdown is assertable.
|
|
// ============================================================
|
|
|
|
type MockResult = { data?: unknown; error?: unknown }
|
|
let mockResults: Record<string, MockResult[]>
|
|
let containsCalls: { table: string; column: string; value: unknown }[]
|
|
|
|
function makeBuilder(tableName: string) {
|
|
const b: Record<string, unknown> = {}
|
|
for (const m of ['select', 'eq', 'in', 'lt', 'lte', 'gte', 'neq', 'not', 'order', 'range']) {
|
|
b[m] = vi.fn().mockReturnValue(b)
|
|
}
|
|
b.contains = vi.fn().mockImplementation((column: string, value: unknown) => {
|
|
containsCalls.push({ table: tableName, column, value })
|
|
return b
|
|
})
|
|
const consume = (): MockResult => {
|
|
const queue = mockResults[tableName]
|
|
if (!queue || queue.length === 0) return { data: null, error: null }
|
|
return queue.shift()!
|
|
}
|
|
b.single = vi.fn().mockImplementation(async () => consume())
|
|
b.maybeSingle = vi.fn().mockImplementation(async () => consume())
|
|
b.then = (resolve: (v: unknown) => void) => resolve(consume())
|
|
return b
|
|
}
|
|
|
|
function makeClient() {
|
|
return {
|
|
from: vi.fn().mockImplementation((table: string) => makeBuilder(table)),
|
|
rpc: vi.fn().mockResolvedValue({ data: [], error: null }),
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
} as any
|
|
}
|
|
|
|
vi.mock('../opening-balances', () => ({
|
|
getOpeningBalances: vi.fn(),
|
|
}))
|
|
|
|
import { generateTrialBalance } from '../trial-balance'
|
|
import { getOpeningBalances } from '../opening-balances'
|
|
|
|
const mockOpeningBalances = vi.mocked(getOpeningBalances)
|
|
|
|
let supabase: ReturnType<typeof makeClient>
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockResults = {}
|
|
containsCalls = []
|
|
supabase = makeClient()
|
|
})
|
|
|
|
const PERIOD = { period_start: '2026-01-01', period_end: '2026-12-31', opening_balance_entry_id: null }
|
|
|
|
function seedCommon() {
|
|
mockResults = {
|
|
fiscal_periods: [{ data: PERIOD, error: null }],
|
|
journal_entry_lines: [
|
|
{
|
|
data: [
|
|
{ id: 'l1', account_number: '3001', debit_amount: 0, credit_amount: 500 },
|
|
{ id: 'l2', account_number: '1930', debit_amount: 500, credit_amount: 0 },
|
|
],
|
|
error: null,
|
|
},
|
|
],
|
|
chart_of_accounts: [
|
|
{
|
|
data: [
|
|
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
|
|
{ account_number: '3001', account_name: 'Försäljning', account_class: 3 },
|
|
],
|
|
error: null,
|
|
},
|
|
],
|
|
}
|
|
}
|
|
|
|
describe('generateTrialBalance — dimensions option', () => {
|
|
it('pushes the filter down as jsonb containment on the line query', async () => {
|
|
seedCommon()
|
|
mockOpeningBalances.mockResolvedValue({ balances: new Map(), obEntryId: null })
|
|
|
|
await generateTrialBalance(supabase, 'company-1', 'period-1', {
|
|
dimensions: { '6': 'P001' },
|
|
})
|
|
|
|
expect(containsCalls).toEqual([
|
|
{ table: 'journal_entry_lines', column: 'dimensions', value: { '6': 'P001' } },
|
|
])
|
|
})
|
|
|
|
it('does not touch the query when no filter is passed (back-compat)', async () => {
|
|
seedCommon()
|
|
mockOpeningBalances.mockResolvedValue({ balances: new Map(), obEntryId: null })
|
|
|
|
await generateTrialBalance(supabase, 'company-1', 'period-1')
|
|
|
|
expect(containsCalls).toEqual([])
|
|
})
|
|
|
|
it('treats an empty filter object as no filter', async () => {
|
|
seedCommon()
|
|
mockOpeningBalances.mockResolvedValue({ balances: new Map(), obEntryId: null })
|
|
|
|
await generateTrialBalance(supabase, 'company-1', 'period-1', { dimensions: {} })
|
|
|
|
expect(containsCalls).toEqual([])
|
|
})
|
|
|
|
it('drops company-wide opening balances when filtered — amounts are dimension-scoped activity only', async () => {
|
|
seedCommon()
|
|
// Company-wide IB on 1930 that CANNOT be dimension-scoped.
|
|
mockOpeningBalances.mockResolvedValue({
|
|
balances: new Map([['1930', { debit: 9000, credit: 0 }]]),
|
|
obEntryId: null,
|
|
})
|
|
|
|
const filtered = await generateTrialBalance(supabase, 'company-1', 'period-1', {
|
|
dimensions: { '6': 'P001' },
|
|
})
|
|
|
|
const bank = filtered.rows.find((r) => r.account_number === '1930')
|
|
expect(bank?.opening_debit).toBe(0)
|
|
expect(bank?.closing_debit).toBe(500) // period activity only
|
|
|
|
// Unfiltered keeps the IB (control).
|
|
seedCommon()
|
|
const unfiltered = await generateTrialBalance(supabase, 'company-1', 'period-1')
|
|
const bank2 = unfiltered.rows.find((r) => r.account_number === '1930')
|
|
expect(bank2?.opening_debit).toBe(9000)
|
|
expect(bank2?.closing_debit).toBe(9500)
|
|
})
|
|
|
|
it('applies the filter to the IB roll-forward query too (fromDate sub-range)', async () => {
|
|
seedCommon()
|
|
// Roll-forward query consumes the first journal_entry_lines result; add a
|
|
// second for the period query.
|
|
mockResults.journal_entry_lines.push({ data: [], error: null })
|
|
mockOpeningBalances.mockResolvedValue({ balances: new Map(), obEntryId: null })
|
|
|
|
await generateTrialBalance(supabase, 'company-1', 'period-1', {
|
|
fromDate: '2026-06-01',
|
|
dimensions: { '1': 'KS01' },
|
|
})
|
|
|
|
// Both line queries (roll-forward + period) carry the containment filter.
|
|
expect(containsCalls).toHaveLength(2)
|
|
expect(containsCalls.every((c) => c.column === 'dimensions')).toBe(true)
|
|
expect(containsCalls.every((c) => JSON.stringify(c.value) === '{"1":"KS01"}')).toBe(true)
|
|
})
|
|
})
|