Files
accounted/lib/import/__tests__/sie-import-derived-ib.test.ts
T
Jakob WennbergandClaude Fable 5 fb3fe82a56 feat(dimensions): PR5 SIE round-trip — lossless dimension import + undo lockstep (#866)
* feat(dimensions): PR5 SIE round-trip — lossless dimension import, registry upsert, undo lockstep

SIE import previously parsed and silently DISCARDED all dimension data
(object lists at sie-parser.ts:651-654, #DIM/#OBJEKT in the ignore list at
:689). Import is now lossless — the dimensions plan PR5 milestone.

Parser: #TRANS object lists ({1 "KS01" 6 "P001"}) land on the line as an
SIE-dim-no → code map (canonical numeric keys, quoted codes, malformed
pairs warn); #DIM/#UNDERDIM/#OBJEKT parse into registry records. OIB/OUB
stay ignored (dimension reporting is P&L-only in v1).

Importer (lib/import/sie-dimensions.ts): upserts missing dimensions/
dimension_values rows — never renames existing ones (ON CONFLICT DO
NOTHING); undeclared reserved numbers synthesize their SIE-standard names
(mirroring the export's orphan synthesis); codes violating the registry
CHECK are skipped with a warning but survive verbatim on lines (documented
legacy-free-text exception). Bulk voucher insert now writes the dimensions
jsonb + cost_center/project mirrors via the sanctioned dual-write helpers
(no trigger suppression needed — the immutability trigger guards
UPDATE/DELETE, not INSERT). Import auto-enables dimensions_enabled with a
result-card notice (pre-authorized by the column comment). arcim-migration
provider syncs inherit all of it via the shared parser/importer.

Undo lockstep (migration 20260702154500): created_by_import_id provenance
on both registry tables (ON DELETE SET NULL); undo_sie_import deletes the
values/dimensions the undone import introduced when no remaining
posted/reversed line references them — user-created rows and rows other
bookkeeping references are untouched. The registry guard triggers act as
backstop. replace_sie_import deliberately skips the lockstep (re-import
re-upserts the same codes). Six pg-real tests cover the lockstep.

Round-trip pinned by test: parse → import state → export → parse preserves
declarations (#UNDERDIM parent links included), values, and per-line object
lists — including synthesis of referenced-but-undeclared values.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(dimensions): restate function-local statement_timeout on undo_sie_import

CREATE OR REPLACE resets proconfig, so the 290s timeout from 20260629160100
was silently dropped — regressing service-client bulk deletes to the
authenticator role's 8s limit. Caught by sie-import.replace.pg.test.ts in CI.
Full pg-real suite green (483/483, TZ=UTC).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(dimensions): surface OIB/OUB drops and dimension presence as parse-level info (#866 review)

Dropping object-balance records must never be silent — one info issue counts
the skipped #OIB/#OUB rows (object-level balances are P&L-out-of-scope in
v1), and a second announces dimension data before the user executes the
import (the preview step renders parse issues), so the auto-enable notice is
no longer purely post-hoc.

Triage notes for the remaining findings: the RPC's opening SELECT is the
company-ownership check the swarm asked for; registry writes are RLS-bound;
line-verbatim codes are the documented legacy-free-text exception; export
emits no #KSUMMA so there is nothing to recompute; SIE dims 3–5 are
"reserved for future use" with no standard names, so generic synthesis is
spec-correct; ON DELETE SET NULL is deliberate — provenance is operational
metadata for undo, not räkenskapsinformation (the guarded journal lines
are), and RESTRICT would block legitimate post-retention housekeeping.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-02 16:05:13 +02:00

279 lines
9.0 KiB
TypeScript

/**
* Full-flow regression suite for issue #675.
*
* Some systems export SIE files without current-year #IB 0 records — the
* opening balances exist only implicitly via the SIE continuity invariant
* IB(year 0) = UB(year -1). executeSIEImport must derive the IB from the
* file's #UB -1 records, create a real opening-balance entry whose voucher
* text documents the derivation, and warn the user.
*
* The make-or-break line is the gate in executeSIEImport: it must open on
* the EFFECTIVE opening balances (getEffectiveOpeningBalances), not on raw
* parsed.openingBalances — the raw set is empty for these files.
*/
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { executeSIEImport } from '../sie-import'
import { createJournalEntry } from '@/lib/bookkeeping/engine'
import type { ParsedSIEFile, AccountMapping } from '../types'
import type { SupabaseClient } from '@supabase/supabase-js'
vi.mock('@/lib/bookkeeping/engine', () => ({
createJournalEntry: vi.fn(async () => ({ id: 'ob-entry-1' })),
reverseEntry: vi.fn(),
}))
// --- Helpers ---
type QueuedResult = { data?: unknown; error?: unknown; count?: number | null }
/**
* Table-routing supabase mock: each table has its own FIFO of results
* (consumed per .from(table) call), falling back to { data: null, error:
* null } when the queue is empty. Order-independent across tables, so the
* mock doesn't break when an unrelated query is added elsewhere in the flow.
*/
function buildRoutingSupabase(tableQueues: Record<string, QueuedResult[]>) {
const queues = new Map<string, QueuedResult[]>(
Object.entries(tableQueues).map(([k, v]) => [k, [...v]])
)
const makeChain = (result: { data: unknown; error: unknown; count: number | null }): unknown => {
const handler: ProxyHandler<object> = {
get(_target, prop) {
if (prop === 'then') {
return (resolve: (v: unknown) => void) => resolve(result)
}
return (..._args: unknown[]) => makeChain(result)
},
}
return new Proxy({}, handler)
}
const supabase = {
from: (table: string) => {
const next = queues.get(table)?.shift() ?? {}
return makeChain({
data: next.data ?? null,
error: next.error ?? null,
count: next.count ?? null,
})
},
rpc: async () => ({ data: null, error: null }),
storage: {
from: () => ({ upload: async () => ({ error: null }) }),
},
}
return supabase as unknown as SupabaseClient
}
function makeParsedFile(overrides?: Partial<ParsedSIEFile>): ParsedSIEFile {
return {
header: {
sieType: 4,
flagga: 0,
program: 'TestProg',
programVersion: '1.0',
generatedDate: '2024-01-01',
format: 'PC8',
companyName: 'Continuity AB',
orgNumber: '5566778899',
address: null,
fiscalYears: [
{ yearIndex: 0, start: '2024-01-01', end: '2024-12-31' },
{ yearIndex: -1, start: '2023-01-01', end: '2023-12-31' },
],
currency: 'SEK',
kontoPlanType: null,
},
accounts: [
{ number: '1930', name: 'Företagskonto' },
{ number: '2010', name: 'Eget kapital' },
],
// Issue #675 shape: no #IB 0 at all — only prior-year IB/UB and current UB.
openingBalances: [{ yearIndex: -1, account: '1930', amount: 9483.08 }],
closingBalances: [
{ yearIndex: -1, account: '1930', amount: 37400.78 },
{ yearIndex: -1, account: '2010', amount: -37400.78 },
{ yearIndex: 0, account: '1930', amount: 160406.0 },
{ yearIndex: 0, account: '2010', amount: -160406.0 },
],
resultBalances: [],
dimensions: [],
dimensionValues: [],
vouchers: [],
issues: [],
stats: {
totalAccounts: 2,
totalVouchers: 0,
totalTransactionLines: 0,
fiscalYearStart: '2024-01-01',
fiscalYearEnd: '2024-12-31',
},
...overrides,
}
}
function makeMapping(source: string, target: string): AccountMapping {
return {
sourceAccount: source,
sourceName: `Account ${source}`,
targetAccount: target,
targetName: `Target ${target}`,
confidence: 1,
matchType: 'exact',
isOverride: false,
}
}
function standardQueues() {
return {
sie_imports: [
{ data: null }, // checkDuplicateImport — no duplicate
{}, // cleanupStaleImportRecords delete
{ data: { id: 'imp-1' } }, // createPendingImportRecord insert
{ data: null }, // checkDuplicatePeriodImport — no duplicate
// finalizeImportRecord updates ride on defaults
],
chart_of_accounts: [
{
// syncMappedAccounts paged fetch — both accounts already exist
data: [
{ account_number: '1930', account_name: 'Företagskonto' },
{ account_number: '2010', account_name: 'Eget kapital' },
],
},
],
fiscal_periods: [
{ data: { id: 'fp-1' } }, // find existing fiscal period
{ data: { opening_balances_set: false, opening_balance_entry_id: null } }, // IB-block check
// link update + resync next-period lookup ride on defaults (null)
],
journal_entries: [
{ count: 0 }, // companyHasPriorActivity — first-ever import
],
}
}
const standardOptions = {
filename: 'continuity.se',
fileContent: '#dummy',
createFiscalPeriod: false,
importOpeningBalances: true,
importTransactions: true,
updateAccountNames: false,
}
const standardMappings = [makeMapping('1930', '1930'), makeMapping('2010', '2010')]
// --- Tests ---
describe('executeSIEImport — derived IB from #UB -1 (issue #675)', () => {
beforeEach(() => {
vi.clearAllMocks()
})
it('creates the opening-balance entry from #UB -1 when #IB 0 is missing', async () => {
const supabase = buildRoutingSupabase(standardQueues())
const result = await executeSIEImport(
supabase,
'company-1',
'user-1',
makeParsedFile(),
standardMappings,
standardOptions,
)
expect(result.errors).toEqual([])
expect(result.success).toBe(true)
expect(result.openingBalanceEntryId).toBe('ob-entry-1')
expect(result.journalEntriesCreated).toBe(1)
expect(result.warnings.join(' ')).toMatch(/kontinuitetsprincipen/)
expect(createJournalEntry).toHaveBeenCalledTimes(1)
const input = vi.mocked(createJournalEntry).mock.calls[0][3]
expect(input.source_type).toBe('opening_balance')
expect(input.fiscal_period_id).toBe('fp-1')
expect(input.entry_date).toBe('2024-01-01')
expect(input.description).toBe(
'Ingående balanser från SIE-import (härledda från föregående års utgående balans)'
)
expect(input.lines).toEqual([
{ account_number: '1930', debit_amount: 37400.78, credit_amount: 0, line_description: 'IB 1930' },
{ account_number: '2010', debit_amount: 0, credit_amount: 37400.78, line_description: 'IB 2010' },
])
})
it('uses the plain description and no continuity warning for explicit #IB 0', async () => {
const supabase = buildRoutingSupabase(standardQueues())
const parsed = makeParsedFile({
openingBalances: [
{ yearIndex: 0, account: '1930', amount: 37400.78 },
{ yearIndex: 0, account: '2010', amount: -37400.78 },
],
})
const result = await executeSIEImport(
supabase,
'company-1',
'user-1',
parsed,
standardMappings,
standardOptions,
)
expect(result.success).toBe(true)
expect(result.warnings.join(' ')).not.toMatch(/kontinuitetsprincipen/)
const input = vi.mocked(createJournalEntry).mock.calls[0][3]
expect(input.description).toBe('Ingående balanser från SIE-import')
})
it('respects the continuation guard — no derived IB when the company has prior activity', async () => {
const queues = standardQueues()
queues.journal_entries = [{ count: 5 }] // posted entries exist
const supabase = buildRoutingSupabase(queues)
const result = await executeSIEImport(
supabase,
'company-1',
'user-1',
makeParsedFile(),
standardMappings,
standardOptions,
)
expect(createJournalEntry).not.toHaveBeenCalled()
expect(result.openingBalanceEntryId).toBeNull()
expect(result.warnings.join(' ')).toMatch(/hoppades över eftersom bolaget redan har bokförda verifikationer/)
// Zero entries created → the finalizer safety net downgrades the run so
// the file slot stays free for a retry (existing behavior).
expect(result.success).toBe(false)
expect(result.errors.join(' ')).toMatch(/0 verifikationer/)
})
it('creates no IB entry when the file has neither #IB 0 nor #UB -1', async () => {
const supabase = buildRoutingSupabase(standardQueues())
const parsed = makeParsedFile({
openingBalances: [],
closingBalances: [
{ yearIndex: 0, account: '1930', amount: 160406.0 },
{ yearIndex: 0, account: '2010', amount: -160406.0 },
],
})
const result = await executeSIEImport(
supabase,
'company-1',
'user-1',
parsed,
standardMappings,
standardOptions,
)
expect(createJournalEntry).not.toHaveBeenCalled()
expect(result.openingBalanceEntryId).toBeNull()
})
})