Files
accounted/lib/bookkeeping/__tests__/account-search.test.ts
T
MattssonandClaude Opus 4.8 f63d3e3100 Bug/open banking flow (#854)
* fix(enable-banking): pin Mobile BankID (decoupled) auth_method so Handelsbanken corporate connects

We never sent auth_method to Enable Banking, so it fell back to the ASPSP's
visible default — REDIRECT for Handelsbanken. For Handelsbanken *corporate*
PSUs the redirect flow does not support Mobile BankID, so authorization failed
right after the user approved in the BankID app. Mobile BankID at Handelsbanken
is a DECOUPLED method flagged hidden_method=true, which Enable Banking only uses
when requested explicitly.

Resolve the bank's preferred auth method before /auth: query the ASPSP's
auth_methods and pick the DECOUPLED (Mobile BankID) method when present,
otherwise leave auth_method unset so banks that already work are untouched.
The method name is read dynamically per psu_type, so it is robust across
sandbox/production naming.

- api-client: add approach/hidden_method to AuthMethod, fix ASPSP.auth_methods
  field name (was available_auth_methods, never populated), add
  getPreferredAuthMethod(), thread optional authMethod through startAuthorization
- index: resolve authMethod in /connect and pass it on both fresh + reconnect
- tests: cover method selection and request-body shaping

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(invoice-inbox): clean up bulk-selection toolbar UI

Redesign the selection toolbar shown when inbox items are checked:
one solid primary "Bokför valda" button with outlined secondary
actions ("Fråga assistenten", "Ta bort") and a plain selection
count. Removes the redundant "Avmarkera" button (users uncheck the
still-visible box), fixes label clipping, and gives the toolbar more
breathing room.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(entitlements): bypass paywall in local development

Add isPaywallBypassed() so all gated capabilities are testable locally
without a subscription. Fires only on NODE_ENV=development (npm run dev)
or an explicit DISABLE_PAYWALL=true escape hatch — production builds run
under NODE_ENV=production and the entitlement suite runs under 'test',
so both keep exercising the real gate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(tic): resolve enskild firma bolagsuppgifter via 12-digit personnummer

TIC's Lens search is fuzzy and only resolves an enskild firma from the 12-digit (century-prefixed) personnummer; a 10-digit form fuzzy-matched an unrelated entity. Expand personnummer to 12 digits before querying and reject hits whose registration number is unrelated to the request. Add a "Hämta" action to the settings Bolagsuppgifter panel to (re)fetch on demand.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(transactions): implement categorize core for bank transaction categorization

- Added `categorize-core.ts` to handle categorization of bank transactions, supporting single and bulk operations.
- Introduced `categorizeMatchedTransaction` and `bulkBookMatchedInboxItems` functions for transaction processing.
- Implemented fiscal period validation and duplicate booking detection.
- Enhanced logging and error handling for transaction categorization.

feat(scripts): add diagnostic script for Handelsbanken ASPSP metadata

- Created `check-handelsbanken-aspsp.mjs` to fetch and display available authentication methods for Handelsbanken.
- Outputs metadata for business and personal PSU types, including default authentication methods.

fix(migrations): increase statement timeout for SIE bulk delete operations

- Updated `20260629160000_sie_bulk_delete_statement_timeout.sql` to set a longer statement timeout for bulk delete RPCs to prevent cancellations during large imports.

feat(migrations): add bulk book inbox items to pending operations

- Expanded `pending_operations` table to include `bulk_book_inbox_items` operation type in `20260630120000_pending_operations_add_bulk_book_inbox_items.sql`.
- Supports bulk booking of matched inbox items against bank transactions.

test(pg): add tests for replace_period_opening_balance_link RPC

- Implemented tests in `replace-period-opening-balance-link.pg.test.ts` to validate the functionality of the opening-balance correction flow.
- Ensured immutability of opening balance links and proper handling of posted vs. non-posted entries.

* fix(sie-export): update journal entries and lines handling in SIE export tests

* fix(migrations): resolve version collision on 20260629160000

The SIE bulk-delete statement_timeout migration shared version
20260629160000 with journal_entries_list_series_filter (merged from
main via #798/#823), causing a schema_migrations_pkey duplicate key
error on apply. Rename the branch's migration to 20260629160100.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(compliance): resolve compliance-swarm + review findings

- opening-balance/correct: compensating rollback for the non-atomic
  storno+rebook so a mid-sequence failure never leaves two posted OB
  entries (ASVS V2.3); durable audit event on every failure path
  (V16); reference the original verifikationsnummer in the corrected
  entry per BFL 5 kap 5§; document that requireWrite already enforces
  write-role + membership (V8.2.1 was a false positive)
- reports sources routes: validate the cursor date component as ISO
  (/^\d{4}-\d{2}-\d{2}$/) before use, 400 on malformed (ASVS V1.2),
  applied to both the VAT-declaration and trial-balance routes
- AgentSessionList: await the rename PATCH, revert the optimistic
  title and toast on failure (ASVS V4.5)
- bank booking: exclude same-batch siblings from the booking-time
  duplicate guard so bulk-booking distinct same-(date,amount)
  transactions no longer false-positives; pre-existing duplicate
  detection is preserved
- BulkBookInboxDialog: drop the unsafe currency-based reverse_charge
  default, add an omvänd skattskyldighet advisory, and type VAT
  options to the backend VatTreatment union
- OpeningBalanceRowEditor: hold onChange in a ref (synced in effect,
  not during render) so an unstable callback can't cause a render loop

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 18:13:00 +02:00

107 lines
4.6 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import {
foldText,
buildAccountIndex,
searchAccounts,
type SearchableAccount,
} from '../account-search'
// Synthetic fixtures — `active` is a minimal chart, `catalog` is the full BAS
// superset (and includes the active rows, as the real catalog does).
const active: SearchableAccount[] = [
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1, description: 'Företagets huvudsakliga bankkonto.' },
{ account_number: '5420', account_name: 'Programvaror', account_class: 5, description: 'Kostnader för mjukvara, prenumerationer och licenser.' },
{ account_number: '7010', account_name: 'Lönekostnader tjänstemän', account_class: 7, description: 'Bruttolöner till anställda tjänstemän.' },
]
const catalog: SearchableAccount[] = [
...active,
{ account_number: '6540', account_name: 'IT-tjänster', account_class: 6, description: 'Kostnader för extern IT-support, konsultation och drifttjänster.' },
{ account_number: '6550', account_name: 'Konsultarvoden', account_class: 6, description: 'Arvode till externa konsulter för rådgivning.' },
{ account_number: '6230', account_name: 'Datakommunikation', account_class: 6, description: 'Internet, bredband och fast uppkoppling.' },
{ account_number: '6570', account_name: 'Bankkostnader', account_class: 6, description: 'Avgifter för banktjänster och konsultation.' },
]
const idx = buildAccountIndex({ active, catalog })
const numbers = (items: { account_number: string }[]) => items.map((i) => i.account_number)
describe('foldText', () => {
it('lowercases and strips Swedish diacritics', () => {
expect(foldText('Lön')).toBe('lon')
expect(foldText('Intäkter')).toBe('intakter')
expect(foldText('IT-tjänster')).toBe('it-tjanster')
expect(foldText('Ränta')).toBe('ranta')
})
})
describe('searchAccounts', () => {
it('returns the active chart (only) for an empty query', () => {
const r = searchAccounts(idx, '')
expect(numbers(r)).toEqual(['1930', '5420', '7010'])
expect(r.every((i) => i.isActive)).toBe(true)
})
it('finds a catalog-only account by name even when it is not in the chart (the "IT" case)', () => {
const r = searchAccounts(idx, 'IT')
expect(numbers(r)).toContain('6540')
expect(r.find((i) => i.account_number === '6540')?.isActive).toBe(false)
})
it('matches words that are not the leading word of the name', () => {
expect(numbers(searchAccounts(idx, 'kommunikation'))).toContain('6230')
})
it('matches words found only in the description', () => {
// "drifttjänster" appears only in 6540's description, not its name.
expect(numbers(searchAccounts(idx, 'drifttjänster'))).toEqual(['6540'])
})
it('is diacritic-insensitive (query typed without å/ä/ö)', () => {
expect(numbers(searchAccounts(idx, 'lonekostnader'))).toContain('7010')
expect(numbers(searchAccounts(idx, 'lon'))).toContain('7010')
})
it('requires every token to match (token-AND), regardless of order or hyphen', () => {
// Both tokens live in 6540 (one in the name, one in the description).
expect(numbers(searchAccounts(idx, 'drift it'))).toEqual(['6540'])
// "extern konsultation": 6540 has both in its description; 6550/6570 miss one.
expect(numbers(searchAccounts(idx, 'extern konsultation'))).toEqual(['6540'])
})
it('prefix-matches account numbers across the full catalog', () => {
const r = searchAccounts(idx, '65')
expect(numbers(r).sort()).toEqual(['6540', '6550', '6570'])
expect(r.every((i) => !i.isActive)).toBe(true)
})
it('dedupes an account present in both active and catalog, preferring the active row', () => {
const r = searchAccounts(idx, '1930')
expect(r).toHaveLength(1)
expect(r[0].isActive).toBe(true)
})
it('ranks active accounts before catalog-only ones', () => {
const r = searchAccounts(idx, 'kostnad')
const firstCatalog = r.findIndex((i) => !i.isActive)
const lastActive = r.map((i) => i.isActive).lastIndexOf(true)
expect(lastActive).toBeLessThan(firstCatalog)
// Within active, a name hit outranks a description-only hit.
expect(r[0].account_number).toBe('7010')
})
it('ranks a name "starts-with" hit first', () => {
// "konsult": 6550 "Konsultarvoden" (name starts) over 6570 (description only).
const r = searchAccounts(idx, 'konsult')
expect(r[0].account_number).toBe('6550')
})
it('returns nothing for a query that matches no account', () => {
expect(searchAccounts(idx, 'zzzxyq')).toEqual([])
})
it('honours the result limit', () => {
expect(searchAccounts(idx, '', 2)).toHaveLength(2)
expect(searchAccounts(idx, '6', 2)).toHaveLength(2)
})
})