Files
accounted/lib/agent/intents/__tests__/verifikation-draft.test.ts
T
MattssonandClaude Opus 4.8 f63d3e3100 Bug/open banking flow (#854)
* fix(enable-banking): pin Mobile BankID (decoupled) auth_method so Handelsbanken corporate connects

We never sent auth_method to Enable Banking, so it fell back to the ASPSP's
visible default — REDIRECT for Handelsbanken. For Handelsbanken *corporate*
PSUs the redirect flow does not support Mobile BankID, so authorization failed
right after the user approved in the BankID app. Mobile BankID at Handelsbanken
is a DECOUPLED method flagged hidden_method=true, which Enable Banking only uses
when requested explicitly.

Resolve the bank's preferred auth method before /auth: query the ASPSP's
auth_methods and pick the DECOUPLED (Mobile BankID) method when present,
otherwise leave auth_method unset so banks that already work are untouched.
The method name is read dynamically per psu_type, so it is robust across
sandbox/production naming.

- api-client: add approach/hidden_method to AuthMethod, fix ASPSP.auth_methods
  field name (was available_auth_methods, never populated), add
  getPreferredAuthMethod(), thread optional authMethod through startAuthorization
- index: resolve authMethod in /connect and pass it on both fresh + reconnect
- tests: cover method selection and request-body shaping

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(invoice-inbox): clean up bulk-selection toolbar UI

Redesign the selection toolbar shown when inbox items are checked:
one solid primary "Bokför valda" button with outlined secondary
actions ("Fråga assistenten", "Ta bort") and a plain selection
count. Removes the redundant "Avmarkera" button (users uncheck the
still-visible box), fixes label clipping, and gives the toolbar more
breathing room.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* chore(entitlements): bypass paywall in local development

Add isPaywallBypassed() so all gated capabilities are testable locally
without a subscription. Fires only on NODE_ENV=development (npm run dev)
or an explicit DISABLE_PAYWALL=true escape hatch — production builds run
under NODE_ENV=production and the entitlement suite runs under 'test',
so both keep exercising the real gate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(tic): resolve enskild firma bolagsuppgifter via 12-digit personnummer

TIC's Lens search is fuzzy and only resolves an enskild firma from the 12-digit (century-prefixed) personnummer; a 10-digit form fuzzy-matched an unrelated entity. Expand personnummer to 12 digits before querying and reject hits whose registration number is unrelated to the request. Add a "Hämta" action to the settings Bolagsuppgifter panel to (re)fetch on demand.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(transactions): implement categorize core for bank transaction categorization

- Added `categorize-core.ts` to handle categorization of bank transactions, supporting single and bulk operations.
- Introduced `categorizeMatchedTransaction` and `bulkBookMatchedInboxItems` functions for transaction processing.
- Implemented fiscal period validation and duplicate booking detection.
- Enhanced logging and error handling for transaction categorization.

feat(scripts): add diagnostic script for Handelsbanken ASPSP metadata

- Created `check-handelsbanken-aspsp.mjs` to fetch and display available authentication methods for Handelsbanken.
- Outputs metadata for business and personal PSU types, including default authentication methods.

fix(migrations): increase statement timeout for SIE bulk delete operations

- Updated `20260629160000_sie_bulk_delete_statement_timeout.sql` to set a longer statement timeout for bulk delete RPCs to prevent cancellations during large imports.

feat(migrations): add bulk book inbox items to pending operations

- Expanded `pending_operations` table to include `bulk_book_inbox_items` operation type in `20260630120000_pending_operations_add_bulk_book_inbox_items.sql`.
- Supports bulk booking of matched inbox items against bank transactions.

test(pg): add tests for replace_period_opening_balance_link RPC

- Implemented tests in `replace-period-opening-balance-link.pg.test.ts` to validate the functionality of the opening-balance correction flow.
- Ensured immutability of opening balance links and proper handling of posted vs. non-posted entries.

* fix(sie-export): update journal entries and lines handling in SIE export tests

* fix(migrations): resolve version collision on 20260629160000

The SIE bulk-delete statement_timeout migration shared version
20260629160000 with journal_entries_list_series_filter (merged from
main via #798/#823), causing a schema_migrations_pkey duplicate key
error on apply. Rename the branch's migration to 20260629160100.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(compliance): resolve compliance-swarm + review findings

- opening-balance/correct: compensating rollback for the non-atomic
  storno+rebook so a mid-sequence failure never leaves two posted OB
  entries (ASVS V2.3); durable audit event on every failure path
  (V16); reference the original verifikationsnummer in the corrected
  entry per BFL 5 kap 5§; document that requireWrite already enforces
  write-role + membership (V8.2.1 was a false positive)
- reports sources routes: validate the cursor date component as ISO
  (/^\d{4}-\d{2}-\d{2}$/) before use, 400 on malformed (ASVS V1.2),
  applied to both the VAT-declaration and trial-balance routes
- AgentSessionList: await the rename PATCH, revert the optimistic
  title and toast on failure (ASVS V4.5)
- bank booking: exclude same-batch siblings from the booking-time
  duplicate guard so bulk-booking distinct same-(date,amount)
  transactions no longer false-positives; pre-existing duplicate
  detection is preserved
- BulkBookInboxDialog: drop the unsafe currency-based reverse_charge
  default, add an omvänd skattskyldighet advisory, and type VAT
  options to the backend VatTreatment union
- OpeningBalanceRowEditor: hold onChange in a ref (synced in effect,
  not during render) so an unstable callback can't cause a render loop

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-07-01 18:13:00 +02:00

140 lines
5.6 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import { verifikationDraft } from '../verifikation-draft'
// verifikation.draft is the assistant entry point on the manual bookkeeping
// surfaces (Bokföring → "Skapa med assistent", the Ny verifikat-dialog handoff,
// and a draft verifikat's own page). These tests lock in the two things that
// make it actually useful:
// 1. it carries the underlag-reading tools its ground rules already reference
// (the intent shipped without them — instructions for tools it couldn't
// call), and
// 2. the prompt drives "read the underlag → suggest accounts → stage a
// voucher", while guarding against duplicating an existing draft (there's
// no MCP edit-draft tool, so for an existing draft the agent must advise,
// not stage a second verifikat).
type Captured = Parameters<typeof verifikationDraft.promptTemplate>[0]['captured']
function baseCaptured(overrides: Partial<Captured> = {}): Captured {
return {
entry: null,
current_lines: [],
period_status: null,
description_hint: null,
underlag: [],
...overrides,
}
}
function renderPrompt(overrides: Partial<Captured> = {}, profileSummary: string | null = null): string {
return verifikationDraft.promptTemplate({
captured: baseCaptured(overrides),
profileSummary,
activeMemory: [],
})
}
describe('verifikation.draft tool scope', () => {
it('carries the underlag-reading tools its ground rules reference', () => {
// shared-rules.ts tells the agent to call gnubok_list_inbox_items /
// gnubok_get_document_content before proposing a booking. The intent
// originally omitted them, so those instructions were dead. Lock them in.
expect(verifikationDraft.tools).toContain('gnubok_get_document_content')
expect(verifikationDraft.tools).toContain('gnubok_list_inbox_items')
expect(verifikationDraft.tools).toContain('gnubok_get_inbox_item')
expect(verifikationDraft.tools).toContain('gnubok_list_unmatched_documents')
})
it('can still stage the voucher', () => {
expect(verifikationDraft.tools).toContain('gnubok_create_voucher')
})
})
describe('verifikation.draft prompt template', () => {
it('renders the shared ground rules (underlag-first discipline)', () => {
const out = renderPrompt()
expect(out).toContain('UNDERLAG FÖRST')
})
it('tells the agent to read the underlag before proposing accounts', () => {
const out = renderPrompt()
expect(out).toContain('UNDERLAG FÖRST.')
expect(out).toContain('gnubok_list_inbox_items')
expect(out).toContain('gnubok_get_document_content')
})
it('stages a new voucher and links the inbox underlag to it', () => {
const out = renderPrompt()
expect(out).toContain('gnubok_create_voucher')
// The kvitto must follow the booking — create_voucher takes inbox_item_id
// and attaches the OCR document on commit.
expect(out).toContain('inbox_item_id')
})
it('guards against duplicating an existing draft', () => {
// No MCP tool edits a draft in place, so for an existing draft the agent
// must advise (suggest accounts / check balance) rather than stage a
// second verifikat — otherwise "help me finish this draft" creates a dupe.
const out = renderPrompt({
entry: { id: 'e1', entry_date: '2026-05-01', description: 'Utkast', status: 'draft' },
})
expect(out).toContain('Staga INTE en ny verifikation för ett utkast som redan finns')
})
it('surfaces extracted underlag fields so the agent does not re-ask', () => {
const out = renderPrompt({
entry: { id: 'e1', entry_date: '2026-05-01', description: 'Inköp', status: 'draft' },
underlag: [
{
document_id: 'doc-1',
file_name: 'kvitto.pdf',
merchant_name: 'Clas Ohlson',
receipt_date: '2026-05-01',
total_amount: 499,
vat_amount: 99.8,
currency: 'SEK',
raw_extraction: null,
},
],
})
expect(out).toContain('UNDERLAG kopplat till verifikationen')
expect(out).toContain('Clas Ohlson')
expect(out).toContain('document_id=doc-1')
})
it('warns when the entry sits in a locked period', () => {
const out = renderPrompt({
entry: { id: 'e1', entry_date: '2025-12-31', description: 'Inköp', status: 'draft' },
period_status: { period_id: 'p1', status: 'locked', lock_date: '2025-12-31' },
})
expect(out).toContain('PERIODEN ÄR LÅST')
})
it('flags an unbalanced set of existing lines', () => {
const out = renderPrompt({
entry: { id: 'e1', entry_date: '2026-05-01', description: 'Inköp', status: 'draft' },
current_lines: [
{ account_number: '5410', debit_amount: 500, credit_amount: null, description: 'Förbrukning' },
{ account_number: '1930', debit_amount: null, credit_amount: 400, description: 'Bank' },
],
})
expect(out).toContain('debet ≠ kredit')
})
})
describe('verifikation.draft capture', () => {
it('returns an empty draft (with an underlag array) when no entry id is given', async () => {
// The fresh-start path (Bokföring → "Skapa med assistent") passes no
// journal_entry_id and must not touch the database — the agent discovers
// underlag itself via the inbox tools.
const captured = await verifikationDraft.capture(
{ description: 'Köp av router' },
{ supabase: {} as never, userId: 'u1', companyId: 'c1' },
)
expect(captured.entry).toBeNull()
expect(captured.current_lines).toEqual([])
expect(captured.underlag).toEqual([])
expect(captured.description_hint).toBe('Köp av router')
})
})