* feat(dimensions): PR4 reports — dimension-filtered P&L everywhere + Resultat per projekt/kostnadsställe The Project P&L milestone of the dimensions plan (dev_docs §7 PR4). One choke point lights up everything: generateTrialBalance gains options.dimensions (SIE dim → code map) pushed down as jsonb containment (dimensions @>, served by idx_jel_dimensions_gin) on both line queries, with company-wide opening balances dropped when filtered (they cannot be dimension-scoped; P&L-safe by whitelist). Resultatrapport, resultaträkning, huvudbok, monthly-breakdown and the TB drill-down inherit the filter; the KPI route filters only its P&L-side inputs (income statement, months, expense composition) — never cash/VAT. New report lib/reports/dimension-pnl.ts — "Resultat per projekt/ kostnadsställe" (Fortnox Resultatrapport projekt): value-as-column matrix over one dimension with an explicit "(Utan dimension)" bucket computed as the residual against the same trial-balance pass resultatrapport uses, so every row and the Totalt column reconcile with the unfiltered resultatrapport by construction. Registered in REPORT_CATALOG (visible only when dimensions_enabled), slug-routed view + xlsx export. UI: DimensionFilter (dimension + value picker, persistent "Filtrerad — ej fullständig rapport" chip) mounts in FocusedReport for catalog entries flagged dimensions: true; huvudbok rows show line dim codes. Statutory exclusion pinned by TEST, not convention: lib/reports/__tests__/dimension-statutory-guard.test.ts fails if the filter parser leaks into balance sheet, balansrapport, kassaflöde, VAT, SIE or full-archive routes/generators, or if the catalog whitelist widens. MCP: new gnubok_get_dimension_pnl (reports:read); dimensions filter arg on get_trial_balance/get_income_statement/get_general_ledger with resolve-don't-select (names → registry codes, resolution echoes); query_journal totals fixed to aggregate the FULL match set (was silently slice-scoped while claiming otherwise) with an honest totals_scope field, plus group_by / group_by_dimension aggregation. Also: voucher-detail dim-6 badge now uses the registry name instead of the non-standard "PR" abbreviation (#859 review follow-up). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(dimensions): address #862 review — export disclosure, prior-column suppression, period-label honesty, route hardening - Filtered XLSX/PDF exports now carry the partial-view disclosure past the file boundary (BFNAR 2013:2): filename suffix (-dim6-p001), a "Filtrerad … — ej fullständig rapport" row on every sheet, and a header note/title line in the PDFs. - Resultatrapport drops the prior-year column when a dimension filter is active — project codes are time-limited under K2/K3, so "this code last year" may be a different project (same rule as narrowed date ranges). - dimension-pnl no longer accepts fromDate: the matrix is cumulative from period_start by design (closing-balance semantics), and the period label now states exactly that instead of echoing a lower bound that was never applied. Routes/MCP tool updated to toDate-only. - dimension-pnl routes 404 on an unknown/foreign period id and cap dim_no to 4 digits (matching the MCP tool's PostgREST-path guard, which the generator now also enforces itself). - Statutory-guard test's generateTrialBalance call-site scan is paren-aware instead of a 300-char window; added fully-untagged and injection-guard test cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
133 lines
4.0 KiB
TypeScript
133 lines
4.0 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { generateDimensionPnl } from '@/lib/reports/dimension-pnl'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
|
|
import { parseReportDateRange } from '@/lib/reports/date-range'
|
|
import {
|
|
reportToWorkbook,
|
|
textColumn,
|
|
currencyColumn,
|
|
xlsxFilename,
|
|
} from '@/lib/reports/xlsx-export'
|
|
import type { DimensionPnlReport } from '@/types'
|
|
|
|
// One row per account; the dimension values are dynamic columns, exactly as
|
|
// the on-screen matrix renders. Column labels stay Swedish (report surface).
|
|
type FlatRow = {
|
|
group: string
|
|
account_number: string
|
|
account_name: string
|
|
values: number[]
|
|
total: number
|
|
}
|
|
|
|
export const GET = withRouteContext(
|
|
'report.dimension_pnl_xlsx',
|
|
async (request, ctx) => {
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
|
|
const { searchParams } = new URL(request.url)
|
|
const periodId = searchParams.get('period_id')
|
|
const dimNo = searchParams.get('dim_no') ?? '6'
|
|
|
|
if (!periodId) {
|
|
return errorResponseFromCode('REPORT_PERIOD_REQUIRED', log, { requestId })
|
|
}
|
|
if (!/^[1-9]\d{0,3}$/.test(dimNo)) {
|
|
return NextResponse.json({ error: 'dim_no must be an SIE dimension number' }, { status: 400 })
|
|
}
|
|
|
|
const [{ data: companyRow }, { data: period }] = await Promise.all([
|
|
supabase
|
|
.from('company_settings')
|
|
.select('company_name')
|
|
.eq('company_id', companyId)
|
|
.single(),
|
|
supabase
|
|
.from('fiscal_periods')
|
|
.select('period_start, period_end')
|
|
.eq('id', periodId)
|
|
.eq('company_id', companyId)
|
|
.single(),
|
|
])
|
|
|
|
if (!period) {
|
|
return NextResponse.json({ error: 'Fiscal period not found' }, { status: 404 })
|
|
}
|
|
|
|
const parsed = parseReportDateRange(searchParams, period)
|
|
if (!parsed.ok) {
|
|
return NextResponse.json({ error: parsed.error }, { status: 400 })
|
|
}
|
|
|
|
try {
|
|
// Only toDate — the matrix is cumulative from period_start by design.
|
|
const report: DimensionPnlReport = await generateDimensionPnl(
|
|
supabase,
|
|
companyId!,
|
|
periodId,
|
|
dimNo,
|
|
{ toDate: parsed.range.toDate },
|
|
)
|
|
|
|
const valueHeaders = report.columns.map((c) =>
|
|
c.code === null ? '(Utan dimension)' : c.name ? `${c.code} ${c.name}` : c.code,
|
|
)
|
|
|
|
const rows: FlatRow[] = []
|
|
for (const g of report.groups) {
|
|
for (const r of g.rows) {
|
|
rows.push({
|
|
group: g.class_label,
|
|
account_number: r.account_number,
|
|
account_name: r.account_name,
|
|
values: r.values,
|
|
total: r.total,
|
|
})
|
|
}
|
|
}
|
|
rows.push({
|
|
group: 'Resultat',
|
|
account_number: '',
|
|
account_name: 'Beräknat resultat',
|
|
values: report.net_per_column,
|
|
total: report.net_total,
|
|
})
|
|
|
|
const workbook = reportToWorkbook<FlatRow>([
|
|
{
|
|
name: `Resultat per ${report.dimension.name}`.slice(0, 31),
|
|
columns: [
|
|
textColumn('Grupp'),
|
|
textColumn('Konto'),
|
|
textColumn('Benämning'),
|
|
...valueHeaders.map((h) => currencyColumn(h)),
|
|
currencyColumn('Totalt'),
|
|
],
|
|
rows,
|
|
mapRow: (r) => [r.group, r.account_number, r.account_name, ...r.values, r.total],
|
|
},
|
|
])
|
|
|
|
const filename = xlsxFilename(
|
|
'resultat-per-dimension',
|
|
companyRow?.company_name ?? '',
|
|
report.period.end,
|
|
)
|
|
|
|
return new NextResponse(new Uint8Array(workbook), {
|
|
headers: {
|
|
'Content-Type': 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
|
|
'Content-Disposition': `attachment; filename="${filename}"`,
|
|
},
|
|
})
|
|
} catch (err) {
|
|
log.error('dimension pnl xlsx failed', err as Error, { periodId, dimNo })
|
|
return errorResponseFromCode('REPORT_GENERATION_FAILED', log, {
|
|
requestId,
|
|
details: { reason: err instanceof Error ? err.message : 'unknown' },
|
|
})
|
|
}
|
|
},
|
|
)
|