Files
accounted/app/api/dimensions/__tests__/import-existing.test.ts
T
Jakob WennbergandClaude Fable 5 8bb49c07a2 feat(dimensions): PR2 registry — CRUD API, register UI, settings toggle, SIE export on the new registry (#858)
* feat(dimensions): PR2 registry — CRUD API, register UI, settings toggle, SIE export on the new registry

Phase 2 of dev_docs/dimensions_implementation_plan.md. Companies with
dimensions_enabled=false (default) see zero change.

API:
- Dashboard CRUD: GET /api/dimensions (lazy-seeds system dims 1/6 via the
  ensure_company_dimensions RPC), PATCH /api/dimensions/[id] (is_system
  rename blocked), POST/PATCH/DELETE values (code immutable after creation;
  strict Fortnox code format ^[A-Za-z0-9ÅÄÖåäö_+\-]{1,20}$ at the API layer;
  retention-trigger deletes surface the Swedish "arkivera istället" message
  as 409 DIMENSION_VALUE_REFERENCED).
- POST /api/dimensions/import-existing — scans journal_entry_lines.dimensions
  for unregistered codes and mints inactive placeholder registry rows.
- v1 public API: GET dimensions + POST values (Idempotency-Key, dry-run),
  registered in the OpenAPI spec (102→104 endpoints).
- dimensions_enabled boolean on company_settings (new migration,
  UI-visibility only, never correctness-bearing) exposed through the
  existing settings read/update path.

SIE export (lib/reports/sie-export.ts):
- Reads the new dimensions/dimension_values registry; legacy
  cost_centers/projects tables now have zero readers (drop migration next).
- Fixes the latent Visma-rejection bug: #OBJEKT now declared for INACTIVE
  values referenced by lines.
- Generic-N: #DIM/#UNDERDIM loop sorted by sie_dim_no; #TRANS object lists
  serialize from the line JSONB map (sorted, '01'→'1' collapse); orphan
  codes/dims synthesize declarations from the SIE reserved-number seed —
  every referenced (dim, code) pair is guaranteed declared.

UI:
- /dimensions register (Register-recipe): tabs per dimension, search,
  sortable table, value dialog (code immutable on edit, projekt dates on
  dim 6), archive-not-delete affordances.
- DimensionCombobox shipped (mounts in the tagging PR).
- Settings toggle "Aktivera kostnadsställen & projekt" — toggle-on runs the
  import-existing scan and links to the register.
- Nav row in redovisning, rendered only when dimensions_enabled (same
  mechanism as pays_salaries).
- dimensions.* i18n namespace (51 keys, sv/en parity).
- Sandbox seed: demo dims + values, revenue line tagged {"1":"BUTIK","6":"P001"}.

Verified: 6328/6328 unit tests, guard + coverage gate green, tsc parity with
main (210=210), production build passes.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(dimensions): PR2 review round — atomic archived-create, UNDERDIM ordering, import robustness, date semantics

- POST values accepts is_active so "create as archived" is atomic; the UI's
  fragile create-then-PATCH fallback is deleted (PR Agent finding 1).
- DimensionCombobox blur revert reads the committed value/values through refs
  so a selection landing inside the 150ms window always wins (finding 2).
- import-existing sanitizes candidate codes like the PR1 backfill and upserts
  with ignoreDuplicates — one bad/duplicate code can no longer abort the
  batch; created counted from returned rows (finding 3).
- SIE export emits all root #DIM before any #UNDERDIM so a parent always
  precedes a lower-numbered child (SIE4 declaration order — Swedish review);
  synthesized placeholder declarations now log one structured warning
  (BFNAR 2013:2 behandlingshistorik) + defence-in-depth comment.
- Value dates rejected (400 DIMENSION_VALUE_DATES_NOT_ALLOWED) when the
  parent dimension is flow-period (resets_annually=true); explicit null
  still clears (Swedish review).
- Sandbox seed logs seeded dimension codes; GET /api/dimensions documents
  the deliberate absence of dimensions_enabled gating (UI-visibility flag,
  not a security boundary — compliance-swarm V8.2.1 rejected by design).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-02 12:26:42 +02:00

173 lines
6.3 KiB
TypeScript

/**
* Tests for POST /api/dimensions/import-existing (backfill scan).
*
* Covers: 401, the empty-company early exit, the happy path where codes
* found on journal lines but missing from the registry are created as
* inactive placeholder values ({ created: n }), code sanitization (PR1
* backfill parity), and duplicate-tolerant upserts.
*/
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { NextResponse } from 'next/server'
import { createQueuedMockSupabase, createMockRequest, parseJsonResponse } from '@/tests/helpers'
const { supabase, enqueue, reset } = createQueuedMockSupabase()
const requireAuthMock = vi.fn()
vi.mock('@/lib/auth/require-auth', () => ({
requireAuth: (...args: unknown[]) => requireAuthMock(...args),
}))
vi.mock('@/lib/company/context', () => ({
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
}))
vi.mock('@/lib/auth/require-write', () => ({
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
}))
vi.mock('@/lib/init', () => ({ ensureInitialized: vi.fn() }))
import { POST } from '../import-existing/route'
const request = () => createMockRequest('/api/dimensions/import-existing', { method: 'POST' })
const noParams = { params: Promise.resolve({}) }
describe('POST /api/dimensions/import-existing', () => {
beforeEach(() => {
vi.clearAllMocks()
reset()
requireAuthMock.mockResolvedValue({ user: { id: 'user-1' }, supabase })
})
it('returns 401 when not authenticated', async () => {
requireAuthMock.mockResolvedValue({
error: NextResponse.json({ error: 'Unauthorized' }, { status: 401 }),
})
const response = await POST(request(), noParams)
expect(response.status).toBe(401)
})
it('returns { created: 0 } when no line carries dimensions', async () => {
enqueue({ data: null }) // ensure RPC
enqueue({ data: [] }) // journal_entry_lines scan
const response = await POST(request(), noParams)
const { status, body } = await parseJsonResponse<{ created: number }>(response)
expect(status).toBe(200)
expect(body.created).toBe(0)
})
it('creates inactive placeholder values for codes missing from the registry', async () => {
enqueue({ data: null }) // ensure RPC
// Lines: KS01 (dim 1) appears twice, P001 (dim 6) once, BUTIK already registered.
enqueue({
data: [
{ id: 'l1', dimensions: { '1': 'KS01' } },
{ id: 'l2', dimensions: { '1': 'KS01', '6': 'P001' } },
{ id: 'l3', dimensions: { '1': 'BUTIK' } },
],
})
// Registry dims 1 & 6 exist (system dims).
enqueue({
data: [
{ id: 'dim-1', sie_dim_no: 1 },
{ id: 'dim-6', sie_dim_no: 6 },
],
})
// Existing values: BUTIK is already registered under dim 1.
enqueue({ data: [{ dimension_id: 'dim-1', code: 'BUTIK' }] })
// Upsert of the two missing values succeeds — created counts returned rows.
enqueue({ data: [{ id: 'nv1' }, { id: 'nv2' }] })
const response = await POST(request(), noParams)
const { status, body } = await parseJsonResponse<{ created: number }>(response)
expect(status).toBe(200)
expect(body.created).toBe(2) // KS01 + P001; BUTIK skipped (already registered)
})
it('sanitizes candidate codes like the PR1 backfill and de-duplicates after sanitization', async () => {
enqueue({ data: null }) // ensure RPC
// 'KS"01"' and 'KS{01}' both sanitize to KS01 (one candidate); a 50-char
// code is capped at 40; '"{}"' sanitizes to empty and is dropped entirely.
enqueue({
data: [
{ id: 'l1', dimensions: { '1': 'KS"01"' } },
{ id: 'l2', dimensions: { '1': 'KS{01}' } },
{ id: 'l3', dimensions: { '1': 'X'.repeat(50) } },
{ id: 'l4', dimensions: { '1': '"{}"' } },
],
})
enqueue({ data: [{ id: 'dim-1', sie_dim_no: 1 }] }) // registry dims
enqueue({ data: [] }) // no existing values
// Upsert returns the two surviving sanitized codes (KS01 + the capped one).
enqueue({ data: [{ id: 'nv1' }, { id: 'nv2' }] })
const response = await POST(request(), noParams)
const { status, body } = await parseJsonResponse<{ created: number }>(response)
expect(status).toBe(200)
expect(body.created).toBe(2)
})
it('tolerates duplicates in the batch — created counts only the rows the upsert returned', async () => {
enqueue({ data: null }) // ensure RPC
enqueue({
data: [
{ id: 'l1', dimensions: { '1': 'KS01' } },
{ id: 'l2', dimensions: { '1': 'KS02' } },
],
})
enqueue({ data: [{ id: 'dim-1', sie_dim_no: 1 }] }) // registry dims
enqueue({ data: [] }) // existing-values snapshot missed a raced KS02
// ignoreDuplicates upsert skips the conflicting row instead of aborting
// the batch — only KS01 comes back.
enqueue({ data: [{ id: 'nv1' }] })
const response = await POST(request(), noParams)
const { status, body } = await parseJsonResponse<{ created: number }>(response)
expect(status).toBe(200)
expect(body.created).toBe(1)
})
it('creates a registry dimension for an unregistered dim number found on lines', async () => {
enqueue({ data: null }) // ensure RPC
enqueue({ data: [{ id: 'l1', dimensions: { '7': 'AVD-A' } }] }) // lines
// Registry only has the system dims — dim 7 is missing.
enqueue({
data: [
{ id: 'dim-1', sie_dim_no: 1 },
{ id: 'dim-6', sie_dim_no: 6 },
],
})
// Upsert of the missing dimension row returns its id.
enqueue({ data: [{ id: 'dim-7', sie_dim_no: 7 }] })
// No existing values.
enqueue({ data: [] })
// Value upsert succeeds.
enqueue({ data: [{ id: 'nv1' }] })
const response = await POST(request(), noParams)
const { status, body } = await parseJsonResponse<{ created: number }>(response)
expect(status).toBe(200)
expect(body.created).toBe(1)
})
it('returns 500 DIMENSION_IMPORT_FAILED when the scan blows up', async () => {
enqueue({ data: null }) // ensure RPC
enqueue({ error: { message: 'relation missing' } }) // fetchAllRows throws
const response = await POST(request(), noParams)
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
expect(status).toBe(500)
expect(body.error.code).toBe('DIMENSION_IMPORT_FAILED')
})
})