* feat(dimensions): PR2 registry — CRUD API, register UI, settings toggle, SIE export on the new registry
Phase 2 of dev_docs/dimensions_implementation_plan.md. Companies with
dimensions_enabled=false (default) see zero change.
API:
- Dashboard CRUD: GET /api/dimensions (lazy-seeds system dims 1/6 via the
ensure_company_dimensions RPC), PATCH /api/dimensions/[id] (is_system
rename blocked), POST/PATCH/DELETE values (code immutable after creation;
strict Fortnox code format ^[A-Za-z0-9ÅÄÖåäö_+\-]{1,20}$ at the API layer;
retention-trigger deletes surface the Swedish "arkivera istället" message
as 409 DIMENSION_VALUE_REFERENCED).
- POST /api/dimensions/import-existing — scans journal_entry_lines.dimensions
for unregistered codes and mints inactive placeholder registry rows.
- v1 public API: GET dimensions + POST values (Idempotency-Key, dry-run),
registered in the OpenAPI spec (102→104 endpoints).
- dimensions_enabled boolean on company_settings (new migration,
UI-visibility only, never correctness-bearing) exposed through the
existing settings read/update path.
SIE export (lib/reports/sie-export.ts):
- Reads the new dimensions/dimension_values registry; legacy
cost_centers/projects tables now have zero readers (drop migration next).
- Fixes the latent Visma-rejection bug: #OBJEKT now declared for INACTIVE
values referenced by lines.
- Generic-N: #DIM/#UNDERDIM loop sorted by sie_dim_no; #TRANS object lists
serialize from the line JSONB map (sorted, '01'→'1' collapse); orphan
codes/dims synthesize declarations from the SIE reserved-number seed —
every referenced (dim, code) pair is guaranteed declared.
UI:
- /dimensions register (Register-recipe): tabs per dimension, search,
sortable table, value dialog (code immutable on edit, projekt dates on
dim 6), archive-not-delete affordances.
- DimensionCombobox shipped (mounts in the tagging PR).
- Settings toggle "Aktivera kostnadsställen & projekt" — toggle-on runs the
import-existing scan and links to the register.
- Nav row in redovisning, rendered only when dimensions_enabled (same
mechanism as pays_salaries).
- dimensions.* i18n namespace (51 keys, sv/en parity).
- Sandbox seed: demo dims + values, revenue line tagged {"1":"BUTIK","6":"P001"}.
Verified: 6328/6328 unit tests, guard + coverage gate green, tsc parity with
main (210=210), production build passes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(dimensions): PR2 review round — atomic archived-create, UNDERDIM ordering, import robustness, date semantics
- POST values accepts is_active so "create as archived" is atomic; the UI's
fragile create-then-PATCH fallback is deleted (PR Agent finding 1).
- DimensionCombobox blur revert reads the committed value/values through refs
so a selection landing inside the 150ms window always wins (finding 2).
- import-existing sanitizes candidate codes like the PR1 backfill and upserts
with ignoreDuplicates — one bad/duplicate code can no longer abort the
batch; created counted from returned rows (finding 3).
- SIE export emits all root #DIM before any #UNDERDIM so a parent always
precedes a lower-numbered child (SIE4 declaration order — Swedish review);
synthesized placeholder declarations now log one structured warning
(BFNAR 2013:2 behandlingshistorik) + defence-in-depth comment.
- Value dates rejected (400 DIMENSION_VALUE_DATES_NOT_ALLOWED) when the
parent dimension is flow-period (resets_annually=true); explicit null
still clears (Swedish review).
- Sandbox seed logs seeded dimension codes; GET /api/dimensions documents
the deliberate absence of dimensions_enabled gating (UI-visibility flag,
not a security boundary — compliance-swarm V8.2.1 rejected by design).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
133 lines
4.8 KiB
TypeScript
133 lines
4.8 KiB
TypeScript
/**
|
|
* PATCH /api/dimensions/[id]/values/[valueId] — update a dimension value
|
|
* (name / is_active / start_date / end_date; `code` is immutable in v1).
|
|
* DELETE /api/dimensions/[id]/values/[valueId] — delete an UNREFERENCED value.
|
|
*
|
|
* Deleting a value referenced by posted/reversed lines is blocked by the DB
|
|
* retention trigger (enforce_dimension_value_retention, BFL 7-year
|
|
* philosophy). Its Swedish message ("Värdet "X" används på bokförda verifikat
|
|
* och kan inte tas bort — arkivera det istället.") is surfaced verbatim as a
|
|
* 409 DIMENSION_VALUE_REFERENCED so the register UI can toast it and offer
|
|
* archive instead.
|
|
*/
|
|
import { NextResponse } from 'next/server'
|
|
import { ensureInitialized } from '@/lib/init'
|
|
import { validateBody } from '@/lib/api/validate'
|
|
import { UpdateDimensionValueSchema } from '@/lib/api/schemas'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { errorResponse, errorResponseFromCode } from '@/lib/errors/get-structured-error'
|
|
|
|
ensureInitialized()
|
|
|
|
type ValueParams = { params: Promise<{ id: string; valueId: string }> }
|
|
|
|
export const PATCH = withRouteContext(
|
|
'dimension.value.update',
|
|
async (request, ctx, { params }: ValueParams) => {
|
|
const { id, valueId } = await params
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
const opLog = log.child({ dimensionId: id, valueId })
|
|
|
|
const result = await validateBody(request, UpdateDimensionValueSchema, {
|
|
log: opLog,
|
|
operation: 'dimension.value.update',
|
|
})
|
|
if (!result.success) return result.response
|
|
const body = result.data
|
|
|
|
// Value dates only make sense on accumulating dimensions (projekt-style
|
|
// ranges). When the request carries an actual date (explicit null = clear,
|
|
// always allowed), check the parent dimension's resets_annually flag.
|
|
if (body.start_date != null || body.end_date != null) {
|
|
const { data: dimension, error: dimError } = await supabase
|
|
.from('dimensions')
|
|
.select('id, resets_annually')
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.maybeSingle()
|
|
|
|
if (dimError) {
|
|
opLog.error('dimension fetch failed', dimError)
|
|
return errorResponse(dimError, opLog, { requestId })
|
|
}
|
|
if (!dimension) {
|
|
return errorResponseFromCode('DIMENSION_NOT_FOUND', opLog, { requestId })
|
|
}
|
|
if (dimension.resets_annually) {
|
|
return errorResponseFromCode('DIMENSION_VALUE_DATES_NOT_ALLOWED', opLog, { requestId })
|
|
}
|
|
}
|
|
|
|
// Sparse update — only the fields the caller actually sent. `code` is
|
|
// deliberately absent from the schema: renaming a code would silently
|
|
// orphan every line tagged with it.
|
|
const updateData: Record<string, unknown> = {}
|
|
for (const key of ['name', 'is_active', 'start_date', 'end_date'] as const) {
|
|
if (body[key] !== undefined) updateData[key] = body[key]
|
|
}
|
|
|
|
const { data, error } = await supabase
|
|
.from('dimension_values')
|
|
.update(updateData)
|
|
.eq('id', valueId)
|
|
.eq('dimension_id', id)
|
|
.eq('company_id', companyId)
|
|
.select('id, dimension_id, code, name, is_active, start_date, end_date')
|
|
.single()
|
|
|
|
if (error) {
|
|
if (error.code === 'PGRST116') {
|
|
return errorResponseFromCode('DIMENSION_VALUE_NOT_FOUND', opLog, { requestId })
|
|
}
|
|
opLog.error('dimension value update failed', error)
|
|
return errorResponseFromCode('DIMENSION_VALUE_UPDATE_FAILED', opLog, {
|
|
requestId,
|
|
details: { reason: error.message },
|
|
})
|
|
}
|
|
|
|
return NextResponse.json({ data })
|
|
},
|
|
{ requireWrite: true },
|
|
)
|
|
|
|
export const DELETE = withRouteContext(
|
|
'dimension.value.delete',
|
|
async (_request, ctx, { params }: ValueParams) => {
|
|
const { id, valueId } = await params
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
const opLog = log.child({ dimensionId: id, valueId })
|
|
|
|
const { data, error } = await supabase
|
|
.from('dimension_values')
|
|
.delete()
|
|
.eq('id', valueId)
|
|
.eq('dimension_id', id)
|
|
.eq('company_id', companyId)
|
|
.select('id')
|
|
|
|
if (error) {
|
|
// P0001 = plpgsql RAISE EXCEPTION — the retention trigger refusing the
|
|
// delete. Surface its Swedish message verbatim (it names the code).
|
|
if (error.code === 'P0001') {
|
|
return errorResponseFromCode('DIMENSION_VALUE_REFERENCED', opLog, {
|
|
requestId,
|
|
messageSv: error.message,
|
|
})
|
|
}
|
|
opLog.error('dimension value delete failed', error)
|
|
return errorResponseFromCode('DIMENSION_VALUE_DELETE_FAILED', opLog, {
|
|
requestId,
|
|
details: { reason: error.message },
|
|
})
|
|
}
|
|
|
|
if (!data || data.length === 0) {
|
|
return errorResponseFromCode('DIMENSION_VALUE_NOT_FOUND', opLog, { requestId })
|
|
}
|
|
|
|
return NextResponse.json({ success: true })
|
|
},
|
|
{ requireWrite: true },
|
|
)
|