* feat(dimensions): PR4 reports — dimension-filtered P&L everywhere + Resultat per projekt/kostnadsställe The Project P&L milestone of the dimensions plan (dev_docs §7 PR4). One choke point lights up everything: generateTrialBalance gains options.dimensions (SIE dim → code map) pushed down as jsonb containment (dimensions @>, served by idx_jel_dimensions_gin) on both line queries, with company-wide opening balances dropped when filtered (they cannot be dimension-scoped; P&L-safe by whitelist). Resultatrapport, resultaträkning, huvudbok, monthly-breakdown and the TB drill-down inherit the filter; the KPI route filters only its P&L-side inputs (income statement, months, expense composition) — never cash/VAT. New report lib/reports/dimension-pnl.ts — "Resultat per projekt/ kostnadsställe" (Fortnox Resultatrapport projekt): value-as-column matrix over one dimension with an explicit "(Utan dimension)" bucket computed as the residual against the same trial-balance pass resultatrapport uses, so every row and the Totalt column reconcile with the unfiltered resultatrapport by construction. Registered in REPORT_CATALOG (visible only when dimensions_enabled), slug-routed view + xlsx export. UI: DimensionFilter (dimension + value picker, persistent "Filtrerad — ej fullständig rapport" chip) mounts in FocusedReport for catalog entries flagged dimensions: true; huvudbok rows show line dim codes. Statutory exclusion pinned by TEST, not convention: lib/reports/__tests__/dimension-statutory-guard.test.ts fails if the filter parser leaks into balance sheet, balansrapport, kassaflöde, VAT, SIE or full-archive routes/generators, or if the catalog whitelist widens. MCP: new gnubok_get_dimension_pnl (reports:read); dimensions filter arg on get_trial_balance/get_income_statement/get_general_ledger with resolve-don't-select (names → registry codes, resolution echoes); query_journal totals fixed to aggregate the FULL match set (was silently slice-scoped while claiming otherwise) with an honest totals_scope field, plus group_by / group_by_dimension aggregation. Also: voucher-detail dim-6 badge now uses the registry name instead of the non-standard "PR" abbreviation (#859 review follow-up). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(dimensions): address #862 review — export disclosure, prior-column suppression, period-label honesty, route hardening - Filtered XLSX/PDF exports now carry the partial-view disclosure past the file boundary (BFNAR 2013:2): filename suffix (-dim6-p001), a "Filtrerad … — ej fullständig rapport" row on every sheet, and a header note/title line in the PDFs. - Resultatrapport drops the prior-year column when a dimension filter is active — project codes are time-limited under K2/K3, so "this code last year" may be a different project (same rule as narrowed date ranges). - dimension-pnl no longer accepts fromDate: the matrix is cumulative from period_start by design (closing-balance semantics), and the period label now states exactly that instead of echoing a lower bound that was never applied. Routes/MCP tool updated to toDate-only. - dimension-pnl routes 404 on an unknown/foreign period id and cap dim_no to 4 digits (matching the MCP tool's PostgREST-path guard, which the generator now also enforces itself). - Statutory-guard test's generateTrialBalance call-site scan is paren-aware instead of a 300-char window; added fully-untagged and injection-guard test cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
98 lines
3.3 KiB
TypeScript
98 lines
3.3 KiB
TypeScript
'use client'
|
|
|
|
import { useState } from 'react'
|
|
import { useRouter } from 'next/navigation'
|
|
import { useTranslations } from 'next-intl'
|
|
import { Skeleton } from '@/components/ui/skeleton'
|
|
import { Card, CardContent } from '@/components/ui/card'
|
|
import { PageHeader } from '@/components/ui/page-header'
|
|
import { EmptyState } from '@/components/ui/empty-state'
|
|
import { useCompany } from '@/contexts/CompanyContext'
|
|
import { useCompanySettings } from '@/components/settings/useSettings'
|
|
import { FiscalYearSelector } from '@/components/common/FiscalYearSelector'
|
|
import { ReportLibrary } from '@/components/reports/ReportLibrary'
|
|
import { RecentReportsShelf } from '@/components/reports/RecentReportsShelf'
|
|
import { useRecentReports } from '@/components/reports/useRecentReports'
|
|
import { getReport } from '@/lib/reports/catalog'
|
|
|
|
/**
|
|
* Reports library landing. A calm, grouped index of every report — selecting
|
|
* one opens the focused /reports/[slug] route. The fiscal year picked here
|
|
* persists (FiscalYearSelector localStorage) and is restored on the focused
|
|
* page, so the choice carries across without URL plumbing.
|
|
*/
|
|
export default function ReportsPage() {
|
|
const router = useRouter()
|
|
const [selectedPeriod, setSelectedPeriod] = useState('')
|
|
const [isLoadingInit, setIsLoadingInit] = useState(true)
|
|
const { company } = useCompany()
|
|
const { settings } = useCompanySettings()
|
|
const t = useTranslations('reports')
|
|
const { recents, pushRecent } = useRecentReports(company?.id)
|
|
|
|
// Open a report. Route-owning reports (cash flow, annual report, KPI, SIE)
|
|
// navigate to their own page; the rest open the focused /reports/[slug] route.
|
|
const openReport = (slug: string) => {
|
|
const report = getReport(slug)
|
|
if (report?.route) {
|
|
const href =
|
|
slug === 'arsredovisning' && selectedPeriod
|
|
? `${report.route}?period=${selectedPeriod}`
|
|
: report.route
|
|
router.push(href)
|
|
return
|
|
}
|
|
pushRecent(slug)
|
|
router.push(`/reports/${slug}`)
|
|
}
|
|
|
|
return (
|
|
<div className="space-y-8">
|
|
<PageHeader
|
|
title={t('title')}
|
|
action={
|
|
<FiscalYearSelector
|
|
value={selectedPeriod || null}
|
|
onChange={(id) => setSelectedPeriod(id || '')}
|
|
includeAllOption={false}
|
|
hideFuturePeriods
|
|
onReady={() => setIsLoadingInit(false)}
|
|
/>
|
|
}
|
|
/>
|
|
|
|
{isLoadingInit ? (
|
|
<div className="space-y-6">
|
|
<Skeleton className="h-4 w-40" />
|
|
<Card>
|
|
<CardContent className="p-6 space-y-4">
|
|
<Skeleton className="h-5 w-32" />
|
|
<Skeleton className="h-64" />
|
|
</CardContent>
|
|
</Card>
|
|
</div>
|
|
) : !selectedPeriod ? (
|
|
<EmptyState
|
|
title="Inget räkenskapsår valt"
|
|
description="Skapa ett räkenskapsår för att kunna se rapporter."
|
|
actionLabel="Gå till inställningar"
|
|
actionHref="/settings"
|
|
/>
|
|
) : (
|
|
<div className="space-y-8">
|
|
<RecentReportsShelf
|
|
slugs={recents}
|
|
entityType={company?.entity_type}
|
|
onOpen={openReport}
|
|
/>
|
|
<ReportLibrary
|
|
entityType={company?.entity_type}
|
|
dimensionsEnabled={settings?.dimensions_enabled === true}
|
|
onOpen={openReport}
|
|
/>
|
|
</div>
|
|
)}
|
|
</div>
|
|
)
|
|
}
|