Files
accounted/lib/onboarding/__tests__/checklist.test.ts
T
MattssonandClaude Fable 5.1 4f33184a9a fix(mcp): explain the Claude-side steps after "Anslut till Claude" and tick the checklist on a real connection (#2133) (#2147)
* fix(mcp): explain the Claude-side steps after "Anslut till Claude" and tick the checklist on a real connection (#2133)

Lazy auth is by design: Claude lists the tools before any sign-in and the
first company-scoped call answers 401, which opens the Accounted sign-in.
Nothing told the user, so a "connected" status with an unanswered first
question read as a broken connection (Axel, Discord).

- Settings -> API & MCP: one sentence of expectation under the button, and
  the step-by-step guide link moved from under two disclosures to directly
  under the button.
- Docs (connect-claude / anslut-claude): new "What happens after you click"
  section for Path A covering the connector dialog, the tools appearing
  before sign-in, the first-call login + consent screen, "ask again", and
  the "Required when the server asks" auth setting that only the manual
  path mentioned.
- Hem checklist step "Anslut till Claude": deep link now carries
  client=claude-connector like the settings button (claudeConnectorLink),
  the footnote carries the same expectation line plus the guide link, and
  the done-signal is an unrevoked api_keys row minted by the MCP OAuth
  token route (OAUTH_MCP_KEY_NAME) instead of the in-app AI-profile flag,
  which never meant "connected to Claude".
- Tests: claudeStepDone with/without a key row, deep-link snapshot.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W7iJQwKiRTDWSMnRm4WM4L

* fix(mcp): correct consent-page claims, stop the completion PATCH loop, count OAuth keys past RLS (#2133)

Three skeptic refutations on PR #2147, fixed in one pass:

- Docs (EN + SV): the consent page shows the company active in the app and
  pre-selects every scope for Claude's connector (founder decision
  2026-08-26); it has no company picker and nothing to tick. Steps 3-4 of
  the new section, the "Read-only by default" paragraph above it, the
  sandbox note and the 10-minute test now describe Endast läs under
  Behörigheter instead.
- Checklist completion: users with initial_setup_path NULL (skipped the
  books question, then imported) hit the route's "Välj först hur du vill
  komma igång" 400 and, with saving as an effect dependency, retried it
  forever with a toast. completionPatchBody() records path=migration when
  none was chosen, and a rejected PATCH is not retried within the session.
- hasMcpKey: api_keys' SELECT policy is company-scoped, so the user client
  could not see companyless (NULL company_id) or archived-company keys and
  the step stayed open for the user who had just connected. The head count
  now runs through the service client with an explicit user_id filter.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W7iJQwKiRTDWSMnRm4WM4L

* fix(mcp): surface a failed OAuth-key count and reserve the marker name (#2133)

CodeRabbit round on PR #2147:

- app/(dashboard)/page.tsx: a failed api_keys count answered count null,
  which claudeStepDone read as "never connected". Throw to the error
  boundary like the settings fetch does instead of guessing.
- app/api/settings/api-keys: reject a hand-minted key named
  MCP-klient (OAuth) (400 VALIDATION_ERROR): that name is the marker the
  Hem checklist reads as "connected to Claude", so a manual key with it
  would tick the step without any connection. Test added.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W7iJQwKiRTDWSMnRm4WM4L

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 00:04:31 +02:00

129 lines
4.7 KiB
TypeScript

import { describe, expect, it } from 'vitest'
import {
checklistNumbers,
claudeConnectorLink,
claudeStepDone,
completionPatchBody,
vatDeadlineLine,
} from '../checklist'
describe('vatDeadlineLine', () => {
it('returns null when the company is not VAT-registered', () => {
expect(
vatDeadlineLine({ vatRegistered: false, momsPeriod: 'quarterly', nextVatDueDate: '2026-11-12' })
).toBeNull()
expect(
vatDeadlineLine({ vatRegistered: null, momsPeriod: null, nextVatDueDate: null })
).toBeNull()
})
it('flags the silent zero-deadline misconfiguration when moms_period is unset', () => {
expect(
vatDeadlineLine({ vatRegistered: true, momsPeriod: null, nextVatDueDate: null })
).toEqual({ kind: 'missing_period' })
// Even with a stray row, an unset period is still a misconfiguration to surface.
expect(
vatDeadlineLine({ vatRegistered: true, momsPeriod: undefined, nextVatDueDate: '2026-11-12' })
).toEqual({ kind: 'missing_period' })
})
it('returns the due date when registered with a period and an upcoming row', () => {
expect(
vatDeadlineLine({ vatRegistered: true, momsPeriod: 'quarterly', nextVatDueDate: '2026-11-12' })
).toEqual({ kind: 'date', dueDate: '2026-11-12' })
})
it('says nothing when a period is set but no upcoming row surfaced', () => {
expect(
vatDeadlineLine({ vatRegistered: true, momsPeriod: 'yearly', nextVatDueDate: null })
).toBeNull()
})
})
describe('checklistNumbers', () => {
it('numbers all five steps when both extensions are on', () => {
expect(checklistNumbers({ hasSkatteverket: true, hasInbox: true })).toEqual({
count: 5,
skv: 3,
receipts: 4,
assistant: 5,
})
})
it('collapses to four steps without the inbox extension', () => {
expect(checklistNumbers({ hasSkatteverket: true, hasInbox: false })).toEqual({
count: 4,
skv: 3,
receipts: 4,
assistant: 4,
})
})
it('collapses to four steps without the skatteverket extension', () => {
expect(checklistNumbers({ hasSkatteverket: false, hasInbox: true })).toEqual({
count: 4,
skv: 3,
receipts: 3,
assistant: 4,
})
})
it('collapses to three steps with neither extension', () => {
expect(checklistNumbers({ hasSkatteverket: false, hasInbox: false })).toEqual({
count: 3,
skv: 3,
receipts: 3,
assistant: 3,
})
})
})
describe('completionPatchBody', () => {
it('keeps a recorded path out of the body', () => {
expect(completionPatchBody('bank')).toEqual({ completed: true })
expect(completionPatchBody('fresh')).toEqual({ completed: true })
})
it('records migration when no path was chosen, so the route accepts completion', () => {
// Skipped the books question, then imported: step 1 is only done via an
// import in that state. Without a path the route answers 400 and the
// completion effect used to retry it forever.
expect(completionPatchBody(null)).toEqual({ completed: true, path: 'migration' })
})
})
describe('claudeStepDone', () => {
it('is done once an OAuth-minted MCP key row exists', () => {
expect(claudeStepDone({ oauthKeyCount: 1 })).toBe(true)
expect(claudeStepDone({ oauthKeyCount: 3 })).toBe(true)
})
it('stays open without a key row, including a null head count', () => {
expect(claudeStepDone({ oauthKeyCount: 0 })).toBe(false)
expect(claudeStepDone({ oauthKeyCount: null })).toBe(false)
expect(claudeStepDone({ oauthKeyCount: undefined })).toBe(false)
})
})
describe('claudeConnectorLink', () => {
it('builds the claude.ai deep link with namespace and client marker, from the page origin', () => {
const link = claudeConnectorLink({ origin: 'https://app.testbrand.example', appName: 'Testbrand' })
expect(link).toBe(
'https://claude.ai/customize/connectors?modal=add-custom-connector' +
'&connectorName=Testbrand' +
'&connectorUrl=https%3A%2F%2Fapp.testbrand.example%2Fapi%2Fextensions%2Fext%2Fmcp-server%2Fmcp%3Ftool_namespace%3Daccounted%26client%3Dclaude-connector',
)
})
it('matches the Settings → API & MCP button shape (tool_namespace + client=claude-connector)', () => {
const link = claudeConnectorLink({ origin: 'http://localhost:3000', appName: 'Bokföring AB' })
const url = new URL(link)
expect(url.searchParams.get('connectorName')).toBe('Bokföring AB')
const server = new URL(url.searchParams.get('connectorUrl') ?? '')
expect(server.origin).toBe('http://localhost:3000')
expect(server.pathname).toBe('/api/extensions/ext/mcp-server/mcp')
expect(server.searchParams.get('tool_namespace')).toBe('accounted')
expect(server.searchParams.get('client')).toBe('claude-connector')
})
})