accounted/lib/providers/__tests__/provider-data-fetcher.test.ts

import { describe, it, expect, beforeEach, vi } from 'vitest'

/**
 * Locks fetchCompanyInfoDirect's failure contract.
 *
 * It used to wrap the whole body in try/catch and return null on ANY error, so
 * a Visma company whose api_standard module is off looked exactly like a
 * company with no details: /preview answered 200 with companyInfo: null and
 * its classify-and-rethrow remediation (PROVIDER_API_MODULE_INACTIVE, with the
 * "Appar och tillägg" instructions) was unreachable code. The customer read
 * "connected" and only found out after an empty migration.
 *
 * Contract now: provider errors propagate, and null keeps its one meaning,
 * "there is nothing to fetch here".
 */

const { vismaGet, bokioGetCompany } = vi.hoisted(() => ({
  vismaGet: vi.fn(),
  bokioGetCompany: vi.fn(),
}))

vi.mock('../visma/client', () => ({
  VismaClient: class {
    get = vismaGet
  },
}))

vi.mock('../bokio/client', () => ({
  BokioClient: class {
    getCompany = bokioGetCompany
  },
  BokioApiError: class BokioApiError extends Error {},
}))

import { fetchCompanyInfoDirect } from '../provider-data-fetcher'

const VISMA_MODULE_BODY =
  '{"ErrorCode":4002,"DeveloperErrorMessage":"ForbiddenRequestException - No access to module: api_standard","ErrorId":"x","Errors":[]}'

function vismaError(statusCode: number, body?: string): Error {
  const e = new Error(`Visma API error: ${statusCode}`) as Error & {
    statusCode: number
    body?: string
  }
  e.statusCode = statusCode
  e.body = body
  return e
}

describe('fetchCompanyInfoDirect', () => {
  beforeEach(() => {
    vi.clearAllMocks()
  })

  it('propagates a provider failure instead of swallowing it into null', async () => {
    vismaGet.mockRejectedValue(vismaError(403, VISMA_MODULE_BODY))

    await expect(fetchCompanyInfoDirect('visma', 'tok')).rejects.toMatchObject({
      statusCode: 403,
      body: VISMA_MODULE_BODY,
    })
  })

  it('propagates transient failures too: the caller decides what is soft', async () => {
    vismaGet.mockRejectedValue(vismaError(500))

    await expect(fetchCompanyInfoDirect('visma', 'tok')).rejects.toMatchObject({ statusCode: 500 })
  })

  it('still returns null when there is nothing to fetch, without calling the provider', async () => {
    // Bokio needs the provider company id to address the company endpoint.
    await expect(fetchCompanyInfoDirect('bokio', 'tok')).resolves.toBeNull()
    expect(bokioGetCompany).not.toHaveBeenCalled()
  })
})