* fix(customers): make country ISO-2 everywhere and check it against the customer type (#2025, #2028) customers.country and suppliers.country were read as ISO codes by the periodisk sammanstallning (SKV 5740), Peppol and the provider importers but written as English names by the customer form and the v1 API, so a correct German customer produced GERMANY811234567 in the SKV file plus two false warnings, and an EU customer saved with land Sverige got reverse charge with nothing objecting until after the invoice was sent. - lib/vat/country-codes.ts: one helper that normalises codes and the Swedish/English names the writers used to store, the country-vs-type rule (swedish_business = SE, eu_business = EU member other than SE that matches the VAT prefix, non_eu_business = outside the EU), and the reverse-charge country gate. - Writers: customer form and supplier form get a country select; internal REST, v1 REST, bulk-create, MCP create/update, CSV/Excel import and the provider migration mapper normalise to a code and refuse unknown text; the consistency rule is a form error and an API 400 (CUSTOMER_COUNTRY_MISMATCH on update). An omitted country is SE for Swedish types, derived from the VAT prefix for eu_business, required for non_eu_business. - vat-rules.ts: getVatRules and friends take the country as a third argument and grant reverse charge only for an EU country other than SE; every invoice/sales-order/MCP call site passes customer.country. - periodisk sammanstallning reads legacy names through the same helper. - Migration 20260903170000: normalize_country_code() SQL twin, country_raw rollback column on both tables, backfill of every non-code row; unknown text is left as-is. pg-real test for the function. Closes #2025, closes #2028 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D5EmmndLyDCmY5NHYAvYkE * fix(customers): keep reverse charge for defaulted-SE EU rows, gate the country rule on the fields it reads, fix build Skeptic and CI findings on #2241, one pass: - Migration step 4: eu_business rows whose country was null or only the old writer default (SE) while the VAT number names another EU member take the country from the prefix. The pre-2026-09 rules granted reverse charge on type + VIES validation alone, so these rows invoiced at 0% and would have flipped to 25% on the next invoice. country_raw = '' marks a null origin; rollback uses nullif(country_raw, ''). - countryPermitsReverseCharge refuses SE only: a VIES-validated number outweighs a non-EU address (Swiss company registered in DE, Monaco with a FR number, Northern Ireland XI). - checkCountryConsistency: an eu_business outside the EU VAT area is accepted when the VAT prefix is an EU-trade registration (incl. XI); Monaco maps to the FR prefix. - Internal PATCH, MCP update and the commit executor judge the country rule only when customer_type, country or vat_number is part of the update, so a contradictory legacy row can still change its email (v1 already did). - Webshop-order customers get the order's billing country; spreadsheet import derives a missing country from the type and flags contradictions (parser row error + execute schema refine). - Build: v1 [id] route typed the existing row through a narrowed alias (never) and passed messageSv/messageEn the v1 error context lacks; the self-billed customer projection lacked country. - Checks: regenerated skills/accounted-api (customer example country SE). - New parity test holds the migration's SQL name table to the TS table. - DECISIONS.md: correct migration version and the revised rule. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D5EmmndLyDCmY5NHYAvYkE --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
216 lines
6.9 KiB
TypeScript
216 lines
6.9 KiB
TypeScript
/**
|
|
* customers.country through the MCP tools: ISO 3166-1 alpha-2, derived from
|
|
* the VAT prefix when an EU business omits it, and checked against the
|
|
* customer type at staging (#2025, #2028).
|
|
*/
|
|
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { createQueuedMockSupabase } from '@/tests/helpers'
|
|
import { eventBus } from '@/lib/events/bus'
|
|
import { tools } from '../server'
|
|
|
|
const CUSTOMER_ID = '11111111-1111-4111-8111-111111111111'
|
|
const createTool = () => tools.find((candidate) => candidate.name === 'gnubok_create_customer')!
|
|
const updateTool = () => tools.find((candidate) => candidate.name === 'gnubok_update_customer')!
|
|
|
|
function currentCustomer(overrides: Record<string, unknown> = {}) {
|
|
return {
|
|
id: CUSTOMER_ID,
|
|
name: 'Test Customer AB',
|
|
customer_type: 'swedish_business',
|
|
customer_number: '1001',
|
|
email: 'billing@example.test',
|
|
phone: '',
|
|
address_line1: 'Testgatan 1',
|
|
address_line2: null,
|
|
postal_code: '12345',
|
|
city: 'Teststad',
|
|
country: 'SE',
|
|
org_number: '556000-0000',
|
|
vat_number: null,
|
|
vat_number_validated: false,
|
|
language: 'sv',
|
|
default_payment_terms: 30,
|
|
notes: null,
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
eventBus.clear()
|
|
})
|
|
|
|
describe('gnubok_create_customer: country', () => {
|
|
it('documents the code shape and the type rule in the input schema', () => {
|
|
const properties = createTool().inputSchema.properties as Record<string, Record<string, unknown>>
|
|
expect(String(properties.country.description)).toMatch(/ISO 3166-1 alpha-2/)
|
|
expect(String(properties.country.description)).toMatch(/default SE/)
|
|
})
|
|
|
|
it('previews a country name as its code', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: null }) // company_settings read (payment-terms default)
|
|
|
|
const result = (await createTool().execute(
|
|
{
|
|
name: 'Muster Handels GmbH',
|
|
customer_type: 'eu_business',
|
|
country: 'Tyskland',
|
|
vat_number: 'DE811234567',
|
|
dry_run: true,
|
|
},
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
)) as { preview: Record<string, unknown> }
|
|
|
|
expect(result.preview.country).toBe('DE')
|
|
})
|
|
|
|
it('derives the country from the VAT prefix when an EU business omits it', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: null })
|
|
|
|
const result = (await createTool().execute(
|
|
{ name: 'Muster Handels GmbH', customer_type: 'eu_business', vat_number: 'DE811234567', dry_run: true },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
)) as { preview: Record<string, unknown> }
|
|
|
|
expect(result.preview.country).toBe('DE')
|
|
})
|
|
|
|
it('defaults a Swedish business to SE, never to the name Sweden', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: null })
|
|
|
|
const result = (await createTool().execute(
|
|
{ name: 'Kund AB', customer_type: 'swedish_business', dry_run: true },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
)) as { preview: Record<string, unknown> }
|
|
|
|
expect(result.preview.country).toBe('SE')
|
|
})
|
|
|
|
it('refuses an EU business with land Sverige before staging (#2025)', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
|
|
await expect(
|
|
createTool().execute(
|
|
{ name: 'Muster Handels GmbH', customer_type: 'eu_business', country: 'SE', vat_number: 'DE811234567' },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
),
|
|
).rejects.toThrow(/country/i)
|
|
expect(supabase.from).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('refuses an EU business with neither a country nor a usable VAT prefix', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
|
|
await expect(
|
|
createTool().execute(
|
|
{ name: 'Muster Handels GmbH', customer_type: 'eu_business', vat_number: '811234567' },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
),
|
|
).rejects.toThrow(/country is required/i)
|
|
})
|
|
|
|
it('refuses a country it cannot read as a code', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
|
|
await expect(
|
|
createTool().execute(
|
|
{ name: 'Kund AB', customer_type: 'swedish_business', country: 'Atlantis' },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
),
|
|
).rejects.toThrow(/not an ISO 3166-1 alpha-2 code/i)
|
|
})
|
|
})
|
|
|
|
describe('gnubok_update_customer: country', () => {
|
|
it('previews a country name as its code', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: currentCustomer() })
|
|
|
|
const result = (await updateTool().execute(
|
|
{
|
|
customer_id: CUSTOMER_ID,
|
|
customer_type: 'eu_business',
|
|
country: 'Tyskland',
|
|
vat_number: 'DE811234567',
|
|
dry_run: true,
|
|
},
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
)) as { preview: { proposed?: Record<string, unknown> } }
|
|
|
|
expect(result.preview.proposed).toMatchObject({ customer_type: 'eu_business', country: 'DE' })
|
|
})
|
|
|
|
it('refuses a type change that contradicts the stored country', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: currentCustomer() })
|
|
|
|
await expect(
|
|
updateTool().execute(
|
|
{ customer_id: CUSTOMER_ID, customer_type: 'eu_business', dry_run: true },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
),
|
|
).rejects.toThrow(/country/i)
|
|
})
|
|
|
|
it('refuses a country change that contradicts the stored VAT prefix', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: currentCustomer({ customer_type: 'eu_business', country: 'DE', vat_number: 'DE811234567' }) })
|
|
|
|
await expect(
|
|
updateTool().execute(
|
|
{ customer_id: CUSTOMER_ID, country: 'FR', dry_run: true },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
),
|
|
).rejects.toThrow(/prefix/i)
|
|
})
|
|
|
|
it('lets a contradictory legacy row change unrelated fields', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: currentCustomer({ customer_type: 'eu_business', country: 'SE', vat_number: 'DE811234567' }) })
|
|
|
|
const result = (await updateTool().execute(
|
|
{ customer_id: CUSTOMER_ID, email: 'new@example.test', dry_run: true },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
)) as { preview: { proposed?: Record<string, unknown> } }
|
|
|
|
expect(result.preview.proposed).toMatchObject({ email: 'new@example.test', country: 'SE' })
|
|
})
|
|
|
|
it('refuses a country it cannot read as a code before touching the database', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
|
|
await expect(
|
|
updateTool().execute(
|
|
{ customer_id: CUSTOMER_ID, country: 'Atlantis', dry_run: true },
|
|
'company-1',
|
|
'user-1',
|
|
supabase as never,
|
|
),
|
|
).rejects.toThrow(/country/i)
|
|
expect(supabase.from).not.toHaveBeenCalled()
|
|
})
|
|
})
|