* fix(reports): drive report line queries from journal_entries, not the unfiltered lines side
Every report generator fetched journal_entry_lines with a
journal_entries!inner(...) embed and put the tenant filter on the
embedded side (.eq('journal_entries.company_id', ...)). PostgREST
compiles that to a correlated INNER JOIN LATERAL with a parameterized
LIMIT inside, which blocks join reordering: Postgres walked the ENTIRE
journal_entry_lines table (603k rows, all tenants) per report query.
Measured in production: 13.6 s vs 2.7 ms for the equivalent plain join,
against Supabase's 8 s statement_timeout; nightly cloud backups failed
for 5 of 11 companies on 2026-07-09 and a GL report 500'd.
Introduce lib/bookkeeping/entry-lines.ts with a shared two-step fetch:
1. fetch matching journal_entries (id + caller-selected columns)
filtered by company_id / fiscal_period_id / status / entry_date /
source_type, paginated via fetchAllRows;
2. fetch journal_entry_lines with .in('journal_entry_id', chunk) in
chunks of 100 ids (URL-length safety), paginated per chunk;
3. reattach the parent entry to each line under the embed's key shape
(line.journal_entries = {...}, aliasable) and sort lines by id
ascending to preserve the old .order('id') semantics.
Converted call sites (selected columns and filters preserved):
trial-balance (x2), general-ledger, journal-register, sie-export
(reuses its existing entry list via fetchLinesByEntryIds),
vat-declaration, dimension-pnl, opening-balances, monthly-breakdown,
periodisk-sammanstallning, rc-basis-gaps (sibling-line fetch now also
chunked), ar-reconciliation, supplier-reconciliation,
bank-reconciliation, asset-service (x2), bolagsskatt-calculator,
sarskild-loneskatt-calculator.
Tests: unit tests for the helper (chunk size, reattachment shape,
forced id/journal_entry_id columns, empty result, cross-chunk sort,
error propagation); existing report/reconciliation/bokslut test mocks
updated to the two-step query shape, preserving every assertion about
report output.
From the 2026-07-09 production log triage.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(reports): stop echoing raw error messages from the general-ledger route
The catch handler returned err.message to the client in
details.reason; internal error strings (SQL fragments, table names,
timeout messages) must not reach the browser. The error is already
logged server-side with the request id, so the client envelope keeps
only the REPORT_GENERATION_FAILED code.
From the 2026-07-09 production log triage.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
251 lines
9.5 KiB
TypeScript
251 lines
9.5 KiB
TypeScript
import type { SupabaseClient } from '@supabase/supabase-js'
|
||
import { fetchAllRows } from '@/lib/supabase/fetch-all'
|
||
import { fetchEntryLines, type EntryLinesQuery } from '@/lib/bookkeeping/entry-lines'
|
||
import { getOpeningBalances } from './opening-balances'
|
||
import type { TrialBalanceRow } from '@/types'
|
||
|
||
/**
|
||
* Generate trial balance (Saldobalans) for a fiscal period or a date range
|
||
* inside one.
|
||
*
|
||
* Computes IB (ingående balans), period movements, and UB (utgående balans)
|
||
* per BFNAR 2013:2 requirements. Uses the opening_balance_entry set by
|
||
* year-end closing when available; falls back to summing prior-period entries.
|
||
*
|
||
* When `fromDate`/`toDate` are passed, they must lie inside the fiscal
|
||
* period. The function rolls the IB forward from `period_start` to
|
||
* `fromDate − 1` (so "opening" reflects the state at `fromDate`) and limits
|
||
* period activity to `[fromDate, toDate]`. Defaults equal `period_start` and
|
||
* `period_end`: identical to the no-options behaviour.
|
||
*
|
||
* When `dimensions` is passed (map of SIE dim number → object code, e.g.
|
||
* `{"6":"P001"}`, AND across keys), both line queries filter with jsonb
|
||
* containment (`dimensions @> …`, served by idx_jel_dimensions_gin). The
|
||
* result is then a PARTIAL view: opening balances from year-end closing are
|
||
* company-wide, so callers must only use the filter for P&L-style reports
|
||
* (classes 3-8) where IB is immaterial: never for balance/statutory reports.
|
||
* The catalog whitelist + statutory-guard test pin this.
|
||
*
|
||
* Uses the shared two-step entry-lines fetch (lib/bookkeeping/entry-lines.ts):
|
||
* entries first, then lines chunked by entry id, both paginated, so any
|
||
* number of entries is handled without the pathological journal_entries!inner
|
||
* embed plan (see entry-lines.ts for the full story).
|
||
*/
|
||
export async function generateTrialBalance(
|
||
supabase: SupabaseClient,
|
||
companyId: string,
|
||
fiscalPeriodId: string,
|
||
options?: {
|
||
excludeYearEndClosing?: boolean
|
||
fromDate?: string
|
||
toDate?: string
|
||
dimensions?: Record<string, string>
|
||
}
|
||
): Promise<{
|
||
rows: TrialBalanceRow[]
|
||
totalDebit: number
|
||
totalCredit: number
|
||
isBalanced: boolean
|
||
}> {
|
||
|
||
// Fetch period for opening balance computation
|
||
const { data: period } = await supabase
|
||
.from('fiscal_periods')
|
||
.select('period_start, period_end, opening_balance_entry_id')
|
||
.eq('id', fiscalPeriodId)
|
||
.eq('company_id', companyId)
|
||
.single()
|
||
|
||
const dimensionFilter =
|
||
options?.dimensions && Object.keys(options.dimensions).length > 0
|
||
? options.dimensions
|
||
: undefined
|
||
|
||
// ── Opening balances (IB) at period_start ──────────────────────
|
||
const { balances: obBalances, obEntryId } = await getOpeningBalances(
|
||
supabase, companyId, period
|
||
)
|
||
// A dimension-filtered view cannot use company-wide opening balances (the
|
||
// OB entry and the prior-period RPC are not dimension-aware). Drop them so
|
||
// every reported amount is dimension-scoped activity: correct for the P&L
|
||
// reports the filter is whitelisted for, and never fabricates balances if
|
||
// misapplied. obEntryId is still needed to exclude the OB entry from lines.
|
||
const openingBalances = dimensionFilter
|
||
? new Map<string, { debit: number; credit: number }>()
|
||
: obBalances
|
||
|
||
// ── Roll IB forward from period_start up to fromDate ───────────
|
||
// When the caller requests a sub-range starting after period_start, the
|
||
// "opening" of that window must include all activity since the period
|
||
// started. We additively fold those lines into openingBalances so the
|
||
// downstream IB/period split stays correct without changing call sites.
|
||
if (
|
||
options?.fromDate &&
|
||
period?.period_start &&
|
||
options.fromDate > period.period_start
|
||
) {
|
||
const priorLines = await fetchEntryLines<{
|
||
id: string
|
||
account_number: string
|
||
debit_amount: number
|
||
credit_amount: number
|
||
}>({
|
||
supabase,
|
||
lineColumns: 'id, account_number, debit_amount, credit_amount',
|
||
filterEntries: (q: EntryLinesQuery) => {
|
||
let query = q
|
||
.eq('company_id', companyId)
|
||
.eq('fiscal_period_id', fiscalPeriodId)
|
||
.in('status', ['posted', 'reversed'])
|
||
.gte('entry_date', period.period_start)
|
||
.lt('entry_date', options.fromDate)
|
||
|
||
if (obEntryId) {
|
||
query = query.neq('id', obEntryId)
|
||
}
|
||
|
||
if (options?.excludeYearEndClosing) {
|
||
query = query.neq('source_type', 'year_end')
|
||
}
|
||
|
||
return query
|
||
},
|
||
filterLines: dimensionFilter
|
||
? // jsonb containment (@>): served by idx_jel_dimensions_gin.
|
||
(q: EntryLinesQuery) => q.contains('dimensions', dimensionFilter)
|
||
: undefined,
|
||
})
|
||
|
||
for (const line of priorLines) {
|
||
const existing = openingBalances.get(line.account_number) || { debit: 0, credit: 0 }
|
||
existing.debit += Number(line.debit_amount) || 0
|
||
existing.credit += Number(line.credit_amount) || 0
|
||
openingBalances.set(line.account_number, existing)
|
||
}
|
||
}
|
||
|
||
// ── Period lines (excluding opening balance entry) ─────────────
|
||
// If year-end closing set an OB entry, exclude it from period lines so
|
||
// its values aren't double-counted (they're already captured as IB).
|
||
// Race condition note: if year-end closing runs concurrently and sets
|
||
// obEntryId between the period query and this query, the OB entry could
|
||
// be missed from both IB and period. The window is sub-second and the
|
||
// consequence is a single stale report: acceptable.
|
||
const lines = await fetchEntryLines<{
|
||
id: string
|
||
account_number: string
|
||
debit_amount: number
|
||
credit_amount: number
|
||
}>({
|
||
supabase,
|
||
lineColumns: 'id, account_number, debit_amount, credit_amount',
|
||
filterEntries: (q: EntryLinesQuery) => {
|
||
let query = q
|
||
.eq('company_id', companyId)
|
||
.eq('fiscal_period_id', fiscalPeriodId)
|
||
.in('status', ['posted', 'reversed'])
|
||
|
||
// Date filters are only applied when the caller explicitly asks. The
|
||
// period itself is already enforced via fiscal_period_id, so adding
|
||
// redundant entry_date bounds for the default case would just
|
||
// increase query complexity (and break older mocks that don't stub gte
|
||
// /lte). The fiscal_period_id constraint plus a CHECK on entry_date in
|
||
// the engine keep activity inside the period.
|
||
if (options?.fromDate) {
|
||
query = query.gte('entry_date', options.fromDate)
|
||
}
|
||
if (options?.toDate) {
|
||
query = query.lte('entry_date', options.toDate)
|
||
}
|
||
|
||
if (obEntryId) {
|
||
query = query.neq('id', obEntryId)
|
||
}
|
||
|
||
if (options?.excludeYearEndClosing) {
|
||
query = query.neq('source_type', 'year_end')
|
||
}
|
||
|
||
return query
|
||
},
|
||
filterLines: dimensionFilter
|
||
? // jsonb containment (@>): served by idx_jel_dimensions_gin.
|
||
(q: EntryLinesQuery) => q.contains('dimensions', dimensionFilter)
|
||
: undefined,
|
||
})
|
||
|
||
if (lines.length === 0 && openingBalances.size === 0) {
|
||
return { rows: [], totalDebit: 0, totalCredit: 0, isBalanced: true }
|
||
}
|
||
|
||
// Get account names
|
||
const accounts = await fetchAllRows<{
|
||
account_number: string
|
||
account_name: string
|
||
account_class: number
|
||
}>(({ from, to }) =>
|
||
supabase
|
||
.from('chart_of_accounts')
|
||
.select('account_number, account_name, account_class')
|
||
.eq('company_id', companyId)
|
||
.order('account_number', { ascending: true })
|
||
.range(from, to)
|
||
)
|
||
|
||
const accountMap = new Map<string, { name: string; class: number }>()
|
||
for (const acc of accounts) {
|
||
accountMap.set(acc.account_number, {
|
||
name: acc.account_name,
|
||
class: acc.account_class,
|
||
})
|
||
}
|
||
|
||
// Aggregate period activity by account
|
||
const periodBalances = new Map<string, { debit: number; credit: number }>()
|
||
|
||
for (const line of lines) {
|
||
const existing = periodBalances.get(line.account_number) || { debit: 0, credit: 0 }
|
||
existing.debit += Number(line.debit_amount) || 0
|
||
existing.credit += Number(line.credit_amount) || 0
|
||
periodBalances.set(line.account_number, existing)
|
||
}
|
||
|
||
// Merge account numbers from both opening and period
|
||
const allAccountNumbers = new Set([...openingBalances.keys(), ...periodBalances.keys()])
|
||
|
||
// Build rows: IB + period = UB
|
||
const rows: TrialBalanceRow[] = []
|
||
for (const accountNumber of allAccountNumbers) {
|
||
const opening = openingBalances.get(accountNumber) || { debit: 0, credit: 0 }
|
||
const periodActivity = periodBalances.get(accountNumber) || { debit: 0, credit: 0 }
|
||
const accountInfo = accountMap.get(accountNumber) || {
|
||
name: `Konto ${accountNumber}`,
|
||
class: parseInt(accountNumber[0]) || 0,
|
||
}
|
||
|
||
rows.push({
|
||
account_number: accountNumber,
|
||
account_name: accountInfo.name,
|
||
account_class: accountInfo.class,
|
||
opening_debit: Math.round(opening.debit * 100) / 100,
|
||
opening_credit: Math.round(opening.credit * 100) / 100,
|
||
period_debit: Math.round(periodActivity.debit * 100) / 100,
|
||
period_credit: Math.round(periodActivity.credit * 100) / 100,
|
||
closing_debit: Math.round((opening.debit + periodActivity.debit) * 100) / 100,
|
||
closing_credit: Math.round((opening.credit + periodActivity.credit) * 100) / 100,
|
||
})
|
||
}
|
||
|
||
rows.sort((a, b) => a.account_number.localeCompare(b.account_number))
|
||
|
||
const totalDebit = Math.round(rows.reduce((sum, r) => sum + r.closing_debit, 0) * 100) / 100
|
||
const totalCredit = Math.round(rows.reduce((sum, r) => sum + r.closing_credit, 0) * 100) / 100
|
||
|
||
return {
|
||
rows,
|
||
totalDebit,
|
||
totalCredit,
|
||
isBalanced: Math.abs(totalDebit - totalCredit) < 0.01,
|
||
}
|
||
}
|