Files
accounted/extensions/general/stripe/__tests__/sync.test.ts
T
MattssonandClaude Fable 5 98d0c7f2d0 Add/stripe skv (#1004)
* fix(salary): align pain.001 salary file with the Swedish domestic bank dialect

Verified against the Swedish Common Interpretation of ISO 20022
(Bankforeningen, Common Payment Types in Sweden, Appendix 1 Example 4:
Salaries) and Nordea Corporate Access pain.001 examples v2.6 (2026-06-22),
and XSD-validated against the official pain.001.001.03 schema:

- drop SvcLvl SEPA (SEPA credit transfers are EUR-only; omitting SvcLvl
  gets the domestic NURG default)
- drop RmtInf (not allowed for SALA salary payments; the beneficiary
  statement text comes from the Dataclearing LON code)
- address employees domestically: clearing as CdtrAgt ClrSysMmbId SESBA,
  account WITHOUT clearing as CdtrAcct Othr with SchmeNm BBAN
- share the clearing/account split (Swedbank 5-digit shift, Nordea
  personkonto prefix dedup) between the LB and pain.001 generators via
  splitDomesticBankAccount, fixing pain.001 duplicating the personkonto
  clearing
- clamp MsgId/PmtInfId/InstrId/EndToEndId to Max35Text with the per-tx
  counter surviving truncation; carry the org number on Dbtr
- return 400 from the pain001 route on an invalid clearing instead of
  emitting a broken file

Also includes two unrelated decision-log lines from the parallel
revisor-review session (DECISIONS.md is a shared append-only log).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(nav): surface the year-end chain in the sidebar

Add Periodiseringar, Arsredovisning (aktiebolag only) and
Inkomstdeklaration (INK2 for AB, NE-bilaga for EF) to the Skatt &
bokslut group, in workflow order. Entity gating via a new entityOnly
flag on NavItem; isActive carve-outs extended so exactly one row
lights up for the new routes. Driven by an external revisor review
that concluded these features did not exist because none of them
were reachable from the nav.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(stripe): Stripe Connect integration behind config gate

Connect OAuth per company (only the acct_ id is stored), automatic
single-use Payment Links on invoice send, deterministic payment
settlement against 1686 (BAS moved acquirer receivables 1580 -> 1686),
payout booking with reverse-charge fees (6570 + 4535/4598 + 2645/2614),
and a 15-minute sync cron. Non-deterministic events land as
needs_review, never guessed at.

Fully dark without STRIPE_CONNECT_CLIENT_ID: connect returns 503, the
send hook and cron no-op, and the settings page shows 'Kommer snart'
(hosted) until the Connect platform is verified. Self-hosted keeps the
honest not-configured message.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(deadlines): add shared completeTaxDeadline and fix dead AGI deadline auto-complete

generate-declaration.ts has updated non-existent columns (type/period/
status) since inception, so the arbetsgivardeklaration deadline was
never auto-completed. Replace with a shared helper targeting the real
schema (tax_deadline_type/tax_period/is_completed), also used by the
kvittens crons and moms handlers in the follow-up commit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(rot-rut): import Skatteverket beslutsfil and record decisions on payout requests

Parse the beslutsfil JSON from Skatteverkets rot/rut e-tjanst and record
godkant belopp on the matching begaran: matched by stored
skv_referensnummer first, then exact name among active undecided
requests; arenden by fakturanummer then personnummer, exactly-one or the
beslut errors (all-or-nothing). Never auto-settles: recording the beslut
and booking the payout are separate acts. Exposed as an API route and
the gnubok_import_rot_rut_beslut MCP tool.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(skatteverket): system auth for background reads, one-click VAT submit, kvittens notifications

Hybrid auth program: system CCG (org certificate) for background reads
while personal BankID stays for interactive submissions, since SKV
per-flow refresh tokens live 65 min and crons structurally cannot run
on them. All system-auth code sits behind SKATTEVERKET_SYSTEM_AUTH_MODE
(default off) with a stub transport until the Expisoft cert and CCG
avtal land; auth resolution is centralized in resolve-auth.ts.

Also in this change:
- One-click VAT submit chaining kontrollera -> utkast -> las
  server-side with a stage discriminator; step-by-step buttons demoted
  to the overflow menu.
- Kvittens crons (AGI + new VAT schedule) with email-only
  notifications, deduped in notification_log under the new
  skv_kvittens type.
- Ombud grant probe + verification UI in the connect panel, and a
  dashboard promo card for unconnected companies.
- skatteverket_company_connections table with pg-real coverage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(salary): auto-settle AGI tax payment from skattekonto and surface SKV reconnect on the tax card

The "Skatt att betala" card only cleared via the manual mark-paid button
on the run detail page; the promised automatic flip from the Skattekonto
sync was never implemented, so paid periods stayed red.

- settleAgiTaxPayments: during every skattekonto sync, a booked
  "Arbetsgivardeklaration YYYYMM" debit row settles the matching
  agi_declarations.tax_paid_at, but only when the amount equals the
  declared total to the ore and the account is not in deficit
  (deterministic; drift or deficit falls back to manual).
- Salary overview card: reconnect hint when the SKV token needs
  re-consent (link to /settings/tax, silent when the extension is off),
  plus an inline "Markera som betald" button reusing the existing
  endpoint and salary_payments strings.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Add cloud backup scheduling and alerting features

- Implement unit tests for scheduling logic in `schedule.test.ts`, covering various scenarios for determining if a backup schedule is due.
- Create a new module `backup-alert.ts` to handle failure alerts for cloud backup auto-sync, including email notifications for reauthentication and repeated failures.
- Introduce `schedule.ts` to manage scheduling logic, including handling local time zones and converting between local and UTC hours.
- Add CSV report generation functions in `archive-csv.ts` for trial balance, income statement, balance sheet, and general ledger, ensuring compatibility with Swedish Excel formats.
- Create a README generator for the archive structure in `archive-readme.ts`, providing clear documentation for users accessing backup files.
- Implement tests for CSV report generation in `archive-csv.test.ts`, ensuring correct formatting and content.
- Establish a full-archive coverage contract test in `full-archive-coverage.pg.test.ts` to ensure all company-scoped tables are properly classified for backup.

* fix(stripe): correct invoice clearing reference and improve type safety in sync logic

* fix(invoices): narrow accountingMethod before resolveInvoicePaymentSourceType

settleInvoicePayment takes accountingMethod as a raw settings string, but
resolveInvoicePaymentSourceType requires the 'accrual' | 'cash' union.
Normalize at the call site (anything but 'cash' books as accrual), matching
the existing useCashEntry semantics.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: address CodeRabbit review findings and nitpicks on PR #1004

Review findings:
- backup settings redirect: always force view=export over incoming params
- AGI/VAT kvittens crons: isolate best-effort post-submit calls, check the
  signed-state persist error, guard recovery calls in catch blocks so one
  company cannot abort the rest; surface grant_revoked in the run summary
- kvittens notifications: atomic claim-first dedup with a partial unique
  index; map non-uuid reference keys to deterministic uuids
- grant probe: record the actual 2xx status; mTLS transport: handle
  response-stream errors
- stripe: amount-aware idempotency keys for payment links; emit
  stripe.disconnected on upstream revocations
- ROT/RUT beslut import: mutate in-memory request state after apply, move
  item + header writes into an atomic apply_rot_rut_beslut RPC, add
  rot_rut_payout to JournalEntrySourceTypeSchema
- migrations: use NOT VALID + VALIDATE CONSTRAINT for CHECK constraints on
  journal_entries, notification_log and rot_rut_payout_requests
- cloud backup: hour_utc-only schedule updates clear stale hour_local

Nitpicks:
- stripe sync: enforce the cron time budget inside per-connection event
  processing with idempotent cursor progress; maybeSingle for settings;
  honest partial-customer DTO shared with the settlement boundary
- shared applyPaymentLinkToInvoice helper for both invoice send routes,
  v1 docblock documents step 6b and PAYMENT_LINK_FAILED
- settings panel: drop redundant decodeURIComponent
- cloud backup: document worst-case archive memory headroom

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-12 19:14:12 +02:00

330 lines
11 KiB
TypeScript

import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
import { createQueuedMockSupabase, makeInvoice } from '@/tests/helpers'
import type { SupabaseClient } from '@supabase/supabase-js'
const eventsList = vi.fn()
vi.mock('@/lib/stripe/client', () => ({
getStripe: () => ({ events: { list: eventsList } }),
}))
vi.mock('@/lib/invoices/settle-invoice-payment', () => ({
settleInvoicePayment: vi.fn(),
}))
import { settleInvoicePayment } from '@/lib/invoices/settle-invoice-payment'
import { eventBus } from '@/lib/events/bus'
import { syncStripeConnection } from '../lib/sync'
import type { StripeConnection } from '../types'
const CONNECTION: StripeConnection = {
id: 'conn-1',
company_id: 'company-1',
user_id: 'user-1',
stripe_account_id: 'acct_1',
livemode: false,
status: 'active',
oauth_state: null,
display_name: 'Test AB',
last_event_created_at: null,
last_event_id: null,
error_message: null,
connected_at: '2026-07-01T00:00:00.000Z',
disconnected_at: null,
created_at: '2026-07-01T00:00:00.000Z',
updated_at: '2026-07-01T00:00:00.000Z',
}
function makeSession(overrides: Record<string, unknown> = {}) {
return {
id: 'cs_1',
payment_link: 'plink_1',
payment_intent: 'pi_1',
amount_total: 125000, // 1250.00 SEK in öre
currency: 'sek',
payment_status: 'paid',
livemode: false,
metadata: { invoice_id: 'inv-1', company_id: 'company-1' },
...overrides,
}
}
function makeEvent(session: Record<string, unknown>, overrides: Record<string, unknown> = {}) {
return {
id: 'evt_1',
type: 'checkout.session.completed',
created: 1_767_000_000,
data: { object: session },
...overrides,
}
}
function stubEvents(events: unknown[]) {
eventsList.mockReturnValue({
autoPagingToArray: vi.fn().mockResolvedValue(events),
})
}
function payableInvoice(overrides: Record<string, unknown> = {}) {
return {
...makeInvoice({
id: 'inv-1',
status: 'sent',
currency: 'SEK',
total: 1250,
}),
remaining_amount: 1250,
paid_amount: 0,
stripe_payment_link_id: 'plink_1',
customer: { name: 'Kund AB' },
items: [],
...overrides,
}
}
describe('syncStripeConnection', () => {
beforeEach(() => {
vi.clearAllMocks()
eventBus.clear()
vi.stubEnv('STRIPE_SECRET_KEY', 'sk_test_123')
vi.stubEnv('STRIPE_CONNECT_CLIENT_ID', 'ca_test_123')
vi.mocked(settleInvoicePayment).mockResolvedValue({
ok: true,
newStatus: 'paid',
newPaidAmount: 1250,
newRemaining: 0,
journalEntryId: 'je-9',
paidAt: '2026-07-12T00:00:00.000Z',
})
})
afterEach(() => {
vi.unstubAllEnvs()
})
it('settles a deterministic match against 1686 and advances the cursor', async () => {
stubEvents([makeEvent(makeSession())])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] }) // claim insert
enqueue({ data: payableInvoice() }) // invoice by payment link
enqueue({ data: { accounting_method: 'accrual', entity_type: 'aktiebolag' } })
enqueue({ data: null }) // event row finalize
enqueue({ data: null }) // cursor update
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary).toMatchObject({ fetched: 1, settled: 1, needsReview: 0, ignored: 0 })
expect(vi.mocked(settleInvoicePayment)).toHaveBeenCalledWith(
expect.anything(),
'company-1',
'user-1',
expect.objectContaining({
paymentAmountInInvoiceCurrency: 1250,
settlementAccountNumber: '1686',
accountingMethod: 'accrual',
entityType: 'aktiebolag',
paymentDate: new Date(1_767_000_000 * 1000).toISOString().split('T')[0],
}),
)
})
it('records amount drift as needs_review and never settles', async () => {
stubEvents([makeEvent(makeSession({ amount_total: 100000 }))]) // 1000 vs 1250 remaining
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] })
enqueue({ data: payableInvoice() })
enqueue({ data: null }) // event row finalize
enqueue({ data: null }) // cursor update
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary).toMatchObject({ settled: 0, needsReview: 1 })
expect(vi.mocked(settleInvoicePayment)).not.toHaveBeenCalled()
})
it('records an already-paid invoice as needs_review (double payment)', async () => {
stubEvents([makeEvent(makeSession())])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] })
enqueue({ data: payableInvoice({ status: 'paid' }) })
enqueue({ data: null })
enqueue({ data: null })
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary.needsReview).toBe(1)
expect(vi.mocked(settleInvoicePayment)).not.toHaveBeenCalled()
})
it('records non-SEK invoices as needs_review (v1 automation scope)', async () => {
stubEvents([makeEvent(makeSession({ currency: 'eur', amount_total: 50000 }))])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] })
enqueue({
data: payableInvoice({ currency: 'EUR', total: 500, remaining_amount: 500 }),
})
enqueue({ data: null })
enqueue({ data: null })
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary.needsReview).toBe(1)
expect(vi.mocked(settleInvoicePayment)).not.toHaveBeenCalled()
})
it('ignores test-mode events on a live-mode connection', async () => {
stubEvents([makeEvent(makeSession({ livemode: false }))])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] })
enqueue({ data: null }) // event row finalize
enqueue({ data: null }) // cursor update
const summary = await syncStripeConnection(
supabase as unknown as SupabaseClient,
{ ...CONNECTION, livemode: true },
)
expect(summary).toMatchObject({ settled: 0, needsReview: 0, ignored: 1 })
})
it('skips events already claimed by an earlier run', async () => {
stubEvents([makeEvent(makeSession())])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [] }) // claim conflict
enqueue({ data: [] }) // reclaim: not stale
enqueue({ data: null }) // cursor update
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary).toMatchObject({ alreadyProcessed: 1, settled: 0 })
expect(vi.mocked(settleInvoicePayment)).not.toHaveBeenCalled()
})
it('marks the connection revoked when Stripe reports severed access', async () => {
eventsList.mockReturnValue({
autoPagingToArray: vi
.fn()
.mockRejectedValue(
Object.assign(new Error('The account acct_1 is not connected to your platform'), {
type: 'StripePermissionError',
}),
),
})
const disconnected = vi.fn()
eventBus.on('stripe.disconnected', disconnected)
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: null }) // connection status update
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary.revoked).toBe(true)
expect(summary.settled).toBe(0)
// Auto-detected revocation must reach the audit trail, mirroring the
// user-initiated disconnect emission.
expect(disconnected).toHaveBeenCalledWith({
connectionId: 'conn-1',
stripeAccountId: 'acct_1',
reason: 'revoked_upstream',
userId: 'user-1',
companyId: 'company-1',
})
})
it('falls back to accrual/enskild_firma when the company has no settings row', async () => {
stubEvents([makeEvent(makeSession())])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] }) // claim insert
enqueue({ data: payableInvoice() }) // invoice by payment link
enqueue({ data: null }) // company_settings: no row (maybeSingle -> null, no error)
enqueue({ data: null }) // event row finalize
enqueue({ data: null }) // cursor update
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary.settled).toBe(1)
expect(vi.mocked(settleInvoicePayment)).toHaveBeenCalledWith(
expect.anything(),
'company-1',
'user-1',
expect.objectContaining({
accountingMethod: 'accrual',
entityType: 'enskild_firma',
}),
)
})
it('stops mid-batch at the deadline and persists the cursor only over processed events', async () => {
let now = 1_000
const nowSpy = vi.spyOn(Date, 'now').mockImplementation(() => now)
try {
// Settling the first event burns the remaining time budget.
vi.mocked(settleInvoicePayment).mockImplementation(async () => {
now = 10_000
return {
ok: true,
newStatus: 'paid',
newPaidAmount: 1250,
newRemaining: 0,
journalEntryId: 'je-9',
paidAt: '2026-07-12T00:00:00.000Z',
}
})
stubEvents([
makeEvent(makeSession()),
makeEvent(makeSession({ id: 'cs_2' }), { id: 'evt_2', created: 1_767_000_100 }),
])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] }) // claim insert (evt_1)
enqueue({ data: payableInvoice() }) // invoice by payment link
enqueue({ data: { accounting_method: 'accrual', entity_type: 'aktiebolag' } })
enqueue({ data: null }) // event row finalize (evt_1)
enqueue({ data: null }) // cursor update
const summary = await syncStripeConnection(
supabase as unknown as SupabaseClient,
CONNECTION,
undefined,
5_000, // deadline passes between the first and second event
)
expect(summary).toMatchObject({
fetched: 2,
settled: 1,
needsReview: 0,
deadlineReached: true,
})
expect(vi.mocked(settleInvoicePayment)).toHaveBeenCalledTimes(1)
// evt_2 was never claimed and the cursor advanced only over evt_1, so
// the next run refetches evt_2 (cursor overlap) and processes it then.
expect(vi.mocked(supabase.from).mock.calls.map((c) => c[0])).toEqual([
'stripe_payment_events', // claim evt_1
'invoices',
'company_settings',
'stripe_payment_events', // finalize evt_1
'stripe_connections', // cursor persisted up to evt_1
])
} finally {
nowSpy.mockRestore()
}
})
it('records a settle failure (e.g. locked period) as needs_review', async () => {
vi.mocked(settleInvoicePayment).mockResolvedValue({
ok: false,
code: 'BOOKKEEPING_ERROR',
error: new Error('Cannot write to locked/closed fiscal period'),
})
stubEvents([makeEvent(makeSession())])
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: [{ id: 'spe-1' }] })
enqueue({ data: payableInvoice() })
enqueue({ data: { accounting_method: 'accrual', entity_type: 'aktiebolag' } })
enqueue({ data: null })
enqueue({ data: null })
const summary = await syncStripeConnection(supabase as unknown as SupabaseClient, CONNECTION)
expect(summary.needsReview).toBe(1)
})
})