Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
92 lines
2.9 KiB
TypeScript
92 lines
2.9 KiB
TypeScript
/**
|
|
* Resend Email Service Implementation
|
|
*
|
|
* Implements EmailService using the Resend API.
|
|
*/
|
|
|
|
import { Resend } from 'resend'
|
|
import { createLogger } from '@/lib/logger'
|
|
import { getBranding } from '@/lib/branding/service'
|
|
import type { EmailService, SendEmailOptions, SendEmailResult } from '@/lib/email/service'
|
|
|
|
const log = createLogger('email')
|
|
|
|
const DEFAULT_FROM_EMAIL = process.env.RESEND_FROM_EMAIL || 'noreply@localhost'
|
|
|
|
function sanitizeHeaderPart(s: string): string {
|
|
return s.replace(/[\r\n<>]/g, '').trim()
|
|
}
|
|
|
|
let resendClient: Resend | null = null
|
|
|
|
function getResendClient(): Resend {
|
|
if (!resendClient) {
|
|
if (!process.env.RESEND_API_KEY) {
|
|
throw new Error('RESEND_API_KEY is not configured')
|
|
}
|
|
resendClient = new Resend(process.env.RESEND_API_KEY)
|
|
}
|
|
return resendClient
|
|
}
|
|
|
|
function isResendConfigured(): boolean {
|
|
return !!process.env.RESEND_API_KEY && !!process.env.RESEND_FROM_EMAIL && process.env.RESEND_FROM_EMAIL !== 'noreply@localhost'
|
|
}
|
|
|
|
export class ResendEmailService implements EmailService {
|
|
async sendEmail(options: SendEmailOptions): Promise<SendEmailResult> {
|
|
const { to, cc, subject, html, text, replyTo, fromName, attachments } = options
|
|
|
|
if (!this.isConfigured()) {
|
|
return { success: false, error: 'Email service is not configured' }
|
|
}
|
|
|
|
// Strip CRLF and angle brackets from name parts to prevent header injection.
|
|
// Resend's API does its own validation, but defense in depth: both fromName
|
|
// (user-controlled, from company settings) and appName (admin-controlled,
|
|
// from branding) flow into the From header.
|
|
const safeAppName = sanitizeHeaderPart(getBranding().appName)
|
|
const safeFromName = fromName ? sanitizeHeaderPart(fromName) : null
|
|
const from = safeFromName
|
|
? `${safeFromName} via ${safeAppName} <${DEFAULT_FROM_EMAIL}>`
|
|
: `${safeAppName} <${DEFAULT_FROM_EMAIL}>`
|
|
|
|
try {
|
|
const resend = getResendClient()
|
|
const response = await resend.emails.send({
|
|
from,
|
|
to: Array.isArray(to) ? to : [to],
|
|
cc: cc ? (Array.isArray(cc) ? cc : [cc]) : undefined,
|
|
subject,
|
|
html,
|
|
text,
|
|
replyTo,
|
|
attachments: attachments?.map(att => ({
|
|
filename: att.filename,
|
|
content: typeof att.content === 'string'
|
|
? Buffer.from(att.content, 'base64')
|
|
: Buffer.from(att.content),
|
|
contentType: att.contentType,
|
|
})),
|
|
})
|
|
|
|
if (response.error) {
|
|
log.error('Resend error:', response.error)
|
|
return { success: false, error: response.error.message }
|
|
}
|
|
|
|
return { success: true, messageId: response.data?.id }
|
|
} catch (error) {
|
|
log.error('Failed to send email:', error)
|
|
return {
|
|
success: false,
|
|
error: error instanceof Error ? error.message : 'Unknown error',
|
|
}
|
|
}
|
|
}
|
|
|
|
isConfigured(): boolean {
|
|
return isResendConfigured()
|
|
}
|
|
}
|