Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
72 lines
2.4 KiB
TypeScript
72 lines
2.4 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { NextRequest } from 'next/server'
|
|
|
|
const verifyOtp = vi.fn()
|
|
const exchangeCodeForSession = vi.fn()
|
|
|
|
vi.mock('@supabase/ssr', () => ({
|
|
createServerClient: vi.fn(() => ({
|
|
auth: {
|
|
verifyOtp,
|
|
exchangeCodeForSession,
|
|
getUser: vi.fn().mockResolvedValue({ data: { user: { id: 'user-1' } } }),
|
|
mfa: {
|
|
getAuthenticatorAssuranceLevel: vi.fn().mockResolvedValue({ data: null }),
|
|
listFactors: vi.fn().mockResolvedValue({ data: null }),
|
|
},
|
|
},
|
|
from: vi.fn(),
|
|
rpc: vi.fn(),
|
|
})),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/invite-tokens', () => ({
|
|
hashInviteToken: vi.fn(),
|
|
}))
|
|
|
|
import { GET } from '../route'
|
|
|
|
describe('GET /auth/callback: recovery flow', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
it('redirects to /reset-password after a successful recovery OTP (token-hash flow)', async () => {
|
|
verifyOtp.mockResolvedValue({ error: null })
|
|
|
|
const request = new NextRequest(
|
|
'http://localhost:3000/auth/callback?token_hash=abc&type=recovery&next=/reset-password'
|
|
)
|
|
const response = await GET(request)
|
|
|
|
expect(response.status).toBe(307)
|
|
expect(response.headers.get('location')).toBe('http://localhost:3000/reset-password')
|
|
expect(verifyOtp).toHaveBeenCalledWith({ token_hash: 'abc', type: 'recovery' })
|
|
})
|
|
|
|
it('redirects to /reset-password after a successful PKCE exchange when next=/reset-password (no type param)', async () => {
|
|
exchangeCodeForSession.mockResolvedValue({ error: null })
|
|
|
|
const request = new NextRequest(
|
|
'http://localhost:3000/auth/callback?code=xyz&next=/reset-password'
|
|
)
|
|
const response = await GET(request)
|
|
|
|
expect(response.status).toBe(307)
|
|
expect(response.headers.get('location')).toBe('http://localhost:3000/reset-password')
|
|
expect(exchangeCodeForSession).toHaveBeenCalledWith('xyz')
|
|
})
|
|
|
|
it('redirects to /login?error=auth_error when the recovery OTP is expired or already consumed', async () => {
|
|
verifyOtp.mockResolvedValue({ error: { message: 'Token has expired or is invalid' } })
|
|
|
|
const request = new NextRequest(
|
|
'http://localhost:3000/auth/callback?token_hash=expired&type=recovery&next=/reset-password'
|
|
)
|
|
const response = await GET(request)
|
|
|
|
expect(response.status).toBe(307)
|
|
expect(response.headers.get('location')).toBe('http://localhost:3000/login?error=auth_error')
|
|
})
|
|
})
|