Files
accounted/lib/branding/__tests__/service.test.ts
T
MattssonandClaude Opus 4.7 32d9978f1b Fix/chrome pdf preview csp (#572)
* feat: add option to exclude year-end closing entries in SIE export and related reports

* delete docs

* fix: allow Chrome's PDF viewer in verifikat document preview

The /api/documents/:id/inline route shipped with
`object-src 'none'` in its CSP, which blocked Chrome's built-in PDF
viewer (it renders inline PDFs via an internal <embed>). Users on
Chrome saw "Det här innehållet har blockerats" when expanding a PDF
attachment in the bookkeeping view; Firefox (PDF.js) and Edge (own
viewer) were unaffected, and JPGs worked because <img> isn't subject
to object-src.

Drops the CSP for this route to the minimum needed for embeddability:
`frame-ancestors 'self'`. X-Content-Type-Options: nosniff plus the
fixed Content-Type from the handler already block MIME confusion;
X-Frame-Options: SAMEORIGIN + frame-ancestors still block clickjacking.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(auth): add webmail deep link to email confirmation screens

Mirrors Stripe's signup UX: after asking the user to verify their email,
detect their webmail provider from the domain and show a button that
opens the inbox in a new tab. Gmail gets a from:<sender> search
pre-populated; Outlook/Yahoo/iCloud/Proton open the inbox directly.
Unknown / custom domains fall back to the existing copy.

Sender address is configurable via NEXT_PUBLIC_BRANDING_AUTH_EMAIL_FROM
(default noreply@gnubok.se) so white-label installs can match their
Supabase Auth SMTP config.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(auth): unblock first-time password set for BankID users with MFA

Supabase rejects updateUser({password}) and mfa.unenroll with "AAL2 session
is required" whenever a TOTP factor is enrolled. BankID magic-link logins
produce AAL1, and middleware skips MFA enforcement for bankid_linked users,
so they had no path to AAL2 — leaving them unable to set a backup password
or disable MFA without going through the email-recovery escape hatch.

- /api/account/password: branch on app_metadata.has_password. First-time set
  writes via service.auth.admin.updateUserById (no existing credential to
  protect, AAL2 guard does not apply). Change-password keeps the user-session
  updateUser so AAL2 still fires for credential rotation.
- /mfa/verify: accept a safeReturnTo query param and route there after
  successful verify, so step-up flows can land back where they came from.
- SecuritySettings: detect the AAL2 error from both change-password and
  mfa.unenroll and redirect through /mfa/verify?returnTo=/settings/account
  instead of toasting a dead-end error.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Add tests and rounding utility for öre precision in bokslut calculations

- Implemented `roundOre` function for rounding SEK amounts to two decimal places, ensuring consistent monetary calculations.
- Introduced `ORE_TOLERANCE` constant for comparing rounded amounts, facilitating invariant checks in financial entries.
- Created comprehensive tests for `roundOre`, covering typical cases, edge cases, and idempotency.
- Added year-end invariants tests to verify database-level guarantees for closing entries, ensuring they balance to the öre and reject discrepancies.
- Developed end-to-end tests for the dispositions chain, validating the correctness of calculations across various scenarios.

* fix: update PDF rendering to remove Swish QR code generation and set default to disable Swish visibility

* fix: enhance security by rejecting data URIs in safeReturnTo function tests

* fix: improve rounding logic in roundOre function and add customer_type migration

* fix: add customer_type column to customers and enforce CHECK constraint

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 22:29:41 +02:00

129 lines
5.1 KiB
TypeScript

import { describe, it, expect, beforeEach, afterEach } from 'vitest'
const ENV_KEYS = [
'NEXT_PUBLIC_BRANDING_APP_NAME',
'NEXT_PUBLIC_BRANDING_APP_DESCRIPTION',
'BRANDING_LEGAL_ENTITY',
'BRANDING_SUPPORT_EMAIL',
'BRANDING_PRIVACY_EMAIL',
'BRANDING_SECURITY_EMAIL',
'NEXT_PUBLIC_BRANDING_AUTH_EMAIL_FROM',
'NEXT_PUBLIC_BRANDING_LOGO_PATH',
'NEXT_PUBLIC_BRANDING_FAVICON_PATH',
'NEXT_PUBLIC_BRANDING_APPLE_ICON_PATH',
'NEXT_PUBLIC_BRANDING_PWA_ICON_BASE',
'NEXT_PUBLIC_BRANDING_THEME_COLOR',
'NEXT_PUBLIC_BRANDING_MANIFEST_THEME_COLOR',
'NEXT_PUBLIC_BRANDING_MANIFEST_BG_COLOR',
'NEXT_PUBLIC_BRANDING_HIDDEN_NAV',
] as const
describe('branding service', () => {
const originalEnv: Record<string, string | undefined> = {}
beforeEach(() => {
for (const key of ENV_KEYS) {
originalEnv[key] = process.env[key]
delete process.env[key]
}
})
afterEach(async () => {
for (const key of ENV_KEYS) {
if (originalEnv[key] === undefined) delete process.env[key]
else process.env[key] = originalEnv[key]
}
const { registerBrandingService } = await import('../service')
registerBrandingService({})
})
it('returns gnubok defaults when nothing is overridden', async () => {
const { getBranding } = await import('../service')
const b = getBranding()
expect(b.appName).toBe('Gnubok')
expect(b.appDescription).toBe('Ekonomihantering')
expect(b.legalEntity).toBe('Arcim')
expect(b.supportEmail).toBe('support@gnubok.se')
expect(b.privacyEmail).toBe('privacy@gnubok.se')
expect(b.securityEmail).toBe('security@arcim.io')
expect(b.authEmailFrom).toBe('noreply@gnubok.se')
expect(b.logoPath).toBe('/gnubokiceon-removebg-preview.png')
expect(b.faviconPath).toBe('/favicon.ico')
expect(b.appleTouchIconPath).toBe('/icons/icon-192.png')
expect(b.pwaIconBasePath).toBe('/icons')
expect(b.themeColor).toBe('#304D83')
expect(b.manifestThemeColor).toBe('#1a1a1a')
expect(b.manifestBackgroundColor).toBe('#ffffff')
expect(b.hiddenNavHrefs).toEqual([])
})
it('parses NEXT_PUBLIC_BRANDING_HIDDEN_NAV as comma-separated hrefs', async () => {
process.env.NEXT_PUBLIC_BRANDING_HIDDEN_NAV = '/salary,/salary/employees,/customers'
const { getBranding } = await import('../service')
expect(getBranding().hiddenNavHrefs).toEqual(['/salary', '/salary/employees', '/customers'])
})
it('trims whitespace and drops empty entries in hidden nav list', async () => {
process.env.NEXT_PUBLIC_BRANDING_HIDDEN_NAV = ' /salary , ,/customers, '
const { getBranding } = await import('../service')
expect(getBranding().hiddenNavHrefs).toEqual(['/salary', '/customers'])
})
it('empty NEXT_PUBLIC_BRANDING_HIDDEN_NAV keeps default empty list', async () => {
process.env.NEXT_PUBLIC_BRANDING_HIDDEN_NAV = ''
const { getBranding } = await import('../service')
expect(getBranding().hiddenNavHrefs).toEqual([])
})
it('extension override replaces hiddenNavHrefs', async () => {
process.env.NEXT_PUBLIC_BRANDING_HIDDEN_NAV = '/salary'
const { getBranding, registerBrandingService } = await import('../service')
registerBrandingService({ hiddenNavHrefs: ['/customers', '/suppliers'] })
expect(getBranding().hiddenNavHrefs).toEqual(['/customers', '/suppliers'])
})
it('env vars override defaults', async () => {
process.env.NEXT_PUBLIC_BRANDING_APP_NAME = 'Holdio'
process.env.BRANDING_SUPPORT_EMAIL = 'hello@holdio.se'
process.env.NEXT_PUBLIC_BRANDING_LOGO_PATH = '/holdio-logo.svg'
process.env.NEXT_PUBLIC_BRANDING_AUTH_EMAIL_FROM = 'noreply@holdio.se'
const { getBranding } = await import('../service')
const b = getBranding()
expect(b.appName).toBe('Holdio')
expect(b.supportEmail).toBe('hello@holdio.se')
expect(b.logoPath).toBe('/holdio-logo.svg')
expect(b.authEmailFrom).toBe('noreply@holdio.se')
expect(b.appDescription).toBe('Ekonomihantering')
})
it('extension override beats env vars', async () => {
process.env.NEXT_PUBLIC_BRANDING_APP_NAME = 'EnvName'
const { getBranding, registerBrandingService } = await import('../service')
registerBrandingService({ appName: 'ExtensionName' })
expect(getBranding().appName).toBe('ExtensionName')
})
it('extension partial override leaves untouched fields at default', async () => {
const { getBranding, registerBrandingService } = await import('../service')
registerBrandingService({ appName: 'Holdio' })
const b = getBranding()
expect(b.appName).toBe('Holdio')
expect(b.legalEntity).toBe('Arcim')
expect(b.supportEmail).toBe('support@gnubok.se')
})
it('empty string env var does not override', async () => {
process.env.NEXT_PUBLIC_BRANDING_APP_NAME = ''
const { getBranding } = await import('../service')
expect(getBranding().appName).toBe('Gnubok')
})
it('clearing extension override returns to env/default resolution', async () => {
const { getBranding, registerBrandingService } = await import('../service')
registerBrandingService({ appName: 'Holdio' })
expect(getBranding().appName).toBe('Holdio')
registerBrandingService({})
expect(getBranding().appName).toBe('Gnubok')
})
})