Jakob WennbergandClaude Fable 5
5b8e3fa130
Supplier invoice items store vat_rate as a decimal fraction (0.25) while customer invoices use integer percent (25). The shared Zod schema accepted 0-100, so a percent-shaped vat_rate silently booked 2500 % VAT via line_total * vat_rate, and the MCP inbox-conversion path staged the AI extraction's percent-integer vatRate straight into the decimal column with per-line vat_amount 0. Part of #310. - CreateSupplierInvoiceItemSchema.vat_rate is now a literal union of the statutory decimal set (0, 0.06, 0.12, 0.25) with a unit-hint error, covering the cookie route, the invoice-inbox convert route, and /api/v1 (whose runtime ALLOWED_SV_VAT_RATES guard stays as defense in depth). - New shared normalizeVatRateToDecimal() in lib/vat: percent-shaped values (25, 12, 6) divide by 100, results snap to the legal Swedish set, and anything else (foreign 19/20, non-finite) maps to 0. - gnubok_create_supplier_invoice_from_inbox normalizes vatRate at the extraction boundary and derives per-line vat_amount when the extraction carries none, so the staged header vat_amount is honest. - The pending-operation executor normalizes staged vat_rate on insert, so rows staged before this fix cannot book percent-scaled VAT. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
73 lines
3.1 KiB
TypeScript
73 lines
3.1 KiB
TypeScript
// Pure submit-time checks for supplier invoice line items (issue #863).
|
|
// Kept free of React so the rules can be unit-tested and reused.
|
|
|
|
import { roundOre } from '@/lib/money'
|
|
|
|
// Only 25/12/6/0 % are legal Swedish VAT rates (ML 2023:200). The supplier
|
|
// invoice form stores rates as decimal fractions (0.25 = 25 %); this list is
|
|
// also the preset dropdown in the form's VAT rate cell.
|
|
// Note on the food rate: livsmedel moved from 12 % to 6 % on 1 April 2026
|
|
// (Prop. 2025/26:55, ML 2023:200), and the reduction is currently legislated
|
|
// to revert after 31 December 2027; 6 % then remains legal (books, transport)
|
|
// but stops being the food rate. This static allow-list cannot express
|
|
// per-category temporal validity, so revisit at the reversion date.
|
|
export const LEGAL_VAT_RATES: readonly number[] = [0.25, 0.12, 0.06, 0]
|
|
|
|
export function isLegalVatRate(rate: number): boolean {
|
|
return LEGAL_VAT_RATES.includes(rate)
|
|
}
|
|
|
|
/**
|
|
* Normalize a VAT rate that may arrive percent-shaped (25, 12, 6: the AI
|
|
* extraction contract and stale staged pending_operations params) to the
|
|
* decimal-fraction convention used by supplier_invoice_items (0.25, 0.12,
|
|
* 0.06); issue #310. Values above 1 are treated as percent and divided by
|
|
* 100; the result is snapped to the legal Swedish set and anything else
|
|
* (foreign 19/20, non-finite or missing input) maps to 0, mirroring the
|
|
* extraction contract: the strict Swedish allowlist applies when converting
|
|
* to a supplier invoice.
|
|
*/
|
|
export function normalizeVatRateToDecimal(rate: unknown): number {
|
|
const n = Number(rate)
|
|
if (!Number.isFinite(n)) return 0
|
|
// roundOre is 2-decimal rounding: exactly the snap a decimal fraction of an
|
|
// integer percent needs (25 / 100 must land on the legal-set double).
|
|
const decimal = roundOre(n > 1 ? n / 100 : n)
|
|
return isLegalVatRate(decimal) ? decimal : 0
|
|
}
|
|
|
|
/**
|
|
* Index of the first line whose VAT rate falls outside the legal Swedish set,
|
|
* or -1 when every line is legal. Reverse charge invoices should skip this
|
|
* check: their line vat_rate is forced to 0 and the self-assessed rate comes
|
|
* from a fixed select that only offers legal rates.
|
|
*/
|
|
export function findIllegalVatRateRow(
|
|
items: ReadonlyArray<{ vat_rate: number }>,
|
|
): number {
|
|
return items.findIndex((item) => !isLegalVatRate(item.vat_rate))
|
|
}
|
|
|
|
/**
|
|
* Indices of lines that look mis-accounted for a reverse charge invoice:
|
|
* omvand skattskyldighet purchases are normally booked on cost accounts
|
|
* (4xxx/5xxx), so a line on a class 1 (assets) or class 6 account is worth a
|
|
* second look. Advisory only, never blocking: class 6 has legitimate reverse
|
|
* charge uses (e.g. 6540 IT-tjanster for EU cloud services).
|
|
*
|
|
* Account numbers are strings (identifiers, not quantities); rows without an
|
|
* account yet are skipped, the separate account-missing check owns those.
|
|
*/
|
|
export function findReverseChargeAccountWarningRows(
|
|
items: ReadonlyArray<{ account_number: string }>,
|
|
): number[] {
|
|
const rows: number[] = []
|
|
items.forEach((item, index) => {
|
|
const account = item.account_number
|
|
if (account && (account.startsWith('1') || account.startsWith('6'))) {
|
|
rows.push(index)
|
|
}
|
|
})
|
|
return rows
|
|
}
|