* feat(webshop-orders): schema, types and error codes for the orders surface webshop_orders (order/refund rows, financial-freeze trigger, member select/update RLS, no DELETE) + webshop_store_settings (per-store payment method -> account map), source_type 'webshop_order', multi-store index drop, customer_country, and a one-time woo cursor reset so the switch-over backfills and cross-marks existing feed rows. Tables classified in the full-archive export; pg-real coverage for RLS, freeze and CHECK. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(webshop-orders): core service (ingest, booking lines) upsertWebshopOrders: two-phase order/refund upsert with FX enrichment, legacy-feed cross-marking, frozen-row protection and field-wise jsonb comparisons (Postgres does not preserve object key order). Booking-line builder: per-rate VAT split with SIGNED buckets (discounts book as revenue reductions), refund mirroring, 3740 residual, per-store account prefill, and advisory export/EU + OSS warnings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(webshop-orders): API routes for list, booking, invoicing and mapping Booking is draft -> atomic claim -> commit (conditional link-back closes the concurrent double-book race; a lost claim cancels the voucher-free draft). Legacy-feed guard honors transactions.is_ignored on both the book and create-invoice paths. Invoice conversion reuses buildInvoiceWriteData for an unnumbered draft with dominant-rate fallback and drift-safe unit prices. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(webshop-orders): Orders page, booking/invoice dialogs and gated nav /orders lists per-store orders with status tabs (server-side filters), exception chips and one action per row. Booking dialog prefills from the per-store payment-method mapping with an opt-in remember; invoice dialog converts to a draft kundfaktura. The Order nav item renders only for companies with an active WooCommerce connection or existing order rows (Shopify deliberately excluded until its sync writes webshop_orders). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(woocommerce): switch the order sync to webshop_orders, multi-store The sync maps rich wc/v3 payloads (billing, line/shipping/fee taxes, refund allocations with parent-prorated VAT fallback) and upserts order rows instead of transactions-inbox rows; already-imported feed rows stay bookable and get cross-marked. Multi-store: several active connections per company, per-store panel cards with the account-mapping editor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(webshop-orders): decision log entries and ratchet baseline Baseline moves DOWN only: naive-ore-round 638 -> 637 via roundOre adoption; hand-rolled invariants stay at 115 (ACCOUNT_NUMBER_RE imported, not inlined). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(webshop-orders): resolve PR #1525 review findings and CI failures Review batch (Superagent, CodeRabbit, Swedish compliance review): - Mutual-exclusion claims: booking guards invoice_id, invoice link-back guards journal_entry_id AND treats zero matched rows as the conflict it is (409 + rollback), closing both TOCTOU races. - Freeze v2 migration (20260812124858): the link columns themselves are protected: invoice links immutable, journal links clearable only while the entry is still a draft (the booking rollback path). - Scraped orgnr no longer auto-written to customers.org_number; rate fallback applies only on single-VAT-bucket orders; refunds get their own WEBSHOP_ORDER_REFUND_NOT_CONVERTIBLE code; VAT advisories outrank the invoice-mode hint in the booking dialog. - Ingest compares every synced field (billing corrections no longer drop as unchanged); sync guards absent refunds arrays; /sync aggregates per-store results; panel disables all cards while a request runs; orders page separates load failure from empty; account field explains itself. CI: regenerated skills/accounted-api; pg tests restructured for transaction-abort/rollback semantics + freeze-link coverage; unresolvable- expression ceiling 375 -> 378 with documented reason (partial-update payloads in ingest, shapes covered by unit tests). Declined: CodeRabbit docstring-coverage advisory (house style: comments only where the code cannot say it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
359 lines
14 KiB
TypeScript
359 lines
14 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
|
|
|
|
// Force the capability gate to run but stub requireCapability so entitlement
|
|
// is controlled per test. Mirrors the stripe/enable-banking suites.
|
|
vi.mock('@/lib/entitlements/has-capability', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('@/lib/entitlements/has-capability')>()
|
|
return { ...actual, requireCapability: vi.fn().mockResolvedValue(null) }
|
|
})
|
|
|
|
// Never let a unit test reach a real WooCommerce host: the credential probe
|
|
// is mocked, the pure helpers (normalizeStoreUrl) stay real.
|
|
vi.mock('../lib/api-client', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('../lib/api-client')>()
|
|
return { ...actual, testConnectionAndFetchStoreInfo: vi.fn() }
|
|
})
|
|
|
|
// The sync engine has its own suite; here it only needs to be callable.
|
|
vi.mock('../lib/order-sync', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('../lib/order-sync')>()
|
|
return { ...actual, syncWooCommerceOrders: vi.fn() }
|
|
})
|
|
|
|
vi.mock('@/lib/auth/api-keys', () => ({
|
|
createServiceClientNoCookies: vi.fn(() => ({ service: true })),
|
|
}))
|
|
|
|
import { woocommerceExtension } from '../index'
|
|
import { requireCapability, capabilityBlockedResponse } from '@/lib/entitlements/has-capability'
|
|
import { CAPABILITY } from '@/lib/entitlements/keys'
|
|
import { testConnectionAndFetchStoreInfo } from '../lib/api-client'
|
|
import { syncWooCommerceOrders } from '../lib/order-sync'
|
|
import { decryptCredential } from '../lib/credentials'
|
|
import { createQueuedMockSupabase } from '@/tests/helpers'
|
|
import type { ExtensionContext } from '@/lib/extensions/types'
|
|
|
|
function findRoute(method: string, path: string) {
|
|
const route = woocommerceExtension.apiRoutes?.find(
|
|
(r) => r.method === method && r.path === path,
|
|
)
|
|
expect(route, `${method} ${path} must be registered`).toBeDefined()
|
|
return route!
|
|
}
|
|
|
|
function makeRequest(method: string, body?: unknown): Request {
|
|
return new Request('https://test.local/api/extensions/ext/woocommerce/x', {
|
|
method,
|
|
headers: { 'Content-Type': 'application/json' },
|
|
...(body !== undefined ? { body: JSON.stringify(body) } : {}),
|
|
})
|
|
}
|
|
|
|
function makeContext(supabase: unknown): ExtensionContext {
|
|
return {
|
|
userId: 'user-1',
|
|
companyId: 'company-1',
|
|
extensionId: 'woocommerce',
|
|
requestId: 'req_test',
|
|
supabase,
|
|
emit: vi.fn().mockResolvedValue(undefined),
|
|
log: { info: vi.fn(), warn: vi.fn(), error: vi.fn() },
|
|
settings: {
|
|
get: vi.fn().mockResolvedValue(null),
|
|
set: vi.fn().mockResolvedValue(undefined),
|
|
clear: vi.fn().mockResolvedValue(undefined),
|
|
},
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
} as any
|
|
}
|
|
|
|
const USER = { id: 'user-1', is_anonymous: false }
|
|
|
|
describe('woocommerce extension routes', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.mocked(requireCapability).mockResolvedValue(null)
|
|
vi.stubEnv('WOOCOMMERCE_CREDENTIALS_ENCRYPTION_KEY', 'test-key')
|
|
vi.stubEnv('NEXT_PUBLIC_APP_URL', 'http://localhost:3000')
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllEnvs()
|
|
})
|
|
|
|
describe('GET /status', () => {
|
|
it('returns 401 without a user', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: null }, error: null })
|
|
const res = await findRoute('GET', '/status').handler(
|
|
makeRequest('GET'),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(401)
|
|
})
|
|
|
|
it('prefers the active connection and reports configured', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({
|
|
data: [
|
|
{ id: 'c2', status: 'revoked' },
|
|
{ id: 'c1', status: 'active', store_url: 'https://shop.example.se' },
|
|
],
|
|
})
|
|
const res = await findRoute('GET', '/status').handler(
|
|
makeRequest('GET'),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(200)
|
|
const body = await res.json()
|
|
expect(body.configured).toBe(true)
|
|
expect(body.connection.id).toBe('c1')
|
|
})
|
|
})
|
|
|
|
describe('POST /connect', () => {
|
|
it('returns 401 without a user', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: null }, error: null })
|
|
const res = await findRoute('POST', '/connect').handler(
|
|
makeRequest('POST', {}),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(401)
|
|
})
|
|
|
|
it('blocks anonymous (sandbox) users before any external call', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({
|
|
data: { user: { id: 'user-1', is_anonymous: true } },
|
|
error: null,
|
|
})
|
|
const res = await findRoute('POST', '/connect').handler(
|
|
makeRequest('POST', {}),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(403)
|
|
const body = await res.json()
|
|
expect(body.sandbox_blocked).toBe(true)
|
|
})
|
|
|
|
it('returns 403 capability_blocked when not entitled', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: { is_sandbox: false } })
|
|
vi.mocked(requireCapability).mockResolvedValue(
|
|
capabilityBlockedResponse(CAPABILITY.woocommerce_sync),
|
|
)
|
|
const res = await findRoute('POST', '/connect').handler(
|
|
makeRequest('POST', { store_url: 'https://shop.example.se' }),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(403)
|
|
})
|
|
|
|
it('rejects an invalid or http store URL with 400', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: { is_sandbox: false } })
|
|
const res = await findRoute('POST', '/connect').handler(
|
|
makeRequest('POST', { store_url: 'http://insecure.se' }),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(400)
|
|
})
|
|
|
|
it('stages a pending row and returns the wc-auth authorize URL', async () => {
|
|
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: { is_sandbox: false } }) // guardSandbox
|
|
enqueue({ data: [] }) // no existing active/pending
|
|
enqueue({ data: { id: 'conn-1' } }) // insert pending
|
|
const res = await findRoute('POST', '/connect').handler(
|
|
makeRequest('POST', { store_url: 'Shop.Example.se/' }),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(200)
|
|
const body = await res.json()
|
|
expect(body.url).toMatch(/^https:\/\/shop\.example\.se\/wc-auth\/v1\/authorize\?/)
|
|
expect(body.url).toContain('scope=read')
|
|
expect(body.url).toContain(
|
|
encodeURIComponent('http://localhost:3000/api/extensions/woocommerce/callback'),
|
|
)
|
|
const inserted = findCall('woocommerce_connections', 'insert')?.[0] as Record<
|
|
string,
|
|
unknown
|
|
>
|
|
expect(inserted.store_url).toBe('https://shop.example.se')
|
|
expect(inserted.status).toBe('pending')
|
|
expect(inserted.oauth_state).toBeTruthy()
|
|
})
|
|
})
|
|
|
|
describe('POST /manual-connect', () => {
|
|
it('rejects missing keys with 400', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: { is_sandbox: false } })
|
|
const res = await findRoute('POST', '/manual-connect').handler(
|
|
makeRequest('POST', { store_url: 'https://shop.example.se', consumer_key: 'ck_x' }),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(400)
|
|
})
|
|
|
|
it('rejects with 400 when the credential probe fails', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: { is_sandbox: false } })
|
|
enqueue({ data: [] }) // no existing connection
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockRejectedValue(new Error('401'))
|
|
const res = await findRoute('POST', '/manual-connect').handler(
|
|
makeRequest('POST', {
|
|
store_url: 'https://shop.example.se',
|
|
consumer_key: 'ck_x',
|
|
consumer_secret: 'cs_y',
|
|
}),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(400)
|
|
})
|
|
|
|
it('verifies, encrypts and activates on the happy path', async () => {
|
|
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: { is_sandbox: false } })
|
|
enqueue({ data: [] }) // no existing connection
|
|
enqueue({ data: { id: 'conn-1', store_url: 'https://shop.example.se' } }) // insert
|
|
vi.mocked(testConnectionAndFetchStoreInfo).mockResolvedValue({
|
|
name: 'Testbutiken',
|
|
currency: 'SEK',
|
|
prices_include_tax: true,
|
|
wc_version: '9.9.5',
|
|
})
|
|
const ctx = makeContext(supabase)
|
|
const res = await findRoute('POST', '/manual-connect').handler(
|
|
makeRequest('POST', {
|
|
store_url: 'https://shop.example.se',
|
|
consumer_key: 'ck_x',
|
|
consumer_secret: 'cs_y',
|
|
}),
|
|
ctx,
|
|
)
|
|
expect(res.status).toBe(200)
|
|
const inserted = findCall('woocommerce_connections', 'insert')?.[0] as Record<
|
|
string,
|
|
string
|
|
>
|
|
expect(inserted.status).toBe('active')
|
|
expect(inserted.store_name).toBe('Testbutiken')
|
|
// Secrets never stored in plaintext, and they decrypt back.
|
|
expect(inserted.consumer_key_encrypted).not.toContain('ck_x')
|
|
expect(decryptCredential(inserted.consumer_key_encrypted)).toBe('ck_x')
|
|
expect(decryptCredential(inserted.consumer_secret_encrypted)).toBe('cs_y')
|
|
expect(ctx.emit).toHaveBeenCalledWith(
|
|
expect.objectContaining({ type: 'woocommerce.connected' }),
|
|
)
|
|
})
|
|
})
|
|
|
|
describe('POST /sync', () => {
|
|
it('returns 404 without an active connection', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: [] })
|
|
const res = await findRoute('POST', '/sync').handler(
|
|
makeRequest('POST'),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(404)
|
|
})
|
|
|
|
it('runs the sync on the service client and returns the summary', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: [{ id: 'conn-1', status: 'active' }] })
|
|
vi.mocked(syncWooCommerceOrders).mockResolvedValue({
|
|
fetched: 3,
|
|
refundsFetched: 1,
|
|
inserted: 4,
|
|
updated: 0,
|
|
unchanged: 0,
|
|
frozenFlagged: 0,
|
|
crossMarked: 0,
|
|
errors: 0,
|
|
})
|
|
const res = await findRoute('POST', '/sync').handler(
|
|
makeRequest('POST'),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(200)
|
|
const body = await res.json()
|
|
expect(body.transactions.inserted).toBe(4)
|
|
expect(vi.mocked(syncWooCommerceOrders).mock.calls[0][0]).toEqual({ service: true })
|
|
})
|
|
})
|
|
|
|
describe('POST /transaction-sync', () => {
|
|
it('rejects a non-boolean enabled with 400', async () => {
|
|
const { supabase } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
const res = await findRoute('POST', '/transaction-sync').handler(
|
|
makeRequest('POST', { enabled: 'yes' }),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(400)
|
|
})
|
|
|
|
it('persists the toggle for the active connection', async () => {
|
|
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: [{ id: 'conn-1' }] })
|
|
const res = await findRoute('POST', '/transaction-sync').handler(
|
|
makeRequest('POST', { enabled: false }),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(200)
|
|
expect(findCall('woocommerce_connections', 'update')?.[0]).toEqual({
|
|
transaction_sync_enabled: false,
|
|
})
|
|
})
|
|
})
|
|
|
|
describe('DELETE /disconnect', () => {
|
|
it('returns 404 when no connection exists', async () => {
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({ data: [] })
|
|
const res = await findRoute('DELETE', '/disconnect').handler(
|
|
makeRequest('DELETE', {}),
|
|
makeContext(supabase),
|
|
)
|
|
expect(res.status).toBe(404)
|
|
})
|
|
|
|
it('revokes (never deletes) and emits the audit event', async () => {
|
|
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
|
supabase.auth.getUser.mockResolvedValue({ data: { user: USER }, error: null })
|
|
enqueue({
|
|
data: [{ id: 'conn-1', status: 'active', store_url: 'https://shop.example.se' }],
|
|
})
|
|
enqueue({ data: null }) // update
|
|
const ctx = makeContext(supabase)
|
|
const res = await findRoute('DELETE', '/disconnect').handler(
|
|
makeRequest('DELETE', {}),
|
|
ctx,
|
|
)
|
|
expect(res.status).toBe(200)
|
|
const updated = findCall('woocommerce_connections', 'update')?.[0] as Record<
|
|
string,
|
|
unknown
|
|
>
|
|
expect(updated.status).toBe('revoked')
|
|
expect(ctx.emit).toHaveBeenCalledWith(
|
|
expect.objectContaining({ type: 'woocommerce.disconnected' }),
|
|
)
|
|
})
|
|
})
|
|
})
|