* fix(whatsapp): make every silent disposition observable, stop pure silence for linked senders (#1552) Silence was a legitimate outcome in seven places and none left a trace a support question could be answered from. Now: - Unknown-sender declines (over quota, quota RPC failure, greeting throttle) persist content-free trace rows: wamid, phone hash, type, disposition. No body, media, raw payload, or profile name; capped at 20 rows per hash and day; deleted by the existing 30-day retention. The wamid dedupe also stops redelivered bad-code/greeting messages from earning a second reply. - Linked-sender deliberate silences (muted, stale tap, ignorable type) record their reason on the skipped row. - Non-policy silences reply: a row missing its media reference sends M18 through the link's reply address, a link revoked between arrival and processing sends the M1 unlinked copy (greeting-throttled). - Outbound rows keep WHY a send failed (Graph error detail), and Meta 'failed' delivery statuses store their error code and title. - The WhatsApp settings panel shows the last inbound event (closed enum, server-derived) and warns when the latest reply never left. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(whatsapp): include errorDetail in typed sendText mock results SendTextResult gained errorDetail; vi.mocked call sites must match the widened type or they raise fresh tsc errors over the repo baseline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(whatsapp): review fixes: fail-closed greeting throttle, cap only declined traces From CodeRabbit's pass on #1563: - greetingThrottled fails closed when the throttle window cannot be read, matching the unknown-sender quota's stance. - The decline-trace day cap applies only to 'skipped' rows (the one unbounded path); 'done' traces always insert so the wamid dedupe keeps preventing duplicate M1/M2 replies even past the cap. Their volume is already bounded upstream by the greeting throttle and the pre-binding quota. - company-question test mocks match the widened SendTextResult. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
206 lines
7.7 KiB
TypeScript
206 lines
7.7 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
|
|
import { createQueuedMockSupabase } from '@/tests/helpers'
|
|
import { TimeoutError } from '@/lib/http/fetch-with-timeout'
|
|
import {
|
|
sendText,
|
|
downloadMedia,
|
|
getDisplayPhoneNumber,
|
|
resetDisplayNumberCacheForTests,
|
|
GraphApiError,
|
|
MAX_MEDIA_BYTES,
|
|
} from '@/extensions/general/whatsapp-inbox/lib/graph-api'
|
|
import { TEMPLATE } from '@/extensions/general/whatsapp-inbox/lib/messages'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
|
|
const fetchMock = vi.fn()
|
|
|
|
describe('graph-api', () => {
|
|
const originalEnv = { ...process.env }
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.stubGlobal('fetch', fetchMock)
|
|
resetDisplayNumberCacheForTests()
|
|
process.env.WHATSAPP_ACCESS_TOKEN = 'token-1'
|
|
process.env.WHATSAPP_PHONE_NUMBER_ID = '111222333'
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals()
|
|
process.env = { ...originalEnv }
|
|
})
|
|
|
|
describe('sendText', () => {
|
|
it('sends and persists an outbound row with the response wamid', async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({ messages: [{ id: 'wamid.OUT1' }] }), { status: 200 }),
|
|
)
|
|
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
|
enqueue({ data: null, error: null })
|
|
|
|
const result = await sendText(supabase as unknown as SupabaseClient, {
|
|
to: '46701234567',
|
|
body: 'Hej!',
|
|
template: TEMPLATE.m16Fallback,
|
|
senderPhoneHash: 'hash-1',
|
|
})
|
|
|
|
expect(result).toEqual({ ok: true, wamid: 'wamid.OUT1', errorDetail: null })
|
|
const [row] = findCall('whatsapp_messages', 'insert') as [Record<string, unknown>]
|
|
expect(row.direction).toBe('outbound')
|
|
expect(row.wamid).toBe('wamid.OUT1')
|
|
expect(row.delivery_status).toBe('sent')
|
|
expect(row.error_message).toBeNull()
|
|
expect(row.processing_status).toBe('done')
|
|
expect(row.raw_payload).toEqual({ template: TEMPLATE.m16Fallback })
|
|
expect(row.sender_phone_hash).toBe('hash-1')
|
|
|
|
// The Graph call itself
|
|
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit]
|
|
expect(url).toContain('/111222333/messages')
|
|
expect((init.headers as Record<string, string>).Authorization).toBe('Bearer token-1')
|
|
expect(JSON.parse(init.body as string).text.body).toBe('Hej!')
|
|
})
|
|
|
|
it('never throws on non-2xx and records a failed row', async () => {
|
|
fetchMock.mockResolvedValueOnce(new Response('{"error":{}}', { status: 500 }))
|
|
const { supabase, enqueue, findCall } = createQueuedMockSupabase()
|
|
enqueue({ data: null, error: null })
|
|
|
|
const result = await sendText(supabase as unknown as SupabaseClient, {
|
|
to: '46701234567',
|
|
body: 'Hej!',
|
|
template: TEMPLATE.m18Error,
|
|
})
|
|
|
|
expect(result.ok).toBe(false)
|
|
expect(result.wamid).toBeNull()
|
|
const [row] = findCall('whatsapp_messages', 'insert') as [Record<string, unknown>]
|
|
expect(row.delivery_status).toBe('failed')
|
|
expect(row.wamid).toBeNull()
|
|
// #1552: the row keeps WHY the send failed, not just that it failed.
|
|
expect(row.error_message).toContain('HTTP 500')
|
|
})
|
|
|
|
it('never throws on a network error', async () => {
|
|
fetchMock.mockRejectedValueOnce(new Error('ECONNRESET'))
|
|
const { supabase, enqueue } = createQueuedMockSupabase()
|
|
enqueue({ data: null, error: null })
|
|
|
|
const result = await sendText(supabase as unknown as SupabaseClient, {
|
|
to: '46701234567',
|
|
body: 'Hej!',
|
|
template: TEMPLATE.m18Error,
|
|
})
|
|
expect(result.ok).toBe(false)
|
|
})
|
|
})
|
|
|
|
describe('downloadMedia', () => {
|
|
it('resolves the media id, downloads with Bearer auth, and returns the bytes', async () => {
|
|
const bytes = new Uint8Array([1, 2, 3, 4])
|
|
fetchMock
|
|
.mockResolvedValueOnce(
|
|
new Response(
|
|
JSON.stringify({ url: 'https://lookaside.example/m1', mime_type: 'image/jpeg' }),
|
|
{ status: 200 },
|
|
),
|
|
)
|
|
.mockResolvedValueOnce(new Response(bytes, { status: 200 }))
|
|
|
|
const media = await downloadMedia('media-1')
|
|
expect(media.mime).toBe('image/jpeg')
|
|
expect(media.fileSize).toBe(4)
|
|
expect(new Uint8Array(media.buffer)).toEqual(bytes)
|
|
|
|
const [downloadUrl, downloadInit] = fetchMock.mock.calls[1] as [string, RequestInit]
|
|
expect(downloadUrl).toBe('https://lookaside.example/m1')
|
|
expect((downloadInit.headers as Record<string, string>).Authorization).toBe('Bearer token-1')
|
|
})
|
|
|
|
it('rejects a non-2xx lookup', async () => {
|
|
fetchMock.mockResolvedValueOnce(new Response('{}', { status: 404 }))
|
|
await expect(downloadMedia('media-1')).rejects.toThrow(GraphApiError)
|
|
})
|
|
|
|
it('rejects a non-2xx download', async () => {
|
|
fetchMock
|
|
.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({ url: 'https://lookaside.example/m1' }), { status: 200 }),
|
|
)
|
|
.mockResolvedValueOnce(new Response('gone', { status: 410 }))
|
|
await expect(downloadMedia('media-1')).rejects.toThrow(/download failed/)
|
|
})
|
|
|
|
it('rejects when the declared file size exceeds the cap', async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(
|
|
JSON.stringify({ url: 'https://x/m1', file_size: MAX_MEDIA_BYTES + 1 }),
|
|
{ status: 200 },
|
|
),
|
|
)
|
|
await expect(downloadMedia('media-1')).rejects.toThrow(/size limit/)
|
|
expect(fetchMock).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('rejects via the content-length header before reading the body', async () => {
|
|
fetchMock
|
|
.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({ url: 'https://x/m1' }), { status: 200 }),
|
|
)
|
|
.mockResolvedValueOnce(
|
|
new Response('x', {
|
|
status: 200,
|
|
headers: { 'content-length': String(MAX_MEDIA_BYTES + 1) },
|
|
}),
|
|
)
|
|
await expect(downloadMedia('media-1')).rejects.toThrow(/size limit/)
|
|
})
|
|
|
|
it('rejects an oversized stream even without a content-length header', async () => {
|
|
const chunk = new Uint8Array(6 * 1024 * 1024)
|
|
const stream = new ReadableStream<Uint8Array>({
|
|
start(controller) {
|
|
controller.enqueue(chunk)
|
|
controller.enqueue(chunk) // 12 MB total > 10 MB cap
|
|
controller.close()
|
|
},
|
|
})
|
|
fetchMock
|
|
.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({ url: 'https://x/m1' }), { status: 200 }),
|
|
)
|
|
.mockResolvedValueOnce(new Response(stream, { status: 200 }))
|
|
|
|
await expect(downloadMedia('media-1')).rejects.toThrow(/size limit/)
|
|
})
|
|
|
|
it('propagates timeouts as TimeoutError', async () => {
|
|
fetchMock.mockRejectedValueOnce(new TimeoutError('WhatsApp media lookup timed out'))
|
|
await expect(downloadMedia('media-1')).rejects.toThrow(TimeoutError)
|
|
})
|
|
|
|
it('throws when the access token is missing', async () => {
|
|
delete process.env.WHATSAPP_ACCESS_TOKEN
|
|
await expect(downloadMedia('media-1')).rejects.toThrow(/WHATSAPP_ACCESS_TOKEN/)
|
|
})
|
|
})
|
|
|
|
describe('getDisplayPhoneNumber', () => {
|
|
it('resolves and caches the display number as digits', async () => {
|
|
fetchMock.mockResolvedValueOnce(
|
|
new Response(JSON.stringify({ display_phone_number: '+46 10 123 45 67' }), { status: 200 }),
|
|
)
|
|
expect(await getDisplayPhoneNumber()).toBe('46101234567')
|
|
// Cached: second call issues no fetch.
|
|
expect(await getDisplayPhoneNumber()).toBe('46101234567')
|
|
expect(fetchMock).toHaveBeenCalledTimes(1)
|
|
})
|
|
|
|
it('returns null on failure instead of throwing', async () => {
|
|
fetchMock.mockResolvedValueOnce(new Response('{}', { status: 500 }))
|
|
expect(await getDisplayPhoneNumber()).toBeNull()
|
|
})
|
|
})
|
|
})
|