* feat(webshop-orders): schema, types and error codes for the orders surface webshop_orders (order/refund rows, financial-freeze trigger, member select/update RLS, no DELETE) + webshop_store_settings (per-store payment method -> account map), source_type 'webshop_order', multi-store index drop, customer_country, and a one-time woo cursor reset so the switch-over backfills and cross-marks existing feed rows. Tables classified in the full-archive export; pg-real coverage for RLS, freeze and CHECK. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(webshop-orders): core service (ingest, booking lines) upsertWebshopOrders: two-phase order/refund upsert with FX enrichment, legacy-feed cross-marking, frozen-row protection and field-wise jsonb comparisons (Postgres does not preserve object key order). Booking-line builder: per-rate VAT split with SIGNED buckets (discounts book as revenue reductions), refund mirroring, 3740 residual, per-store account prefill, and advisory export/EU + OSS warnings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(webshop-orders): API routes for list, booking, invoicing and mapping Booking is draft -> atomic claim -> commit (conditional link-back closes the concurrent double-book race; a lost claim cancels the voucher-free draft). Legacy-feed guard honors transactions.is_ignored on both the book and create-invoice paths. Invoice conversion reuses buildInvoiceWriteData for an unnumbered draft with dominant-rate fallback and drift-safe unit prices. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(webshop-orders): Orders page, booking/invoice dialogs and gated nav /orders lists per-store orders with status tabs (server-side filters), exception chips and one action per row. Booking dialog prefills from the per-store payment-method mapping with an opt-in remember; invoice dialog converts to a draft kundfaktura. The Order nav item renders only for companies with an active WooCommerce connection or existing order rows (Shopify deliberately excluded until its sync writes webshop_orders). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(woocommerce): switch the order sync to webshop_orders, multi-store The sync maps rich wc/v3 payloads (billing, line/shipping/fee taxes, refund allocations with parent-prorated VAT fallback) and upserts order rows instead of transactions-inbox rows; already-imported feed rows stay bookable and get cross-marked. Multi-store: several active connections per company, per-store panel cards with the account-mapping editor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(webshop-orders): decision log entries and ratchet baseline Baseline moves DOWN only: naive-ore-round 638 -> 637 via roundOre adoption; hand-rolled invariants stay at 115 (ACCOUNT_NUMBER_RE imported, not inlined). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(webshop-orders): resolve PR #1525 review findings and CI failures Review batch (Superagent, CodeRabbit, Swedish compliance review): - Mutual-exclusion claims: booking guards invoice_id, invoice link-back guards journal_entry_id AND treats zero matched rows as the conflict it is (409 + rollback), closing both TOCTOU races. - Freeze v2 migration (20260812124858): the link columns themselves are protected: invoice links immutable, journal links clearable only while the entry is still a draft (the booking rollback path). - Scraped orgnr no longer auto-written to customers.org_number; rate fallback applies only on single-VAT-bucket orders; refunds get their own WEBSHOP_ORDER_REFUND_NOT_CONVERTIBLE code; VAT advisories outrank the invoice-mode hint in the booking dialog. - Ingest compares every synced field (billing corrections no longer drop as unchanged); sync guards absent refunds arrays; /sync aggregates per-store results; panel disables all cards while a request runs; orders page separates load failure from empty; account field explains itself. CI: regenerated skills/accounted-api; pg tests restructured for transaction-abort/rollback semantics + freeze-link coverage; unresolvable- expression ceiling 375 -> 378 with documented reason (partial-update payloads in ingest, shapes covered by unit tests). Declined: CodeRabbit docstring-coverage advisory (house style: comments only where the code cannot say it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
239 lines
8.8 KiB
TypeScript
239 lines
8.8 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { ensureInitialized } from '@/lib/init'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { createDraftEntry, commitEntry } from '@/lib/bookkeeping/engine'
|
|
import { bookkeepingErrorResponse } from '@/lib/bookkeeping/errors'
|
|
import { validateBody } from '@/lib/api/validate'
|
|
import { BookWebshopOrderSchema } from '@/lib/api/schemas'
|
|
import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
|
|
import { getErrorMessage } from '@/lib/errors/get-error-message'
|
|
import { fetchExchangeRate } from '@/lib/currency/riksbanken'
|
|
import { roundOre } from '@/lib/money'
|
|
import type { Currency, WebshopOrder } from '@/types'
|
|
|
|
ensureInitialized()
|
|
|
|
/**
|
|
* Book one webshop order/refund row as a verifikat. The dialog sends the
|
|
* (user-reviewed) lines built by lib/webshop-orders/booking-lines; the server
|
|
* re-guards state and routes everything through the engine
|
|
* (source_type 'webshop_order'). Period/company locks and balance are
|
|
* enforced by the engine + DB triggers as usual.
|
|
*/
|
|
export const POST = withRouteContext<{ params: Promise<{ id: string }> }>(
|
|
'webshop_order.book',
|
|
async (request, { supabase, user, companyId, log, requestId }, { params }) => {
|
|
const { id } = await params
|
|
|
|
const validation = await validateBody(request, BookWebshopOrderSchema)
|
|
if (!validation.success) return validation.response
|
|
const { fiscal_period_id, entry_date, description, lines, voucher_series, notes } =
|
|
validation.data
|
|
|
|
const { data: order, error: fetchError } = await supabase
|
|
.from('webshop_orders')
|
|
.select('*')
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.single<WebshopOrder>()
|
|
|
|
if (fetchError || !order) {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_NOT_FOUND', log, { requestId })
|
|
}
|
|
|
|
if (order.journal_entry_id) {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_ALREADY_BOOKED', log, {
|
|
requestId,
|
|
details: { journal_entry_id: order.journal_entry_id },
|
|
})
|
|
}
|
|
if (order.invoice_id) {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_ALREADY_INVOICED', log, {
|
|
requestId,
|
|
details: { invoice_id: order.invoice_id },
|
|
})
|
|
}
|
|
// Refunds of an invoiced order belong in the credit-note flow.
|
|
if (order.row_type === 'refund' && order.parent_order_id) {
|
|
const { data: parent } = await supabase
|
|
.from('webshop_orders')
|
|
.select('invoice_id')
|
|
.eq('id', order.parent_order_id)
|
|
.eq('company_id', companyId)
|
|
.maybeSingle()
|
|
if (parent?.invoice_id) {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_REFUND_PARENT_INVOICED', log, {
|
|
requestId,
|
|
details: { invoice_id: parent.invoice_id },
|
|
})
|
|
}
|
|
}
|
|
if (!order.is_paid && order.row_type === 'order') {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_NOT_PAID', log, { requestId })
|
|
}
|
|
|
|
// Double-booking lock against the legacy transactions feed: the same
|
|
// money event may already sit in the inbox (imported before the Orders
|
|
// switch-over). A booked feed row means this order IS booked via the
|
|
// feed; an open one must be booked or IGNORED there first — and an
|
|
// ignored row (is_ignored) unlocks order-side booking, exactly as the
|
|
// error message instructs.
|
|
if (order.legacy_transaction_id) {
|
|
const { data: legacyTxn } = await supabase
|
|
.from('transactions')
|
|
.select('id, journal_entry_id, is_ignored')
|
|
.eq('id', order.legacy_transaction_id)
|
|
.eq('company_id', companyId)
|
|
.maybeSingle()
|
|
if (legacyTxn) {
|
|
if (legacyTxn.journal_entry_id) {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_LEGACY_TRANSACTION_BOOKED', log, {
|
|
requestId,
|
|
details: {
|
|
transaction_id: legacyTxn.id,
|
|
journal_entry_id: legacyTxn.journal_entry_id,
|
|
},
|
|
})
|
|
}
|
|
if (!legacyTxn.is_ignored) {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_LEGACY_TRANSACTION_OPEN', log, {
|
|
requestId,
|
|
details: { transaction_id: legacyTxn.id },
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
// Non-SEK rows book in SEK; retry the rate once at booking time before
|
|
// refusing (a sync-time Riksbanken hiccup should not strand the order).
|
|
if (order.currency.toUpperCase() !== 'SEK' && order.total_sek === null) {
|
|
let resolved = false
|
|
try {
|
|
const rate = await fetchExchangeRate(
|
|
order.currency.toUpperCase() as Currency,
|
|
new Date(`${order.paid_date ?? order.order_date}T00:00:00Z`),
|
|
supabase,
|
|
)
|
|
if (rate?.rate) {
|
|
const totalSek = roundOre(order.total * rate.rate)
|
|
const { error: fxError } = await supabase
|
|
.from('webshop_orders')
|
|
.update({ total_sek: totalSek, exchange_rate: rate.rate })
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
resolved = !fxError
|
|
}
|
|
} catch (err) {
|
|
log.warn('booking-time FX retry failed', err as Error)
|
|
}
|
|
if (!resolved) {
|
|
return errorResponseFromCode('WEBSHOP_ORDER_FX_UNRESOLVED', log, {
|
|
requestId,
|
|
details: { currency: order.currency },
|
|
})
|
|
}
|
|
}
|
|
|
|
// Race-free booking: draft -> atomic claim -> commit. The read-then-book
|
|
// pattern let two concurrent requests each post an immutable verifikat
|
|
// for the same order (skeptic finding). Instead the order row is claimed
|
|
// with a conditional update BEFORE anything gets a voucher number: the
|
|
// loser's claim matches zero rows and its draft (no voucher yet, so no
|
|
// series gap) is cancelled.
|
|
let draft
|
|
try {
|
|
draft = await createDraftEntry(supabase, companyId, user.id, {
|
|
fiscal_period_id,
|
|
entry_date,
|
|
description,
|
|
source_type: 'webshop_order',
|
|
source_id: id,
|
|
voucher_series,
|
|
notes,
|
|
lines,
|
|
})
|
|
} catch (err) {
|
|
const typed = bookkeepingErrorResponse(err)
|
|
if (typed) return typed
|
|
log.error('failed to draft journal entry for webshop order', err as Error)
|
|
return NextResponse.json(
|
|
{ error: getErrorMessage(err, { context: 'transaction' }) },
|
|
{ status: 400 },
|
|
)
|
|
}
|
|
|
|
const cancelDraft = async () => {
|
|
const { error: cancelError } = await supabase
|
|
.from('journal_entries')
|
|
.update({ status: 'cancelled' })
|
|
.eq('id', draft.id)
|
|
.eq('status', 'draft')
|
|
if (cancelError) {
|
|
log.error('draft cleanup failed after claim/commit failure', cancelError, {
|
|
entryId: draft.id,
|
|
})
|
|
}
|
|
}
|
|
|
|
// The claim guards BOTH links: a concurrent create-invoice between our
|
|
// read and this update must lose too (mutual exclusivity, not just
|
|
// no-double-booking).
|
|
const { data: claimed, error: claimError } = await supabase
|
|
.from('webshop_orders')
|
|
.update({ journal_entry_id: draft.id })
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.is('journal_entry_id', null)
|
|
.is('invoice_id', null)
|
|
.select('id')
|
|
if (claimError || !claimed || claimed.length === 0) {
|
|
await cancelDraft()
|
|
if (claimError) {
|
|
log.error('webshop order claim failed', claimError, { orderId: id })
|
|
return NextResponse.json(
|
|
{ error: getErrorMessage(claimError, { context: 'transaction' }) },
|
|
{ status: 500 },
|
|
)
|
|
}
|
|
// Zero rows matched: someone else booked it between our read and claim.
|
|
return errorResponseFromCode('WEBSHOP_ORDER_ALREADY_BOOKED', log, { requestId })
|
|
}
|
|
|
|
let journalEntry
|
|
try {
|
|
journalEntry = await commitEntry(supabase, companyId, user.id, draft.id)
|
|
} catch (err) {
|
|
// Unlink so the row does not point at a cancelled draft, then cancel.
|
|
// Order matters: the financial-freeze trigger keys on journal_entry_id
|
|
// being set, but journal_entry_id itself is not in its protected list,
|
|
// so the unlink passes.
|
|
await supabase
|
|
.from('webshop_orders')
|
|
.update({ journal_entry_id: null })
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.eq('journal_entry_id', draft.id)
|
|
await cancelDraft()
|
|
const typed = bookkeepingErrorResponse(err)
|
|
if (typed) return typed
|
|
log.error('failed to commit journal entry for webshop order', err as Error)
|
|
return NextResponse.json(
|
|
{ error: getErrorMessage(err, { context: 'transaction' }) },
|
|
{ status: 400 },
|
|
)
|
|
}
|
|
|
|
// No extra event here: commitEntry() already emits
|
|
// journal_entry.committed from inside the engine.
|
|
|
|
return NextResponse.json({
|
|
data: journalEntry,
|
|
// commitEntry's post-commit fetch can theoretically return no row;
|
|
// the entry still exists under draft.id.
|
|
journal_entry_id: journalEntry?.id ?? draft.id,
|
|
success: true,
|
|
})
|
|
},
|
|
{ requireWrite: true },
|
|
)
|