Files
accounted/app/(dashboard)/bookkeeping/page.tsx
T
c897a906df fix(ux): actions update lists in place - no more takeovers, jumps and dead air (#1629)
* fix(ux): update lists in place on actions instead of takeover spinners and jumps

Founder report: the app feels glitchy when clicking around, especially
when deleting a row or booking something. The repo-wide anti-pattern
behind it: single-row actions trigger whole-list skeleton/spinner
takeovers (layout collapse, scroll jump, full stagger-enter replay),
deletes give zero feedback then hard-jump, and the /transactions exit
"animation" was filter-only and never animated.

Per surface:

- Never take over a rendered list for a background refresh. The
  skeleton/spinner swap is now reserved for an empty (or foreign) list
  on /transactions (fetchTransactions), /pending (fetchOperations,
  covering both listed Granskning findings, one file), kundfakturor
  (fetchInvoices), leverantörsfakturor (fetchInvoices, plus
  try/catch/finally so a failed fetch can no longer stick the skeleton
  or masquerade as an empty register) and the verifikat list
  (JournalEntryList now takes a refreshToken prop and refetches in
  place; /bookkeeping no longer key-remounts it into a spinner, so
  expansion/selection/pagination/scroll survive a created verifikat).
  Quiet inline Loader2 cues near the list headers on /transactions and
  /pending signal a background reconcile.

- /transactions row exit: exiting rows (booked/ignored/deleted) stay
  rendered through the existing 350ms window with a real exit
  transition (.row-exit: fast fade, then the space closes by
  transitioning cell paddings/line metrics and a numeric max-height on
  the fixed-height cell spans) and pointer-events off. Instant removal
  under prefers-reduced-motion. Applied to the inbox cards, the
  skattekonto card and the history rows.

- /transactions delete: routes through processingId (row spinner) and
  the exitingIds path, and decrements totalUncategorizedCount when the
  deleted row was pending (the realtime echo is not guaranteed for
  DELETE on a filtered subscription).

- FyPicker double-fetch: the initial fetch now waits for FyPicker's
  onReady (fires after its persisted-scope restore), so mount does one
  correctly scoped fetch instead of racing an unscoped fetch against
  the restore refetch (list -> skeleton -> list on every visit). Period
  changes refetch background-only behind the client-filtered list.

- Pagination survives realtime echoes: background refreshes re-fetch
  range(0, pagedCountRef) instead of resetting to the first 200 rows,
  so "Visa fler" pages no longer collapse after any action.

Gates: full vitest suite green (14764 passed), tsc output byte-identical
to the origin/main baseline, eslint 0 errors on touched files,
check:guards green, package-lock untouched.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(ui): apply review round on action-feedback smoothness

- /pending: sequence-guard fetchOperations so a stale previous-tab
  response can't overwrite the current tab's rows, counts, or loading cues
- /pending: check res.ok on the pending fetch and both history fetches
  before applying payloads; failures keep current rows and surface the
  existing error toast
- /transactions: reset fiscal scope (fyReady/fyPeriodId/fyPeriod) during
  render on company switch so FyPicker re-runs its persisted restore and
  stale bounds never scope a fetch for the wrong company
- /transactions: drop a deleted row's id from selectedIds so the bulk bar
  can't act on a deleted row
- row exit: add the inert attribute on exiting row wrappers alongside
  pointer-events so keyboard focus and activation are blocked too
- JournalEntryList: preserve selection on refreshToken background
  refreshes (reconciled against the refreshed page); user-initiated
  reloads still clear it

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-16 18:44:02 +02:00

355 lines
13 KiB
TypeScript

'use client'
import { useState, useEffect, useMemo } from 'react'
import dynamic from 'next/dynamic'
import { useRouter, useSearchParams } from 'next/navigation'
import { useTranslations } from 'next-intl'
import JournalEntryList from '@/components/bookkeeping/JournalEntryList'
import { StartCard } from '@/components/dashboard/StartCard'
import { type FormLine } from '@/components/bookkeeping/JournalEntryForm'
import type { CopyPrefill, SkvLinkPrefill } from '@/components/bookkeeping/NewJournalEntryDialog'
import {
buildSkvPrefillLines,
takeSkvManualPrefill,
type SkvManualPrefill,
} from '@/lib/skatteverket/manual-verifikat-prefill'
import { getErrorMessage } from '@/lib/errors/get-error-message'
import { formatCurrency, formatDate } from '@/lib/utils'
import { DialogLoadingSkeleton } from '@/components/ui/dialog-loading-skeleton'
import { SplitButton } from '@/components/ui/split-button'
import { useAgentSheet } from '@/components/agent/AgentSheetProvider'
import { useUiState } from '@/lib/hooks/use-ui-state'
import { resolveInitialMode } from '@/lib/ui-state/client'
import { useToast } from '@/components/ui/use-toast'
import { Plus, LayoutTemplate, Sparkles } from 'lucide-react'
import { PageHeader } from '@/components/ui/page-header'
import { formatVoucher } from '@/lib/bookkeeping/voucher-series-resolver'
import type { JournalEntry, JournalEntryLine } from '@/types'
const NewJournalEntryDialog = dynamic(
() => import('@/components/bookkeeping/NewJournalEntryDialog'),
{ loading: DialogLoadingSkeleton },
)
const TemplateBookDialog = dynamic(
() => import('@/components/bookkeeping/TemplateBookDialog'),
{ loading: DialogLoadingSkeleton },
)
// SplitButton modes for "Nytt verifikat" (concept scene 9). The last-used
// mode persists per user in ui_state.create_mode.bookkeeping.
const CREATE_MODES = ['tomt', 'mall', 'assistent'] as const
interface NextVoucher {
next: number
series: string
}
const UUID_RE = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i
export default function BookkeepingPage() {
const { toast } = useToast()
const router = useRouter()
const searchParams = useSearchParams()
const copyFromId = useMemo<string | null>(() => {
const raw = searchParams.get('copy_from')
return raw && UUID_RE.test(raw) ? raw : null
}, [searchParams])
const [refreshKey, setRefreshKey] = useState(0)
const [showNewEntry, setShowNewEntry] = useState(false)
const [showTemplateDialog, setShowTemplateDialog] = useState(false)
const [copyPrefill, setCopyPrefill] = useState<CopyPrefill | null>(null)
const [isLoadingCopy, setIsLoadingCopy] = useState(false)
// Set from the skattekonto deep link (skv_tx & co): prefills the Nytt
// verifikat dialog and makes the created entry auto-link back to the row.
const [skvLink, setSkvLink] = useState<SkvManualPrefill | null>(null)
const [nextVoucher, setNextVoucher] = useState<NextVoucher | null>(null)
const t = useTranslations('bookkeeping')
const tStart = useTranslations('start_cards')
const { openAgentSheet } = useAgentSheet()
const { uiState, loaded: uiStateLoaded } = useUiState()
// React to copy_from in URL: switch tab, fetch source entry, then clean URL.
// useSearchParams keeps this reactive even when navigation happens within the
// same route (e.g. clicking the Kopiera button in the expanded list row),
// which a one-shot useState initializer wouldn't notice.
/* eslint-disable react-hooks/set-state-in-effect -- URL→state sync requires sync setState */
useEffect(() => {
if (!copyFromId) return
setShowNewEntry(true)
setCopyPrefill(null)
setIsLoadingCopy(true)
fetch(`/api/bookkeeping/journal-entries/${copyFromId}`)
.then((res) => res.json())
.then(({ data, error }: { data?: JournalEntry; error?: string }) => {
if (error || !data) {
toast({
title: t('copy_failed_title'),
description: error || t('copy_source_missing'),
variant: 'destructive',
})
return
}
const sourceLines = ((data.lines || []) as JournalEntryLine[])
.slice()
.sort((a, b) => a.sort_order - b.sort_order)
const lines: FormLine[] = sourceLines.map((l) => {
const debit = Number(l.debit_amount) || 0
const credit = Number(l.credit_amount) || 0
return {
account_number: l.account_number,
debit_amount: debit > 0 ? debit.toFixed(2) : '',
credit_amount: credit > 0 ? credit.toFixed(2) : '',
line_description: l.line_description || '',
}
})
setCopyPrefill({
sourceId: copyFromId,
sourceVoucherLabel: formatVoucher(data),
lines,
description: data.description || '',
notes: data.notes || '',
})
})
.catch(() => {
toast({
title: t('copy_failed_title'),
description: t('copy_fetch_failed'),
variant: 'destructive',
})
})
.finally(() => {
setIsLoadingCopy(false)
// Clear copy_from so a refresh doesn't re-trigger and so clicking the
// same entry's Kopiera button again re-fires this effect.
router.replace('/bookkeeping')
})
}, [copyFromId, toast, router])
// React to the skattekonto deep link the same way: consume the staged
// payload (single-use, sessionStorage; the URL carries only the opaque id),
// open the dialog prefilled, and clean the URL so a refresh doesn't
// re-trigger. copy_from wins if both are somehow present. A missing or
// invalid payload (shared/stale link) degrades to the plain list.
useEffect(() => {
if (copyFromId) return
const rawId = searchParams.get('skv_tx')
if (!rawId) return
const prefill = takeSkvManualPrefill(rawId)
router.replace('/bookkeeping')
if (!prefill) return
setSkvLink(prefill)
setCopyPrefill(null)
setShowNewEntry(true)
}, [searchParams, copyFromId, router])
/* eslint-enable react-hooks/set-state-in-effect */
const skvPrefill = useMemo<SkvLinkPrefill | null>(() => {
if (!skvLink) return null
return {
transactionId: skvLink.transactionId,
bannerLabel: [formatDate(skvLink.date), skvLink.text, formatCurrency(skvLink.amount)]
.filter(Boolean)
.join(' • '),
lines: buildSkvPrefillLines(skvLink) as FormLine[],
description: skvLink.text,
date: skvLink.date,
}
}, [skvLink])
// Link the created verifikat back to the skattekonto row. The entry exists
// either way, so a failed link degrades to a loud toast pointing at the
// manual "Matcha mot verifikat" path instead of silently orphaning the row.
async function handleSkvEntryCreated(entryId: string) {
if (!skvLink) return
const target = skvLink
setSkvLink(null)
let reason = ''
try {
const res = await fetch(
`/api/extensions/ext/skatteverket/skattekonto/transaktioner/${target.transactionId}/match`,
{
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ journal_entry_id: entryId }),
},
)
if (res.ok) {
toast({
title: t('skv_link_success_title'),
description: t('skv_link_success_description', { text: target.text }),
})
return
}
const json: unknown = await res.json().catch(() => null)
reason = getErrorMessage(json ?? {}, { statusCode: res.status })
} catch (err) {
reason = err instanceof Error ? getErrorMessage(err) : ''
}
toast({
title: t('skv_link_failed_title'),
description: [reason, t('skv_link_failed_hint')].filter(Boolean).join(' '),
variant: 'destructive',
})
}
// Fetch the next voucher number for today's fiscal period + default series.
// Re-runs after each commit (refreshKey++) so the tab label stays current.
useEffect(() => {
let cancelled = false
fetch('/api/bookkeeping/voucher-sequences/next')
.then((r) => r.json())
.then(({ data }) => {
if (cancelled) return
if (data?.next != null) {
setNextVoucher({ next: data.next, series: data.series })
} else {
setNextVoucher(null)
}
})
.catch(() => {
if (!cancelled) setNextVoucher(null)
})
return () => {
cancelled = true
}
}, [refreshKey])
return (
<div className="space-y-8">
<PageHeader
title={t('title')}
action={
<SplitButton
// Remount once ui_state loads so the primary face re-resolves
// to the persisted last-used mode.
key={uiStateLoaded ? 'loaded' : 'initial'}
persistKey="bookkeeping"
initialModeKey={resolveInitialMode(uiState, 'bookkeeping', CREATE_MODES, 'tomt')}
options={[
{
key: 'tomt',
label: nextVoucher
? `${t('create_tomt')} (${nextVoucher.series}${nextVoucher.next})`
: t('create_tomt'),
icon: Plus,
description: t('create_tomt_desc'),
onSelect: () => {
setCopyPrefill(null)
setSkvLink(null)
setShowNewEntry(true)
},
},
{
key: 'mall',
label: t('create_mall'),
icon: LayoutTemplate,
description: t('create_mall_desc'),
onSelect: () => setShowTemplateDialog(true),
},
{
key: 'assistent',
label: t('create_with_assistant'),
icon: Sparkles,
description: t('create_assistent_desc'),
onSelect: () =>
openAgentSheet({
intentId: 'verifikation.draft',
contextRef: 'verifikation:new',
}),
},
]}
/>
}
/>
{/* refreshToken, NOT key: a created verifikat refreshes the list in
place (dim + refetch) instead of remounting it into a spinner and
losing expansion/selection/scroll. */}
<JournalEntryList
refreshToken={refreshKey}
pristineSlot={
<div className="animate-fade-in space-y-4">
<StartCard
card="ledger"
layout="bleed-left"
title={tStart('bookkeeping_title')}
body={tStart('bookkeeping_body')}
primary={{ label: tStart('bookkeeping_primary'), href: '/import?mode=migration' }}
secondary={{ label: tStart('bookkeeping_secondary'), href: '/import?mode=sie' }}
/>
{/* The split button's three create modes, laid out as cards so the
pristine page shows what the ledger can do instead of a bare table. */}
<div className="grid gap-4 sm:grid-cols-3">
{(
[
['mall', () => setShowTemplateDialog(true)],
[
'assistent',
() => openAgentSheet({ intentId: 'verifikation.draft', contextRef: 'verifikation:new' }),
],
[
'tomt',
() => {
setCopyPrefill(null)
setSkvLink(null)
setShowNewEntry(true)
},
],
] as const
).map(([mode, onClick]) => (
<button
key={mode}
type="button"
onClick={onClick}
className="rounded-lg border border-border bg-background p-4 text-left transition-colors duration-150 hover:bg-secondary/35 active:bg-secondary/35 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring"
>
<div className="text-[13px] font-medium">{tStart(`bookkeeping_mini_${mode}_title`)}</div>
<p className="mt-1 text-xs leading-relaxed text-muted-foreground">
{tStart(`bookkeeping_mini_${mode}_body`)}
</p>
</button>
))}
</div>
</div>
}
/>
{showTemplateDialog && (
<TemplateBookDialog
open
onOpenChange={setShowTemplateDialog}
onCreated={() => setRefreshKey((k) => k + 1)}
/>
)}
{showNewEntry && (
<NewJournalEntryDialog
open
onOpenChange={(o) => {
setShowNewEntry(o)
if (!o) {
setCopyPrefill(null)
setSkvLink(null)
}
}}
onCreated={() => {
setRefreshKey((k) => k + 1)
setShowNewEntry(false)
setCopyPrefill(null)
// handleSkvEntryCreated runs from the same render's closure, so
// clearing here doesn't rob it of the link target.
setSkvLink(null)
}}
onEntryCreated={skvLink ? handleSkvEntryCreated : undefined}
copyPrefill={copyPrefill}
skvPrefill={skvPrefill}
isLoading={isLoadingCopy}
/>
)}
</div>
)
}