Files
accounted/types/skatteverket.ts
T
0a8544e0cb feat(reconciliation): account-keyed engine: one bridge for bank and skattekonto (#1813)
* feat(reconciliation): skattekonto bridge engine, sync-time twin proposals, account-keyed facade

The engine half of the reconciliation page (design: Avstämningsmotorn).

- lib/reconciliation/skattekonto-reconciliation.ts: getSkattekontoReconciliationStatus
  anchors at the saldo snapshot and returns the bridge (saldo hos Skatteverket,
  händelser som saknas, 1630-rader utan händelse, ignorerade, ingående skillnad,
  bokfört), the item buckets the page shows (proposed, unmatched external,
  unmatched ledger, matched, ignored, upcoming), opening_difference,
  unexplained_difference (0,00 by construction when data is consistent),
  dead-link handling (a link to a reversed/draft entry counts as unlinked and is
  flagged), awaiting_external for ledger lines within 5 days of the snapshot,
  staleness, and a window that scopes item lists without hiding older rows.
  Core reads skattekonto_transactions and the extension's snapshot row directly;
  no @/extensions import.
- lib/reconciliation/gl-balance.ts: one ledger-balance helper with the
  trial-balance predicate status IN (posted, reversed). The drift check summed
  posted only, which misstated 1630 for any company with a storno on the account;
  skattekonto-drift.ts now delegates to the helper.
- Proposals at sync: migration 20260823120000 adds suggested_journal_entry_id /
  suggested_at (ON DELETE SET NULL, partial index on open rows); the sync calls
  refreshSkattekontoProposals after the upsert. findMatchSuggestionsBulk now
  assigns one-to-one across rows (AGI period first, then nearest date) and falls
  back to an entry whose 1630 lines net to the amount (split lines); a proposal
  is never a link.
- lib/reconciliation/service.ts + schemas.ts: the account-keyed facade
  (bank:<cash_account_id> | skattekonto | manual:NNNN) with listReconciliationAccounts
  (enabled cash accounts folded per IBAN, skattekonto when configured) and
  getAccountStatus dispatching to the bank engine or the new one; shared Zod
  shapes for the v1 registry, MCP schemas and the UI (PR 2).

Tests: identity on a mixed fixture, storno pair, stale snapshot, awaiting window,
window scoping, failed ledger read, live-linked entries never proposed; matcher
one-to-one and split-line cases; proposal refresh writes/clears; service
dedupe and dispatch. No UI in this PR.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(reconciliation): roundOre instead of inline öre rounding (guard ratchet)

The antipattern ratchet counts Math.round(x*100)/100; the new engine used it in
five places. Switch to roundOre from @/lib/money and ratchet the baseline down
by the three occurrences this removes net of the matcher rewrite.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-24 13:55:08 +02:00

143 lines
5.1 KiB
TypeScript

/**
* Skatteverket data shapes used by core UI (the /transactions page lives
* in core, but renders skattekonto rows alongside bank tx). The DB table
* `skattekonto_transactions` lives in core migrations even when the
* skatteverket extension is disabled: the extension only owns the API
* that populates it. Keeping these types in core means components can
* render the table's shape without depending on the extension module.
*
* If skatteverket is disabled, the API returns 503 and the UI just sees
* an empty list: the types remain valid descriptors of the schema.
*/
/** Row shape for the `skattekonto_transactions` table (DB → app). */
export interface StoredSkattekontoTransaction {
id: string
company_id: string
transaktionsidentitet: number | null
dedup_key: string
transaktionsdatum: string
forfallodatum: string | null
ranteberakningsdatum: string | null
transaktionstext: string
belopp_skatteverket: number
belopp_kronofogden: number | null
status: 'booked' | 'upcoming'
journal_entry_id: string | null
/** User's explicit "hide from the work list, never going to book it".
* Mirrors transactions.is_ignored; an ignored row never has a
* journal_entry_id (DB CHECK, migration 20260819200000). */
is_ignored: boolean
source: 'api' | 'file_import'
file_import_id: string | null
imported_at: string
updated_at: string
/**
* Best exact-twin verifikat proposed by the sync (migration 20260823120000).
* A proposal, never a link: journal_entry_id is the only link. Optional on
* the type because rows fetched with a narrower select omit it.
*/
suggested_journal_entry_id?: string | null
suggested_at?: string | null
}
/** Row shape for the `skattekonto_file_imports` tracking table (DB → app). */
export interface SkattekontoFileImportRecord {
id: string
company_id: string
/** Importing user; null after that user's account is deleted. */
user_id: string | null
filename: string
file_hash: string
file_variant: 'csv' | 'skv'
row_count: number
imported_count: number
duplicate_count: number
promoted_count: number
date_from: string | null
date_to: string | null
closing_saldo: number | null
status: 'pending' | 'processing' | 'completed' | 'failed'
error_message: string | null
created_at: string
updated_at: string
}
/**
* Single best candidate verifikat for an unmatched SKV row. Attached by
* the `/skattekonto/transaktioner` endpoint when exactly one strong match
* exists, so the UI can offer a one-click "koppla till A12" hint instead
* of forcing the user to open the full Matcha-dialog.
*/
export interface SkattekontoMatchSuggestion {
journal_entry_id: string
voucher_number: number | null
voucher_series: string | null
entry_date: string
description: string
status: 'draft' | 'posted' | 'reversed'
}
/**
* The deterministic counter-account a "Bokför" on this row would use,
* resolved from `skattekonto_rules` server-side. Lets the list show what a
* booking will do ("Bokförs mot 8314 Skattefria ränteintäkter") and drives
* bulk-booking eligibility. `account_name` comes from the BAS reference and
* may be null for custom accounts; `label` is the matched rule's label.
*/
export interface SkattekontoBookingSuggestion {
account: string
account_name?: string | null
label?: string | null
}
/**
* API response variant: stored row plus optional auto-match suggestion.
* `match_suggestion` is optional because kommande/upcoming rows skip the
* enrichment step entirely (no journal entry can match a future event).
* `booking_suggestion` is likewise only computed for unbooked genomförda
* rows: undefined means "not computed", null means "no rule matched".
*/
export interface SkattekontoTransactionWithSuggestion extends StoredSkattekontoTransaction {
match_suggestion?: SkattekontoMatchSuggestion | null
booking_suggestion?: SkattekontoBookingSuggestion | null
/**
* Why booking_suggestion is null despite a rule matching the text.
* 'requires_employer': the matched rule is employer-gated and this is an
* enskild firma without employer_registered, so "Avdragen skatt" is most
* likely the owner's private A-skatt, not the firm's payroll liability.
* The UI shows a distinct hint instead of the generic "no rule matched".
*/
booking_gate?: 'requires_employer' | null
}
/**
* Per-row outcome from POST /skattekonto/transaktioner/bokfor-batch.
* `journal_entry_id` is present on success AND on COMMIT_FAILED (the draft
* was created and stays linked; only the commit step failed).
*/
export interface SkattekontoBatchRowResult {
id: string
ok: boolean
journal_entry_id?: string
voucher_number?: number | null
voucher_series?: string | null
error_code?:
| 'NO_COUNTER_ACCOUNT'
| 'NO_FISCAL_PERIOD'
| 'PERIOD_LOCKED'
| 'ALREADY_BOOKED'
| 'NOT_SETTLED'
| 'ROW_IGNORED'
| 'TRANSACTION_NOT_FOUND'
| 'COMMIT_FAILED'
| 'UNKNOWN'
error_message?: string
}
/** Response envelope body for the bokfor-batch endpoint. */
export interface SkattekontoBatchResult {
results: SkattekontoBatchRowResult[]
summary: { total: number; succeeded: number; failed: number }
}