The onboarding flow now mirrors the web wizard: ask for the organisationsnummer first, look the company up in the public registry (one TIC Lens call through the extracted extensions/general/tic/lib/lookup.ts, shared with the /lookup HTTP route), and present the facts for confirmation instead of interrogating the user. The new gnubok_lookup_company tool (companies:read, company-independent, default catalog) returns the registry facts, a prefilled suggested_create_company_input, and a still_to_ask list that encodes the same fact-vs-question rules as lib/onboarding-journey/reducer.ts: F-skatt is a fact both ways, VAT is a fact only when positively registered (ML 17 kap 24 paragraf), moms period and accounting method are always asked, an enskild firma's verksamhetsnamn is the user's choice, and a known fiscal year becomes a confirm question. Registry outages degrade to the full question list instead of failing onboarding. The onboarding skill and the plugin's /accounted:setup command are updated to the orgnr-first flow (plugin 1.2.0). tools/list ceiling bumped 61.2K to 61.5K with the reason documented in the bench. Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
186 lines
6.0 KiB
TypeScript
186 lines
6.0 KiB
TypeScript
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import type { ApiKeyScope } from '@/lib/auth/api-keys'
|
|
import type { CompanyRole } from '@/types'
|
|
|
|
const UUID_PATTERN =
|
|
/^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i
|
|
|
|
const COMPANY_INDEPENDENT_TOOLS = new Set([
|
|
'gnubok_search_tools',
|
|
'gnubok_list_skills',
|
|
'gnubok_load_skill',
|
|
'gnubok_list_companies',
|
|
// Creates the company: by definition it runs before one exists.
|
|
'gnubok_create_company',
|
|
// Public-registry lookup that feeds gnubok_create_company: same pre-company
|
|
// stage of onboarding, no company data touched at all.
|
|
'gnubok_lookup_company',
|
|
])
|
|
|
|
/**
|
|
* Company-independent tools that still USE a company when one is available:
|
|
* they run without one (anonymous or not-yet-onboarded callers, issue #1814)
|
|
* but accept an explicit company_id, which is then membership-checked like
|
|
* on any company-dependent tool. gnubok_list_skills filters skills by the
|
|
* company's entity type, employees and VAT registration.
|
|
*/
|
|
const OPTIONAL_COMPANY_TOOLS = new Set(['gnubok_list_skills'])
|
|
|
|
export function isOptionalCompanyTool(toolName: string): boolean {
|
|
return OPTIONAL_COMPANY_TOOLS.has(toolName)
|
|
}
|
|
|
|
export const COMPANY_ID_INPUT_PROPERTY = {
|
|
type: 'string',
|
|
format: 'uuid',
|
|
description: 'Target company ID. Omit for default.',
|
|
} as const
|
|
|
|
export interface McpCompanyContext {
|
|
companyId: string
|
|
role: CompanyRole
|
|
isDefault: boolean
|
|
}
|
|
|
|
interface ToolSchemaSource {
|
|
name: string
|
|
inputSchema: Record<string, unknown>
|
|
}
|
|
|
|
export function codedError(
|
|
code: 'VALIDATION_ERROR' | 'NOT_FOUND' | 'FORBIDDEN' | 'INTERNAL_ERROR' | 'NO_COMPANY_YET',
|
|
message: string
|
|
) {
|
|
return Object.assign(new Error(message), { code })
|
|
}
|
|
|
|
/**
|
|
* Thrown when a company-scoped operation runs on a key whose user has no
|
|
* company at all (minted from the OAuth popup before onboarding, issue
|
|
* #1814). Maps to the NO_COMPANY_YET structured error with its remediation.
|
|
*/
|
|
export function noCompanyYetError(): Error {
|
|
return codedError(
|
|
'NO_COMPANY_YET',
|
|
'This account has no company yet. Create the company in the web app, then retry.'
|
|
)
|
|
}
|
|
|
|
function isCompanyRole(value: unknown): value is CompanyRole {
|
|
return value === 'owner' || value === 'admin' || value === 'member' || value === 'viewer'
|
|
}
|
|
|
|
export function isCompanyDependentTool(toolName: string): boolean {
|
|
return !COMPANY_INDEPENDENT_TOOLS.has(toolName)
|
|
}
|
|
|
|
export function isTenantWriteScope(scope: ApiKeyScope | undefined): boolean {
|
|
return (
|
|
scope?.endsWith(':write') === true ||
|
|
scope?.endsWith(':approve') === true ||
|
|
scope?.endsWith(':manage') === true ||
|
|
// Sign-off attests on the company's behalf: a write for the role guard
|
|
// even though the scope is deliberately not `:write` (linking rows must
|
|
// not imply the right to attest).
|
|
scope?.endsWith(':signoff') === true
|
|
)
|
|
}
|
|
|
|
export function projectToolInputSchema(tool: ToolSchemaSource): Record<string, unknown> {
|
|
if (!isCompanyDependentTool(tool.name) && !isOptionalCompanyTool(tool.name)) return tool.inputSchema
|
|
|
|
const properties =
|
|
tool.inputSchema.properties && typeof tool.inputSchema.properties === 'object'
|
|
? (tool.inputSchema.properties as Record<string, unknown>)
|
|
: {}
|
|
|
|
return {
|
|
...tool.inputSchema,
|
|
properties: {
|
|
...properties,
|
|
company_id: COMPANY_ID_INPUT_PROPERTY,
|
|
},
|
|
}
|
|
}
|
|
|
|
export function extractRequestedCompany(
|
|
rawArgs: Record<string, unknown>
|
|
): { requestedCompanyId: string | undefined; toolArgs: Record<string, unknown> } {
|
|
const { company_id: rawCompanyId, ...toolArgs } = rawArgs
|
|
if (rawCompanyId === undefined) return { requestedCompanyId: undefined, toolArgs }
|
|
if (typeof rawCompanyId !== 'string' || !UUID_PATTERN.test(rawCompanyId)) {
|
|
throw codedError('VALIDATION_ERROR', 'company_id must be a valid UUID')
|
|
}
|
|
return { requestedCompanyId: rawCompanyId, toolArgs }
|
|
}
|
|
|
|
export async function resolveMcpCompanyContext(args: {
|
|
supabase: SupabaseClient
|
|
userId: string
|
|
/** null while the key's user has no company (see validateApiKey). */
|
|
defaultCompanyId: string | null
|
|
requestedCompanyId?: string
|
|
}): Promise<McpCompanyContext> {
|
|
const companyId = args.requestedCompanyId ?? args.defaultCompanyId
|
|
if (!companyId) {
|
|
throw noCompanyYetError()
|
|
}
|
|
|
|
const { data: membership, error } = await args.supabase
|
|
.from('company_members')
|
|
.select('company_id, role, companies!inner(archived_at)')
|
|
.eq('user_id', args.userId)
|
|
.eq('company_id', companyId)
|
|
.is('companies.archived_at', null)
|
|
.maybeSingle()
|
|
|
|
if (error) {
|
|
throw codedError('INTERNAL_ERROR', `Failed to resolve company membership: ${error.message}`)
|
|
}
|
|
if (!membership) {
|
|
throw codedError('NOT_FOUND', 'Company not found')
|
|
}
|
|
if (!isCompanyRole(membership.role)) {
|
|
throw codedError('FORBIDDEN', 'Company membership has an unsupported role')
|
|
}
|
|
|
|
return {
|
|
companyId,
|
|
role: membership.role,
|
|
isDefault: companyId === args.defaultCompanyId,
|
|
}
|
|
}
|
|
|
|
export function assertMcpCompanyWriteAccess(
|
|
context: McpCompanyContext,
|
|
scope: ApiKeyScope | undefined
|
|
): void {
|
|
if (context.role === 'viewer' && isTenantWriteScope(scope)) {
|
|
throw codedError('FORBIDDEN', 'Write permission required for this company')
|
|
}
|
|
}
|
|
|
|
export function addCompanyToNextHint(next: unknown, companyId: string): unknown {
|
|
if (!next || typeof next !== 'object' || Array.isArray(next)) return next
|
|
const hint = next as Record<string, unknown>
|
|
if (typeof hint.tool !== 'string' || !isCompanyDependentTool(hint.tool)) return next
|
|
const args =
|
|
hint.args && typeof hint.args === 'object' && !Array.isArray(hint.args)
|
|
? (hint.args as Record<string, unknown>)
|
|
: {}
|
|
return {
|
|
...hint,
|
|
args: { ...args, company_id: companyId },
|
|
}
|
|
}
|
|
|
|
export function addCompanyToTopLevelNext(result: unknown, companyId: string): unknown {
|
|
if (!result || typeof result !== 'object' || Array.isArray(result)) return result
|
|
const record = result as Record<string, unknown>
|
|
if (!record.next) return result
|
|
return {
|
|
...record,
|
|
next: addCompanyToNextHint(record.next, companyId),
|
|
}
|
|
}
|