Files
accounted/app/api/extensions/woocommerce/callback/route.ts
T
18cbc4c30a fix(security): audit remediation 2026-09-01: api_keys identity, viewer gates, OAuth binding, XSS, MFA gate (#2155)
* fix(security): bind api_keys to the caller, lock hash-as-bearer RPCs and provider token tables

Security audit 2026-09-01, critical items.

- api_keys INSERT requires user_id = auth.uid() again (an admin could
  forge a key for any co-member and act as them in every company they
  belong to); SELECT is own-keys-or-admin; a BEFORE trigger freezes the
  identity and credential columns against user-session UPDATEs.
- rotate_mcp_refresh_token and validate_and_increment_api_key become
  service_role only: they match rows by a presented SHA-256, so a hash
  readable by co-members was a bearer credential.
- validate_and_increment_api_key fails closed when the key's user is no
  longer a member of the key's company.
- provider_consent_tokens and provider_otc: the DELETE policies collapsed
  to "caller has any team row" (correlated subquery on a non-existent
  team_members.company_id). All member policies dropped; service_role
  only, matching every existing code path.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): role gates, ownership guards and posting integrity in the database

Security audit 2026-09-01, high items at the database layer.

- One table-level guard, enforce_company_writer_role(), blocks the
  read-only viewer role on 55 company-scoped tables including through
  the 15 membership-only SECURITY DEFINER writers. Keyed on the JWT role
  claim so it fires inside definer bodies; no-op for service_role and
  trigger cascades.
- company_members user_id/company_id immutable from user sessions;
  invitations can never grant owner; team_members gains a transition
  guard (admins keep non-owner role moves); companies team_id and
  archiving are owner-only and team attachment needs team membership.
- Direct statements (current_user = authenticated) can no longer insert
  posted headers, add lines under posted verifikat, or post a draft with
  a voucher number the sequence never issued. Sanctioned RPCs run as the
  definer and are untouched; the engine's own draft-then-post shapes
  still pass.
- create_document_version refuses viewers and foreign storage paths;
  validate_version_chain needs membership and loses anon EXECUTE;
  match_documents / match_booking_templates lose anon; cron maintenance
  RPCs become service_role only; the production-only
  seed_asset_categories is dropped.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* build: pin tsx as an exact devDependency instead of fetching it with npx at build time

prebuild ran "npx tsx" with no lockfile entry, so every Vercel, Docker
and CI build downloaded tsx@latest and its transitive tree from the
registry with no integrity check, inside the build environment.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): refuse the viewer role on API-key and MCP write paths

The v1 wrapper and the MCP company routing checked company membership
but never role, and both run as service role, so a read-only viewer
holding an API key could post vouchers and change settings through the
API. Mutating methods and non-read scopes now return 403 ROLE_READ_ONLY
for viewers on v1; MCP write tools refuse viewers the same way.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): stop serving uploaded SVG, XML and HTML as executable content on the app origin

Uploads persisted the browser-declared mime type and the inline proxy
served it verbatim, sandboxing only text/html; the storage proxy
forwarded the uploader's Content-Type. Any writer, or any Peppol sender,
could plant a scripted SVG or XHTML that executed on app.gnubok.se.

- inline route: allow-list of natively safe types (PDF, raster images)
  served as before; everything else gets the opaque sandbox CSP.
- storage proxy: octet-stream + attachment + sandbox unless the DB
  mime for the key is on the allow-list.
- document-service: the stored mime is the magic-byte validated type.
- logo upload: magic-byte validation, SVG refused.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): byrå brand logo upload decides the type by magic bytes and drops SVG

Same pattern as the company logo route: the logos bucket is public, so a
scripted SVG (or anything declared as an image) must never land there.
The upload pickers stop advertising SVG.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): bind Enable Banking, Stripe and WooCommerce callbacks to the initiating user

The callbacks resolved the pending row by oauth_state alone, so a
victim who completed an attacker-initiated consent had their bank
account, merchant account or store attached to the attacker's company.
requireFlowInitiator() now requires the cookie session of the user who
started the flow: no session redirects to login with the callback URL
preserved, a different user is refused and nothing is exchanged.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): guard tenant-controlled outbound fetches and surface the disabled rate limiter

WooCommerce and Shopify syncs fetched a member-editable store URL with
plain fetch() and redirect following under the service role, and the
invoice PDF renderer fetched company_settings.logo_url unguarded. All
three go through a new safeFetch() (public-IP validation via url-guard,
https only, redirect: 'manual', body size cap) and re-normalise the
stored host at use time. checkRateLimit() keeps failing open on hosted
but logs one error per process when Upstash is not configured and
exports isRateLimiterConfigured().

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): decide the API MFA gate from server-authenticated factors, not the session cookie

getAuthenticatorAssuranceLevel() without arguments derives nextLevel
from session.user.factors, which comes from the unsigned sb-*-auth-token
cookie. Deleting factors from the cookie made an enrolled account look
like it had nothing to step up to, on every /api route and in
requireAuth. Both gates now read factors from the getUser() result or
listFactors() and the level from the verified JWT claim, and fail closed
on errors. Page-branch gate hardened the same way.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): bind Fortnox/Visma, Gmail and Skatteverket callbacks to the initiating user

The arcim-migration callback exchanged the provider code onto whatever
consent the one-time state named, with no check of who completed the
flow and no org-number comparison, so a phished Fortnox admin handed
their ledger to the attacker's company. provider_otc now records the
initiating user (migration 20260902100000); the callback requires that
session and, after the exchange, refuses a provider company whose org
number differs from the consent's company. The Gmail and Skatteverket
callbacks enforce the same initiator check.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): BankID signup confirms the email before linking the identity

Signup created an email-confirmed, MFA-exempt account for any address
the caller typed and returned a magic link, so an attacker could
pre-register a victim's email and keep a permanent BankID login into the
account the victim later adopted. The user is now created unconfirmed,
the identity carries email_verified_at NULL (migration 20260902101000),
bankid_linked is not set until the mailed confirmation is clicked, and
BankID login of a pending identity is refused with the confirmation
re-sent.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(security): bind MCP OAuth redirect URIs to the consenting user and cap scopes

A user-registered redirect URI was allowlisted globally, the consent page
named no client, and all scopes were pre-checked, so one phishing link
handed an attacker a full-scope key for the victim's company. Registered
URIs now resolve only for the registrant or a colleague sharing a
company; the consent page shows the client identity and redirect host;
non-built-in clients default to read-only pre-checks; scopes are capped
by the user's role (viewer: read only) at consent and at /token.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(auth): client follow-ups for BankID confirmation, callback mismatch copy and decision log

- register client handles the new confirmation_sent response from BankID
  signup with the existing inbox screen instead of calling verifyOtp.
- BankID login surfaces the email_unconfirmed explanation.
- WooCommerce settings map woocommerce_error=wrong_user to its own copy.
- Logo help text no longer advertises SVG.
- DECISIONS.md records the audit remediation choices.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* fix(mcp-oauth): literal SoD columns in the api_keys insert so the phantom-column scanner resolves them

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(logo): type the upload fixtures as Uint8Array<ArrayBuffer> so they are valid BlobParts

Fixes the typecheck ratchet on PR #2155 and ratchets the baseline down
by the one legacy error the change removed.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 11:38:30 +02:00

190 lines
7.1 KiB
TypeScript

import { NextResponse } from 'next/server'
import { createServiceClient } from '@/lib/supabase/server'
import { ensureInitialized } from '@/lib/init'
import { eventBus } from '@/lib/events/bus'
import { loadExtensions } from '@/lib/extensions/loader'
import { extensionRegistry } from '@/lib/extensions/registry'
import { createLogger } from '@/lib/logger'
import {
encryptCredential,
isWooCommerceConfigured,
} from '@/extensions/general/woocommerce/lib/credentials'
import { testConnectionAndFetchStoreInfo } from '@/extensions/general/woocommerce/lib/api-client'
// This route emits woocommerce.connected (audit trail). ensureInitialized()
// must run at module load so the event_log handler has subscribed before the
// first emit on a cold instance.
ensureInitialized()
const log = createLogger('woocommerce/callback')
// The credential probe talks to an arbitrary (often slow) WooCommerce host.
export const maxDuration = 60
/**
* POST /api/extensions/woocommerce/callback
*
* Server-to-server delivery of the wc-auth handshake result: WooCommerce
* POSTs { key_id, user_id, consumer_key, consumer_secret, key_permissions }
* here after the merchant approves. Must be a real Next.js route (not an
* extension dispatcher handler) because the store calls it directly,
* unauthenticated: the single-use oauth_state riding in user_id locates the
* pending row, and the received keys are verified against that row's stored
* store_url before anything is persisted.
*/
export async function POST(request: Request) {
loadExtensions()
if (!extensionRegistry.get('woocommerce')) {
return NextResponse.json(
{ error: 'WooCommerce extension is not enabled', code: 'EXTENSION_DISABLED' },
{ status: 503 },
)
}
// The registry does not check manifest requiredEnvVars, so this route can be
// live without the encryption key; without this guard encryptCredential()
// would throw AFTER the probe, escaping the markError path entirely.
if (!isWooCommerceConfigured()) {
return NextResponse.json(
{ error: 'WooCommerce integration is not configured', code: 'NOT_CONFIGURED' },
{ status: 503 },
)
}
let body: {
user_id?: unknown
consumer_key?: unknown
consumer_secret?: unknown
key_permissions?: unknown
}
try {
body = await request.json()
} catch {
return NextResponse.json({ error: 'Invalid JSON body' }, { status: 400 })
}
const state = typeof body.user_id === 'string' ? body.user_id : null
const consumerKey = typeof body.consumer_key === 'string' ? body.consumer_key : null
const consumerSecret = typeof body.consumer_secret === 'string' ? body.consumer_secret : null
const keyPermissions =
typeof body.key_permissions === 'string' ? body.key_permissions : null
// The state is a UUID we generated; reject anything else before it reaches
// the DB (the column is typed uuid and would error opaquely).
const isUuid =
state !== null &&
/^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i.test(state)
if (!isUuid || !consumerKey || !consumerSecret) {
return NextResponse.json({ error: 'Missing parameters' }, { status: 400 })
}
const supabase = await createServiceClient()
const { data: pending, error: findError } = await supabase
.from('woocommerce_connections')
.select('id, company_id, user_id, store_url')
.eq('oauth_state', state)
.eq('status', 'pending')
.single()
if (findError || !pending) {
log.warn('no pending connection for handshake state', {
hasRow: Boolean(pending),
code: findError?.code,
})
return NextResponse.json({ error: 'Unknown or expired state' }, { status: 404 })
}
const markError = (message: string) =>
supabase
.from('woocommerce_connections')
.update({ status: 'error', error_message: message, oauth_state: null })
.eq('id', pending.id)
.eq('status', 'pending')
// Authenticity check: the keys must actually work against the store URL the
// user asked to connect. A forged callback with someone else's (or made-up)
// keys fails here and never gets stored.
let storeInfo
try {
storeInfo = await testConnectionAndFetchStoreInfo({
storeUrl: pending.store_url,
consumerKey,
consumerSecret,
})
} catch (probeError) {
log.error('credential probe failed during handshake', {
connectionId: pending.id,
message: probeError instanceof Error ? probeError.message : String(probeError),
})
await markError('Nycklarna kunde inte verifieras mot butiken.')
return NextResponse.json({ error: 'Credential verification failed' }, { status: 502 })
}
const { data: activated, error: updateError } = await supabase
.from('woocommerce_connections')
.update({
consumer_key_encrypted: encryptCredential(consumerKey),
consumer_secret_encrypted: encryptCredential(consumerSecret),
key_permissions: keyPermissions,
store_name: storeInfo.name,
currency: storeInfo.currency,
prices_include_tax: storeInfo.prices_include_tax,
wc_version: storeInfo.wc_version,
status: 'active',
connected_at: new Date().toISOString(),
error_message: null,
// oauth_state is deliberately KEPT here. This POST is server-to-server
// (the store calls it, no browser session), so the initiator check has
// to happen on the browser leg (../return), which locates the row by
// this same state and consumes it there. Replay is still blocked: both
// the lookup above and this update are scoped to status 'pending', so
// an active row can never be activated again.
// Feed-only product: connecting the store means fetching its orders, so
// the nightly feed starts on by default; the panel toggle is the opt-out.
transaction_sync_enabled: true,
})
.eq('id', pending.id)
.eq('status', 'pending')
.select('id, company_id, user_id, store_url')
.single()
if (updateError || !activated) {
// 23505 = a partial unique index: the store is already actively connected
// (to this or another company), or the company connected in a parallel tab.
const isConflict = updateError?.code === '23505'
log.error('failed to activate connection', {
connectionId: pending.id,
code: updateError?.code,
message: updateError?.message,
})
await markError(
isConflict
? 'Butiken är redan ansluten till ett företag.'
: 'Anslutningen kunde inte slutföras.',
)
return NextResponse.json(
{ error: isConflict ? 'Store already connected' : 'Activation failed' },
{ status: isConflict ? 409 : 500 },
)
}
try {
await eventBus.emit({
type: 'woocommerce.connected',
payload: {
connectionId: activated.id,
storeUrl: activated.store_url,
userId: activated.user_id,
companyId: activated.company_id,
},
})
} catch (emitError) {
// Non-fatal: the DB state (source of truth) is already committed.
log.error('failed to emit woocommerce.connected', {
connectionId: activated.id,
message: emitError instanceof Error ? emitError.message : String(emitError),
})
}
return NextResponse.json({ success: true })
}