Files
accounted/lib/invoices/supplier-invoice-matching.ts
T
Jakob WennbergandClaude Opus 4.8 b38b3d0230 fix(bookkeeping): settle öre differences to 3740 and improve supplier-invoice matching (#699)
Whole-krona Bankgiro/Swish payments of öre-bearing invoices were stranded
as partially_paid forever (e.g. 11 231 paid on an 11 231,25 invoice left
0,25 kr open). Book the sub-krona residual to BAS 3740 (Öres- och
kronutjämning) and settle the invoice in full, on both the supplier- and
customer-invoice match flows.

New shared pure helpers buildSupplierPaymentClearingLines +
planSupplierPayment mirror the customer-side primitives; routing preview
and commit through the same builder also fixes two pre-existing
preview↔commit drifts (payment account + line descriptions). Öre
absorption is accrual-only — cash entries book the full invoice, so
absorbing there would hide a 1930 discrepancy.

Also improves supplier-invoice ↔ bank matching:
- Pass-3 date window now spans [invoice_date-5, due_date+5] instead of
  due_date ±5, so early payments auto-match; an ambiguity guard demotes
  non-unique amount matches to suggestions.
- New retroactive matcher (on supplier_invoice.registered/.approved)
  surfaces the settling bank payment when the invoice is registered after
  the payment was imported. Matches are written as suggestions for
  one-click confirm-to-book, never silently auto-booked.

Tests: new unit tests for both pure helpers; extended matching, handler,
customer öre, and route suites. Full suite green (407 files / 5364 tests).

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-09 19:09:39 +02:00

166 lines
6.5 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* Supplier Invoice Matching — auto-match expense transactions to unpaid supplier invoices.
*
* 4-pass matching algorithm (ordered by confidence):
* 1. Payment reference/OCR exact match → 0.98
* 2. Exact amount + bankgiro/plusgiro match → 0.92
* 3. Exact amount + payment date within [invoice_date − 5, due_date + 5] → 0.85
* 4. Fuzzy amount (±0.01) + supplier name in description → 0.70
*
* Auto-match threshold: ≥0.85 → applied automatically
* Suggestion threshold: 0.70–0.85 → stored as potential_supplier_invoice_id
*
* The Pass-3 window spans the whole credit period (issue → due, ±5d) so an
* early payment — common when a bank pays a Bankgiro the day the invoice lands,
* weeks before the due date — still auto-matches. To contain the false-positive
* risk of the wider window, a Pass-3 hit where more than one invoice matches the
* same amount in-window is flagged `ambiguous`; callers must downgrade an
* ambiguous auto-match to a mere suggestion.
*/
import type { Transaction, SupplierInvoice } from '@/types'
export interface SupplierInvoiceMatch {
supplierInvoice: SupplierInvoice
confidence: number
matchMethod: 'payment_reference' | 'amount_bankgiro' | 'amount_date' | 'fuzzy_name'
/**
* True when this is a Pass-3 (amount + date-window) match but more than one
* invoice matched the same amount in-window — the date heuristic alone can't
* disambiguate. Callers must treat an ambiguous 0.85 as a suggestion, never an
* auto-link. Undefined/false for the unique passes (OCR, bankgiro).
*/
ambiguous?: boolean
}
/**
* Normalize payment reference for comparison (strip whitespace and non-digits).
*/
function normalizeReference(ref: string): string {
return ref.replace(/\D/g, '')
}
/**
* Find the best matching supplier invoice for an expense transaction.
* Expects invoices to have the `supplier` relation populated (for name/bankgiro matching).
* Only matches against invoices with status 'registered' or 'approved'
* and with remaining_amount > 0.
*/
export function findSupplierInvoiceMatch(
transaction: Transaction,
unpaidInvoices: SupplierInvoice[]
): SupplierInvoiceMatch | null {
if (unpaidInvoices.length === 0) return null
// Only match expense transactions
const txAmount = Math.abs(transaction.amount)
if (txAmount === 0) return null
let bestMatch: SupplierInvoiceMatch | null = null
// How many invoices matched the exact amount within their date window. >1
// makes a Pass-3 (amount_date) winner ambiguous — the date can't pick between
// same-amount invoices, so the caller must not auto-link it.
let amountDateMatchCount = 0
for (const invoice of unpaidInvoices) {
// Only match against registered/approved invoices with remaining amount
if (!['registered', 'approved'].includes(invoice.status)) continue
const remaining = invoice.remaining_amount ?? invoice.total
if (remaining <= 0) continue
// Pass 1: Payment reference/OCR exact match → 0.98
if (transaction.reference && invoice.payment_reference) {
const txRef = normalizeReference(transaction.reference)
const invRef = normalizeReference(invoice.payment_reference)
if (txRef && invRef && txRef === invRef) {
return {
supplierInvoice: invoice,
confidence: 0.98,
matchMethod: 'payment_reference',
}
}
}
// Pass 2: Exact amount + bankgiro/plusgiro match → 0.92
const amountMatch = Math.abs(txAmount - remaining) < 0.005
if (amountMatch) {
const txDesc = (transaction.description || '').toLowerCase()
const supplierBg = invoice.supplier?.bankgiro
const supplierPg = invoice.supplier?.plusgiro
const bgMatch = supplierBg && txDesc.includes(normalizeReference(supplierBg))
const pgMatch = supplierPg && txDesc.includes(normalizeReference(supplierPg))
if (bgMatch || pgMatch) {
return {
supplierInvoice: invoice,
confidence: 0.92,
matchMethod: 'amount_bankgiro',
}
}
}
// Pass 3: Exact amount + payment date within the credit period → 0.85.
// Window = [invoice_date − 5, due_date + 5]; when only one date is known,
// span ~30 days on the missing side (typical net terms). This catches early
// payments (paid near the invoice date, weeks before due) that a due-date-
// only window missed.
if (amountMatch && (invoice.invoice_date || invoice.due_date)) {
const DAY = 24 * 60 * 60 * 1000
const txMs = new Date(transaction.date).getTime()
const invoiceMs = invoice.invoice_date ? new Date(invoice.invoice_date).getTime() : null
const dueMs = invoice.due_date ? new Date(invoice.due_date).getTime() : null
const startMs = invoiceMs !== null ? invoiceMs - 5 * DAY : (dueMs as number) - 35 * DAY
const endMs = dueMs !== null ? dueMs + 5 * DAY : (invoiceMs as number) + 35 * DAY
if (txMs >= startMs && txMs <= endMs) {
amountDateMatchCount++
const confidence = 0.85
if (!bestMatch || confidence > bestMatch.confidence) {
bestMatch = {
supplierInvoice: invoice,
confidence,
matchMethod: 'amount_date',
}
}
}
}
// Pass 4: Fuzzy amount (±5 SEK) + supplier name in description → 0.70
// Tolerance covers öresavrundning and minor fee differences
const fuzzyAmountMatch = Math.abs(txAmount - remaining) <= 5.00
const supplierName = invoice.supplier?.name
if (fuzzyAmountMatch && supplierName) {
const txDesc = (transaction.description || '').toLowerCase()
const normalizedName = supplierName.toLowerCase()
// Check if any significant word from the supplier name appears in the description
const nameWords = normalizedName
.replace(/[^\w\såäöé]/g, '')
.split(/\s+/)
.filter((w) => w.length >= 3)
const nameInDesc = nameWords.some((word) => txDesc.includes(word))
if (nameInDesc) {
const confidence = 0.70
if (!bestMatch || confidence > bestMatch.confidence) {
bestMatch = {
supplierInvoice: invoice,
confidence,
matchMethod: 'fuzzy_name',
}
}
}
}
}
// A Pass-3 winner is only trustworthy enough to auto-link when its amount was
// unique in-window. If several invoices shared the amount, the date can't
// disambiguate — flag it so the caller demotes it to a suggestion.
if (bestMatch && bestMatch.matchMethod === 'amount_date' && amountDateMatchCount > 1) {
bestMatch.ambiguous = true
}
return bestMatch
}