Files
accounted/lib/import/bank-file/__tests__/suggest-column-mapping.test.ts
T
MattssonandClaude Opus 4.8 0ca9c25aba Add/user feedback (#679)
* feat(bookkeeping): make blocked fiscal-year creation actionable

When creating a new räkenskapsår is blocked because a prior period is
still open, the "Skapa räkenskapsår" dialog no longer dead-ends on an
English toast. The API now returns the canonical bilingual error envelope
with the blocking periods (id/name/dates) under details, and the dialog
renders a Swedish panel that locks them inline (reversible locked_at) via
the existing /lock endpoint and retries creation.

The guard rule is unchanged and remains BFL-compliant: BFL 6 kap allows
löpande bokföring of the new year in parallel with the prior year's
bokslut, so a lock (not a full close) is sufficient and reversible.

- Add PERIOD_CREATE_BLOCKED_BY_OPEN_PERIODS structured error code
- Return envelope + details.blockingPeriods from the 409 (was English string)
- CreatePeriodDialog: inline "lås och skapa" panel + lock-and-retry
- Update route tests for the new envelope shape

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(ui): prevent mouse wheel from mutating number inputs

A focused <input type="number"> would change its value on scroll,
silently turning e.g. a 20000 salary into 19998. Blur number inputs
on wheel so the page scrolls instead of editing the value. Applied
at the Input primitive so all number fields are protected.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(salary): auto-derive skattetabell and kolumn for employees

Replace the opaque manual "Skattetabell (29-42)" and "Kolumn (1-6)" inputs
on the employee form with a self-deriving flow: the user picks their
folkbokföringskommun from a searchable dropdown and the tax table fills
itself in, while the column derives from the personnummer we already collect.

- Add a searchable municipality picker (MunicipalityCombobox) backed by a
  new cached GET /api/salary/tax-tables/kommuner endpoint.
- Wrap the whole "Skatt" card in a self-contained EmployeeTaxCard used by
  both the create and edit pages, with InfoTooltips and named column options.
- deriveTaxColumn(): auto-select column 1 for under-66 employees; leave the
  ambiguous 66+ case (pension vs working senior) to a clearly-named manual
  choice.
- Fix fetchKommunTaxRates() to page through all ~1300 församling rows instead
  of a single 500-row page (which silently dropped ~200 kommuner, incl.
  Göteborg) and normalize the uppercase names to title case.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(import): correct CSV amount-column guess and surface skipped rows

Manual CSV column-mapping auto-guess walked each data row right-to-left
and picked the first numeric cell as the amount, so on the common
...;Belopp;Saldo layout it grabbed the trailing running-balance column.
Extract the guess into a pure, tested suggestColumnMapping(): match
header labels first (belopp/amount -> amount, saldo/balance -> balance),
auto-fill the balance field, and fall back to value heuristics that skip
the balance column and prefer a column carrying negative values.

Also surface stats.skipped_rows + parse warnings in BankFileConfirmStep -
the manual-mapping path skips the preview step that was the only place
they showed, so skipped rows were silently dropped from view.

Add a unit test reproducing the Saldo-as-amount regression.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat: add "Save as draft" functionality for invoices

- Implemented a new feature to allow users to save invoices as unnumbered drafts without generating an invoice number until finalized.
- Added a `save_as_draft` flag to the CreateInvoiceInput schema to handle draft saving logic.
- Updated the invoice creation API to skip number allocation when saving as a draft.
- Introduced a new endpoint for finalizing drafts, which allocates an invoice number and emits an `invoice.created` event.
- Enhanced the UI to include a "Save as draft" button, with loading states and tooltips.
- Updated tests to cover the new draft saving and finalization logic, including race conditions for concurrent modifications.
- Added relevant error handling for draft finalization and deletion scenarios.

* feat(employee): add employment start and end date fields to employee forms

* feat: enhance invoice and salary run handling with improved validation and event logging

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-05 17:26:40 +02:00

107 lines
4.1 KiB
TypeScript
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
/**
* Tests for suggestColumnMapping — the auto-guess that seeds the manual CSV
* column-mapping UI.
*
* Regression context: the previous heuristic walked each data row right-to-left
* and picked the first numeric cell as the amount. Because virtually every
* Swedish bank export ends with `…;Belopp;Saldo`, that grabbed the trailing
* running-balance column as the amount, so the live preview showed the balance
* instead of the transaction amount. The fix matches header labels first.
*/
import { describe, it, expect } from 'vitest'
import { suggestColumnMapping } from '../formats/generic-csv'
describe('suggestColumnMapping', () => {
it('REGRESSION: picks Belopp (not the trailing Saldo) as amount when a header is present', () => {
// Handelsbanken Företag-style layout: Bokföringsdatum;Referens;Belopp;Saldo.
// The old reverse-scan heuristic would have returned amount = 3 (Saldo).
const headers = ['Bokföringsdatum', 'Referens', 'Belopp', 'Saldo']
const dataRows = [
['2024-01-15', 'Swish Anna Svensson', '-99,00', '12345,67'],
['2024-01-14', 'HEMKÖP', '-432,50', '12444,67'],
['2024-01-13', 'LÖNEUTBETALNING', '25000,00', '12877,17'],
]
const result = suggestColumnMapping(headers, dataRows)
expect(result.amount).toBe(2) // Belopp — NOT 3 (Saldo)
expect(result.balance).toBe(3) // Saldo auto-filled
expect(result.date).toBe(0)
expect(result.description).toBe(1)
})
it('without a header, prefers the column with negative values as amount and the trailing column as balance', () => {
// date ; text ; belopp ; saldo — no header row at all.
const dataRows = [
['2024-01-15', 'Swish Anna Svensson', '-99,00', '12345,67'],
['2024-01-14', 'HEMKÖP', '-432,50', '12444,67'],
['2024-01-13', 'LÖNEUTBETALNING', '25000,00', '12877,17'],
]
const result = suggestColumnMapping(null, dataRows)
expect(result.date).toBe(0)
expect(result.description).toBe(1)
expect(result.amount).toBe(2) // has negative values
expect(result.balance).toBe(3) // remaining (all-positive) numeric column
})
it('handles the Handelsbanken private layout (Reskontra + Transaktionsdatum + Text)', () => {
const headers = ['Reskontradatum', 'Transaktionsdatum', 'Text', 'Belopp', 'Saldo']
const dataRows = [
['2024-01-15', '2024-01-15', 'SPOTIFY AB', '-99,00', '12345,67'],
['2024-01-14', '2024-01-14', 'HEMKÖP', '-432,50', '12444,67'],
]
const result = suggestColumnMapping(headers, dataRows)
expect(result.date).toBe(1) // prefers transaktionsdatum over reskontradatum
expect(result.description).toBe(2) // Text
expect(result.amount).toBe(3) // Belopp — NOT 4 (Saldo)
expect(result.balance).toBe(4)
})
it('does not invent a balance column when the file has none', () => {
const headers = ['Datum', 'Text', 'Belopp']
const dataRows = [
['2024-01-15', 'SPOTIFY', '-99,00'],
['2024-01-14', 'HEMKÖP', '-432,50'],
]
const result = suggestColumnMapping(headers, dataRows)
expect(result.date).toBe(0)
expect(result.description).toBe(1)
expect(result.amount).toBe(2)
expect(result.balance).toBe(-1)
})
it('matches the amount by label even when every amount is positive', () => {
// No negative values to fall back on — the label match must still win.
const headers = ['Bokföringsdatum', 'Referens', 'Belopp', 'Saldo']
const dataRows = [['2024-01-15', 'Inbetalning kund', '5000,00', '12345,67']]
const result = suggestColumnMapping(headers, dataRows)
expect(result.amount).toBe(2) // Belopp by label, not Saldo
expect(result.balance).toBe(3)
})
it('tolerates space-grouped thousands and Unicode minus signs', () => {
const headers = ['Datum', 'Text', 'Belopp', 'Saldo']
const dataRows = [
['2024-01-15', 'STOR BETALNING', '−1 432,50', '120 000,00'],
]
const result = suggestColumnMapping(headers, dataRows)
expect(result.amount).toBe(2)
expect(result.balance).toBe(3)
})
it('returns all -1 for empty input', () => {
expect(suggestColumnMapping(null, [])).toEqual({ date: -1, description: -1, amount: -1, balance: -1 })
})
})