Jakob WennbergandClaude Opus 4.8
c74b19df1b
* feat(reconciliation): close the bank-feed loop on voucher links and re-tag mis-typed opening balances
Two related fixes to bank reconciliation correctness:
1. Auto-reconcile on voucher link. Linking an invoice or supplier invoice to
an existing voucher previously advanced only the invoice — the bank
transaction that paid it kept sitting in the Transactions inbox with a null
journal_entry_id. linkInvoiceToVoucher / linkSupplierInvoiceToVoucher now
call autoReconcileTransactionForLinkedVoucher (lib/reconciliation), which
links the bank transaction to the same verifikat when exactly one unbooked
line matches it. Best-effort and post-commit: a failure here never fails the
link. The result surfaces reconciledTransactionId; the inbox row leaves the
list and the UI shows link_success_tx_reconciled.
2. Re-tag mis-typed opening balances. getReconciliationStatus and the GL-line
matching RPCs identify a cash account's ingående balans solely by
journal_entries.source_type='opening_balance'. Companies migrated from other
systems often booked the bank IB as an ordinary voucher (source_type
'import' or 'manual'), so it was never excluded and surfaced as a phantom
reconciliation difference equal to the opening balance. Adds:
- migration mark_entry_as_opening_balance: a GUC-gated carve-out in the
immutability trigger plus a SECURITY DEFINER RPC that validates the entry
(balance-sheet lines only, dated on a fiscal-period boundary), flips the
source_type, and writes an audit row — no blanket data sweep.
- POST /api/reconciliation/bank/mark-opening-balance + MarkOpeningBalanceSchema.
- BankReconciliationView action to trigger it from the IB diff.
The gnubok_create_voucher executor now accepts a typed is_opening_balance flag
and derives source_type='opening_balance' only after validating class 1/2 lines
on the period start, so new IBs land correctly typed.
Covered by lib/reconciliation auto-reconcile tests, voucher-executors tests,
and a mark-entry-as-opening-balance pg-real test.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore: rebrand gnubok → Accounted and prune swarm agent skills
Product rebrand and skills housekeeping. No runtime behaviour change.
Rebrand: replace user-visible "gnubok" with "Accounted" across docs, READMEs,
in-code comments, doc-site content, MCP skill/resource prose, and the
gnubok-mcp package description. The MCP resource URI scheme is moved gnubok://
→ Accounted:// consistently across resource registrations, the event-type
comment, and the resource/skill tests. Deliberately preserved as stable
identifiers (NOT rebranded): the gnubok-company-id cookie, gnubok_sk_ / gnubok_inv_
token prefixes, the gnubok-mcp npm bridge name, and the AGI <gem:Programnamn>
value (kept 'gnubok' per its source comment — it is the software identifier sent
to Skatteverket and must not churn across visual rebrands).
Skills: remove the 27 swarm-* agent SKILL.md atoms (no longer used; already
absent from the agent_atom_registry in prod), refresh the remaining skill docs,
add the .claude/rules/ path-scoped rule set, and regenerate the
seed_agent_atom_bodies migration + .skill-body-manifest.json via
`npm run skills:generate` so the DB-backed skill bodies match the trimmed set.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
34 lines
1.3 KiB
TypeScript
34 lines
1.3 KiB
TypeScript
import { luhnValidate } from '@/lib/bankgiro/luhn'
|
|
|
|
/**
|
|
* Normalize an org number to Accounted's canonical 10-digit storage form.
|
|
*
|
|
* Accepts hyphen/space-formatted input in either of the two shapes Swedish
|
|
* users commonly type:
|
|
* - 10 digits (5560125790 or 8001011231) — stored as-is
|
|
* - 12 digits (198001011231) — century prefix stripped
|
|
*
|
|
* Returns null for any other length, non-digit content, or invalid Luhn
|
|
* check digit (the structural rule Bolagsverket and personnummer share).
|
|
* Storing a structurally invalid org number would later be caught by
|
|
* Skatteverket SRU and any receiving SIE4 system — refusing at the boundary
|
|
* keeps Accounted's bookkeeping from accumulating under an unusable identifier.
|
|
*
|
|
* 10-digit storage matches the rest of the codebase — see
|
|
* `lib/skatteverket/format.ts`, which converts 10→12 at export time by
|
|
* prefixing with '16' (AB) or '19'/'20' (EF personnummer).
|
|
*/
|
|
export function normalizeOrgNumber(raw: string | null | undefined): string | null {
|
|
if (!raw) return null
|
|
const cleaned = raw.replace(/[\s-]/g, '')
|
|
let canonical: string
|
|
if (/^\d{10}$/.test(cleaned)) {
|
|
canonical = cleaned
|
|
} else if (/^\d{12}$/.test(cleaned)) {
|
|
canonical = cleaned.substring(2)
|
|
} else {
|
|
return null
|
|
}
|
|
return luhnValidate(canonical) ? canonical : null
|
|
}
|