Files
accounted/lib/bokslut/assets/k3-components.ts
T
MattssonandClaude Opus 4.7 32d9978f1b Fix/chrome pdf preview csp (#572)
* feat: add option to exclude year-end closing entries in SIE export and related reports

* delete docs

* fix: allow Chrome's PDF viewer in verifikat document preview

The /api/documents/:id/inline route shipped with
`object-src 'none'` in its CSP, which blocked Chrome's built-in PDF
viewer (it renders inline PDFs via an internal <embed>). Users on
Chrome saw "Det här innehållet har blockerats" when expanding a PDF
attachment in the bookkeeping view; Firefox (PDF.js) and Edge (own
viewer) were unaffected, and JPGs worked because <img> isn't subject
to object-src.

Drops the CSP for this route to the minimum needed for embeddability:
`frame-ancestors 'self'`. X-Content-Type-Options: nosniff plus the
fixed Content-Type from the handler already block MIME confusion;
X-Frame-Options: SAMEORIGIN + frame-ancestors still block clickjacking.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(auth): add webmail deep link to email confirmation screens

Mirrors Stripe's signup UX: after asking the user to verify their email,
detect their webmail provider from the domain and show a button that
opens the inbox in a new tab. Gmail gets a from:<sender> search
pre-populated; Outlook/Yahoo/iCloud/Proton open the inbox directly.
Unknown / custom domains fall back to the existing copy.

Sender address is configurable via NEXT_PUBLIC_BRANDING_AUTH_EMAIL_FROM
(default noreply@gnubok.se) so white-label installs can match their
Supabase Auth SMTP config.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(auth): unblock first-time password set for BankID users with MFA

Supabase rejects updateUser({password}) and mfa.unenroll with "AAL2 session
is required" whenever a TOTP factor is enrolled. BankID magic-link logins
produce AAL1, and middleware skips MFA enforcement for bankid_linked users,
so they had no path to AAL2 — leaving them unable to set a backup password
or disable MFA without going through the email-recovery escape hatch.

- /api/account/password: branch on app_metadata.has_password. First-time set
  writes via service.auth.admin.updateUserById (no existing credential to
  protect, AAL2 guard does not apply). Change-password keeps the user-session
  updateUser so AAL2 still fires for credential rotation.
- /mfa/verify: accept a safeReturnTo query param and route there after
  successful verify, so step-up flows can land back where they came from.
- SecuritySettings: detect the AAL2 error from both change-password and
  mfa.unenroll and redirect through /mfa/verify?returnTo=/settings/account
  instead of toasting a dead-end error.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Add tests and rounding utility for öre precision in bokslut calculations

- Implemented `roundOre` function for rounding SEK amounts to two decimal places, ensuring consistent monetary calculations.
- Introduced `ORE_TOLERANCE` constant for comparing rounded amounts, facilitating invariant checks in financial entries.
- Created comprehensive tests for `roundOre`, covering typical cases, edge cases, and idempotency.
- Added year-end invariants tests to verify database-level guarantees for closing entries, ensuring they balance to the öre and reject discrepancies.
- Developed end-to-end tests for the dispositions chain, validating the correctness of calculations across various scenarios.

* fix: update PDF rendering to remove Swish QR code generation and set default to disable Swish visibility

* fix: enhance security by rejecting data URIs in safeReturnTo function tests

* fix: improve rounding logic in roundOre function and add customer_type migration

* fix: add customer_type column to customers and enforce CHECK constraint

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-26 22:29:41 +02:00

100 lines
3.8 KiB
TypeScript

/**
* K3 component depreciation validation (BFNAR 2012:1 ch.17.4).
*
* Pure functions — no I/O — so unit tests can exercise edge cases without
* mocking Supabase or the engine. Shared between the Zod refinement on
* AssetCreate / AssetUpdate (`lib/api/schemas.ts`) and any callers that
* want to validate K3 components outside the API surface (MCP, scripts).
*
* The cross-column rule "sum(components.cost) ≈ acquisition_cost" cannot
* be expressed in a Postgres CHECK on JSONB, so we enforce it here. The
* engine itself does NOT re-validate at depreciation time — callers must
* ensure the asset row is consistent before persisting.
*/
import type { K3Component } from '@/types'
/** Tolerance for the sum-equals-acquisition-cost check. 1 kr is enough to
* absorb öre rounding differences when the user types whole-kronor values
* but tight enough to catch real input errors. */
const COMPONENT_SUM_TOLERANCE_KR = 1
export interface ValidationResult {
/** Human-readable Swedish error messages. Empty array = valid. */
errors: string[]
}
/**
* Validate that an asset's K3 component breakdown is internally consistent
* and matches the asset's acquisition cost.
*
* Returns the full list of issues (the API can surface all at once instead
* of bailing on the first). The check is independent of accounting_framework —
* that gate sits at the API layer because this module is also used by
* non-HTTP callers that have already decided to use K3.
*/
export function validateComponents(asset: {
acquisition_cost: number
k3_components: K3Component[] | null | undefined
}): ValidationResult {
const errors: string[] = []
const components = asset.k3_components
if (components === null || components === undefined) {
return { errors: [] }
}
if (!Array.isArray(components)) {
errors.push('k3_components måste vara en lista av komponenter eller null.')
return { errors }
}
if (components.length === 0) {
errors.push(
'k3_components får inte vara en tom lista — sätt fältet till null om asset inte använder komponentuppdelning.',
)
return { errors }
}
let totalCost = 0
components.forEach((component, index) => {
const label = component.name?.trim() || `komponent ${index + 1}`
if (typeof component.cost !== 'number' || !Number.isFinite(component.cost)) {
errors.push(`${label}: anskaffningsvärdet måste vara ett tal.`)
return
}
if (component.cost <= 0) {
errors.push(`${label}: anskaffningsvärdet måste vara större än 0.`)
}
if (
typeof component.useful_life_months !== 'number'
|| !Number.isInteger(component.useful_life_months)
|| component.useful_life_months <= 0
) {
errors.push(`${label}: nyttjandeperioden måste vara ett positivt heltal månader.`)
}
if (component.salvage_value !== undefined && component.salvage_value !== null) {
if (
typeof component.salvage_value !== 'number'
|| !Number.isFinite(component.salvage_value)
|| component.salvage_value < 0
) {
errors.push(`${label}: restvärdet får inte vara negativt.`)
} else if (component.salvage_value > component.cost) {
errors.push(
`${label}: restvärdet (${component.salvage_value} kr) får inte överstiga anskaffningsvärdet (${component.cost} kr).`,
)
}
}
totalCost += component.cost
})
const expected = Number(asset.acquisition_cost)
if (Number.isFinite(expected) && Math.abs(totalCost - expected) > COMPONENT_SUM_TOLERANCE_KR) {
errors.push(
`Komponenter summerar till ${Math.round(totalCost * 100) / 100} kr men asset.acquisition_cost är ${Math.round(expected * 100) / 100} kr — differensen får vara högst ${COMPONENT_SUM_TOLERANCE_KR} kr.`,
)
}
return { errors }
}