Files
accounted/app/api/invoices/[id]/finalize/route.ts
T
MattssonandClaude Opus 4.8 0ca9c25aba Add/user feedback (#679)
* feat(bookkeeping): make blocked fiscal-year creation actionable

When creating a new räkenskapsår is blocked because a prior period is
still open, the "Skapa räkenskapsår" dialog no longer dead-ends on an
English toast. The API now returns the canonical bilingual error envelope
with the blocking periods (id/name/dates) under details, and the dialog
renders a Swedish panel that locks them inline (reversible locked_at) via
the existing /lock endpoint and retries creation.

The guard rule is unchanged and remains BFL-compliant: BFL 6 kap allows
löpande bokföring of the new year in parallel with the prior year's
bokslut, so a lock (not a full close) is sufficient and reversible.

- Add PERIOD_CREATE_BLOCKED_BY_OPEN_PERIODS structured error code
- Return envelope + details.blockingPeriods from the 409 (was English string)
- CreatePeriodDialog: inline "lås och skapa" panel + lock-and-retry
- Update route tests for the new envelope shape

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(ui): prevent mouse wheel from mutating number inputs

A focused <input type="number"> would change its value on scroll,
silently turning e.g. a 20000 salary into 19998. Blur number inputs
on wheel so the page scrolls instead of editing the value. Applied
at the Input primitive so all number fields are protected.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(salary): auto-derive skattetabell and kolumn for employees

Replace the opaque manual "Skattetabell (29-42)" and "Kolumn (1-6)" inputs
on the employee form with a self-deriving flow: the user picks their
folkbokföringskommun from a searchable dropdown and the tax table fills
itself in, while the column derives from the personnummer we already collect.

- Add a searchable municipality picker (MunicipalityCombobox) backed by a
  new cached GET /api/salary/tax-tables/kommuner endpoint.
- Wrap the whole "Skatt" card in a self-contained EmployeeTaxCard used by
  both the create and edit pages, with InfoTooltips and named column options.
- deriveTaxColumn(): auto-select column 1 for under-66 employees; leave the
  ambiguous 66+ case (pension vs working senior) to a clearly-named manual
  choice.
- Fix fetchKommunTaxRates() to page through all ~1300 församling rows instead
  of a single 500-row page (which silently dropped ~200 kommuner, incl.
  Göteborg) and normalize the uppercase names to title case.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(import): correct CSV amount-column guess and surface skipped rows

Manual CSV column-mapping auto-guess walked each data row right-to-left
and picked the first numeric cell as the amount, so on the common
...;Belopp;Saldo layout it grabbed the trailing running-balance column.
Extract the guess into a pure, tested suggestColumnMapping(): match
header labels first (belopp/amount -> amount, saldo/balance -> balance),
auto-fill the balance field, and fall back to value heuristics that skip
the balance column and prefer a column carrying negative values.

Also surface stats.skipped_rows + parse warnings in BankFileConfirmStep -
the manual-mapping path skips the preview step that was the only place
they showed, so skipped rows were silently dropped from view.

Add a unit test reproducing the Saldo-as-amount regression.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat: add "Save as draft" functionality for invoices

- Implemented a new feature to allow users to save invoices as unnumbered drafts without generating an invoice number until finalized.
- Added a `save_as_draft` flag to the CreateInvoiceInput schema to handle draft saving logic.
- Updated the invoice creation API to skip number allocation when saving as a draft.
- Introduced a new endpoint for finalizing drafts, which allocates an invoice number and emits an `invoice.created` event.
- Enhanced the UI to include a "Save as draft" button, with loading states and tooltips.
- Updated tests to cover the new draft saving and finalization logic, including race conditions for concurrent modifications.
- Added relevant error handling for draft finalization and deletion scenarios.

* feat(employee): add employment start and end date fields to employee forms

* feat: enhance invoice and salary run handling with improved validation and event logging

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-05 17:26:40 +02:00

94 lines
3.9 KiB
TypeScript

import { NextResponse } from 'next/server'
import { eventBus } from '@/lib/events'
import { ensureInitialized } from '@/lib/init'
import { ensureInvoiceNumber } from '@/lib/invoices/ensure-invoice-number'
import { withRouteContext } from '@/lib/api/with-route-context'
import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
import type { Invoice } from '@/types'
ensureInitialized() // Module-level — loads extensions so invoice.created handlers are wired.
/**
* POST /api/invoices/[id]/finalize — "Granska och skapa".
*
* Turns an unnumbered draft (saved via "Spara som utkast") into a real, issued
* invoice: allocates the F-series number and emits invoice.created (which drives
* webhooks + the audit log). After this the invoice behaves exactly like one
* created directly — it can be sent or cancelled (makulerad), but no longer
* hard-deleted, because the number now belongs to the gap-free series
* (ML 17 kap 24§).
*
* Only an unnumbered draft (status='draft', invoice_number IS NULL,
* document_type='invoice') may be finalized. Numbering is idempotent inside the
* generate_invoice_number RPC, but the explicit guard keeps the contract clear.
*/
export const POST = withRouteContext<{ params: Promise<{ id: string }> }>(
'invoice.finalize',
async (_request, { supabase, companyId, user, log, requestId }, { params }) => {
const { id } = await params
const { data: invoice, error: fetchError } = await supabase
.from('invoices')
.select('id, status, invoice_number, document_type, is_self_billed')
.eq('id', id)
.eq('company_id', companyId)
.single()
if (fetchError || !invoice) {
return errorResponseFromCode('INVOICE_NOT_FOUND', log, { requestId })
}
// Only an unnumbered draft can be finalized. Numbered drafts are already
// issued (cancel via makulering instead); sent/paid invoices are immutable.
// A null document_type means a plain invoice (older rows / default).
// Self-billed drafts are counterparty documents (självfakturering) and must
// not be allocated an F-series number through this flow even if a direct
// API call left one unnumbered.
const docType = invoice.document_type ?? 'invoice'
if (
invoice.status !== 'draft' ||
invoice.invoice_number ||
docType !== 'invoice' ||
invoice.is_self_billed
) {
return errorResponseFromCode('INVOICE_FINALIZE_NOT_DRAFT', log, { requestId })
}
try {
await ensureInvoiceNumber(supabase, companyId!, invoice as Invoice)
} catch (err) {
log.error('failed to assign invoice number on finalize', err as Error, { invoiceId: id })
return errorResponseFromCode('INVOICE_CREATE_NUMBER_ASSIGN_FAILED', log, { requestId })
}
const { data: completeInvoice, error: refetchError } = await supabase
.from('invoices')
.select('*, customer:customers(*), items:invoice_items(*)')
.eq('id', id)
.single()
// The number was already allocated, so the invoice is finalized in the DB —
// but if the re-read fails we cannot emit invoice.created with a complete
// payload, which would silently drop the audit-log entry, webhooks, and any
// extension wired to the event. Surface it as a 500 rather than returning
// 200 with a null body and a hollow success toast. A reload shows the
// (correctly numbered) invoice; the failure is now visible in monitoring.
if (refetchError || !completeInvoice) {
log.error(
'finalize: number allocated but invoice re-read failed; invoice.created not emitted',
refetchError as Error,
{ invoiceId: id },
)
return errorResponseFromCode('INVOICE_FINALIZE_INCOMPLETE', log, { requestId })
}
await eventBus.emit({
type: 'invoice.created',
payload: { invoice: completeInvoice as Invoice, companyId: companyId!, userId: user.id },
})
return NextResponse.json({ data: completeInvoice })
},
{ requireWrite: true },
)