* feat(bookkeeping): make blocked fiscal-year creation actionable When creating a new räkenskapsår is blocked because a prior period is still open, the "Skapa räkenskapsår" dialog no longer dead-ends on an English toast. The API now returns the canonical bilingual error envelope with the blocking periods (id/name/dates) under details, and the dialog renders a Swedish panel that locks them inline (reversible locked_at) via the existing /lock endpoint and retries creation. The guard rule is unchanged and remains BFL-compliant: BFL 6 kap allows löpande bokföring of the new year in parallel with the prior year's bokslut, so a lock (not a full close) is sufficient and reversible. - Add PERIOD_CREATE_BLOCKED_BY_OPEN_PERIODS structured error code - Return envelope + details.blockingPeriods from the 409 (was English string) - CreatePeriodDialog: inline "lås och skapa" panel + lock-and-retry - Update route tests for the new envelope shape Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(ui): prevent mouse wheel from mutating number inputs A focused <input type="number"> would change its value on scroll, silently turning e.g. a 20000 salary into 19998. Blur number inputs on wheel so the page scrolls instead of editing the value. Applied at the Input primitive so all number fields are protected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(salary): auto-derive skattetabell and kolumn for employees Replace the opaque manual "Skattetabell (29-42)" and "Kolumn (1-6)" inputs on the employee form with a self-deriving flow: the user picks their folkbokföringskommun from a searchable dropdown and the tax table fills itself in, while the column derives from the personnummer we already collect. - Add a searchable municipality picker (MunicipalityCombobox) backed by a new cached GET /api/salary/tax-tables/kommuner endpoint. - Wrap the whole "Skatt" card in a self-contained EmployeeTaxCard used by both the create and edit pages, with InfoTooltips and named column options. - deriveTaxColumn(): auto-select column 1 for under-66 employees; leave the ambiguous 66+ case (pension vs working senior) to a clearly-named manual choice. - Fix fetchKommunTaxRates() to page through all ~1300 församling rows instead of a single 500-row page (which silently dropped ~200 kommuner, incl. Göteborg) and normalize the uppercase names to title case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(import): correct CSV amount-column guess and surface skipped rows Manual CSV column-mapping auto-guess walked each data row right-to-left and picked the first numeric cell as the amount, so on the common ...;Belopp;Saldo layout it grabbed the trailing running-balance column. Extract the guess into a pure, tested suggestColumnMapping(): match header labels first (belopp/amount -> amount, saldo/balance -> balance), auto-fill the balance field, and fall back to value heuristics that skip the balance column and prefer a column carrying negative values. Also surface stats.skipped_rows + parse warnings in BankFileConfirmStep - the manual-mapping path skips the preview step that was the only place they showed, so skipped rows were silently dropped from view. Add a unit test reproducing the Saldo-as-amount regression. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: add "Save as draft" functionality for invoices - Implemented a new feature to allow users to save invoices as unnumbered drafts without generating an invoice number until finalized. - Added a `save_as_draft` flag to the CreateInvoiceInput schema to handle draft saving logic. - Updated the invoice creation API to skip number allocation when saving as a draft. - Introduced a new endpoint for finalizing drafts, which allocates an invoice number and emits an `invoice.created` event. - Enhanced the UI to include a "Save as draft" button, with loading states and tooltips. - Updated tests to cover the new draft saving and finalization logic, including race conditions for concurrent modifications. - Added relevant error handling for draft finalization and deletion scenarios. * feat(employee): add employment start and end date fields to employee forms * feat: enhance invoice and salary run handling with improved validation and event logging --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
178 lines
5.9 KiB
TypeScript
178 lines
5.9 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import {
|
|
createMockRequest,
|
|
createMockRouteParams,
|
|
parseJsonResponse,
|
|
createQueuedMockSupabase,
|
|
} from '@/tests/helpers'
|
|
import { eventBus } from '@/lib/events'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createClient: () => Promise.resolve(mockSupabase),
|
|
}))
|
|
|
|
vi.mock('@/lib/init', () => ({
|
|
ensureInitialized: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/require-write', () => ({
|
|
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
|
|
}))
|
|
|
|
import { DELETE } from '../route'
|
|
|
|
describe('DELETE /api/invoices/[id]', () => {
|
|
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
eventBus.clear()
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: mockUser } })
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
|
|
|
expect(status).toBe(401)
|
|
expect(body.error).toBe('Unauthorized')
|
|
})
|
|
|
|
it('returns 404 when invoice not found', async () => {
|
|
enqueue({ data: null, error: { message: 'not found' } })
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(404)
|
|
})
|
|
|
|
it('rejects cancellation of a non-draft invoice with INVOICE_DELETE_NOT_DRAFT', async () => {
|
|
enqueue({
|
|
data: { id: 'inv-1', status: 'sent', invoice_number: 'F-2026099', user_id: 'user-1' },
|
|
error: null,
|
|
})
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(400)
|
|
expect(body.error.code).toBe('INVOICE_DELETE_NOT_DRAFT')
|
|
})
|
|
|
|
it('cancels a numbered draft, retaining the F-series number', async () => {
|
|
enqueue({
|
|
data: { id: 'inv-1', status: 'draft', invoice_number: 'F-2026001', user_id: 'user-1' },
|
|
error: null,
|
|
})
|
|
enqueue({ data: [{ id: 'inv-1' }], error: null })
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{
|
|
data: { cancelled: boolean; invoice_number: string | null }
|
|
}>(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data.cancelled).toBe(true)
|
|
expect(body.data.invoice_number).toBe('F-2026001')
|
|
})
|
|
|
|
it('hard deletes an un-numbered draft (saved via "Spara som utkast") and emits an audit event', async () => {
|
|
enqueue({
|
|
data: { id: 'inv-1', status: 'draft', invoice_number: null, user_id: 'user-1' },
|
|
error: null,
|
|
})
|
|
// delete().select('id') returns the removed row
|
|
enqueue({ data: [{ id: 'inv-1' }], error: null })
|
|
|
|
const emitSpy = vi.spyOn(eventBus, 'emit')
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ data: { deleted: boolean } }>(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data.deleted).toBe(true)
|
|
// The hard delete leaves no journal trace, so an audit event must record it.
|
|
expect(emitSpy).toHaveBeenCalledWith({
|
|
type: 'invoice.draft_deleted',
|
|
payload: { invoiceId: 'inv-1', companyId: 'company-1', userId: 'user-1' },
|
|
})
|
|
})
|
|
|
|
it('returns 409 INVOICE_CANCEL_RACE when an un-numbered draft is finalized concurrently', async () => {
|
|
enqueue({
|
|
data: { id: 'inv-1', status: 'draft', invoice_number: null, user_id: 'user-1' },
|
|
error: null,
|
|
})
|
|
// delete matched 0 rows — the draft was finalized (numbered) in the meantime.
|
|
enqueue({ data: [], error: null })
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(409)
|
|
expect(body.error.code).toBe('INVOICE_CANCEL_RACE')
|
|
})
|
|
|
|
it('returns 409 INVOICE_CANCEL_RACE when status flipped between fetch and update', async () => {
|
|
enqueue({
|
|
data: { id: 'inv-1', status: 'draft', invoice_number: 'F-2026001', user_id: 'user-1' },
|
|
error: null,
|
|
})
|
|
// Update succeeds with no error but matches 0 rows because the .eq('status','draft')
|
|
// guard rejected the row (concurrent send/cancel flipped status in the meantime).
|
|
enqueue({ data: [], error: null })
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(409)
|
|
expect(body.error.code).toBe('INVOICE_CANCEL_RACE')
|
|
})
|
|
|
|
it('returns 500 when the cancel update fails', async () => {
|
|
enqueue({
|
|
data: { id: 'inv-1', status: 'draft', invoice_number: 'F-2026001', user_id: 'user-1' },
|
|
error: null,
|
|
})
|
|
enqueue({ data: null, error: { message: 'cancel update failed' } })
|
|
|
|
const response = await DELETE(
|
|
createMockRequest('/api/invoices/inv-1', { method: 'DELETE' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(500)
|
|
})
|
|
})
|