* feat(agent): telemetry completeness + durability, CI gates, commit_method provenance Quick wins from the "Building AI systems that ship" audit: - mcp.tool_called gains errorMessage (message_sv, truncated 500 chars) on all failure exits; new mcp.skill_loaded event on every gnubok_load_skill (all tiers) so atom usage is finally measurable - event_log: (event_type, created_at) index; cleanup cron keeps mcp.*/agent.* telemetry 180 days (delivery events stay 30) - CI: lint ratchet (npm run check:lint — 60 legacy errors baselined, fails only on NEW errors) and a pg-real coverage gate (migrations touching trigger/RPC/RLS/DEFERRABLE require a *.pg.test.ts change; escape hatch: -- pg-test: covered-by/skip) - journal_entries.commit_method CHECK widened with 'api_key'/'agent'; the MCP approve path records 'api_key' truthfully instead of 'user_accept' (agent_first_vision §8 P0-1). 'agent' is reserved — ALL MCP traffic (incl. claude.ai OAuth, whose access_token is a minted API key) authenticates as api_key today Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(import): derive opening balances from prior-year #UB when SIE lacks #IB (#675) SIE files exported without #IB 0 rows (only #UB -1) previously imported with zero opening balances. getEffectiveOpeningBalances() now derives IB from prior-year UB for balance-sheet accounts when explicit #IB is absent, surfaces the derivation as an info issue in the import preview, and excludes share-capital vouchers from opening-balance detection. Detection regexes are shared between parser and importer so the two checks cannot drift. 507 lib/import tests pass. (Authored in a parallel session in this checkout; included per request.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(review): address PR #677 bot findings — RoPA entry, execFileSync, gate scope note Triage of the compliance-swarm + Greptile findings: Applied: - .compliance/ropa.yaml: new mcp.telemetry processing activity declaring the 180-day mcp.*/agent.* retention, lawful basis, data categories, and the no-args/no-results minimisation (ISO A.8.10, GDPR Art.5(1)(c) — the retention split is now formally documented, referenced from the cron) - check-pg-test-coverage.mjs: execFileSync with argv array — no shell, so a hostile base-ref can't inject (ASVS V13.2.1); verified an injection attempt exits 2 without executing - check-pg-test-coverage.mjs: documented the PR-level (not per-migration) scope of the gate so reviewers know to check coverage per migration when a PR carries several risky migrations (Greptile P2) Acknowledged, no change: - errorMessage PII risk: messages are domain-mapped strings; event_log already persists far richer delivery payloads under the same RLS; now declared in ropa.yaml - cron error envelope: errorResponse maps to the canonical safe envelope and the endpoint is CRON_SECRET-gated - two-pass delete "partial state": TTL deletes are idempotent — the next daily run sweeps whatever a failed pass left behind - skill_loaded actorLabel/sessionId: mirrors the pre-existing mcp.tool_called payload; sessionId is the join key the analytics exist for Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
109 lines
3.2 KiB
TypeScript
109 lines
3.2 KiB
TypeScript
/**
|
|
* Tests for the event_log cleanup cron's differentiated retention:
|
|
* delivery events at 30 days, agent telemetry (mcp.*, agent.*) at 180 days.
|
|
*/
|
|
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
vi.mock('@/lib/auth/cron', () => ({
|
|
verifyCronSecret: vi.fn(() => null),
|
|
}))
|
|
|
|
interface FilterCall {
|
|
method: string
|
|
args: unknown[]
|
|
}
|
|
|
|
interface DeleteCapture {
|
|
filters: FilterCall[]
|
|
}
|
|
|
|
const deleteCalls: DeleteCapture[] = []
|
|
let deleteResults: Array<{ error: unknown; count: number | null }> = []
|
|
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createServiceClient: vi.fn(() => ({
|
|
from: vi.fn(() => {
|
|
const capture: DeleteCapture = { filters: [] }
|
|
deleteCalls.push(capture)
|
|
const result = deleteResults.shift() ?? { error: null, count: 0 }
|
|
const chain: Record<string, unknown> = {}
|
|
chain.delete = vi.fn(() => chain)
|
|
chain.lt = vi.fn((...args: unknown[]) => {
|
|
capture.filters.push({ method: 'lt', args })
|
|
return chain
|
|
})
|
|
chain.not = vi.fn((...args: unknown[]) => {
|
|
capture.filters.push({ method: 'not', args })
|
|
return chain
|
|
})
|
|
// Thenable — awaiting the builder resolves the queued result.
|
|
chain.then = (resolve: (v: unknown) => unknown) => Promise.resolve(result).then(resolve)
|
|
return chain
|
|
}),
|
|
})),
|
|
}))
|
|
|
|
import { GET } from '../route'
|
|
|
|
function cronRequest(): Request {
|
|
return new Request('http://localhost:3000/api/events/cleanup/cron')
|
|
}
|
|
|
|
function daysAgo(iso: string): number {
|
|
return (Date.now() - new Date(iso).getTime()) / 86_400_000
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
deleteCalls.length = 0
|
|
deleteResults = []
|
|
})
|
|
|
|
describe('GET /api/events/cleanup/cron', () => {
|
|
it('runs two delete passes: delivery at 30 days (telemetry excluded), everything at 180', async () => {
|
|
deleteResults = [
|
|
{ error: null, count: 12 },
|
|
{ error: null, count: 3 },
|
|
]
|
|
|
|
const response = await GET(cronRequest())
|
|
const json = await response.json()
|
|
|
|
expect(json).toEqual({
|
|
success: true,
|
|
deleted: 15,
|
|
deletedDelivery: 12,
|
|
deletedTelemetry: 3,
|
|
})
|
|
|
|
expect(deleteCalls).toHaveLength(2)
|
|
|
|
// Pass 1: 30-day cutoff + telemetry exclusion filters.
|
|
const pass1 = deleteCalls[0]
|
|
const lt1 = pass1.filters.find((f) => f.method === 'lt')!
|
|
expect(lt1.args[0]).toBe('created_at')
|
|
expect(daysAgo(lt1.args[1] as string)).toBeCloseTo(30, 0)
|
|
const notFilters = pass1.filters.filter((f) => f.method === 'not')
|
|
expect(notFilters.map((f) => f.args)).toEqual([
|
|
['event_type', 'like', 'mcp.%'],
|
|
['event_type', 'like', 'agent.%'],
|
|
])
|
|
|
|
// Pass 2: 180-day cutoff, no exclusions — sweeps the telemetry rows.
|
|
const pass2 = deleteCalls[1]
|
|
const lt2 = pass2.filters.find((f) => f.method === 'lt')!
|
|
expect(daysAgo(lt2.args[1] as string)).toBeCloseTo(180, 0)
|
|
expect(pass2.filters.filter((f) => f.method === 'not')).toHaveLength(0)
|
|
})
|
|
|
|
it('short-circuits with an error envelope when the delivery pass fails', async () => {
|
|
deleteResults = [{ error: { message: 'boom', code: 'XX000' }, count: null }]
|
|
|
|
const response = await GET(cronRequest())
|
|
|
|
expect(response.status).toBeGreaterThanOrEqual(500)
|
|
// The 180-day pass never ran.
|
|
expect(deleteCalls).toHaveLength(1)
|
|
})
|
|
})
|