* fix(reports): stabilize fetchAllRows paging to stop doubled/dropped balances (#790, #791) PostgREST `.range()` paging is only correct when the underlying query has a stable TOTAL order. Several aggregating report queries (general ledger, trial balance, grundbok, supplier/AR ledgers, etc.) paginated without `.order()`, so on datasets larger than one 1000-row page Postgres could return rows in a different order between requests — silently DUPLICATING or SKIPPING rows on a page boundary and doubling or dropping financial totals. - fetch-all.ts: document the ordering invariant and add an optional `dedupeBy` defense-in-depth that drops cross-page duplicates and warns when it fires (surfaces a missing `.order()` in logs instead of corrupting money). - Add a stable `.order()` (line PK or account_number) to every paginated query in lib/reports/ and the account-balances route; pass `dedupeBy` on the money-aggregating line queries. - Add fetch-all unit tests and update report test fixtures to carry row ids. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(api): declare the real { data, meta } envelope on v1 single/write/204 endpoints (#794) The OpenAPI generator derives each endpoint's documented body purely from its registered `response.success` Zod schema, and that schema is never validated at runtime — so a route could advertise a shape its handler never sends. #802 fixed this for list endpoints; the same drift was latent on single-resource and write endpoints, which declared the bare resource schema instead of the `{ data, meta }` envelope the handlers actually return. - registry.ts: extend `ResponseMetaSchema` with the optional `audit` block and `partial_expansions` list that writes/expansions emit; add the `NoBodyResponse` sentinel so 204 DELETE handlers document a bare 204 instead of a phantom 200. - Wrap every single/write endpoint's `response.success` in `dataEnvelope(...)` (or `NoBodyResponse` for 204s) across the v1 routes. - Add a response-envelope contract test that fails CI if any JSON endpoint forgets to wrap its schema, with binary downloads and 204s as the only exemptions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(reports): extend paging dedupeBy to rc-basis-gaps and opening-balances Address PR review: these two money-aggregating line queries already had the stable `.order('id')` (so paging was correct) but didn't carry `id` in the select, so they couldn't use the `dedupeBy` defense-in-depth that general-ledger and trial-balance got. Select `id` and pass `dedupeBy: r => r.id` so the whole report layer applies the ordering invariant consistently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
163 lines
6.1 KiB
TypeScript
163 lines
6.1 KiB
TypeScript
import { createClient } from '@/lib/supabase/server'
|
|
import { NextResponse } from 'next/server'
|
|
import { requireCompanyId } from '@/lib/company/context'
|
|
import { validateQuery } from '@/lib/api/validate'
|
|
import { AccountBalancesQuerySchema } from '@/lib/api/schemas'
|
|
import { getOpeningBalances } from '@/lib/reports/opening-balances'
|
|
import { fetchAllRows } from '@/lib/supabase/fetch-all'
|
|
import { createLogger } from '@/lib/logger'
|
|
|
|
const log = createLogger('api.bookkeeping.account-balances')
|
|
|
|
/**
|
|
* Per-account saldo as of a date. Used by the journal-entry form to show
|
|
* each account's balance before the draft entry is posted.
|
|
*
|
|
* Mirrors the trial-balance model:
|
|
* - Balance-sheet accounts (class 1-2): IB + period activity through as_of.
|
|
* - P&L accounts (class 3-8): period activity only (P&L resets
|
|
* each räkenskapsår; carrying a
|
|
* since-inception sum would violate
|
|
* BFNAR 2013:2).
|
|
*
|
|
* IB is sourced via getOpeningBalances() so SIE-imported and year-end-closed
|
|
* companies behave identically. The opening-balance entry is excluded from
|
|
* period activity to avoid double-counting its lines.
|
|
*/
|
|
export async function GET(request: Request) {
|
|
const supabase = await createClient()
|
|
const { data: { user } } = await supabase.auth.getUser()
|
|
|
|
if (!user) {
|
|
return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
|
|
}
|
|
|
|
const params = validateQuery(request, AccountBalancesQuerySchema)
|
|
if (!params.success) return params.response
|
|
const { accounts, as_of } = params.data
|
|
|
|
const companyId = await requireCompanyId(supabase, user.id)
|
|
|
|
// Find the fiscal period containing as_of (any state — we want a reference
|
|
// saldo even for closed/locked periods).
|
|
const { data: period, error: periodError } = await supabase
|
|
.from('fiscal_periods')
|
|
.select('id, period_start, period_end, opening_balance_entry_id')
|
|
.eq('company_id', companyId)
|
|
.lte('period_start', as_of)
|
|
.gte('period_end', as_of)
|
|
.order('period_start', { ascending: false })
|
|
.limit(1)
|
|
.maybeSingle()
|
|
|
|
if (periodError) {
|
|
log.error('fiscal period lookup failed', { companyId, as_of, error: periodError.message })
|
|
return NextResponse.json({ error: 'Internal server error' }, { status: 500 })
|
|
}
|
|
|
|
// No period anchor → no meaningful IB, return zeros so the UI degrades cleanly.
|
|
if (!period) {
|
|
return NextResponse.json({
|
|
data: accounts.map((account_number) => ({ account_number, balance: 0 })),
|
|
})
|
|
}
|
|
|
|
const { data: coaRows, error: coaError } = await supabase
|
|
.from('chart_of_accounts')
|
|
.select('account_number, account_class')
|
|
.eq('company_id', companyId)
|
|
.in('account_number', accounts)
|
|
|
|
if (coaError) {
|
|
log.error('chart of accounts lookup failed', { companyId, error: coaError.message })
|
|
return NextResponse.json({ error: 'Internal server error' }, { status: 500 })
|
|
}
|
|
|
|
const accountClass = new Map<string, number>()
|
|
for (const row of coaRows ?? []) {
|
|
accountClass.set(row.account_number, row.account_class)
|
|
}
|
|
|
|
let openingBalances: Map<string, { debit: number; credit: number }>
|
|
let obEntryId: string | null
|
|
try {
|
|
const result = await getOpeningBalances(supabase, companyId, {
|
|
period_start: period.period_start,
|
|
opening_balance_entry_id: period.opening_balance_entry_id,
|
|
})
|
|
openingBalances = result.balances
|
|
obEntryId = result.obEntryId
|
|
} catch (err) {
|
|
log.error('opening-balance computation failed', {
|
|
companyId,
|
|
period_id: period.id,
|
|
error: err instanceof Error ? err.message : String(err),
|
|
})
|
|
return NextResponse.json({ error: 'Internal server error' }, { status: 500 })
|
|
}
|
|
|
|
// Sum activity from period_start through as_of, excluding the OB entry
|
|
// (its lines are already in openingBalances).
|
|
let lines: Array<{ account_number: string; debit_amount: number; credit_amount: number }>
|
|
try {
|
|
lines = await fetchAllRows<{
|
|
account_number: string
|
|
debit_amount: number
|
|
credit_amount: number
|
|
}>(({ from, to }) => {
|
|
let query = supabase
|
|
.from('journal_entry_lines')
|
|
.select(
|
|
'account_number, debit_amount, credit_amount, journal_entries!inner(company_id, status, entry_date)'
|
|
)
|
|
.eq('journal_entries.company_id', companyId)
|
|
.in('account_number', accounts)
|
|
.in('journal_entries.status', ['posted', 'reversed'])
|
|
.gte('journal_entries.entry_date', period.period_start)
|
|
.lte('journal_entries.entry_date', as_of)
|
|
|
|
if (obEntryId) {
|
|
query = query.neq('journal_entry_id', obEntryId)
|
|
}
|
|
|
|
// Stable total order for correct paging (see fetch-all.ts).
|
|
return query.order('id', { ascending: true }).range(from, to)
|
|
})
|
|
} catch (err) {
|
|
log.error('period activity lookup failed', {
|
|
companyId,
|
|
period_id: period.id,
|
|
error: err instanceof Error ? err.message : String(err),
|
|
})
|
|
return NextResponse.json({ error: 'Internal server error' }, { status: 500 })
|
|
}
|
|
|
|
const periodActivity = new Map<string, { debit: number; credit: number }>()
|
|
for (const line of lines) {
|
|
const existing = periodActivity.get(line.account_number) || { debit: 0, credit: 0 }
|
|
existing.debit += Number(line.debit_amount) || 0
|
|
existing.credit += Number(line.credit_amount) || 0
|
|
periodActivity.set(line.account_number, existing)
|
|
}
|
|
|
|
return NextResponse.json({
|
|
data: accounts.map((account_number) => {
|
|
// Fall back to inferring class from the first digit for accounts not in
|
|
// the company's COA (e.g. system accounts the user typed manually).
|
|
const klass = accountClass.get(account_number) ?? (parseInt(account_number[0], 10) || 0)
|
|
const isBalanceSheet = klass >= 1 && klass <= 2
|
|
|
|
const ib = isBalanceSheet
|
|
? openingBalances.get(account_number) || { debit: 0, credit: 0 }
|
|
: { debit: 0, credit: 0 }
|
|
const activity = periodActivity.get(account_number) || { debit: 0, credit: 0 }
|
|
|
|
const net = ib.debit - ib.credit + activity.debit - activity.credit
|
|
return {
|
|
account_number,
|
|
balance: Math.round(net * 100) / 100,
|
|
}
|
|
}),
|
|
})
|
|
}
|