* feat(reconciliation): close the bank-feed loop on voucher links and re-tag mis-typed opening balances
Two related fixes to bank reconciliation correctness:
1. Auto-reconcile on voucher link. Linking an invoice or supplier invoice to
an existing voucher previously advanced only the invoice — the bank
transaction that paid it kept sitting in the Transactions inbox with a null
journal_entry_id. linkInvoiceToVoucher / linkSupplierInvoiceToVoucher now
call autoReconcileTransactionForLinkedVoucher (lib/reconciliation), which
links the bank transaction to the same verifikat when exactly one unbooked
line matches it. Best-effort and post-commit: a failure here never fails the
link. The result surfaces reconciledTransactionId; the inbox row leaves the
list and the UI shows link_success_tx_reconciled.
2. Re-tag mis-typed opening balances. getReconciliationStatus and the GL-line
matching RPCs identify a cash account's ingående balans solely by
journal_entries.source_type='opening_balance'. Companies migrated from other
systems often booked the bank IB as an ordinary voucher (source_type
'import' or 'manual'), so it was never excluded and surfaced as a phantom
reconciliation difference equal to the opening balance. Adds:
- migration mark_entry_as_opening_balance: a GUC-gated carve-out in the
immutability trigger plus a SECURITY DEFINER RPC that validates the entry
(balance-sheet lines only, dated on a fiscal-period boundary), flips the
source_type, and writes an audit row — no blanket data sweep.
- POST /api/reconciliation/bank/mark-opening-balance + MarkOpeningBalanceSchema.
- BankReconciliationView action to trigger it from the IB diff.
The gnubok_create_voucher executor now accepts a typed is_opening_balance flag
and derives source_type='opening_balance' only after validating class 1/2 lines
on the period start, so new IBs land correctly typed.
Covered by lib/reconciliation auto-reconcile tests, voucher-executors tests,
and a mark-entry-as-opening-balance pg-real test.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore: rebrand gnubok → Accounted and prune swarm agent skills
Product rebrand and skills housekeeping. No runtime behaviour change.
Rebrand: replace user-visible "gnubok" with "Accounted" across docs, READMEs,
in-code comments, doc-site content, MCP skill/resource prose, and the
gnubok-mcp package description. The MCP resource URI scheme is moved gnubok://
→ Accounted:// consistently across resource registrations, the event-type
comment, and the resource/skill tests. Deliberately preserved as stable
identifiers (NOT rebranded): the gnubok-company-id cookie, gnubok_sk_ / gnubok_inv_
token prefixes, the gnubok-mcp npm bridge name, and the AGI <gem:Programnamn>
value (kept 'gnubok' per its source comment — it is the software identifier sent
to Skatteverket and must not churn across visual rebrands).
Skills: remove the 27 swarm-* agent SKILL.md atoms (no longer used; already
absent from the agent_atom_registry in prod), refresh the remaining skill docs,
add the .claude/rules/ path-scoped rule set, and regenerate the
seed_agent_atom_bodies migration + .skill-body-manifest.json via
`npm run skills:generate` so the DB-backed skill bodies match the trimmed set.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6.8 KiB
Authorization Policy
Status: Approved Documented Security Decision Owner: Emil Mattsson (emil.mattsson@arcim.io) Last reviewed: 2026-05-11
This document records authorization decisions for Accounted that go beyond the
default "the resource creator is the only person who can act on it" model.
It is the canonical reference for compliance reviewers (OWASP ASVS V8, ISO
27001:2022 A.5.1 / A.8.3 / A.8.5, SOC 2 CC6.1) when they encounter an
authorization check that uses company_id rather than user_id.
Multi-tenant model
Accounted is a multi-tenant SaaS where the unit of business ownership is the
company (a row in public.companies). Users access companies through
the company_members table, which links a user to one or more companies
with a role (owner / admin / member / viewer).
The active company is resolved on every request by
lib/supabase/middleware.ts. Application code reads it via
ctx.companyId (extensions) or companyId resolved from the cookie. Row
Level Security policies on every business table use the user_company_ids()
DB helper to enforce membership.
The user is never the authoritative tenant identifier on its own. Any
business data ownership check that compares user_id to the actor's
user.id instead of the resource's company_id is a bug.
Shared-resource model (default)
Business records inside a company are shared resources: any member of the company can read and write them, subject to their role. This includes:
- Customer invoices and supplier invoices
- Journal entries and bank transactions
- Customers and suppliers
- Receipts and documents
- Bank connections (Enable Banking PSD2)
- Mapping rules, booking templates, counterparty templates
- Salary runs and AGI declarations
- Company settings
The role of the actor (owner, admin, member, viewer) restricts what
operations they can perform via lib/auth/require-write.ts, but does not
restrict which records they can act on. A viewer cannot post any journal
entry; a member can post any journal entry their company owns, regardless
of who originally drafted it.
Why this is intentional
Accounted's users are small businesses and the bookkeepers / consultants they share access with. Compliance scenarios that drive this model:
- Bookkeeper handover. A consultant who connected a bank during
onboarding might not be the same person who later configures account
selection. Forcing
user_idownership would lock the second person out of fixing the first person's setup. - Vacation cover. A second admin must be able to disconnect a bank, approve a supplier invoice, or send a customer invoice when the primary user is unreachable.
- Audit trail under BFL 7 kap. Swedish bookkeeping law requires a continuous audit trail per company, not per user. Locking entries to a single user would interrupt that trail at every personnel change.
- Role-based, not identity-based, separation of duties. Where SoD
matters (e.g. AGI submission, year-end close, salary approval) we
enforce it through the
rolecolumn oncompany_members, not by recording which specific user created the underlying record.
Compensating controls
Although authorization is by company_id, the audit trail is by user_id:
journal_entries.user_id,transactions.user_id, etc. record who created a record. These columns are never used for authorization, but they are preserved for the audit log and the immutableaudit_logtable.event_logrows includeuser_idso every privileged action (consent grants, invoice sends, period locks, document uploads) is attributable to a specific user even when authorization is shared.- The
audit_logtable is immutable (DB triggeraudit_log_immutable) and retained for 7 years per BFL.
Specific decisions
bank_connections — managed at company scope
Decision. Any active company_members row for a company can manage
any bank_connection belonging to that company. This covers POST /connect,
PATCH /accounts, POST /sync, and DELETE /disconnect in the
enable-banking extension.
Why. A bank connection is a company-level resource (it represents the company's relationship to its bank under PSD2 consent obtained on behalf of the company, not a personal banking relationship). Restricting management to the user who initiated the OAuth flow would create a lockout failure mode that exceeds the cross-tenant access risk of the broader model.
Compensating audit. Every state transition on a bank connection emits
a structured event persisted to event_log with both user_id and
company_id:
bank_connection.consent_granted— PSD2 callback completed, account metadata stored, statuspending_selection. Emitted fromapp/api/extensions/enable-banking/callback/route.ts.bank_connection.account_selection_changed— user chose which accounts to sync; status may transitionpending_selection → active. Emitted fromPATCH /accountsinextensions/general/enable-banking/index.ts.bank_connection.revoked— user disconnected the bank; PSD2 session is revoked at Enable Banking; status set torevoked. Emitted fromDELETE /disconnect.
The event_log row carries: connectionId, bankName, previousStatus,
newStatus, accountCount / enabledCount / totalCount, userId,
companyId, consentExpiresAt. This is sufficient to attribute every
PSD2 consent decision to a specific user under that company.
Cross-references.
- ASVS V8.2.1 — authorization checks at trust boundary
- ASVS V16 — audit logging of security-relevant events
- ISO 27001:2022 A.5.1, A.8.3, A.8.5 — access control and information access restriction
- SOC 2 CC6.1, CC7.2 — logical access controls and detection of unauthorized changes
- GDPR Art.30 — records of processing activities (PSD2 consent decisions)
- BFL 7 kap. — 7-year retention of audit trail
Reviewers' checklist
When reviewing a PR that touches authorization:
- The check filters by
company_idresolved from the verified request context (ctx.companyIdin extensions;companyIdin API routes). Neveruser.idas a substitute. - If
companyIdis absent, the handler returns400. Never falls back to a different identifier. - The actor's company membership is enforced by either RLS
(
user_company_ids()policy) or an explicit application-side check againstcompany_members. Both is best. - Any state change is emitted as a structured event with
userIdandcompanyIdso the audit trail remains attributable. - Where role-level restrictions apply,
requireWrite()/requireRole()fromlib/auth/require-write.tsenforces them.
Deviations from the shared-resource model (e.g. resources that should be locked to a single user) must be added to this document with the same "Decision / Why / Compensating audit" structure before merging.