* feat(reconciliation): skattekonto bridge engine, sync-time twin proposals, account-keyed facade The engine half of the reconciliation page (design: Avstämningsmotorn). - lib/reconciliation/skattekonto-reconciliation.ts: getSkattekontoReconciliationStatus anchors at the saldo snapshot and returns the bridge (saldo hos Skatteverket, händelser som saknas, 1630-rader utan händelse, ignorerade, ingående skillnad, bokfört), the item buckets the page shows (proposed, unmatched external, unmatched ledger, matched, ignored, upcoming), opening_difference, unexplained_difference (0,00 by construction when data is consistent), dead-link handling (a link to a reversed/draft entry counts as unlinked and is flagged), awaiting_external for ledger lines within 5 days of the snapshot, staleness, and a window that scopes item lists without hiding older rows. Core reads skattekonto_transactions and the extension's snapshot row directly; no @/extensions import. - lib/reconciliation/gl-balance.ts: one ledger-balance helper with the trial-balance predicate status IN (posted, reversed). The drift check summed posted only, which misstated 1630 for any company with a storno on the account; skattekonto-drift.ts now delegates to the helper. - Proposals at sync: migration 20260823120000 adds suggested_journal_entry_id / suggested_at (ON DELETE SET NULL, partial index on open rows); the sync calls refreshSkattekontoProposals after the upsert. findMatchSuggestionsBulk now assigns one-to-one across rows (AGI period first, then nearest date) and falls back to an entry whose 1630 lines net to the amount (split lines); a proposal is never a link. - lib/reconciliation/service.ts + schemas.ts: the account-keyed facade (bank:<cash_account_id> | skattekonto | manual:NNNN) with listReconciliationAccounts (enabled cash accounts folded per IBAN, skattekonto when configured) and getAccountStatus dispatching to the bank engine or the new one; shared Zod shapes for the v1 registry, MCP schemas and the UI (PR 2). Tests: identity on a mixed fixture, storno pair, stale snapshot, awaiting window, window scoping, failed ledger read, live-linked entries never proposed; matcher one-to-one and split-line cases; proposal refresh writes/clears; service dedupe and dispatch. No UI in this PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): roundOre instead of inline öre rounding (guard ratchet) The antipattern ratchet counts Math.round(x*100)/100; the new engine used it in five places. Switch to roundOre from @/lib/money and ratchet the baseline down by the three occurrences this removes net of the matcher rewrite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(reconciliation): three doors over one engine: dashboard routes, v1 API and MCP tools for account-keyed reconciliation PR 2 of the Avstämning build (design: Avstämning via API och MCP). Every door calls lib/reconciliation/{service,items,actions}.ts; none re-implements a link. - lib/reconciliation/items.ts: listAccountItems per account_key, the page's buckets (proposed, unmatched_external, unmatched_ledger, matched, ignored, upcoming), limit/offset; skattekonto from the engine, bank from the scoped transactions + unlinked GL lines (netted per entry). - lib/reconciliation/actions.ts: matchPairs (pairs or use_proposals, dry run, partial success with codes), unmatchLink, setItemIgnored; emits reconciliation.matched / reconciliation.unmatched. - lib/skatteverket/skattekonto-link.ts: canonical core link semantics for a skattekonto row (single line or entry net on 1630, live-link guard, race-safe update, unlink, ignore); the extension keeps its own matchSkattekontoToEntry until its tests are ported. - Dashboard routes /api/reconciliation/accounts[...]: list, status, items, links (POST), links/{linkId} (DELETE), items/{itemId}/ignore (POST); apply directly (a human clicked). - v1 routes /api/v1/companies/{id}/reconciliation/accounts[...]: same six, withApiV1, new scopes reconciliation:read / reconciliation:write (write is a staging scope for SoD), Idempotency-Key + dry_run on writes, registered for OpenAPI, load-routes, skills/accounted-api regenerated. Legacy bank routes and their transactions:* scopes unchanged. - MCP: gnubok_get_reconciliation_status takes account_key (legacy bank path untouched), new gnubok_list_reconciliation_items (default catalog), gnubok_reconcile_match (stages reconciliation_match, preflight = status) and gnubok_reconcile_unmatch (stages reconciliation_unmatch), both search-only to stay under the tools/list payload ceiling; gnubok_link_transaction_to_journal_entry moved to search. Executors in commit.ts; risk tiers medium/low; migration pair 20260823130000/130001 adds the two op types to the CHECK constraint (value list = live prod as of 2026-08-23 + the two); close_period loadout updated. Tests: service/actions/items/link unit tests, v1 route tests (401/403/400/404/ happy, idempotency, dry run), dashboard route tests, MCP tool tests + the guard suite (payload ceiling, descriptions, staging meta, qualified ids). Guards and apiskill:check green; no type errors in changed files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): refresh the v1 spec snapshot and keep the ignore update readable by the phantom-column guard The six new v1 reconciliation endpoints and the two new scopes were not recorded in the spec snapshot, and setSkattekontoRowIgnored updated through one conditional payload, which the phantom-column scanner cannot read (ceiling 380 -> 381). Two literal payloads instead; snapshot updated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
292 lines
9.9 KiB
TypeScript
292 lines
9.9 KiB
TypeScript
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import { eventBus } from '@/lib/events/bus'
|
|
import { createLogger } from '@/lib/logger'
|
|
import {
|
|
linkSkattekontoRow,
|
|
setSkattekontoRowIgnored,
|
|
SkattekontoLinkError,
|
|
unlinkSkattekontoRow,
|
|
} from '@/lib/skatteverket/skattekonto-link'
|
|
import { manualLink, unlinkReconciliation } from './bank-reconciliation'
|
|
import { getSkattekontoReconciliationStatus } from './skattekonto-reconciliation'
|
|
import { parseAccountKey } from './schemas'
|
|
|
|
const log = createLogger('reconciliation/actions')
|
|
|
|
/**
|
|
* Write actions of the account-keyed reconciliation surface. Every door (page
|
|
* route, v1, MCP commit executor) calls these; none of them links on its own.
|
|
*
|
|
* Links never touch the ledger: they pair an outside row with an existing
|
|
* verifikat, so they are allowed in locked periods and reversible by
|
|
* unmatch. Bookings (residual postings) are a separate, later action.
|
|
*/
|
|
|
|
export interface ReconciliationPair {
|
|
/** Outside rows: transaction ids (bank) or skattekonto_transaction ids. */
|
|
external_ids: string[]
|
|
journal_entry_ids: string[]
|
|
}
|
|
|
|
export type PairSkipCode =
|
|
| 'UNSUPPORTED_PAIR_SHAPE'
|
|
| 'ALREADY_LINKED'
|
|
| 'ENTRY_NOT_FOUND'
|
|
| 'ENTRY_REVERSED'
|
|
| 'PAIR_NOT_CLOSED'
|
|
| 'ROW_IGNORED'
|
|
| 'NOT_FOUND'
|
|
| 'LINK_RACE'
|
|
| 'UNKNOWN'
|
|
|
|
export interface AppliedLink {
|
|
external_id: string
|
|
journal_entry_id: string
|
|
via?: 'line' | 'entry_total'
|
|
}
|
|
|
|
export interface SkippedPair {
|
|
pair: ReconciliationPair
|
|
code: PairSkipCode
|
|
message: string
|
|
}
|
|
|
|
export interface MatchPairsInput {
|
|
pairs?: ReconciliationPair[]
|
|
/** Use the persisted proposals (skattekonto) or potential matches (bank) as pairs. */
|
|
use_proposals?: boolean
|
|
/** Only with use_proposals: skip proposals below this confidence. */
|
|
confidence_threshold?: number
|
|
}
|
|
|
|
export interface MatchPairsResult {
|
|
dry_run: boolean
|
|
applied: AppliedLink[]
|
|
skipped: SkippedPair[]
|
|
considered: number
|
|
}
|
|
|
|
function skipCodeFor(err: unknown): { code: PairSkipCode; message: string } {
|
|
if (err instanceof SkattekontoLinkError) {
|
|
const map: Record<string, PairSkipCode> = {
|
|
TRANSACTION_NOT_FOUND: 'NOT_FOUND',
|
|
ALREADY_BOOKED: 'ALREADY_LINKED',
|
|
ROW_IGNORED: 'ROW_IGNORED',
|
|
ENTRY_NOT_FOUND: 'ENTRY_NOT_FOUND',
|
|
ENTRY_ALREADY_LINKED: 'ALREADY_LINKED',
|
|
INVALID_CANDIDATE: 'PAIR_NOT_CLOSED',
|
|
NOT_LINKED: 'UNKNOWN',
|
|
LINK_RACE: 'LINK_RACE',
|
|
}
|
|
return { code: map[err.code] ?? 'UNKNOWN', message: err.message }
|
|
}
|
|
return { code: 'UNKNOWN', message: err instanceof Error ? err.message : String(err) }
|
|
}
|
|
|
|
async function proposalsAsPairs(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
accountKey: string,
|
|
threshold: number,
|
|
): Promise<ReconciliationPair[]> {
|
|
const parsed = parseAccountKey(accountKey)
|
|
if (!parsed) return []
|
|
if (parsed.kind === 'skattekonto') {
|
|
const status = await getSkattekontoReconciliationStatus(supabase, companyId)
|
|
if (!status) return []
|
|
return status.items.proposed
|
|
.filter((i) => i.proposal && i.proposal.confidence >= threshold)
|
|
.map((i) => ({ external_ids: [i.item_id], journal_entry_ids: [i.proposal!.journal_entry_id] }))
|
|
}
|
|
if (parsed.kind === 'bank') {
|
|
const { data } = await supabase
|
|
.from('transactions')
|
|
.select('id, potential_journal_entry_id, potential_match_confidence')
|
|
.eq('company_id', companyId)
|
|
.eq('cash_account_id', parsed.cashAccountId)
|
|
.is('journal_entry_id', null)
|
|
.eq('is_ignored', false)
|
|
.not('potential_journal_entry_id', 'is', null)
|
|
return ((data ?? []) as Array<{ id: string; potential_journal_entry_id: string; potential_match_confidence: number | string | null }>)
|
|
.filter((r) => Number(r.potential_match_confidence ?? 0) >= threshold)
|
|
.map((r) => ({ external_ids: [r.id], journal_entry_ids: [r.potential_journal_entry_id] }))
|
|
}
|
|
return []
|
|
}
|
|
|
|
/**
|
|
* Link pairs on one account. Today each pair is one outside row and one
|
|
* verifikat (the N:M worksheet selection arrives with the manual-match mode);
|
|
* other shapes are reported as UNSUPPORTED_PAIR_SHAPE, never silently
|
|
* reduced. Dry run validates shapes and resolves proposals without writing.
|
|
* Partial success is first-class: `applied` and `skipped` together cover
|
|
* every considered pair.
|
|
*/
|
|
export async function matchPairs(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
userId: string,
|
|
accountKey: string,
|
|
input: MatchPairsInput,
|
|
options: { dryRun?: boolean } = {},
|
|
): Promise<MatchPairsResult | null> {
|
|
const parsed = parseAccountKey(accountKey)
|
|
if (!parsed || parsed.kind === 'manual') return null
|
|
const dryRun = options.dryRun ?? false
|
|
|
|
const pairs: ReconciliationPair[] = [...(input.pairs ?? [])]
|
|
if (input.use_proposals) {
|
|
pairs.push(
|
|
...(await proposalsAsPairs(supabase, companyId, accountKey, input.confidence_threshold ?? 0)),
|
|
)
|
|
}
|
|
|
|
const applied: AppliedLink[] = []
|
|
const skipped: SkippedPair[] = []
|
|
|
|
for (const pair of pairs) {
|
|
if (pair.external_ids.length !== 1 || pair.journal_entry_ids.length !== 1) {
|
|
skipped.push({
|
|
pair,
|
|
code: 'UNSUPPORTED_PAIR_SHAPE',
|
|
message: 'Ett par är en händelse och ett verifikat i den här versionen.',
|
|
})
|
|
continue
|
|
}
|
|
const [externalId] = pair.external_ids
|
|
const [journalEntryId] = pair.journal_entry_ids
|
|
|
|
if (dryRun) {
|
|
applied.push({ external_id: externalId, journal_entry_id: journalEntryId })
|
|
continue
|
|
}
|
|
|
|
try {
|
|
if (parsed.kind === 'skattekonto') {
|
|
const r = await linkSkattekontoRow(supabase, companyId, externalId, journalEntryId)
|
|
applied.push({ external_id: externalId, journal_entry_id: journalEntryId, via: r.via })
|
|
} else {
|
|
const { data: account } = await supabase
|
|
.from('cash_accounts')
|
|
.select('ledger_account')
|
|
.eq('company_id', companyId)
|
|
.eq('id', parsed.cashAccountId)
|
|
.maybeSingle<{ ledger_account: string }>()
|
|
const r = await manualLink(
|
|
supabase,
|
|
companyId,
|
|
externalId,
|
|
journalEntryId,
|
|
userId,
|
|
account?.ledger_account ?? '1930',
|
|
)
|
|
if (!r.success) {
|
|
skipped.push({ pair, code: 'PAIR_NOT_CLOSED', message: r.error ?? 'Kunde inte koppla' })
|
|
continue
|
|
}
|
|
applied.push({ external_id: externalId, journal_entry_id: journalEntryId })
|
|
}
|
|
await eventBus.emit({
|
|
type: 'reconciliation.matched',
|
|
payload: {
|
|
accountKey,
|
|
externalId,
|
|
journalEntryId,
|
|
method: input.use_proposals ? 'proposal' : 'manual',
|
|
userId,
|
|
companyId,
|
|
},
|
|
})
|
|
} catch (err) {
|
|
const { code, message } = skipCodeFor(err)
|
|
skipped.push({ pair, code, message })
|
|
}
|
|
}
|
|
|
|
if (!dryRun && applied.length > 0) {
|
|
log.info('reconciliation pairs linked', { companyId, accountKey, applied: applied.length, skipped: skipped.length })
|
|
}
|
|
|
|
return { dry_run: dryRun, applied, skipped, considered: pairs.length }
|
|
}
|
|
|
|
export interface UnmatchResult {
|
|
external_id: string
|
|
previous_journal_entry_id: string | null
|
|
}
|
|
|
|
/**
|
|
* Remove one link. link id = the outside row's id (transaction or
|
|
* skattekonto row), which is the one-link-per-row identity both kinds share.
|
|
*/
|
|
export async function unmatchLink(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
userId: string,
|
|
accountKey: string,
|
|
linkId: string,
|
|
): Promise<UnmatchResult | null> {
|
|
const parsed = parseAccountKey(accountKey)
|
|
if (!parsed || parsed.kind === 'manual') return null
|
|
|
|
let previous: string | null = null
|
|
if (parsed.kind === 'skattekonto') {
|
|
const r = await unlinkSkattekontoRow(supabase, companyId, linkId)
|
|
previous = r.previous_journal_entry_id
|
|
} else {
|
|
const { data: tx } = await supabase
|
|
.from('transactions')
|
|
.select('journal_entry_id')
|
|
.eq('company_id', companyId)
|
|
.eq('id', linkId)
|
|
.maybeSingle<{ journal_entry_id: string | null }>()
|
|
previous = tx?.journal_entry_id ?? null
|
|
const r = await unlinkReconciliation(supabase, companyId, linkId, userId)
|
|
if (!r.success) throw new Error(r.error ?? 'Kunde inte koppla bort')
|
|
}
|
|
await eventBus.emit({
|
|
type: 'reconciliation.unmatched',
|
|
payload: { accountKey, externalId: linkId, previousJournalEntryId: previous, userId, companyId },
|
|
})
|
|
return { external_id: linkId, previous_journal_entry_id: previous }
|
|
}
|
|
|
|
/**
|
|
* Ignore / restore one outside row. Ignored rows leave the unmatched totals
|
|
* and surface on the bridge's exclusion line (bank #1705 precedent).
|
|
*/
|
|
export async function setItemIgnored(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
accountKey: string,
|
|
itemId: string,
|
|
ignored: boolean,
|
|
): Promise<{ external_id: string; is_ignored: boolean } | null> {
|
|
const parsed = parseAccountKey(accountKey)
|
|
if (!parsed || parsed.kind === 'manual') return null
|
|
if (parsed.kind === 'skattekonto') {
|
|
const r = await setSkattekontoRowIgnored(supabase, companyId, itemId, ignored)
|
|
return { external_id: r.skattekonto_transaction_id, is_ignored: r.is_ignored }
|
|
}
|
|
const { data: tx, error } = await supabase
|
|
.from('transactions')
|
|
.select('id, journal_entry_id, is_ignored')
|
|
.eq('company_id', companyId)
|
|
.eq('id', itemId)
|
|
.maybeSingle<{ id: string; journal_entry_id: string | null; is_ignored: boolean | null }>()
|
|
if (error) throw new Error(`Kunde inte hämta transaktionen: ${error.message}`)
|
|
if (!tx) throw new SkattekontoLinkError('Transaktionen hittades inte.', 'TRANSACTION_NOT_FOUND')
|
|
if (ignored && tx.journal_entry_id) {
|
|
throw new SkattekontoLinkError('En bokförd transaktion kan inte ignoreras.', 'ALREADY_BOOKED')
|
|
}
|
|
if (Boolean(tx.is_ignored) !== ignored) {
|
|
const { error: updateError } = await supabase
|
|
.from('transactions')
|
|
.update({ is_ignored: ignored })
|
|
.eq('company_id', companyId)
|
|
.eq('id', itemId)
|
|
if (updateError) throw new Error(`Kunde inte uppdatera: ${updateError.message}`)
|
|
}
|
|
return { external_id: itemId, is_ignored: ignored }
|
|
}
|