Files
accounted/lib/reconciliation/__tests__/actions.test.ts
T
3a62c5419e feat(reconciliation): three doors over one engine: dashboard routes, v1 API and MCP tools (#1833)
* feat(reconciliation): skattekonto bridge engine, sync-time twin proposals, account-keyed facade

The engine half of the reconciliation page (design: Avstämningsmotorn).

- lib/reconciliation/skattekonto-reconciliation.ts: getSkattekontoReconciliationStatus
  anchors at the saldo snapshot and returns the bridge (saldo hos Skatteverket,
  händelser som saknas, 1630-rader utan händelse, ignorerade, ingående skillnad,
  bokfört), the item buckets the page shows (proposed, unmatched external,
  unmatched ledger, matched, ignored, upcoming), opening_difference,
  unexplained_difference (0,00 by construction when data is consistent),
  dead-link handling (a link to a reversed/draft entry counts as unlinked and is
  flagged), awaiting_external for ledger lines within 5 days of the snapshot,
  staleness, and a window that scopes item lists without hiding older rows.
  Core reads skattekonto_transactions and the extension's snapshot row directly;
  no @/extensions import.
- lib/reconciliation/gl-balance.ts: one ledger-balance helper with the
  trial-balance predicate status IN (posted, reversed). The drift check summed
  posted only, which misstated 1630 for any company with a storno on the account;
  skattekonto-drift.ts now delegates to the helper.
- Proposals at sync: migration 20260823120000 adds suggested_journal_entry_id /
  suggested_at (ON DELETE SET NULL, partial index on open rows); the sync calls
  refreshSkattekontoProposals after the upsert. findMatchSuggestionsBulk now
  assigns one-to-one across rows (AGI period first, then nearest date) and falls
  back to an entry whose 1630 lines net to the amount (split lines); a proposal
  is never a link.
- lib/reconciliation/service.ts + schemas.ts: the account-keyed facade
  (bank:<cash_account_id> | skattekonto | manual:NNNN) with listReconciliationAccounts
  (enabled cash accounts folded per IBAN, skattekonto when configured) and
  getAccountStatus dispatching to the bank engine or the new one; shared Zod
  shapes for the v1 registry, MCP schemas and the UI (PR 2).

Tests: identity on a mixed fixture, storno pair, stale snapshot, awaiting window,
window scoping, failed ledger read, live-linked entries never proposed; matcher
one-to-one and split-line cases; proposal refresh writes/clears; service
dedupe and dispatch. No UI in this PR.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(reconciliation): roundOre instead of inline öre rounding (guard ratchet)

The antipattern ratchet counts Math.round(x*100)/100; the new engine used it in
five places. Switch to roundOre from @/lib/money and ratchet the baseline down
by the three occurrences this removes net of the matcher rewrite.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(reconciliation): three doors over one engine: dashboard routes, v1 API and MCP tools for account-keyed reconciliation

PR 2 of the Avstämning build (design: Avstämning via API och MCP). Every door
calls lib/reconciliation/{service,items,actions}.ts; none re-implements a link.

- lib/reconciliation/items.ts: listAccountItems per account_key, the page's
  buckets (proposed, unmatched_external, unmatched_ledger, matched, ignored,
  upcoming), limit/offset; skattekonto from the engine, bank from the scoped
  transactions + unlinked GL lines (netted per entry).
- lib/reconciliation/actions.ts: matchPairs (pairs or use_proposals, dry run,
  partial success with codes), unmatchLink, setItemIgnored; emits
  reconciliation.matched / reconciliation.unmatched.
- lib/skatteverket/skattekonto-link.ts: canonical core link semantics for a
  skattekonto row (single line or entry net on 1630, live-link guard, race-safe
  update, unlink, ignore); the extension keeps its own matchSkattekontoToEntry
  until its tests are ported.
- Dashboard routes /api/reconciliation/accounts[...]: list, status, items,
  links (POST), links/{linkId} (DELETE), items/{itemId}/ignore (POST); apply
  directly (a human clicked).
- v1 routes /api/v1/companies/{id}/reconciliation/accounts[...]: same six,
  withApiV1, new scopes reconciliation:read / reconciliation:write (write is a
  staging scope for SoD), Idempotency-Key + dry_run on writes, registered for
  OpenAPI, load-routes, skills/accounted-api regenerated. Legacy bank routes
  and their transactions:* scopes unchanged.
- MCP: gnubok_get_reconciliation_status takes account_key (legacy bank path
  untouched), new gnubok_list_reconciliation_items (default catalog),
  gnubok_reconcile_match (stages reconciliation_match, preflight = status) and
  gnubok_reconcile_unmatch (stages reconciliation_unmatch), both search-only to
  stay under the tools/list payload ceiling; gnubok_link_transaction_to_journal_entry
  moved to search. Executors in commit.ts; risk tiers medium/low; migration pair
  20260823130000/130001 adds the two op types to the CHECK constraint (value
  list = live prod as of 2026-08-23 + the two); close_period loadout updated.

Tests: service/actions/items/link unit tests, v1 route tests (401/403/400/404/
happy, idempotency, dry run), dashboard route tests, MCP tool tests + the guard
suite (payload ceiling, descriptions, staging meta, qualified ids). Guards and
apiskill:check green; no type errors in changed files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(reconciliation): refresh the v1 spec snapshot and keep the ignore update readable by the phantom-column guard

The six new v1 reconciliation endpoints and the two new scopes were not
recorded in the spec snapshot, and setSkattekontoRowIgnored updated
through one conditional payload, which the phantom-column scanner cannot
read (ceiling 380 -> 381). Two literal payloads instead; snapshot updated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-24 14:03:20 +02:00

183 lines
7.6 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
import { createQueuedMockSupabase } from '@/tests/helpers'
const linkMock = vi.fn()
const unlinkMock = vi.fn()
const setIgnoredMock = vi.fn()
const manualLinkMock = vi.fn()
const unlinkReconciliationMock = vi.fn()
const skvStatusMock = vi.fn()
const emitMock = vi.fn()
vi.mock('@/lib/skatteverket/skattekonto-link', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/skatteverket/skattekonto-link')>()
return {
...actual,
linkSkattekontoRow: (...args: unknown[]) => linkMock(...args),
unlinkSkattekontoRow: (...args: unknown[]) => unlinkMock(...args),
setSkattekontoRowIgnored: (...args: unknown[]) => setIgnoredMock(...args),
}
})
vi.mock('../bank-reconciliation', () => ({
manualLink: (...args: unknown[]) => manualLinkMock(...args),
unlinkReconciliation: (...args: unknown[]) => unlinkReconciliationMock(...args),
}))
vi.mock('../skattekonto-reconciliation', () => ({
getSkattekontoReconciliationStatus: (...args: unknown[]) => skvStatusMock(...args),
}))
vi.mock('@/lib/events/bus', () => ({ eventBus: { emit: (...args: unknown[]) => emitMock(...args) } }))
import { SkattekontoLinkError } from '@/lib/skatteverket/skattekonto-link'
import { matchPairs, setItemIgnored, unmatchLink } from '../actions'
const COMPANY = 'company-1'
const USER = 'user-1'
const CASH = '11111111-1111-4111-8111-111111111111'
const R1 = '22222222-2222-4222-8222-222222222222'
const R2 = '33333333-3333-4333-8333-333333333333'
const E1 = '44444444-4444-4444-8444-444444444444'
const E2 = '55555555-5555-4555-8555-555555555555'
describe('matchPairs', () => {
beforeEach(() => {
vi.clearAllMocks()
linkMock.mockReset()
manualLinkMock.mockReset()
skvStatusMock.mockReset()
emitMock.mockResolvedValue(undefined)
})
it('returns null for an unknown or manual account key', async () => {
const { supabase } = createQueuedMockSupabase()
expect(await matchPairs(supabase as never, COMPANY, USER, 'nope', { pairs: [] })).toBeNull()
expect(await matchPairs(supabase as never, COMPANY, USER, 'manual:1910', { pairs: [] })).toBeNull()
})
it('links skattekonto pairs one by one, reports skips with codes, and emits one event per link', async () => {
const { supabase } = createQueuedMockSupabase()
linkMock
.mockResolvedValueOnce({ skattekonto_transaction_id: R1, journal_entry_id: E1, via: 'line' })
.mockRejectedValueOnce(new SkattekontoLinkError('redan kopplat', 'ENTRY_ALREADY_LINKED'))
const result = await matchPairs(supabase as never, COMPANY, USER, 'skattekonto', {
pairs: [
{ external_ids: [R1], journal_entry_ids: [E1] },
{ external_ids: [R2], journal_entry_ids: [E1] },
{ external_ids: [R1, R2], journal_entry_ids: [E2] },
],
})
expect(result).toMatchObject({ dry_run: false, considered: 3 })
expect(result?.applied).toEqual([{ external_id: R1, journal_entry_id: E1, via: 'line' }])
expect(result?.skipped.map((s) => s.code)).toEqual(['ALREADY_LINKED', 'UNSUPPORTED_PAIR_SHAPE'])
expect(emitMock).toHaveBeenCalledTimes(1)
expect(emitMock.mock.calls[0][0]).toMatchObject({
type: 'reconciliation.matched',
payload: { accountKey: 'skattekonto', externalId: R1, journalEntryId: E1, method: 'manual' },
})
})
it('dry run resolves proposals into pairs without writing', async () => {
const { supabase } = createQueuedMockSupabase()
skvStatusMock.mockResolvedValue({
items: {
proposed: [
{ item_id: R1, proposal: { journal_entry_id: E1, confidence: 0.95 } },
{ item_id: R2, proposal: { journal_entry_id: E2, confidence: 0.8 } },
],
},
})
const result = await matchPairs(
supabase as never,
COMPANY,
USER,
'skattekonto',
{ use_proposals: true, confidence_threshold: 0.9 },
{ dryRun: true },
)
expect(result).toMatchObject({ dry_run: true, considered: 1 })
expect(result?.applied).toEqual([{ external_id: R1, journal_entry_id: E1 }])
expect(linkMock).not.toHaveBeenCalled()
expect(emitMock).not.toHaveBeenCalled()
})
it('links bank pairs through manualLink with the account ledger number', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { ledger_account: '1931' } }) // cash_accounts lookup
manualLinkMock.mockResolvedValue({ success: true })
const result = await matchPairs(supabase as never, COMPANY, USER, `bank:${CASH}`, {
pairs: [{ external_ids: [R1], journal_entry_ids: [E1] }],
})
expect(manualLinkMock).toHaveBeenCalledWith(supabase, COMPANY, R1, E1, USER, '1931')
expect(result?.applied).toHaveLength(1)
})
it('a failed bank link is a PAIR_NOT_CLOSED skip, not a throw', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { ledger_account: '1930' } })
manualLinkMock.mockResolvedValue({ success: false, error: 'Beloppen stämmer inte' })
const result = await matchPairs(supabase as never, COMPANY, USER, `bank:${CASH}`, {
pairs: [{ external_ids: [R1], journal_entry_ids: [E1] }],
})
expect(result?.skipped[0]).toMatchObject({ code: 'PAIR_NOT_CLOSED', message: 'Beloppen stämmer inte' })
})
})
describe('unmatchLink / setItemIgnored', () => {
beforeEach(() => {
vi.clearAllMocks()
unlinkMock.mockReset()
unlinkReconciliationMock.mockReset()
setIgnoredMock.mockReset()
emitMock.mockResolvedValue(undefined)
})
it('unlinks a skattekonto row and emits reconciliation.unmatched', async () => {
const { supabase } = createQueuedMockSupabase()
unlinkMock.mockResolvedValue({ skattekonto_transaction_id: R1, previous_journal_entry_id: E1 })
const result = await unmatchLink(supabase as never, COMPANY, USER, 'skattekonto', R1)
expect(result).toEqual({ external_id: R1, previous_journal_entry_id: E1 })
expect(emitMock.mock.calls[0][0]).toMatchObject({ type: 'reconciliation.unmatched', payload: { externalId: R1 } })
})
it('unlinks a bank transaction through the bank engine', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { journal_entry_id: E1 } })
unlinkReconciliationMock.mockResolvedValue({ success: true })
const result = await unmatchLink(supabase as never, COMPANY, USER, `bank:${CASH}`, R1)
expect(unlinkReconciliationMock).toHaveBeenCalledWith(supabase, COMPANY, R1, USER)
expect(result).toEqual({ external_id: R1, previous_journal_entry_id: E1 })
})
it('ignores a skattekonto row via the core helper', async () => {
const { supabase } = createQueuedMockSupabase()
setIgnoredMock.mockResolvedValue({ skattekonto_transaction_id: R1, is_ignored: true })
expect(await setItemIgnored(supabase as never, COMPANY, 'skattekonto', R1, true)).toEqual({
external_id: R1,
is_ignored: true,
})
})
it('refuses to ignore a booked bank transaction', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { id: R1, journal_entry_id: E1, is_ignored: false } })
await expect(setItemIgnored(supabase as never, COMPANY, `bank:${CASH}`, R1, true)).rejects.toMatchObject({
code: 'ALREADY_BOOKED',
})
})
it('ignores an unbooked bank transaction', async () => {
const { supabase, enqueue, findCalls } = createQueuedMockSupabase()
enqueue({ data: { id: R1, journal_entry_id: null, is_ignored: false } })
enqueue({ data: null }) // update
const result = await setItemIgnored(supabase as never, COMPANY, `bank:${CASH}`, R1, true)
expect(result).toEqual({ external_id: R1, is_ignored: true })
expect(findCalls('transactions', 'update')[0][0]).toEqual({ is_ignored: true })
})
})