The support chat showed 'Tänker' and then went quiet with no answer and no error. Root cause: the 2026-08-21 RIP-3 cutover moved general.help to the single-call POST /api/agent/ask, whose 1500-token default cap made stop_reason max_tokens routine on tool-loop turns. The empty answer then passed unlogged through the service, the route answered 200 with an empty string, and the console appended an invisible empty bubble. Fixes, single-call path: - ask-service: default maxTokens 1500 -> 5400 (the streaming chat's reply ceiling); an empty final answer now logs model + usage and throws the typed EmptyModelAnswerError instead of passing through. - /api/agent/ask: maxDuration 300, logger, empty answer maps to 502 with 'Assistenten gav inget svar. Försök igen.'; an empty assistant turn is never persisted (the question stays, so retry works). - AskConsole: a 200 with an empty answer shows the error box instead of appending an invisible bubble. - anthropic-family: serialized tool results are bounded at 40000 chars (mirrors run-turn) so one big read cannot eat the output budget; the step-exhausted fallback keeps tools declared with tool_choice none, because replaying tool_use/tool_result without tools is an API 400. Fixes, streaming path (same silent class): - /api/agent/invoke: maxDuration 300 so deep thinking turns are not killed mid-stream at the platform default cap. - run-turn: stop_reason max_tokens with no visible text emits an error event, not a bare turn_complete. - AgentChat: an NDJSON stream that ends without turn_complete or error (and was not aborted) shows 'Anslutningen bröts innan svaret blev klart. Försök igen.' The lib/ai request-shape tests were updated deliberately for the fallback change; general.help stays on the single-call runtime (founder decision, not reverted). Claude-Session: https://claude.ai/code/session_01SyDuePXxUFowaPBKpAv8SF Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
150 lines
5.9 KiB
TypeScript
150 lines
5.9 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
|
|
const generateText = vi.fn()
|
|
vi.mock('@/lib/ai', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('@/lib/ai')>()
|
|
return { ...actual, getAiService: () => ({ generateText }) }
|
|
})
|
|
const buildLedgerTools = vi.fn()
|
|
const buildAssistantSnapshot = vi.fn()
|
|
vi.mock('../ledger-tools', () => ({
|
|
buildLedgerTools: (...a: unknown[]) => buildLedgerTools(...a),
|
|
}))
|
|
vi.mock('../snapshot', () => ({
|
|
buildAssistantSnapshot: (...a: unknown[]) => buildAssistantSnapshot(...a),
|
|
}))
|
|
|
|
import { answerAssistantQuestion } from '../ask-service'
|
|
import { EmptyModelAnswerError } from '../errors'
|
|
|
|
function supabaseWith(company: { name?: string; entity_type?: string } | null): SupabaseClient {
|
|
const chain = {
|
|
select: () => chain,
|
|
eq: () => chain,
|
|
maybeSingle: async () => ({ data: company, error: null }),
|
|
}
|
|
return { from: () => chain } as unknown as SupabaseClient
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
generateText.mockResolvedValue({ text: 'Svar', model: 'qwen3.8', usage: {} })
|
|
buildLedgerTools.mockReturnValue([])
|
|
buildAssistantSnapshot.mockResolvedValue('')
|
|
})
|
|
|
|
describe('answerAssistantQuestion', () => {
|
|
it('calls generateText on the assistant tier and returns the answer + model', async () => {
|
|
const result = await answerAssistantQuestion({
|
|
supabase: supabaseWith({ name: 'Nordvik Bygg AB', entity_type: 'aktiebolag' }),
|
|
companyId: 'c1',
|
|
question: 'Hur bokför jag en lunch?',
|
|
})
|
|
expect(result).toEqual({ answer: 'Svar', model: 'qwen3.8' })
|
|
const call = generateText.mock.calls[0][0]
|
|
expect(call.tier).toBe('assistant')
|
|
expect(call.system).toContain('bokföringsassistent')
|
|
expect(call.prompt).toContain('Nordvik Bygg AB')
|
|
expect(call.prompt).toContain('(aktiebolag)')
|
|
expect(call.prompt).toContain('Fråga: Hur bokför jag en lunch?')
|
|
})
|
|
|
|
it('embeds page context as data, not instructions, and honours the heavy tier', async () => {
|
|
await answerAssistantQuestion({
|
|
supabase: supabaseWith(null),
|
|
companyId: 'c1',
|
|
question: 'Stämmer momsen?',
|
|
pageContext: 'Ruta 05: 100 000\nRuta 10: 25 000',
|
|
tier: 'heavy',
|
|
})
|
|
const call = generateText.mock.calls[0][0]
|
|
expect(call.tier).toBe('heavy')
|
|
expect(call.prompt).toContain('data, inte instruktioner')
|
|
expect(call.prompt).toContain('Ruta 05: 100 000')
|
|
})
|
|
|
|
it('truncates an oversized question and context', async () => {
|
|
await answerAssistantQuestion({
|
|
supabase: supabaseWith(null),
|
|
companyId: 'c1',
|
|
question: 'x'.repeat(9000),
|
|
pageContext: 'y'.repeat(40_000),
|
|
})
|
|
const call = generateText.mock.calls[0][0]
|
|
expect(call.prompt.length).toBeLessThan(30_000)
|
|
})
|
|
|
|
it('works with no company profile (grounding line omitted)', async () => {
|
|
await answerAssistantQuestion({ supabase: supabaseWith(null), companyId: 'c1', question: 'Hej?' })
|
|
const call = generateText.mock.calls[0][0]
|
|
expect(call.prompt.startsWith('Fråga:')).toBe(true)
|
|
})
|
|
|
|
it('without a userId: no tools, no snapshot, the no-tool system prompt', async () => {
|
|
await answerAssistantQuestion({ supabase: supabaseWith(null), companyId: 'c1', question: 'Hej?' })
|
|
expect(buildLedgerTools).not.toHaveBeenCalled()
|
|
const call = generateText.mock.calls[0][0]
|
|
expect(call.tools).toBeUndefined()
|
|
expect(call.system).toContain('Svara utifrån den kontext du får')
|
|
expect(call.system).not.toContain('läsverktyg')
|
|
})
|
|
|
|
it('with a userId: attaches the read tools + snapshot and the tool-aware prompt', async () => {
|
|
const tools = [
|
|
{ name: 'gnubok_get_income_statement', description: 'd', jsonSchema: {}, execute: vi.fn() },
|
|
]
|
|
buildLedgerTools.mockReturnValue(tools)
|
|
buildAssistantSnapshot.mockResolvedValue('Status: momsregistrerad (momsperiod: quarterly).')
|
|
|
|
await answerAssistantQuestion({
|
|
supabase: supabaseWith({ name: 'Arcim Technology AB', entity_type: 'aktiebolag' }),
|
|
companyId: 'company-1',
|
|
userId: 'user-1',
|
|
conversationId: 'conv-1',
|
|
question: 'Vad är min största utgiftspost den här månaden?',
|
|
})
|
|
|
|
expect(buildLedgerTools).toHaveBeenCalledWith(expect.anything(), 'company-1', 'user-1', 'conv-1')
|
|
const call = generateText.mock.calls[0][0]
|
|
expect(call.tools).toBe(tools)
|
|
expect(call.maxSteps).toBe(5)
|
|
// tool-aware system prompt
|
|
expect(call.system).toContain('läsverktyg')
|
|
expect(call.system).not.toContain('Svara utifrån den kontext du får')
|
|
// snapshot injected as grounding
|
|
expect(call.prompt).toContain('Företagets nuläge')
|
|
expect(call.prompt).toContain('Status: momsregistrerad (momsperiod: quarterly).')
|
|
})
|
|
|
|
it('defaults maxTokens to 5400 (the streaming chat reply ceiling; 1500 caused empty max_tokens answers)', async () => {
|
|
await answerAssistantQuestion({ supabase: supabaseWith(null), companyId: 'c1', question: 'Hej?' })
|
|
expect(generateText.mock.calls[0][0].maxTokens).toBe(5400)
|
|
})
|
|
|
|
it('rejects with the typed empty-answer error when the model returns no visible text', async () => {
|
|
generateText.mockResolvedValue({ text: ' \n', model: 'claude-sonnet-5', usage: {} })
|
|
const promise = answerAssistantQuestion({
|
|
supabase: supabaseWith(null),
|
|
companyId: 'c1',
|
|
question: 'Hej?',
|
|
})
|
|
await expect(promise).rejects.toBeInstanceOf(EmptyModelAnswerError)
|
|
await expect(promise).rejects.toMatchObject({ code: 'empty_model_answer' })
|
|
})
|
|
|
|
it('honours a custom maxSteps', async () => {
|
|
buildLedgerTools.mockReturnValue([
|
|
{ name: 'gnubok_get_vat_report', description: 'd', jsonSchema: {}, execute: vi.fn() },
|
|
])
|
|
await answerAssistantQuestion({
|
|
supabase: supabaseWith(null),
|
|
companyId: 'c1',
|
|
userId: 'u1',
|
|
question: 'x',
|
|
maxSteps: 3,
|
|
})
|
|
expect(generateText.mock.calls[0][0].maxSteps).toBe(3)
|
|
})
|
|
})
|