Files
accounted/lib/invoices
MattssonandClaude Fable 5 638a25a11a fix(rot-rut): floor BegartBelopp so a half-krona deduction cannot exceed the cap (#1910)
* fix(rot-rut): floor BegartBelopp so a half-krona deduction cannot exceed the cap

The payout file is whole kronor and skattereduktionen is capped at a
share of the work price (HUSFL: 50% RUT / 30% ROT). Math.round pushed an
exact half-krona deduction up: 125 kr work -> 62,50 kr RUT became
begart 63 with betalt 125 - 63 = 62, so the DEDUCTION_EXCEEDS_PAYMENT
guard blocked a perfectly correct invoice. Every work price that is an
odd number of kronor hits this.

BegartBelopp now floors the ore-rounded sum: 62,50 -> 62, betalt 63,
valid file. Flooring can never create begart > betalt (2*floor(D) is an
integer <= pris <= round(pris) whenever the ledger deduction respects
the cap), so the guard becomes a pure corruption check. Invoices that
pass today are unchanged: round and floor only differ at fraction >= .5,
and those were all blocked. The ore-rounding before the floor keeps
float noise (62.499999...) from dropping a whole krona; a test pins it.

Regression tests cover the 125-kr half-krona case end to end (evaluate,
XML amounts, eligible list).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(rot-rut): use roundOre helper for the pre-floor ore rounding

check:guards naive-ore-round flags inline Math.round(x*100)/100; the
sanctioned @/lib/money roundOre does the same with an EPSILON nudge.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(rot-rut): pin the ROT half-ore class and use truncateToWholeKronor

Skeptic findings on the frozen head (fbc3bb0c8):

1. The 'previously-passing invoices are byte-identical' claim was false
   for ROT: at 30% the deduction sits far below the begart > betalt
   guard, so e.g. 500 kr labor + 125 moms (ROT 187,50) previously
   PASSED and emitted 188, exceeding both the statutory cap and the
   1513 fordran. The floor now emits 187/438: deliberately 1 kr lower.
   A test pins the case, and DECISIONS.md states the real blast radius.

2. lib/money.ts already ships truncateToWholeKronor, documented as the
   amount rule for everything Skatteverket-bound, with the same
   ore-round-then-truncate semantics; use it instead of hand-rolling
   Math.floor(roundOre(...)).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-25 21:32:06 +02:00
..
2026-07-15 15:53:15 +02:00
2026-07-21 23:00:15 +02:00
2026-07-15 15:53:15 +02:00
2026-07-21 23:00:15 +02:00
2026-07-12 00:56:16 +02:00