* fix: prevent silent data truncation in report generators Supabase PostgREST silently truncates queries at 1000 rows. Several report generators used bare .select() without fetchAllRows(), causing incomplete financial data — a BFL compliance violation. Wrapped 10 queries across 7 files with fetchAllRows(): - monthly-breakdown: journal_entry_lines (easily >1000/period) - ar-ledger: unpaid invoices - supplier-ledger: unpaid supplier invoices - salary-journal: salary_run_employees (+ optimized with !inner join) - vacation-liability: employees + salary_run_employees - full-archive-export: document_attachments + journal_entry IDs - ingest.ts: supplier invoices for auto-matching Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: address Greptile review — try/catch and client-side safety checks - Wrap full-archive-export document fetch in try/catch to match the VAT section pattern — a failed document query should not prevent the rest of the archive from being generated. - Restore client-side year/status safety checks in salary-journal and vacation-liability as defense-in-depth against PostgREST !inner filter regressions, per BFL lönejournal and BFNAR 2016:10 compliance. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
229 lines
7.6 KiB
TypeScript
229 lines
7.6 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { createMockSupabase } from '@/tests/helpers'
|
|
|
|
const { supabase, mockResult } = createMockSupabase()
|
|
|
|
import { generateMonthlyBreakdown } from '../monthly-breakdown'
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
describe('generateMonthlyBreakdown', () => {
|
|
it('returns empty months when no fiscal period found', async () => {
|
|
mockResult({ data: null, error: { message: 'not found' } })
|
|
|
|
const result = await generateMonthlyBreakdown(supabase as never, 'company-1', 'period-1')
|
|
expect(result.months).toEqual([])
|
|
})
|
|
|
|
it('returns empty months when no journal entries exist', async () => {
|
|
// First call: fiscal period
|
|
mockResult({
|
|
data: { period_start: '2024-01-01', period_end: '2024-12-31' },
|
|
error: null,
|
|
})
|
|
|
|
// We need two sequential calls with different results.
|
|
// The proxy-based mock returns the same result for all calls,
|
|
// so we re-mock after the first await completes.
|
|
// Instead, test that an empty lines result returns initialized months.
|
|
|
|
// For this test, override at the supabase.from level to return different chains
|
|
let callCount = 0
|
|
supabase.from.mockImplementation(() => {
|
|
callCount++
|
|
if (callCount === 1) {
|
|
// fiscal_periods query
|
|
return {
|
|
select: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
single: () =>
|
|
Promise.resolve({
|
|
data: { period_start: '2024-01-01', period_end: '2024-12-31' },
|
|
error: null,
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}
|
|
}
|
|
// journal_entry_lines query
|
|
return {
|
|
select: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
range: () =>
|
|
Promise.resolve({
|
|
data: [],
|
|
error: null,
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}
|
|
})
|
|
|
|
const result = await generateMonthlyBreakdown(supabase as never, 'company-1', 'period-1')
|
|
expect(result.months.length).toBe(12)
|
|
expect(result.months[0].label).toBe('Jan')
|
|
expect(result.months[0].income).toBe(0)
|
|
expect(result.months[0].expenses).toBe(0)
|
|
expect(result.months[11].label).toBe('Dec')
|
|
})
|
|
|
|
it('correctly classifies revenue (class 3) and expense (class 4-7) accounts', async () => {
|
|
let callCount = 0
|
|
supabase.from.mockImplementation(() => {
|
|
callCount++
|
|
if (callCount === 1) {
|
|
return {
|
|
select: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
single: () =>
|
|
Promise.resolve({
|
|
data: { period_start: '2024-01-01', period_end: '2024-03-31' },
|
|
error: null,
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}
|
|
}
|
|
return {
|
|
select: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
range: () =>
|
|
Promise.resolve({
|
|
data: [
|
|
{
|
|
account_number: '3001',
|
|
debit_amount: 0,
|
|
credit_amount: 10000,
|
|
journal_entry: { entry_date: '2024-01-15', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
{
|
|
account_number: '5010',
|
|
debit_amount: 3000,
|
|
credit_amount: 0,
|
|
journal_entry: { entry_date: '2024-01-20', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
{
|
|
account_number: '3001',
|
|
debit_amount: 0,
|
|
credit_amount: 5000,
|
|
journal_entry: { entry_date: '2024-02-10', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
{
|
|
account_number: '6200',
|
|
debit_amount: 1500,
|
|
credit_amount: 0,
|
|
journal_entry: { entry_date: '2024-02-15', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
],
|
|
error: null,
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}
|
|
})
|
|
|
|
const result = await generateMonthlyBreakdown(supabase as never, 'company-1', 'period-1')
|
|
|
|
// January
|
|
const jan = result.months.find((m) => m.label === 'Jan')!
|
|
expect(jan.income).toBe(10000)
|
|
expect(jan.expenses).toBe(3000)
|
|
expect(jan.net).toBe(7000)
|
|
|
|
// February
|
|
const feb = result.months.find((m) => m.label === 'Feb')!
|
|
expect(feb.income).toBe(5000)
|
|
expect(feb.expenses).toBe(1500)
|
|
expect(feb.net).toBe(3500)
|
|
|
|
// March should be zero
|
|
const mar = result.months.find((m) => m.label === 'Mar')!
|
|
expect(mar.income).toBe(0)
|
|
expect(mar.expenses).toBe(0)
|
|
})
|
|
|
|
it('ignores balance sheet accounts (class 1, 2) but includes class 8 financial items', async () => {
|
|
let callCount = 0
|
|
supabase.from.mockImplementation(() => {
|
|
callCount++
|
|
if (callCount === 1) {
|
|
return {
|
|
select: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
single: () =>
|
|
Promise.resolve({
|
|
data: { period_start: '2024-01-01', period_end: '2024-01-31' },
|
|
error: null,
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}
|
|
}
|
|
return {
|
|
select: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
eq: () => ({
|
|
range: () =>
|
|
Promise.resolve({
|
|
data: [
|
|
{
|
|
account_number: '1930',
|
|
debit_amount: 10000,
|
|
credit_amount: 0,
|
|
journal_entry: { entry_date: '2024-01-15', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
{
|
|
account_number: '2611',
|
|
debit_amount: 0,
|
|
credit_amount: 2500,
|
|
journal_entry: { entry_date: '2024-01-15', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
{
|
|
account_number: '8400',
|
|
debit_amount: 500,
|
|
credit_amount: 0,
|
|
journal_entry: { entry_date: '2024-01-20', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
{
|
|
account_number: '8300',
|
|
debit_amount: 0,
|
|
credit_amount: 200,
|
|
journal_entry: { entry_date: '2024-01-25', status: 'posted', user_id: 'user-1', fiscal_period_id: 'period-1' },
|
|
},
|
|
],
|
|
error: null,
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}),
|
|
}
|
|
})
|
|
|
|
const result = await generateMonthlyBreakdown(supabase as never, 'company-1', 'period-1')
|
|
const jan = result.months.find((m) => m.label === 'Jan')!
|
|
// Class 1 and 2 are ignored
|
|
// Class 8 debit (8400 interest expense) → expense
|
|
expect(jan.expenses).toBe(500)
|
|
// Class 8 credit (8300 interest income) → income
|
|
expect(jan.income).toBe(200)
|
|
})
|
|
})
|