Jakob WennbergandClaude Opus 4.7
cc351158f8
* feat: invoicing & account-security polish bundle Five independent improvements bundled to ship together: - BankID/password lockout fix: BankID-only users could enroll MFA and brick themselves (Supabase requires AAL2 to change password or unenroll MFA, and AAL2 needs a password sign-in). New app_metadata.has_password flag tracks this; middleware gates /mfa/enroll behind it, /account/set- password is the unlock path, SecuritySettings shows a banner, and /api/account/password is the single write path that flips the flag. Backfill script for existing users. - Swish invoice payment method: company_settings.swish + invoice_show_swish columns, validation in lib/api/schemas.ts (accepts 123XXXXXXX företag or 07XXXXXXXX mobile, strips whitespace/hyphens), rendered on invoice PDFs. - Send-reminders kill switch: per-company company_settings.send_invoice_ reminders toggle in PdfPrintSettings/Automatisering. Reminder processor also tightened: positive status allowlist (sent + overdue) so terminal statuses can never match; skip when customer already responded via reminder link; race-window re-check before send. - First-invoice logo prompt: one-shot dialog when creating the first invoice without a logo (issue #520). Self-limits via head-only count. - SIE export opening-balance fallback: route IB through getOpeningBalances so the compute_prior_opening_balances RPC supplies #IB after multi-year imports where opening_balance_entry_id is intentionally NULL. Previously #IB silently went to zero and #UB collapsed to current-period movements. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(account-polish): address PR review feedback - BankID-link path (extensions/general/tic/index.ts): read-merge-write app_metadata instead of passing { bankid_linked: true } alone. updateUserById REPLACES app_metadata wholesale, so the previous code would have wiped has_password for any user who later linked BankID, causing the set-password banner to (incorrectly) reappear and blocking the standard MFA enrollment button. The comment is now corrected. - Middleware (lib/supabase/middleware.ts): thread inner returnTo through the /mfa/enroll → /account/set-password redirect so the user lands on their original destination after the full chain completes, not on /. - safeReturnTo helper (lib/auth/safe-return-to.ts): replace the starts-with-/-but-not-// guard on mfa/enroll and set-password pages. The previous guard let /\evil.com and /@evil.com through. The new helper parses against a synthetic base origin and verifies it matches. - set-password page (app/(auth)/account/set-password/page.tsx): remove CLAUDE.md design system violations — bg-gradient-to-b on page bg, inline shadow-md style on the card, space-y-5, font-medium on the h1, rounded-xl on the card. Flat surface, hairline border, font-display h1 per the design tokens. - Swish dedup (lib/payments/swish.ts): extract normaliseSwish() and isValidSwish() helpers and use them in lib/api/schemas.ts, components/settings/BankDetailsForm.tsx, and the invoicing settings page. Single source of truth for the regex. - Password route (app/api/account/password/route.ts): emit a structured success log so the audit pipeline can detect password-set events, not just failures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
40 lines
1.3 KiB
TypeScript
40 lines
1.3 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { normaliseSwish, isValidSwish } from '../swish'
|
|
|
|
describe('normaliseSwish', () => {
|
|
it('strips whitespace and hyphens', () => {
|
|
expect(normaliseSwish('123 456 78 90')).toBe('1234567890')
|
|
expect(normaliseSwish('070-123 45 67')).toBe('0701234567')
|
|
expect(normaliseSwish(' 1234567890 ')).toBe('1234567890')
|
|
})
|
|
|
|
it('returns empty string for null/undefined/empty', () => {
|
|
expect(normaliseSwish(null)).toBe('')
|
|
expect(normaliseSwish(undefined)).toBe('')
|
|
expect(normaliseSwish('')).toBe('')
|
|
})
|
|
})
|
|
|
|
describe('isValidSwish', () => {
|
|
it('accepts Swish Företag numbers (123XXXXXXX)', () => {
|
|
expect(isValidSwish('1234567890')).toBe(true)
|
|
expect(isValidSwish('1230000000')).toBe(true)
|
|
})
|
|
|
|
it('accepts Swedish mobile numbers (07XXXXXXXX)', () => {
|
|
expect(isValidSwish('0701234567')).toBe(true)
|
|
expect(isValidSwish('0700000000')).toBe(true)
|
|
})
|
|
|
|
it('accepts empty string for clearing the field', () => {
|
|
expect(isValidSwish('')).toBe(true)
|
|
})
|
|
|
|
it('rejects non-conforming numbers', () => {
|
|
expect(isValidSwish('0123456789')).toBe(false)
|
|
expect(isValidSwish('1239')).toBe(false)
|
|
expect(isValidSwish('12345678901')).toBe(false)
|
|
expect(isValidSwish('123abc4567')).toBe(false)
|
|
})
|
|
})
|